Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 06, 2023
  2. Sep 21, 2023
  3. Sep 07, 2023
    • Nemanja Glumac's avatar
      Fix e2e skipped test naming 2 (#33804) · 15ad8b3c
      Nemanja Glumac authored
      The original attempt was #33777.
      
      As revealed in #33799, the issue hasn't been fully fixed.
      Take a look at this run: https://github.com/metabase/metabase/actions/runs/6110515399
      
      The skipped test names are now in this format: e2e-tests-collectionsslow-ee
      Let's see how do we create a name:
      
      name: e2e-tests-${{ matrix.folder }}${{ matrix.context }}-${{ matrix.edition }}
      So it's obvious that both folder and context are included, when in reality we need only one of the two.
      
      The flaw in the logic was trying to remove the runner from the matrix. At least ONE matrix parameter needs to be different in the slow context. We achieve this by setting the runner to ubuntu-latest instead of ubuntu-22.04. This should now finally fix the names.
      
      [ci skip]
      Unverified
      15ad8b3c
    • Nemanja Glumac's avatar
      Fix e2e skipped tests naming (#33777) · 5afb2ed0
      Nemanja Glumac authored
      * Update additional context for E2E stubbed/skipped tests
      
      * Include two new E2E groups to stubbed/skipped E2E tests
      Unverified
      5afb2ed0
  4. Sep 06, 2023
    • Nemanja Glumac's avatar
      [POC] Faster E2E tests in CI (#33124) · be30839e
      Nemanja Glumac authored
      * Run slow E2E tests using faster runner
      
      * Tag slow tests
      
      * Add additional x-ray tests to the slow batch
      Unverified
      be30839e
    • Nemanja Glumac's avatar
      Fix `download-uberjar` job logic (#33745) · 69e076d9
      Nemanja Glumac authored
      This log shows the output of the files changed:
      https://github.com/metabase/metabase/actions/runs/6087912385/job/16537680230#step:3:602
      
      ```
      Changes output set to ["shared_sources","frontend_sources","frontend_specs","frontend_all","backend_sources","backend_specs","backend_all","sources","e2e_specs","e2e_all","codeql","i18n","visualizations"]
      ```
      
      Yet, the `download-uberjar` job ran, and the `build` never ran.
      This resulted in E2E test failures due to missing FE changes.
      
      The fault in the logic introduced in #33190 was thinking that
      `needs.files-changed.outputs.e2e_specs == 'true'` means the only output,
      when in reality it means one of many outputs.
      
      This PR should fix this by making sure that `needs.files-changed.outputs.e2e_all != 'true'`
      is also respected. This translates to - if there were no source code changes.
      
      [ci skip]
      Unverified
      69e076d9
  5. Sep 05, 2023
  6. Aug 21, 2023
  7. Aug 09, 2023
  8. Aug 04, 2023
  9. Jul 27, 2023
    • Nemanja Glumac's avatar
      Run E2E tests on Chrome v114 (#32688) · 53450025
      Nemanja Glumac authored
      As of two days ago we started seeing Chrome crashing in E2E tests.
      An example of the failed run: https://github.com/metabase/metabase/actions/runs/5665970958/job/15354475344
      
      ```
      We detected that the Chromium Renderer process just crashed.
      
      This is the equivalent to seeing the 'sad face' when Chrome dies.
      
      This can happen for a number of different reasons:
      
      - You wrote an endless loop and you must fix your own code
      - You are running Docker (there is an easy fix for this: see link below)
      - You are running lots of tests on a memory intense application.
          - Try enabling experimentalMemoryManagement in your config file.
          - Try lowering numTestsKeptInMemory in your config file.
      - You are running in a memory starved VM environment.
          - Try enabling experimentalMemoryManagement in your config file.
          - Try lowering numTestsKeptInMemory in your config file.
      - There are problems with your GPU / GPU drivers
      - There are browser bugs in Chromium
      ```
      
      I'm not quite sure whether this is a bug in Chrome v115 or some interplay between Cypress and this particular Chrome version, but running all tests on older Chrome version v114 seems to be working just fine.
      https://github.com/metabase/metabase/actions/runs/5677579526?pr=32688
      
      Proposal
      Let's merge this ASAP as a hotfix to unblock everyone, and then we'll follow-up when there's a clear resolution of this problem (most likely upstream).
      Unverified
      53450025
  10. Jul 25, 2023
  11. Jul 11, 2023
    • Nemanja Glumac's avatar
      Overhaul E2E tests token activation logic (#32186) · a54b3dc6
      Nemanja Glumac authored
      
      * Start all tests without a token
      
      * Update tests
      
      * Fix tests in `admin` group
      
      * Fix tests in `dashboard-filters` group
      
      * Fix tests `visualizations` group
      
      * Batch fixes
      
      * Fix database banner snowplow test
      
      * Fix full-app mobile view banner test
      
      * Simplify and remove `isPremiumActive` check
      
      * Fix the helper
      
      * Fix helper to fail fast
      
      * Fix tests
      
      * Ensure token scope is set
      
      * Ensure CYPRESS_ env tokens are present
      
      * Set token only if running Metabase ee
      
      * Improve JSDoc
      
      * Slightly tweak log message
      
      * Update E2E dev guide
      
      * Update cross-version tests
      
      * Remove premium token from Cypress backend setup
      
      * Improve a comment
      
      * Fix test
      
      * Update embedding copy
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Unverified
      a54b3dc6
  12. Jul 10, 2023
  13. Jul 03, 2023
  14. Jun 30, 2023
    • Nemanja Glumac's avatar
      Run E2E tests using Replay browser weekly (#32021) · 7f972ab9
      Nemanja Glumac authored
      Replay is adding a significant overhead and is making every single run
      fail. This is messing with our statistics and analytics.
      
      While the Replay.io team is working on some optimizations that would
      remove the overhead, we can significantly dial down the frequency of
      these runs. We'll switch to running them only once per week, on Sunday.
      
      For now...
      Unverified
      7f972ab9
  15. Jun 16, 2023
  16. Jun 14, 2023
    • Nemanja Glumac's avatar
      Refactor E2E tests in the `sharing` folder (#31455) · 4c01a8cf
      Nemanja Glumac authored
      * Extract `questionDetails`
      
      * Move `public-sharing` to the `sharing` folder
      
      * Remove redundant test
      
      This part was covered in `public-sharing.cy.spec.js`.
      
      * Create a separate `public-dashboard` E2E spec
      
      - Extract relevant part from `public.cy.spec.js`
      - Make all tests in `public-dashboard.cy.spec.js` run in isolation
      
      * Make tests in `public.cy.spec.js` run in isolation
      
      * Remove redundant wait
      
      * Limit the query results to speed test up
      
      * Merge public questions E2E tests
      
      * Merge `downloads` with the `sharing` E2E group
      
      * Remove `downloads` from the folder list
      
      * Refactor `public-dashboard.cy.spec.js`
      
      - Clean up linter warnings by using semantic selectors
      - Speed test up by using API
      Unverified
      4c01a8cf
  17. Jun 08, 2023
  18. Jun 01, 2023
  19. May 29, 2023
  20. May 26, 2023
    • Nemanja Glumac's avatar
      [E2E] Cypress Replay.io Integration (#29787) · 5e359e20
      Nemanja Glumac authored
      
      * Install `replay.io` library
      
      * Register `replay.io` in the Cypress config
      
      * Run E2E tests using Replay chromium browser but only in CI
      
      * Upload Replay.io recordings to the dashboard
      
      * Manually install Replay.io browser
      
      * Always upload recordings
      
      * Pass in a custom test run id
      
      * Disable asserts and send replays to a separate team
      
      * Upload OSS recordings as well
      
      * Use specific Ubuntu version
      
      * Record and run Replay.io on `master` only
      
      * Do not toggle CI browsers in the config
      
      * Test run: pass `replay-chromium` browser as CLI flag in a run
      
      * Fix multi-line command
      
      * Use replay plugin conditionally
      
      * Set the flag correctly
      
      * Require node process
      
      * Remove sourcemap vars
      
      * Record using replay.io on schedule
      
      * Explicitly name replay runs
      
      ---------
      
      Co-authored-by: default avatarJaril <jarilvalenciano@gmail.com>
      Unverified
      5e359e20
  21. Apr 18, 2023
  22. Mar 03, 2023
    • Ryan Laurie's avatar
      Test Time Fields in Action Forms (#28627) · 8f8ee7df
      Ryan Laurie authored
      * WIP action data type tests
      
      * DRY up the actions tests
      
      * lots of type tests
      
      * make the tests work
      
      * reorganize tests
      
      * WIP action data type tests
      
      * DRY up the actions tests
      
      * lots of type tests
      
      * make the tests work
      
      * reorganize tests
      
      * reduce some flakes
      
      * better time formatting in action forms
      
      * sort out all the timezones :woozy_face:
      
      * update after rebase
      
      * rebase disaster
      Unverified
      8f8ee7df
  23. Mar 01, 2023
    • Cam Saul's avatar
      Build script overhaul 2023 (#28767) · 3c980639
      Cam Saul authored
      * Build Script overhaul
      
      * Remove stray deps.edn
      
      * Include :ci profile for build and release tests
      
      * Fix release script
      
      * Update markdown dox
      
      * Update another dox
      
      * Tweakz
      
      * Don't pin new version of data.xml to core project, just for build scripts
      
      * Ignore unrecognized options
      
      * Fix i18n/enumerate
      Unverified
      3c980639
    • Nemanja Glumac's avatar
      [E2E] Regroup and move all related files to the root (#28749) · f71f20e1
      Nemanja Glumac authored
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      Unverified
      f71f20e1
  24. Feb 24, 2023
  25. Feb 23, 2023
  26. Feb 21, 2023
  27. Feb 20, 2023
  28. Feb 15, 2023
  29. Feb 14, 2023
  30. Feb 09, 2023
  31. Feb 08, 2023
  32. Jan 26, 2023
  33. Nov 18, 2022
Loading