Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 08, 2022
  2. Aug 05, 2022
    • Noah Moss's avatar
      Bump shadow-cljs to 2.19.6 (#24647) · dfd93579
      Noah Moss authored
      * Bump shadow-cljs
      
      This lets us use the template tag functionality
      
      ```
      add experimental support for creating js template strings
      
      used like str but emits native JS `` template
      
        (js-template "foo" (+ 1 2) "bar")
      
      emits the literal
      
        `foo${(1 + 2)}bar`
      ```
      
      But this required a few changes on our side as well.
      
      Required for this:
      
      -- LOGGING
      
      Bumped glogi
      ```diff
         ;; new stuff
      -  [lambdaisland/glogi "1.0.106"]]
      -
      +  [com.lambdaisland/glogi "1.1.144"]]
      ```
      Annoying because it had a group name change due to Clojars policy. This
      had the same error as us below. That's why I'm hopeful that it will
      actually just work.
      
      There were some changes with the Google Closure library with things not
      included or referenceable. So I just removed these imports and the
      typehints that used them. We'll need to verify that this still works but
      both compiling for dev and release (with advanced compilation)
      work. Still possible there will be some runtime errors but i'm hopeful
      there wont be. We can grab a jar from CI and poke around
      
      ```shell
      ❯ npx shadow-cljs compile app
      shadow-cljs - config: /Users/dan/projects/work/metabase/shadow-cljs.edn
      shadow-cljs - connected to server
      [:app] Compiling ...
      [:app] Build completed. (100 files, 0 compiled, 0 warnings, 1.65s)
      
      metabase on  nm-all-options-formatting [$!+?] via :coffee: v17.30 on :cloud:
      
        metabase-query took 2s
      ❯ npx shadow-cljs release app
      shadow-cljs - config: /Users/dan/projects/work/metabase/shadow-cljs.edn
      shadow-cljs - connected to server
      [:app] Compiling ...
      [:app] Build completed. (100 files, 30 compiled, 0 warnings, 28.04s)
      ```
      
      ```diff
                   [lambdaisland.glogi.console :as glogi-console])
      -  (:require-macros metabase.shared.util.log)
      -  (:import goog.debug.Logger
      -           goog.debug.Logger.Level))
      +  (:require-macros metabase.shared.util.log))
      ```
      
      ```diff
      @@ -37,4 +35,4 @@
       (defn is-loggable?
         "Part of the impl for [[metabase.shared.util.log/js-logp]] and [[metabase.shared.util.log/js-logf]]."
         [logger-name level]
      -  (.isLoggable ^Logger (log/logger logger-name) ^Level (log/levels level)))
      +  (.isLoggable (log/logger logger-name) (log/levels level)))
      ```
      
      -- WARNINGS ABOUT shadowing `abs`
      
      -  [medley "1.3.0"]
      +  [medley "1.4.0"]
      
      Similar to what we bumped for the backend. ClojureScript 1.11.x has an
      `abs` function.
      
      * use update-keys and update-vals in cljs
      
      * bump clj-kondo in CI
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      dfd93579
  3. Aug 02, 2022
  4. Aug 01, 2022
  5. Jul 20, 2022
  6. Jul 19, 2022
  7. Jul 18, 2022
  8. Jul 13, 2022
    • Cal Herries's avatar
      Session activity timeout (#23349) · 0defe7f8
      Cal Herries authored
      
      * logout when session expires, login when session appears
      
      * add setting UI
      
      * Add last_activity column to session table
      
      * Start implementing session middleware to check for expired sessions
      
      * Change last_activity field to include timezone offset
      
      * Update session middleware to check user activity timeout
      
      * Update last_activity after checking the timeout, or not at all if the setting is nil
      
      * Move session-timeout settings to server.middleware.session
      
      * Handcode timeout for testing
      
      * Fix migrations validation error
      
      * Fix whitespace
      
      * Change session timeout to use metabase.TIMEOUT cookie with expiry
      
      * Remove migration for last_activity column on session table
      
      * Revert changes to logout endpoint
      
      * Revert change to Session model pre-update
      
      * Remove tap>
      
      * Fix tests to include cookie value
      
      * Fix timeout when user is logged out. Timeout loop should only start when a user is logged in
      
      * Update comment and date format
      
      * Store the session-timeout setting as json and convert it to seconds on the fly
      
      * Set zoned date time to use GMT instead of default time zone
      
      * Refactor for testing
      
      * refactor session listener (#23686)
      
      * remove old session listener
      
      * Clear the timeout cookie when user signs out
      
      * Clear session cookie if the timeout cookie expires
      
      * fe tweaks
      
      * Update expires attribute for session and timeout cookies together
      
      * Reapply minimum limit on session-timeout
      
      * Rename functions and fix lint warnings
      
      * Fix resetting session-timeout
      
      * Fix sign out
      
      * Fix tests
      
      * Whitespace
      
      * Get full-app-embeds working
      
      * Add test for embedded session
      
      * session timeout ui tweaks
      
      * fix security issue
      
      * Fix test
      
      * Fix tests
      
      * Do not redirect to "/" if there isn't any redirect URL
      
      * Add test for session-cookies setting
      
      * Fix bug when toggling off timeout and adjust tests
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Unverified
      0defe7f8
  9. Jul 08, 2022
    • Anton Kulyk's avatar
      Update model cache refresh scheduling control (#23696) · 3becfb2d
      Anton Kulyk authored
      * Remove anchor time setting
      
      * Remove anchor time setting
      
      * Update setting
      
      * Allow styling `SettingSelect` component
      
      * Add `ModelCachingScheduleWidget`
      
      * Remove `PersistedModelRefreshIntervalWidget`
      
      * Pass `disabled` prop to expression input
      
      * Install `cron-expression-validator`
      
      * Wrap cron validator to support i18n
      
      * Fix React hooks style
      
      * Handle "custom" select value
      
      * Clean cron input when selecting built-in schedule
      
      * Connect custom cron input
      
      * Update API endpoint to change schedule
      
      * wip
      
      * Handle the "year" CRON component
      
      * Extract components, make explainer text live
      
      * Add default custom schedule value
      
      * Add helpful docs
      
      * Don't allow configuring CRON seconds part
      
      * Fix error message
      
      * Tweak popover spacing
      
      * Workaround validation lib issue
      
      * Run prettier
      Unverified
      3becfb2d
  10. Jul 06, 2022
  11. Jul 04, 2022
  12. Jun 30, 2022
    • Diogo Mendes's avatar
      Add `mochawesome` report to Cypress (#23603) · 0381866b
      Diogo Mendes authored
      * Removing old report configuration
      
      * Adding mochawesome, mochawesome-merge and mochawesome-report-generator
      
      * Adding mochawesome configuration to cypress.json
      
      * Adding mochawesome context (screenshot and video) for failed runs
      
      * Adding report to CI artifacts upon failure
      
      * Fixing whitespace
      
      * Fixing import pointed by es-lint
      
      * Moving titleToFileName inside of failure analysis
      
      * Adding suggestion
      Unverified
      0381866b
  13. Jun 29, 2022
  14. Jun 22, 2022
  15. Jun 15, 2022
  16. Jun 06, 2022
  17. Jun 02, 2022
  18. May 27, 2022
  19. May 16, 2022
  20. May 12, 2022
  21. May 11, 2022
    • Alexander Kiselev's avatar
      Remove `memoize` decorator (#22610) · 95fd206a
      Alexander Kiselev authored
      * remove memoize decorator
      
      * remove babel plugins
      
      * Fix AccordionList
      
      * remove memoize from accordionlist
      
      * fix value vs type issue with wrapped classes
      
      * fix typechecking in memoize class
      
      * rewrote query to export the memoized class directly
      Unverified
      95fd206a
  22. May 10, 2022
  23. Apr 29, 2022
  24. Apr 28, 2022
    • Anton Kulyk's avatar
      Optimise ExplicitSize performance (#22094) · b1689921
      Anton Kulyk authored
      * Add shared ResizeObserver
      
      * Migrate `Ellipsified`
      
      * Use shared resize observer
      
      * Uninstall `resize-observer-polyfill`
      
      * Adjust ExplicitSize settings
      
      * Add UI throttle for main resize observer handler
      
      * Throttle TableSimple render when editing a dashboard
      
      * Disable resize observer throttling in Cypress
      
      * Replace `for` loop with `forEach`
      
      * Remove ref from `Ellipsified`
      
      * Only update observer subscription when mode change
      Unverified
      b1689921
  25. Apr 26, 2022
  26. Apr 12, 2022
  27. Apr 02, 2022
  28. Mar 27, 2022
  29. Mar 25, 2022
  30. Mar 19, 2022
  31. Mar 18, 2022
Loading