Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 30, 2024
  2. May 17, 2024
  3. Apr 08, 2024
  4. Jan 18, 2024
  5. Jan 17, 2024
  6. Jan 04, 2024
  7. Dec 08, 2023
  8. Nov 15, 2023
  9. Nov 08, 2023
  10. Nov 07, 2023
  11. Oct 17, 2023
  12. Oct 04, 2023
    • Nemanja Glumac's avatar
      Remove `delete-file!` function (#34306) · 80ee48bf
      Nemanja Glumac authored
      It was deprecated and left in a codebase for backwards compatibility.
      But it seems we've migrated all references to the new method `delete-file-if-exists`.
      
      The last time this was touched was three years ago.
      Should be safe to remove.
      Unverified
      80ee48bf
  13. Sep 28, 2023
  14. Sep 05, 2023
  15. Sep 02, 2023
  16. Aug 22, 2023
    • Cam Saul's avatar
      Parallelize QP tests (August 2023 attempt) (#33068) · d54caf88
      Cam Saul authored
      * Parallel QP tests; linter improvements; move QP test fns
      
      * Cleanup
      
      * Move query->expected-cols
      
      * Fix QP test namespace
      
      * Test fix :wrench:
      
      * Fix merge issues
      
      * Revert unrelated changes
      
      * Test fix :wrench:
      
      * Fix some things that are actually ^:parallel safe
      
      * Remove Oracle logic for destroying DBs from different sessions since we don't test on AWS anymore
      
      * Use ReentrantReadWriteLock for getting + creating test datasets to avoid race conditions
      
      * Add non-`metabase.test` versions of things to the disallowed list for `^:parallel` tests
      Unverified
      d54caf88
  17. Aug 18, 2023
    • Nemanja Glumac's avatar
      Rename build.version-info to `version-properties` (#33345) · cd6aa464
      Nemanja Glumac authored
      We have to sets of functions that deal with the information about Metabase version.
      1. During build process we create `version.properties` file
      2. During release we create new `version-info.json` or `version-info-ee.json` files that we store in AWS
      
      The first contains the information about the current Metabase version.
      It's used to generate info in "About Metabase" window, among others.
      
      Calling both namespaces `version-info` leads to unnecessary confusion.
      This commit should make the disctinction between the two more obvious and clear.
      Unverified
      cd6aa464
  18. Aug 07, 2023
  19. Jul 21, 2023
  20. Jul 04, 2023
  21. Jun 26, 2023
  22. Jun 21, 2023
  23. Jun 20, 2023
  24. Jun 10, 2023
  25. Jun 09, 2023
  26. Jun 07, 2023
  27. Jun 04, 2023
    • Nemanja Glumac's avatar
      Update fallback for `interactive?` check (#31311) · ca8bdae5
      Nemanja Glumac authored
      We migrated from CircleCI a long time ago and are now using GitHub Actions.
      But even without that CircleCI, like many other CI providers, sets the
      `CI` environment variable to `true` or to `1` by default.
      
      This PR updates the `interactive?` check to use that env var as fallback.
      Unverified
      ca8bdae5
  28. Apr 26, 2023
    • Tim Macdonald's avatar
      Upload CSVs (#30256) · a06e640e
      Tim Macdonald authored
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * CSV: schema detection (#29650)
      
      * CSV / Admin Upload Settings (#29709)
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * Add defsettings
      
      * Add table prefix setting
      
      * add data upload settings
      
      * Add newline
      
      * update settings mock
      
      * Whether or not uploads are enabled
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Create table and insert rows from CSV uploads for postgres (#29677)
      
      * WIP create table and insert rows
      
      * Add newline
      
      * Use multimethods
      
      * WIP
      
      * Fix postgres
      
      * Fix postgres impl
      
      * Use detect-schema and add test
      
      * Fix load-from-csv arglists
      
      * Undo whitespace change
      
      * Use empty db instead
      
      * Add table and field tests
      
      * Remove prn
      
      * Uniquify names
      
      * newline
      
      * Add test for float
      
      * Add a test for the table contents
      
      * Tidy load-from-csv
      
      * Drop the table if loading the csv fails
      
      * Drop the table only if loading the csv fails
      
      * whitespace
      
      * Address SQL injection vulnerability
      
      * Use the slugified file-name as the table-name
      
      * Fix kondo
      
      * Using absolute path instead of relative
      
      * Fix kondo
      
      * Detect types for empty CSV files appropriately (#29754)
      
      * Create models from CSV uploads (#29966)
      
      * Wire up CSV uploads, sync the new table
      
      Still need to create a model
      
      * Check database support for CSV uploads better
      
      * Another test
      
      * Create model after sync
      
      * Fix request with formData
      
      * Fix tests
      
      * Fix tests
      
      * Revert "Fix request with formData"
      
      This reverts commit 66f146a41cf42feb34dbb03ed8566fa4220d0642.
      
      * Add whitespace
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix postgres support for uploads (#29922)
      
      * Check write perms for collection (#29976)
      
      * Rename metabase.csv -> metabase.upload (#29975)
      
      * Rename metabase.csv -> metabase.upload
      
      * Add docstring
      
      * Rename alias for release.common.upload
      
      ---------
      
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * WIP - 29598 csv status toast (#29757)
      
      * temp
      
      * generalize StatusListing types
      
      * Putting a pin in this for now
      
      * poorly done typing
      
      * generalizing upload function names
      
      * point to real API
      
      * Fixing Storybook
      
      * Permissions for Status Listing
      
      * use formdata and fix types
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      
      * Don't support redshift (#29981)
      
      * Handle uploads to the root collection (#29985)
      
      * Allow the uploads schema to be nil (for MySQL, etc.) (#29987)
      
      * CSV upload: fix stack overflow in detect-schema (#29983)
      
      * Fix stack overflow error on detect schema
      
      * map + vec -> mapv
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * reload collection data after upload (#30009)
      
      * MySQL support for uploads (#29829)
      
      * Add MySQL support for uploads
      
      * Rename arg to upload-type
      
      * Use new ns name
      
      * Allow no table-name prefix to be specified and fix tests
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix setting descriptions (#30023)
      
      * Batch CSV insertion for better performance (#30028)
      
      * CSV upload e2e tests (#30005)
      
      * add CSV upload e2e tests
      
      * update tests
      
      * H2 support for uploads (#29828)
      
      * Add uploads support for H2
      
      * Rename arg
      
      * whitespace
      
      * Use new metabase.upload ns name
      
      * Fix tests for H2
      
      * Make table and field matching case insensitive
      
      * Fix kondo error
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Clear CSV upload state after a while (#30014)
      
      * clear upload status after 5s
      
      * make async behavior clearer
      
      * CSV Upload Dates and Datetimes Types (#30076)
      
      * Simple dates
      
      * Simple datetimes
      
      * Fix coalesce for date and datetime
      
      * Add mysql and h2 types
      
      * Fix test
      
      * Misc cleanup
      
      * Fix test
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix Kondo (rebase gone wrong)
      
      * MySQL test fix
      
      * Fix order of Metabot setting
      
      * adding unit tests to upload actions and reducers (#30161)
      
      * adding unit tests to upload actions and reducers
      
      * use fetch-mock
      
      * Adding component unit test
      
      * Check CSV Upload permissions on the frontend (#30094)
      
      * CSV / Admin Upload Settings (#29709)
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * Add defsettings
      
      * Add table prefix setting
      
      * add data upload settings
      
      * Add newline
      
      * update settings mock
      
      * Whether or not uploads are enabled
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * properly check if user can upload to a collection
      
      * do some db checking
      
      * don't check admin status for upload notification
      
      * misc cleanup
      
      * fix rebase
      
      * add loggedin check to statusListing
      
      also combines container + view component into a single file
      
      * update unit tests
      
      * update tests
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Csv/misc bugfixes (#30219)
      
      * Support empty header names
      
      * Handle long CSV names more appropriately
      
      Handle duplicate column names in CSVs
      
      * Test fix
      
      * Partition CSV inserts a little more intelligently
      
      * Test fix
      
      * Remove 'duplicate' from duplicated column names
      
      * More intelligent sampling
      
      * Add comment re. Postgres table-name-length-limit
      
      * Quote column names, clean up tests
      
      When unquoted, we couldn't use reserved words (true, false, group, etc.)
      as column names
      
      * Fix test
      
      Now that we quote things, H2 is case-sensitive
      
      * Use dialect-appropriate quoting
      
      Also clean up some card-filtering tests so they work with a dirty DB
      
      * Fix deduplication
      
      * Remove use of setting/get
      
      * Remove unneeded migration
      
      ---------
      
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Fix test (#30383)
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      a06e640e
  29. Apr 18, 2023
  30. Apr 13, 2023
    • Braden Shepherdson's avatar
      Clean up dev and release CLJS and JS builds (#30072) · fe8da907
      Braden Shepherdson authored
      There are now four families of FE builds:
      
      - `build` does a one-shot dev build.
      - `build-watch` watches for changes and does dev rebuilds; no server.
      - `build-hot` is `build-watch` plus a development web server.
      - `build-release` is a one-shot release mode build.
      
      Each family has `:cljs` and `:js` variants, to build just one part.
      Unverified
      fe8da907
  31. Mar 30, 2023
  32. Mar 21, 2023
  33. Mar 13, 2023
  34. Mar 08, 2023
    • dpsutton's avatar
      Fix flaky json test (#29048) · fd5bd5e0
      dpsutton authored
      Occasionally in CI we get
      
      ```
      “Syntax error compiling at (release/version_info_test.clj:46:26).\nNo such var: json/read-json\n”,
      ```
      
      from `release.version-info-test`.
      This namespace requires `[clojure.data.json :as json]` and uses the
      function `json/read-json` which is deprecated since version 2.x.
      
      The way that deprecated function is defined in version 2.0.2 is
      
      ```clojure
      (ns clojure.data.json)
      ...
      (load "json_compat_0_1")
      ```
      
      and in `clojure/data/json_compat_0_1.clj`:
      
      ```clojure
      (in-ns 'clojure.data.json)
      
      (defn read-json
        "DEPRECATED; replaced by read-str.
        ...)
      ```
      
      And I guess the way that hawk requires some namespaces we can get into
      this half loaded, half not finished state and the var is not (yet)
      defined.
      
      So we can just put aside this nonsense and use a non-deprecated var that
      isn't defined with a `load` statement but in the regular namespace we
      require.
      Unverified
      fd5bd5e0
  35. Mar 07, 2023
    • dpsutton's avatar
      Update tools.build and usage (#28977) · b549b291
      dpsutton authored
      Calling our basis function with just :oss or :ee we don't end up with an
      `:argmap` key.
      
      ```clojure
      uberjar=> (def basis (create-basis :oss))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      nil          ;; nothing extra in oss
      
      uberjar=> (def basis (create-basis :ee))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      {:extra-paths ["enterprise/backend/src"]}
      
      ;; and if other aliases are used:
      uberjar=> (def basis' (b/create-basis {:project "deps.edn" :aliases [:dev :test]}))
      ,#'build.uberjar/basis'
      uberjar=> (:argmap basis')
      {:extra-deps {lambdaisland/deep-diff2 {:mvn/version "2.7.169"},
                    methodical/methodical {:mvn/version "0.15.1"},
                    io.github.metabase/hawk {:sha
                    "45ed36008014f9ac1ea66beb56fb1c4c39f8342b"},
                    ....}
       :extra-paths ["dev/src"...]
       :jvm-opts ["-Dmb.run.mode=dev" ...]
       :exec-fn metabase.test-runner/find-and-run-tests-cli}
      ```
      Unverified
      b549b291
  36. Mar 01, 2023
    • Cam Saul's avatar
      Release script fix (#28803) · cfc92762
      Cam Saul authored
      * Release script fix
      
      * Add test :wrench:
      Unverified
      cfc92762
    • Cam Saul's avatar
      Build script overhaul 2023 (#28767) · 3c980639
      Cam Saul authored
      * Build Script overhaul
      
      * Remove stray deps.edn
      
      * Include :ci profile for build and release tests
      
      * Fix release script
      
      * Update markdown dox
      
      * Update another dox
      
      * Tweakz
      
      * Don't pin new version of data.xml to core project, just for build scripts
      
      * Ignore unrecognized options
      
      * Fix i18n/enumerate
      Unverified
      3c980639
  37. Mar 14, 2022
    • Cam Saul's avatar
      Upgrade Liquibase to latest version; remove final Java source file and need... · aaf1b601
      Cam Saul authored
      Upgrade Liquibase to latest version; remove final Java source file and need for `clojure -X:deps prep` (#20611)
      
      * Upgrade Liquibase to latest version
      
      * Try adjusting log
      
      * Fix checksums for the TWO migrations with ID = 32
      
      * FINALLY get Liquibase to use Log4j2
      
      * Set Liquibase ConsoleUIService OutputStream to null OutputStream
      
      * Manually define a package for our H2 proxy class so Java 8 works
      
      * Fix package-name determination code
      
      * Update migrations file spec
      
      * `databasechangelog` shouldn't be upper-case
      
      * Lower-case quartz table names
      
      * More MySQL fixes :wrench:
      
      * Properties for all the Quartz tables :cry:
      
      * Formatting tweaks [ci skip]
      
      * Revert a few more busted changes
      
      * Fix more busted changes
      
      * Bump Liquibase version to 4.8.0 to fix MySQL defaultValueBoolean bug
      
      * OMG I think I finally fixed MySQL
      
      * Remove Java source file and prep-deps code
      
      * Remove two more references to bin/prep.sh
      
      * Minor cleanup
      
      * Revert unneeded changes
      
      * Fix busted indentation
      
      * Don't search inside java/ anymore since it's G-O-N-E
      
      * Appease the namespace linter
      
      * Update src/metabase/db/liquibase/h2.clj
      Unverified
      aaf1b601
  38. Jul 30, 2021
Loading