Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 26, 2020
  2. Nov 25, 2020
  3. Nov 24, 2020
  4. Nov 23, 2020
  5. Nov 19, 2020
    • dpsutton's avatar
      Unverified
      407aba6c
    • Walter Leibbrandt's avatar
      Order fields to dump by ID (#13839) · 79134b6b
      Walter Leibbrandt authored
      This is to ensure that fields are dumped in ID order, which is necessary to ensure that parent fields are insert _before_ their children.
      
      This issue was discovered while investigating a hosted instance for which snapshotting was failing. The failures were caused by the `fk_field_parent_ref_field_id` db constraint in Metabase being violated for a MongoDB database, indicating that child fields were being inserted before parent fields. This was confirmed experimentally, and being strict about the order of the field records were confirmed as the fix.
      
      This isn't a common issue, because it only affects fields that can have parent fields, like in MongoDB.
      Unverified
      79134b6b
    • Damon P. Cortesi's avatar
      Enable enterprise cypress tests on release branch (#13809) · c607ce23
      Damon P. Cortesi authored
      * Enable enterprise cypress tests (#13756)
      
      * Get auditing.cy.spec to pass
      
      * Skip custom drill through tests until we replace them
      
      * A few updates to the whitelabel test case:
      - Move custom colors into constant variable to reference throughout
      - remove some 'it' blocks we didn't need to speed up tests
      - Remove a few 'wait's
      - Restructure tests to be a bit more in line with best practices
      
      * Update the snippet permissions test:
      - Create test for just creating snippet as admin
      - Create test for inability to create snippet as user by default
      - Quarantine the user snippet creation test
      
      * Rename sandboxes
      
      * Replace legacy ENABLE_ENTERPRISE_EDITION env variable with MB_EDITION
      
      * Add MB_EDITION env variable to Cypress test run
      
      * Fix admin settings `auth` cypress test (#13841) [ci skip]
      
      * Fix `snippet` Cypress test for CI (#13843)
      
      - related: https://github.com/metabase/metabase-enterprise/issues/543
      
      
      
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      c607ce23
  6. Nov 18, 2020
  7. Nov 17, 2020
  8. Nov 16, 2020
  9. Nov 13, 2020
  10. Nov 12, 2020
  11. Nov 11, 2020
    • Cam Saul's avatar
      Mega sync performance improvements (#13746) · a81ae199
      Cam Saul authored
      * Add a Postgres test [ci postgres]
      
      * Mega-optimized SELECT probe query [ci drivers]
      
      * Mega sync improvements [ci drivers]
      
      * Even more amazing sync perf improvements [ci drivers]
      
      * Fix bad edit [ci drivers]
      
      * Test/lint fixes :wrench:
      
      * Test fix :wrench: [ci drivers]
      
      * Some driver fixes :wrench: [ci drivers]
      
      * Address PR feedback [ci drivers]
      
      * Test fixes for everything except for Oracle [ci drivers]
      
      * Fix Oracle [ci drivers]
      
      * Fix Redshift [ci redshift]
      Unverified
      a81ae199
  12. Nov 10, 2020
  13. Nov 09, 2020
    • Nemanja Glumac's avatar
      Port Cypress fixes/updates from `master` into `release-x.37.x` (#13743) · 8be8f81f
      Nemanja Glumac authored
      
      * Quarantine flaky tests (#13682) (#13683)
      
      * Quarantine flaky tests (#13682)
      
      * Add TODO note re: `describeWithToken`
      
      Co-authored-by: Nemanja Glumac
      
      * Add a circleci workflow that runs a set of Cypress smoketests (#12775)
      
      * Add a circleci nightly workflow that runs a bigger set of Cypress smoketests
      
      * Run this every hour while we're testing it, add a small fix to the admin test
      
      * Smoketests: Skip some known failing tests
      
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      
      * Narrow down the quarantine for chart_drill spec (#13682) (#13699)
      
      * CI: Fix the cache key for uberjar for running smoketest (#13698)
      
      Smoketest for OSS edition (for now)
      
      * Fix `settings/settings.cy.spec.js` flakes (#13701)
      
      - isolated flake (`it.only("should surface an error when validation for any field fails (metabase#4506)", () => {...})`) passed 10x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348275781)
      - the whole spec passed 20x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348306177)
      
      * CI: Update uberjar oss key for smoketest (#13704)
      
      * Fix Cypress flakes in `dashboard/dashboard.cy.spec.js` file (#13703)
      
      * Fix flakes in `revisions screen` block
      
      * Improve test assertions (there were some rendering problems, so I adjusted the assertions)
      
      * Narrow down the quarantine for dash_drill spec (#13682) (#13706)
      
      * Fix `metrics.cy.spec.js` flakes (#13709)
      
      * Fix `metrics.cy.spec.js` flakes (#13682)
      
      * Refactor the test using API
      
      * Smoketest: run nightly at 1am PST (#13711)
      
      1 am PST = 09:00 UTC
      
      CircleCI cron is for UTC:
      https://circleci.com/docs/2.0/workflows/#scheduling-a-workflow
      
      * Upgrade Cypress to v5.5.0 (#13674)
      
      * Upgrade Cypress to v5.5.0
      
      * Needed to unset the `DISPLAY` ENV through `config.yml` to finally make this work! (Reference: https://github.com/cypress-io/cypress/issues/4034#issuecomment-486773042
      
      )
      
      * Improve `segments` tests with the use of API (#13718)
      
      * Unquarantine `scenarios/pulse/pulse.cy.spec.js` (#13727)
      
      * Unset `DISPLAY` ENV in smoketests CI group (#13732)
      
      * Unquarantine ee `custom_drill_through/drill_through.cy.spec.js` [ci skip] (#13734)
      
      * Unquarantine `question/nested.cy.spec.js` (#13733)
      
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      Co-authored-by: default avatarDamon P. Cortesi <d.lifehacker@gmail.com>
      Unverified
      8be8f81f
    • Cam Saul's avatar
      Fix formatting temporal values with custom day of week (#13740) · f188ae29
      Cam Saul authored
      * Fix formatting temporal values as day of week with custom day of week (#13604)
      
      * Pretty
      
      * PR feedback
      
      * Need to update when user locale changes as well
      
      * Update Moment start of week in i18n.js instead
      
      * Make it nice
      
      * Remove some unneeded stuff
      Unverified
      f188ae29
Loading