Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 10, 2023
    • Aleksandr Lesnenko's avatar
    • metabase-bot[bot]'s avatar
      List actions endpoint (#29055) (#29131) · 3a003ad7
      metabase-bot[bot] authored
      
      * List all actions
      
      previously `api/action` required `?model-id=<model-id>`. This caused the
      FE to DOS the backend looping over each action. On stats I found 350 or
      so sequential requests, with app-db saturation leading to requests
      taking from 400ms near the beginning to 7seconds near the end.
      
      This makes `model-id` option and now returns actions on all models the
      user can see.
      
      ```
      ❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb
      [
          {
              "archived": false,
              "creator": {...},
              "creator_id": 1,
              "database_id": 3,
              "dataset_query": {...},
              "id": 1,
              "model_id": 1,
              "name": "source = foo",
              "parameter_mappings": null,
              "parameters": [...],
              ...
          }
          ...
      ]
      ```
      
      * update frontend for action picker to support single action list endpoint
      
      * list actions tests
      
      * update actions e2e tests
      
      * Return empty vector if no results
      
      Running tests locally might return some extra actions not asserted on in
      the tests. And there you might expect a 200. But CI runs with an empty
      database and returns no response so you get a 204. Quite annoying and
      there's no good way to expect a "2xx" status code at the moment. So just
      return the empty vector so it's always a 200 code.
      
      * update actions endpoint unit test mocks
      
      * Simplify logic a little
      
      * docstring tweak
      
      * schema with better error message
      
      * update mocks to accept optional modelId
      
      * simplify sorting and grouping
      
      * make sort case-insensitive
      
      * simplify action api test mocks
      
      ---------
      
      Co-authored-by: default avatardpsutton <dan@dpsutton.com>
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      3a003ad7
    • Aleksandr Lesnenko's avatar
      Remove personal collections from collection detail page (#28879) (#29089) · 33ed288f
      Aleksandr Lesnenko authored
      * Remove personal collections from collection detail page
      
      https://github.com/metabase/metabase/pull/28023
      
       Added "sub collections"
      to the collection detail page. Makes sense. The problem is that personal
      collections started appearing in this view. We have traditionally
      treated personal collections as siblings to the "Our Analytics" root of
      collections. So this was an impedence mismatch.
      
      This PR just removes all personal collections from the items returned
      from `"api/collection/root/items"`. The personal collection is still
      visible in the sidebar (returned from
      `api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true`
      . Furthermore, all personal collections are still visible from the
      "three dots" menu on the sidebar.
      
      * poke ci
      
      * remove last personal collections from tests
      
      * e2e tests
      
      don't include a personal collection in the details page.
      
      * off by one from removing personal collections
      
      * Can't select personal collections if they aren't there
      
      Co-authored-by: default avatardpsutton <dan@dpsutton.com>
      33ed288f
    • metabase-bot[bot]'s avatar
      pulling out column title logic and sharing with settings (#28937) (#29086) · 0a61a957
      metabase-bot[bot] authored
      
      * pulling out column title logic and sharing with settings
      
      * Pivot Table Custom Column Names
      
      * removing cyclic dependency
      
      * adjusting tests
      
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      0a61a957
  2. Mar 09, 2023
  3. Mar 08, 2023
  4. Mar 07, 2023
    • metabase-bot[bot]'s avatar
      Elevate field type in the action editor (#28862) (#28960) · 7a8bf439
      metabase-bot[bot] authored
      
      * Remove redundant `isSettings` prop
      
      * Extract `FormFieldEditorDragContainer`
      
      * Extract `FormFieldEditor` component
      
      * Update field editor UI
      
      * Disable validation in parameters editor
      
      * Fix crash on adding a new parameter
      
      * Add new tests and fix existing
      
      * Remove redundant `overflow: hidden`
      
      * Use shorter flex properties
      
      * Remove redundant `key` prop
      
      * Increase icon size
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      7a8bf439
  5. Mar 06, 2023
  6. Mar 03, 2023
  7. Mar 02, 2023
  8. Mar 01, 2023
    • metabase-bot[bot]'s avatar
      :robot: backported "Build script overhaul 2023" (#28782) · ed60a018
      metabase-bot[bot] authored
      
      * Build script overhaul 2023 (#28767)
      
      * Build Script overhaul
      
      * Remove stray deps.edn
      
      * Include :ci profile for build and release tests
      
      * Fix release script
      
      * Update markdown dox
      
      * Update another dox
      
      * Tweakz
      
      * Don't pin new version of data.xml to core project, just for build scripts
      
      * Ignore unrecognized options
      
      * Fix i18n/enumerate
      
      * Fix broken link
      
      ---------
      
      Co-authored-by: default avatarCam Saul <1455846+camsaul@users.noreply.github.com>
      Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
    • metabase-bot[bot]'s avatar
      [E2E] Regroup and move all related files to the root (#28749) (#28777) · 28b00a04
      metabase-bot[bot] authored
      
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      28b00a04
Loading