This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 10, 2023
-
-
Aleksandr Lesnenko authored
-
metabase-bot[bot] authored
* List all actions previously `api/action` required `?model-id=<model-id>`. This caused the FE to DOS the backend looping over each action. On stats I found 350 or so sequential requests, with app-db saturation leading to requests taking from 400ms near the beginning to 7seconds near the end. This makes `model-id` option and now returns actions on all models the user can see. ``` ❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb [ { "archived": false, "creator": {...}, "creator_id": 1, "database_id": 3, "dataset_query": {...}, "id": 1, "model_id": 1, "name": "source = foo", "parameter_mappings": null, "parameters": [...], ... } ... ] ``` * update frontend for action picker to support single action list endpoint * list actions tests * update actions e2e tests * Return empty vector if no results Running tests locally might return some extra actions not asserted on in the tests. And there you might expect a 200. But CI runs with an empty database and returns no response so you get a 204. Quite annoying and there's no good way to expect a "2xx" status code at the moment. So just return the empty vector so it's always a 200 code. * update actions endpoint unit test mocks * Simplify logic a little * docstring tweak * schema with better error message * update mocks to accept optional modelId * simplify sorting and grouping * make sort case-insensitive * simplify action api test mocks --------- Co-authored-by:
dpsutton <dan@dpsutton.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Aleksandr Lesnenko authored
* Remove personal collections from collection detail page https://github.com/metabase/metabase/pull/28023 Added "sub collections" to the collection detail page. Makes sense. The problem is that personal collections started appearing in this view. We have traditionally treated personal collections as siblings to the "Our Analytics" root of collections. So this was an impedence mismatch. This PR just removes all personal collections from the items returned from `"api/collection/root/items"`. The personal collection is still visible in the sidebar (returned from `api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true` . Furthermore, all personal collections are still visible from the "three dots" menu on the sidebar. * poke ci * remove last personal collections from tests * e2e tests don't include a personal collection in the details page. * off by one from removing personal collections * Can't select personal collections if they aren't there Co-authored-by:
dpsutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
* pulling out column title logic and sharing with settings * Pivot Table Custom Column Names * removing cyclic dependency * adjusting tests Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Mar 09, 2023
-
-
metabase-bot[bot] authored
* Adding classname prop to ObjectDetail * making className optional Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Mar 08, 2023
-
-
Anton Kulyk authored
* Properly connect actions to search entity * Add e2e test
-
metabase-bot[bot] authored
* adding hover states, switching icons for buttons * ChartSettingFieldsPicker unit tests * fixing background hover state * using userEvent.click instead of fireEvent * adjusting e2e tests Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Noah Moss authored
* Bind *card-id* when executing a dashboard subscription to fix perm checks (#28961) * bind *card-id* when executing a dashboard subscription so that perm checks work properly * refactor & address test comment * fix spacing * unskip repro that this also fixes * fix lint
-
metabase-bot[bot] authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix dashboard filter values coercsion for actions * update custom action e2e test to cover parameters --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
- Mar 07, 2023
-
-
metabase-bot[bot] authored
* Remove redundant `isSettings` prop * Extract `FormFieldEditorDragContainer` * Extract `FormFieldEditor` component * Update field editor UI * Disable validation in parameters editor * Fix crash on adding a new parameter * Add new tests and fix existing * Remove redundant `overflow: hidden` * Use shorter flex properties * Remove redundant `key` prop * Increase icon size Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- Mar 06, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Mar 03, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
metabase-bot[bot] authored
* WIP action data type tests * DRY up the actions tests * lots of type tests * make the tests work * reorganize tests * WIP action data type tests * DRY up the actions tests * lots of type tests * make the tests work * reorganize tests * reduce some flakes * better time formatting in action forms * sort out all the timezones
* update after rebase * rebase disaster Co-authored-by:Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Mahatthana (Kelvin) Nomsawadi authored
22788 fix custom column filter lose their settings when editing dashboards a second time (#28903) (#28913) * Refactor: Simplify code * Fix custom field parameter lose their settings Ref: https://github.com/metabase/metabase/issues/22788 this fixes the issue where custom field parameter seems to be unselected when editing dashboard a second time. The reason is because how current Metabase lib is handling expression's MBQL. In FE, we uses `["expression", "name", null] while in BE, we will normalize it to `["expression" "name"]`.
-
metabase-bot[bot] authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Previously, JS files isn't picked up by VS Code, so they'll have limited intellisence. Also, Jest and Cypress has conflicting names e.g. `describe` or `expect`. So, this commit attempt to resolve that as well. Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 02, 2023
-
-
metabase-bot[bot] authored
* Fix wrong aggregation field's `base_type` It should be the same as the underlying field, not a hard-coded number typ (`type/Integer` or `type/Float`) * Add unit tests Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
* WIP action data type tests * DRY up the actions tests * lots of type tests * make the tests work * reorganize tests * reduce some flakes * updates after rebase Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
- Mar 01, 2023
-
-
metabase-bot[bot] authored
* Build script overhaul 2023 (#28767) * Build Script overhaul * Remove stray deps.edn * Include :ci profile for build and release tests * Fix release script * Update markdown dox * Update another dox * Tweakz * Don't pin new version of data.xml to core project, just for build scripts * Ignore unrecognized options * Fix i18n/enumerate * Fix broken link --------- Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
* Register new E2E path alias * Move E2E support files * Move E2E runner files * Move E2E snapshot related files * Move E2E visual regression tests * Move E2E `downloads` scenarios * Move E2E `admin` scenarios * Move E2E `auditing` scenarios * Move E2E `bining` scenarios * Move E2E `ccollections` scenarios * Move E2E `cross-version` scenarios * Move E2E `custom-column` scenarios * Move E2E `dashboard` scenarios * Move E2E `dashboard-filters` scenarios * Move E2E `dashboard` reproductions * Move E2E `embedding` scenarios * Move E2E `filters` scenarios * Move E2E `joins` scenarios * Move E2E `models` scenarios * Move E2E `native-filters` scenarios * Move E2E `native` scenarios * Move E2E `onboarding` scenarios * Move E2E `organization` scenarios * Move E2E `permissions` scenarios * Move E2E `question` scenarios * Move E2E `visualizations` scenarios * Move E2E `sharing` scenarios * Move E2E `docker-compose` * Fix commands imports * Fix helpers imports * Fix downloads reproductions imports * Fix integration imports * Move visual regression tests * Various fixes * Move `validate-e2e-files` script * Add eslint rules for E2E folder * Improve file paths * Move `cross-version` tests into scenarios * Path fixes * Register E2E alias in tsconfig * Fix failing tests after rebase Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-