Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 26, 2022
  2. Oct 25, 2022
  3. Oct 24, 2022
  4. Oct 22, 2022
  5. Oct 21, 2022
    • Nemanja Glumac's avatar
      b3d4cd24
    • Maz Ameli's avatar
      Tweak copy and add educational link to the New -> Model screen (#26047) · 8793c847
      Maz Ameli authored
      * update new model copy
      
      * add educational button
      
      * remove EducationalButtonProps
      8793c847
    • Cam Saul's avatar
      Add `created_at` to Collection (#25871) · 7af4f706
      Cam Saul authored
      * Add created_at to Collection
      
      * Simplified migrations [ci skip]
      
      * Add SQL for H2 and MySQL; add tests
      
      * Sort namespaces
      
      * Test fixes :wrench:
      
      * Test fixes
      
      * Test fixes :wrench:
      
      * Make sure MySQL/MariaDB Liquibase generator sets the current timestamp function for ADD COLUMN
      7af4f706
    • Jeff Bruemmer's avatar
      update anchor links (#26070) · d54edd00
      Jeff Bruemmer authored
      d54edd00
    • adam-james's avatar
      Correctly Apply Column Formatting to Static Visualizations (#25493) · d1c61272
      adam-james authored
      * Column settings correct keys. Show Axes labels logic defaults 'true'
      
      These are two small changes related to static viz column formatting.
      
      The show axes labels logic change fixes a faulty assumption from an earlier PR where it was assumed that if
      :labels_enabled key was NOT present, then it was 'false'. The default however, is 'true', so the check had to change
      to reflect the frontend.
      
      Column settings have to be formatted so that the js code running in the backend looks in the right places. For
      example, `:number-format` must become `:number_format`. I move the function that does that change up so that it can be
      rolled up into `settings-from-column` to reduce the number of call sites for `update-col-for-js`.
      
      * Adjust number format fn to consider :decimal_digits of currencies
      
      * Simpler date-separator fix
      
      * Prevent non-temporal labels from being passed to datetime formatter
      
      * Table Temporal format columns are improved
      
      The column headers will now be properly looked up, the key format was incorrect before, causing the `:column_title`
      lookup to return nil, which ignores when a user changes the column name.
      
      Table columns with temporal formatting settings come in with `:unit` `:default`, so that case was added to the
      datetime formatter. Additionally, a helper function was added to pull the correct column viz settings to pass to the datetime.
      
      * Change some table rendering to look for '_' keys instead of '-'
      
      And also allow the field-id to take the form `[:field-id 10 nil]` OR `[:field-id 10]`
      
      * Added test utils for static-viz rendering. Docstrings for details.
      
      A big set of functions to enable cleaner static-viz rendering tests.
      
      Next push will be thorough table tests, and some other static viz cleanup
      
      * Add some viz-scenarios to help with table testing
      
      * Lint
      
      * Wrong map here
      
      * Currently unused bindings
      
      * Writing tests with render-test utils now, and catching new bugs
      
      * Use column's field ref to maybe get the column settings
      
      * Adjustments so that column-settings are properly grabbed
      
      * Number formatter no longer assumes decimal places
      
      The frontend will only display decimal places when strictly necessary OR when the column formatting dictates the
      number of decimal places to show.
      
      The number formatter on the backend made different assumptions about decimal places, so precision may be lost OR
      needlessly displayed.
      
      The formatter now checks the actual value passed in and adjusts the format string according to the decimal places
      present in the value, not just via column-settings, though the column settings will still take priority.
      
      * Shame on me. inline def is not needed here :/
      
      * Adjust number format tests to assert that now we match FE behavior
      
      * Really trying to get formatting buttoned up.
      
      * Matching frontend's default format behavior for numbers
      
      * Some tests failed because they assumed two decimal places always
      
      * Values less than one still round after 2 sig-figs
      
      * Column formatting on tables follows expected default behavior
      
      * Getting public-settings included in number and datetime formatters
      
      * Test for custom formatting public settings
      
      * Removed unused require.
      
      * address some PR feedback
      
      * Try to clarify the logic in the number formatter
      
      * Add some clarifying comments
      
      * Use the existing viz tools to help create field-refs properly
      
      * Cleaned up column-name impl. to use normed field-refs. Much nicer!
      
      * Remove some unnecessary tests, and add a negative scientific num
      
      * Simplify table columns test
      
      * Simplify and add more format settings to column-formatting test
      
      * Unused require
      
      * Another one
      
      * Fix format of column refs in test
      
      * Remove unused thread
      d1c61272
    • Braden Shepherdson's avatar
      Serdes v2: Refactor entire serdes flow to use real Toucan, not low level (#25981) · a9f44010
      Braden Shepherdson authored
      Previously, some automatic behavior was causing problems in serdes.
      (The worst example is generating an `entity_id` on insert while
      deserializing an entity we don't own - if deserialized again it would be
      duplicated.)
      
      A whole cascade of design choices fell out of this problem:
      - `insert!` would generate `entity_id`s, so use `simple-insert!`
      - But `simple-insert!` doesn't convert eg. MBQL `:definition` maps back
        into JSON strings
      - We got the maps as Clojure data and not JSON strings because `select`
        and `simple-select` both run `post-select` and parse the JSON.
      - So we ended up with a raw query on the select side and `simple-insert!`
        on the storage side.
      
      This change unwinds that whole stack, and instead uses a dynamic
      var to suppress the few pieces of `pre-insert` and `pre-update` logic
      that causes problems.
      
      The end result is much cleaner, and much more consistent with the rest
      of Metabase's backend logic.
      a9f44010
    • Natalie's avatar
      docs - update email (#26056) · 760eb6d9
      Natalie authored
      760eb6d9
    • Cal Herries's avatar
      Fix back navigation (#26049) · 8d7f1753
      Cal Herries authored
      8d7f1753
    • Natalie's avatar
      docs - update aws elastic beanstalk (#26042) · cfa280e1
      Natalie authored
      cfa280e1
    • Tim Macdonald's avatar
      Ensure static visualizations with multiple cards are rendered (#25811) · 6c226a69
      Tim Macdonald authored
      * Ensure static visualizations with multiple cards are rendered
      
      [Fixes #21559]
      
      * [static viz] Render multiple scalars as a bar chart
      6c226a69
  6. Oct 20, 2022
  7. Oct 19, 2022
    • Case Nelson's avatar
      [Apps] Remove emitters (#25999) · f5a9ea85
      Case Nelson authored
      * [Apps] Remove emitters
      
      Emitters were created when we thought that we would be adding actions to
      multiple places in metabase. Instead we've coalesced to actions being a
      core feature of data-apps and are executed from within them. Attaching
      actions to models, as a form of re-use rather than a form of execution,
      means that actions can still be executed directly from a model, if we
      want to allow that in the future.
      
      * Fix lint errors
      
      * Move perform-action! tests out of the api.
      
      Since we want to keep the implicit bulk functionality but remove those
      endpoints move the tests to the actions namespace.
      
      * Fix linter
      
      * Change driver test to use function instead of endpoint
      f5a9ea85
    • metamben's avatar
      Remove data app permission code (#26016) · b8c92cf1
      metamben authored
      * Revert "Use "apps" collection namespace for app collections (#25963)"
      
      This reverts commit a1894202.
      
      * Revert "Implement EE/Pro app permissions (#25764)"
      
      This reverts commit cf9b1bf5.
      
      * Revert "Implement global app permissions for the "All Users" group (#25679)"
      
      This reverts commit 63e950f2.
      
      * Revert "Require data permissions for executing actions (#25784)"
      
      This reverts commit 732bf6b1.
      
      * Revert "Prevent modifying app permissions via the collection endpoint (#25684)"
      
      This reverts commit 5d3f8279.
      
      * Revert "Implement DB specific execution permissions (#25629)"
      
      This reverts commit 141a13ce.
      
      * Revert "Introduce /execution/ permission (#25529)"
      
      This reverts commit 57cbb921.
      
      * Keep the app permission revision table
      b8c92cf1
    • Cal Herries's avatar
      Remove unused CardTagEditor code (#26008) · 81c3639c
      Cal Herries authored
      * Remove CardTagEditor
      
      * Remove unused cardTagRegexFromId
      81c3639c
    • Case Nelson's avatar
      [Apps] Disable data-apps prior to release (#25982) · 51147027
      Case Nelson authored
      This ensures that the api endpoints and the relevant models cannot be
      created.
      
      We enable during testing, so that we can ensure the integration points
      like permissions, search, collection items, etc... will continue to be tested.
      51147027
    • Natalie's avatar
      docs - restore sample db (#25944) · 32d8638f
      Natalie authored
      32d8638f
    • Cal Herries's avatar
      Fix SidebarContent padding (#26005) · 513b919a
      Cal Herries authored
      513b919a
    • metamben's avatar
      Revert "Prevent repeated coercion of fields (#24718)" (#26004) · 1e4d8bdd
      metamben authored
      This reverts commit 23666516.
      1e4d8bdd
Loading