This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 29, 2024
-
-
Kamil Mielnik authored
* Refactor dashboard helpers to TypeScript * Reuse existing helper * Refactor cy.createQuestionAndDashboard to a function helper - there was no good place to put it, so I also created new helpers/api directory - and I moved all helpers using cy.request (with 1 exception, where a CSV download helper also does a bunch of assertions) in there * Merge TS command definitions into a single file * Export types * Make dashboardDetails optional * Export StructuredQuestionDetails * Remove duplicated function * Extract createNativeQuestion to separate file - 1 exported helper per file, no exceptions! * Reuse const * Remove old definitions * Add missing export
- Jul 26, 2024
-
-
Denis Berezin authored
* Migrate DahboardSidebars to TS * More fixes for types
-
Alexander Polyankin authored
* Fix homepage dashboard being loaded everywhere * Fix * Fix
-
Oleksandr Yakushev authored
* perf: Optimize metabase.lib.schema.util/unique-uuids? * perf: Allocation improvements on sync-db/fingerprinting path
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
* Remove unused dimension options * Fix test
-
Braden Shepherdson authored
The `dashboard_load_id` is attached to the body for queries, not as a query parameter. This correctly receives the `dashboard_load_id` and uses it for `/query` calls.
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
Ryan Laurie authored
* filter invalid recent and search items in move modal * e2e test disabled moving search and recent items * update test
-
bryan authored
* pull sdk info into data on-thread * include api tests for query_execution and view_log * Try mt/test-helpers-set-global-values! - disambiguate names used in tests * pass test + cleanup test helper * make sure view logging is enabled in test
-
Alexander Polyankin authored
* Remove unused properties * Remove unused properties * Remove comment * Experiment * Simplify * general cleanup and adding dashboard links handling * fix tests, link cards; sort output * include databases from queries, not just tables, fix card sort * use a simplified get-databases that doesn't throw * Fix tests --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Oisin Coveney authored
-
Braden Shepherdson authored
This was missed in the original PR #45394 due to clumsy `git` wrangling; my bad.
-
Ryan Laurie authored
* refetch metric after save to log view * Update e2e/test/scenarios/metrics/metrics-editing.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Ryan Laurie authored
-
Cal Herries authored
-
Alexander Polyankin authored
* Add a test * Add a unit test for TextLike
-
- Jul 25, 2024
-
-
Raphael Krut-Landau authored
fix(admin/nav): Ensure that the "Exit admin" button can be clicked regardless of locale or viewport size (#45882) Closes #45876
-
adam-james authored
* fix conditional formatting color lookup with correct col names The column names for color lookup are expected to be the same as the :name key of each column, and applying column formatting broke this lookup. This fixes it. * move overflow-x into pulse body div to exlude card title from scroll * add a test for conditional formatting w/ a hidden row. This still fails at the moment, working on a fix yet. * apply conditional formatting in static viz even when col is hidden Conditional formatting that depends on a hidden column was not being rendered in the static viz, but now we pass all columns into the color selector fn, thus when rendering the table with the ordered/hidden columns, all other columns will still use their appropriate conditional formatting * I missed a linter warning * fix tab rendering * fix test * fix up tests with some better structural searching
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Do not store elements in a `const` * Remove mid-test save and edit dashboard
-
metamben authored
Add Azure managed identity support --------- Co-authored-by:
Case Nelson <case@metabase.com>
-
Uladzimir Havenchyk authored
-
Raphael Krut-Landau authored
Closes #45127
-
Raphael Krut-Landau authored
Closes #45916
-
Uladzimir Havenchyk authored
-
bryan authored
* Adds a middleware that sets 2 dynamic vars - These vars will be used to insert context for embedding analytics * migration adding embedding_client and embedding_version to qe and vl tables * clarify function api * headers come in -> dynamic vars -> written to db When the vars are set we insert their values into query execution and query_log under embedding_client and embedding_version. * update update migrations * add predconditions to migrations * fix tablenames + dataset_test * Code Review responses - remove commented out requires - clarify test for merge-count-maps
-
Raphael Krut-Landau authored
feat(question): Make two messages in the question footer - query runtime and cache age - more useful (#46072) Closes #46009
-
John Swanson authored
* Lock down the trash collection more Oops. I was very thorough in checking that you couldn't modify the trash collection in the sense of moving things to or from it. I missed the most obvious thing: actually modifying the trash collection itself. So if someone wanted, they could change the name of the Trash to "Definitely Not the Trash". * Remove the Trash Collection from serialization Serialization tests were failing due to the previous change, but this got me thinking, and I realized that serializing the Trash collection is completely unnecessary. We want to create it programatically on startup (which we are) and then nothing should change it afterwards.
-
John Swanson authored
I tightened this up by removing the condition here, thinking that CI would catch it if it was necessary - but I'm getting failures in development. Oops - didn't realize that this defmethod wasn't actually applied during CI runs.
-
Noah Moss authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Raphael Krut-Landau authored
Closes #46123
-
Oisin Coveney authored
-
use-tusk[bot] authored
* Updating Tusk Sanity GitHub workflow * fix: automatic Tusk self-review --------- Co-authored-by:
use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
-
bryan authored
* add mu/defn- * use new built-in mu/defn- * mu/defn- preserves metadata --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Nemanja Glumac authored
* Rewrite repro for 27643 * Add TODO for the remaining tasks * Make a test name consistent with others * Finish the E2E test for #27643 * Fix the test to use PostgresDB Since H2 originally doesn't fail the test * Attempt to fix a flake on CI by waiting for table to finish syncing * Create QA snapshot with fully synced field metadata * Fix failed tests from field metadata change * Simplify question scenarios * Simplify dashboard scenarios * Fix permissions * Rework titles * Add comment about PG * Add limit to speed things up * Fix and improve dashboard assertions * Fix and improve question assertions --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
adam-james authored
* Bigquery Pagination Use next page to get proper results Fixes 45953 WIP * use new-page in values-iterator * disable just the part of the test that is still flaky Want to keep the other part of the test that does prove we're not getting duplicates due to incorrect pagination.
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
Noah Moss authored
Make the sandbox cleanup logic more robust, and reorganize some perms code for better testing (#46102)
-