This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 05, 2023
-
-
Cal Herries authored
-
Tim Macdonald authored
-
- Jun 02, 2023
-
-
Case Nelson authored
* [MLv2] Add expressionable-columns * Fix test
-
Cam Saul authored
Use MLv2 for metadata calculation in QP (part 1); make column name calculation consistent with QP (#29583) * Simplified impl * Add #31266 test * Yay * Very nice * Test fixes * Fix Kondo warnings
-
Cam Saul authored
* Ban `tt/with-temp` and convert usages to Toucan 2 * Ban `tt/with-temp*` and convert usages to Toucan 2 * Revert changes not meant for this PR * Ban `mt/with-temp` and replace usages with `t2.with-temp/with-temp` * Fixes
* Fix indentation * fix syntax in models.secret_test --------- Co-authored-by:Ngoc Khuat <qn.khuat@gmail.com>
-
john-metabase authored
-
Braden Shepherdson authored
That's `:datetime-add`, `:datetime-subtract`, and `:convert-timezone`. Fixes #29910
-
Cal Herries authored
* Add reverse migration for AddJoinAliasToVisualizationSettingsFieldRefs * Limit selections to query_type="query" * Make like strings more specific * Fix where clause * Further optimize where clause * Rename and refactor * Update test name * Fix indentation and naming consistency
-
Cam Saul authored
-
Cam Saul authored
* Ban `tt/with-temp` and convert usages to Toucan 2 * Ban `tt/with-temp*` and convert usages to Toucan 2 * Revert changes not meant for this PR
-
- Jun 01, 2023
-
-
Case Nelson authored
* [MLv2] Change expressions map into a vector of expressions * Fix tests
-
Cam Saul authored
* Ban `tt/with-temp` and convert usages to Toucan 2 * Revert changes not meant for this PR
-
Cam Saul authored
-
Cam Saul authored
-
Cam Saul authored
* `visible-columns` should return all columns from joins regardless of `:fields` * Backport stuff from #31266 * fieldableColumns [WIP] * MLv2 `fieldable-columns` * Remove redundant comp
-
Case Nelson authored
* [MLv2] Keep order-by in sync when replacing breakouts * Handle removing order-by when changing breakouts
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
- May 31, 2023
-
-
john-metabase authored
-
Ngoc Khuat authored
-
Cal Herries authored
* Apply inclusion and exclusion patterns to `driver/syncable-schemas` for sql-jdbc drivers * Fix kondo * Fix postgres test * Remove unnecessary test DB names
-
- May 30, 2023
-
-
Braden Shepherdson authored
Fixes #29935. Part of the issue here was incorrect hand-rolling of the second argument to `:case`, the default value. In the failing test case given in #29935, it was written as `{:default 0}`. But that's accidentally transferring for legacy MBQL works, where the default is an option and the options come last rather than first in a clause. This also fixes `lib.common/->op-arg` to make sure it recurses properly. It wasn't recursing into lists or MBQL clauses, which left unresolved `(fn [query stage] ...)` functions in eg. `:case` alternatives, since those are nested inside lists.
-
bryan authored
* add migration for typed collections * add hydration of collections to card+dashboard api - adds it for: - GET /api/question/:id - GET /api/dashboard/:id * fix test that checks for collection shape * get tests working with hydrated collection * typo fixes * fix more tests - PUT requests don't hydrate :collection * update tests to fix param_values {} vs nil inconsistencies
-
Tim Macdonald authored
* Use faster inserts in MySQL * Add local_infile check * PR feedback * Fix boolean handling for MySQL * Fix tests; fix MySQL fallback if local_infile is turned off * Turn local_infile on for MySQL tests * Another way of doing MySQL local_infile :/ * sanitize-file-name was a misstep. Not needed for security and could cause problems * Mistaken docstring
-
Braden Shepherdson authored
This was causing ambiguous references, since `order-by` clauses reference columns from previous stages by name. Fixes #30401.
-
Cal Herries authored
-
- May 29, 2023
-
-
Case Nelson authored
* Add initial filterable columns implemenation * Implement filterable-columns Change filters to return internal clauses rather than external operators * Add comments
-
metamben authored
-
Cal Herries authored
Hydrate whether actions are enabled/disabled for the database on action dashcards instead of using GET /api/database/:id (#31021) --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
metamben authored
-
Cal Herries authored
-
- May 26, 2023
-
-
Mark Bastian authored
We use async to monitor ddl execution for MySQL since it does not have the concept of a (non-select) statement timeout. @snoe had originally set this to 10 minutes, but (we believe) this was causing tests to run exceptionally long and 30 seconds felt more reasonable. After receiving customer feedback that we actually do need longer timeouts, we are restoring the timeout to 10 minutes. Links containing context: - https://github.com/metabase/metabase/pull/23443 - https://github.com/metabase/metabase/pull/27858 - https://metaboat.slack.com/archives/CKZEMT1MJ/p1685128597747419 Fixes #31102
-
metamben authored
-
Cam Saul authored
* Fix `:convert-timezone` and `:get-week` schemas * Make sure moment-timezone stuff gets loaded in Cljs
-
Cam Saul authored
* MLv2: TS wrappers for `fields` and `withFields`; minor tweaks * Fix type declaration
-
lbrdnk authored
* Fix native source query handling for mongo * Add test for mongo nested native query * Fix mongo `aggregation-at-index` usage * Add test for source query with aggregation and sort * Adjust test for presto and oracle * Add PR suggestions
-
Ngoc Khuat authored
* Dashboard Tab entity (#29802) * add dashboard tab entity * Dashboard tabs CRUD (#29861) * Dashboard tabs frontend (#30189) * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx` commit-id:7cdfd86a * add tabs to dash commit-id:d3c2fa74 * improve code structure and other fixes * rename `dashboardtab_id` to `dashboard_tab_id` * remove explicit `position` logic * improve code quality * add renaming functionality * add two new tabs when creating first tab * hide tabs if there is only one * add unit test for `DashboardTabs` component * refactor * fix type errors * add `tabId` to text cards * add `tabId` to link cards * add `tabId` to action button * use disabled state when only one tab remains * refetch cards with filter value when changing tabs * add e2e test * fix broken e2e tests * add horizontal scrolling * fix unit test * fix create tab button being on right * fix performance issue when switching tabs * add `ttag` to `tabs.ts` * use `aria-label` in e2e test helper * fix type error after rebasing * making ordered_tabs optional for tests purposes * fix failing unit tests * fix failing e2e tests * fix flaky revision history e2e test * fix type error after merging feature branch with master and rebasing * fix revisions unit test * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * migrating revision logic to BE * handle description for multiple cards add/remove * test fixes * adds tests * make sures events are started so tests work * remove additional `:maybe` that was added while rebasing * add title and has_multile_changes to revision * fixes potential test flake * more tests * remove debug code * handles collection change description in card and dashboard * fixes fail to build * use backend for revision history (#30772) * use BE response for revision history * update `service.unit.spec.js` * sort revision and moderation events for question timeline * test fixes * create revision directly instead of via API to avoid flake * reverted to an earlier revision => reverted to an earlier version * translate the model name too * Rename functions: - diff-strs -> diff-strings - diff-strings -> diff-strings* - diff-strings* -> diff-string * move the diff to diff-strings* * use case instead of map for model-str->i18n-str * remove title from API response * do not translate test model * rename var `title_text` to `titleText` * address comments * stringify the display name * fix revert button not working * add loading wrapper to fix unit test * fix tests * fix type error * fix QuestionActivityTimeline test * add a dot for edited this --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
Cal Herries authored
* Fix not being able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled * Fix test
-
- May 25, 2023