This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 27, 2023
-
-
Noah Moss authored
Ignore another clj-kondo library config missed by https://github.com/metabase/metabase/pull/36889 This was causing dirty changes to be left in the repo after running `bin/kondo.sh`. The script should be clean after this change, I think.
-
Noah Moss authored
Fixes misc clj-kondo errors in tests (and one random whitespace issue in a src namespace).
-
Alexander Polyankin authored
-
Noah Moss authored
-
Anton Kulyk authored
-
Uladzimir Havenchyk authored
* Upgrade chromatic * Revert back to NODE_ENV * Sync storybook packages * Replace imports from clients-api to addons
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Filip Hric authored
Add delay instead of throttle. Fixing a flake analyzed in this document. https://replayio.notion.site/dashboard-filters-reproductions-25322-loading-list-19324262f19d404ba03787c9f70968ab The test `25322-loading-list-values.cy.spec.js` has become flaky because the period of time to find loading-spinner element is too short. This is thanks to API response being fast. in the past, this was partially remedied by adding `setThrottle()` method to slow the API response down. while it is a good initial approach, it is not resilient to a situation when the data transfer size becomes smaller. I’m suggesting changing the method to setTimeout that will give the test enough time to catch the loading state. In the future, this particular test would be a good candidate for a component test as it is quite granular.
-
Nemanja Glumac authored
From the maintainer: "includes a fix for a bug your tests were hitting in a couple places".
-
Nemanja Glumac authored
This code has been commented out for the last six years!
-
- Dec 26, 2023
-
-
Oisin Coveney authored
* Add fixes * Quick changes * Fix e2e issues * Attempt to fix public-question test * Update embedding setup icons and disabled card state * Potential fix for failing e2e * Remove failing e2e tests as it is covered by unit tests --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Dec 25, 2023
-
-
Nicolò Pretto authored
* feat: single view for embedding settings regardless of setting status (#36802) * feat: single view for embedding settings regardless of setting status * refactor: rename component as now it doesn't container legalese * rename component and refactor * remove unused prop type * test: update e2e * fix not handling null value * fix: keep same behaviour for event * Update frontend/src/metabase/admin/settings/components/widgets/EmbeddingSwitchWidget/EmbeddingSwitchWidget.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * use target instead of currentTarget --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * remove deprecated event on embedding settings (#36857) * feat: Update the UI and copy of the embedding options cards (#36819) * feat: adds icon and some other small ui change * update buttons and ui * update links/buttons for interactive embed option * update unit tests * make e2e pass with the new changes * make unit test pass * integration/unit tests for embedding settings * fix herf -> href
* fix e2e suite * refactor: splti components in two * update url as by updaterd product doc * fix imports * update width as by design * fix linting error * fix copy * update layout, paddings, fontsize etc * add upgrade text * other ui fixes * last minute copy change * inline variable in tests to avoid beforeEach * fix typo * fix e2e by moving assertion on the correct page * fix typo in unit * update link as per product doc * inlie urls * only return used parts in setup function * e2e: update e2e upgrage url * remove oss version of the interactive embedding settings page (#36938) * remove oss version of the interactive embedding settings page * fix redirect logic + add tests * add key to make react not complain * merge lists of embedded questions and dashboards to have new heading structure (#36944) * feat: adds icon and some other small ui change * update buttons and ui * update links/buttons for interactive embed option * update unit tests * make e2e pass with the new changes * make unit test pass * integration/unit tests for embedding settings * fix herf -> href * fix e2e suite * refactor: splti components in two * update url as by updaterd product doc * fix imports * update width as by design * fix linting error * remove oss version of the interactive embedding settings page * merge lists of embedded questions and dashboards to have new heading structure * fix redirect logic + add tests * add key to make react not complain * use plain strings instead of regex when possible * remove regex for testids * fix copy * update layout, paddings, fontsize etc * add upgrade text * other ui fixes * last minute copy change * inline variable in tests to avoid beforeEach * fix typo * fix e2e by moving assertion on the correct page * fix typo in unit * update link as per product doc * inlie urls * only return used parts in setup function * e2e: update e2e upgrage url * update interactive embedding settings page ui (#36949) * feat: adds icon and some other small ui change * update buttons and ui * update links/buttons for interactive embed option * update unit tests * make e2e pass with the new changes * make unit test pass * integration/unit tests for embedding settings * fix herf -> href * fix e2e suite * refactor: splti components in two * update url as by updaterd product doc * fix imports * update width as by design * fix linting error * remove oss version of the interactive embedding settings page * merge lists of embedded questions and dashboards to have new heading structure * update interactive embedding settings page ui * fix redirect logic + add tests * add key to make react not complain * use plain strings instead of regex when possible * remove regex for testids * fix copy * update layout, paddings, fontsize etc * add upgrade text * other ui fixes * last minute copy change * inline variable in tests to avoid beforeEach * fix typo * fix e2e by moving assertion on the correct page * fix typo in unit * update link as per product doc * inlie urls * only return used parts in setup function * e2e: update e2e upgrage url * rename test files with correct naming (#37044) * rename test files with correct naming * test: fix setup functions and add enterprise suite * Fix interactive embedding link target * Update embedding toggle copy * Use default setting labels * Fix failed E2E test --------- Co-authored-by:Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
- Dec 24, 2023
-
-
Ngoc Khuat authored
-
- Dec 22, 2023
-
-
Nicolò Pretto authored
* adds "applications-colors" to the settings type and to createMockSettings this removes errors in jest output when using enterprise plugins * use EnterpriseSettings to avoid typechecking errors
-
Noah Moss authored
-
Denis Berezin authored
* Add SegmentedToggle component from mantine * Code review fixes * Fix dependencies issue
-
Braden Shepherdson authored
Progress towards #37067, might not fix it entirely. There may be other bugs stemming from the string `:fk-field-id`, but I can't reproduce it locally.
-
Alexander Solovyov authored
-
Oisin Coveney authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Uladzimir Havenchyk authored
* Upgrade path-parse to 1.0.7 * Upgrade color package to 4.2.3 * Upgrade d3-color to 3.1.0
-
Cal Herries authored
-
John Swanson authored
This required a bit of modification of the DB. First, I had named the column meant to hold the ID of the user who last updated an API key as `updated_by`. But it seemed like `updated_by` was the natural field to hold the user name that FE wanted, and I didn't want to clobber an existing field with `hydrate`. So, I renamed the existing column to `updated_by_id` and used `updated_by` to hold the hydrated user that updated the ApiKey. Second, for consistency, I renamed `created_by` to `creator_id`. The logic for presenting an ApiKey was getting a bit complicated and spread out over many different endpoints, so I pulled it out into its own function that's called from almost every endpoint defined in the `metabase.api.api-key` namespace. Note that it calls `(t2/hydrate api-key :updated_by :group_name)` - but I verified that this will not result in additional DB calls if the model was already hydrated.
-
Cal Herries authored
-
Oleg Gromov authored
-
John Swanson authored
While implementing this, I realized that I made a mistake when implementing the Create endpoint - I returned a `group_id` instead of the `group_name` that frontend had requested to get back from the List endpoint. I think for consistency's sake it's best to return `group_name` from both endpoints. To achieve this, I added a hydration method to the ApiKey. It adds the name of a single group to each ApiKey, preferring group names that aren't "All Users". Beyond that, the 3 new endpoints are pretty straightforward. All are audit logged, and I added audit logging to creation as well. Note that the API Key prefix is audit logged. I don't think this should be a problem - we can think of the prefix as the "public" portion of the key, like a username.
-
Alexander Polyankin authored
-
lbrdnk authored
* Use driver multi instead of jdbc specific calls * Factor out `notify-database-updated` function * Add notify databases test utils * Remove parallel and add TODO comment
-
lbrdnk authored
* Add remove remark functionality to athena * Update frontend/src/metabase/databases/constants.tsx Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update comment --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Dec 21, 2023
-
-
Ngoc Khuat authored
* Kondo: ignore all libraries config * Add README * Update .gitignore
-
Oleg Gromov authored
-
Anton Kulyk authored
-
shaun authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Lars Klingen authored
* Dont retry cancelled queries on Bigquery * Add test coverage for ignoring retry on cancellation * Cancel running BQ jobs on cancellation request * Fix indentation * Throw exception with cancelled flag * Join lines * Change unique query string * Fix parentheses Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Change e to ex-data * Set namespace explictly in mock exception * Rename query identification string * Use bigquery namespace Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Remove query cancellation code * Remove comment --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Dec 20, 2023
-
-
Noah Moss authored
-
Noah Moss authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Mark Bastian authored
* Renamed columns are displayed correctly in downloads (#18572) When custom viz settings or metadata is applied to questions and models, the downloaded artifact labels do not always mirror what is displayed on the tabular view in Metabase. This happens for several reasons: - The `:visualization_settings` were not applied to CSV and JSON downloads - `update-card-viz-settings` in `metabase.query-processor.middleware.visualization-settings` did not correctly merge keys, resulting in dropped column names in Excel file - The logic for reconciling column metadata in a result set and the keys in `:visualization_settings` of a query result is not straightforward This PR is an attempt to move this consistency in the right direction without fixing all the challenges of field matching as discussed in [this thread](https://metaboat.slack.com/archives/CKZEMT1MJ/p1703091539541279) and [this issue](Duplicated columns in a source query cannot be distinguished #36185) as this sounds like a significant effort. The following changes were made: 1. Update `metabase.query-processor.middleware.visualization-settings/update-card-viz-settings` to merge field settings, if present, into `column-viz-settings` without introducing new keys, especially ambiguous keys as follows: ```clojure (defn- update-card-viz-settings "For each field, fetch its settings from the QP store, convert the settings into the normalized form for visualization settings, and then merge in the card-level column settings." [column-viz-settings field-ids] ;; Retrieve field-level settings (let [field-id->settings (reduce (fn [m field-id] (let [field-settings (:settings (lib.metadata/field (qp.store/metadata-provider) field-id)) norm-field-settings (normalize-field-settings field-id field-settings)] (assoc m field-id norm-field-settings))) {} field-ids)] ;; For each column viz setting, if there is a match on the field settings, merge it in, ;; with the column viz settings being the default in the event of conflicts. (reduce-kv (fn [coll {field-id ::mb.viz/field-id :as k} column-viz-setting] (assoc coll k (merge (get field-id->settings field-id {}) column-viz-setting))) {} column-viz-settings))) ``` The primary difference is rather than merging in new keys as `{::mb.viz/field-id field-id} -> field-settings` this code will merge settings found by field id with any `column-viz-setting` containing that field id as part of its key. The merge prefers `column-viz-settings`. This should be an improvement over what already exists. 2. Move `column-titles` from `metabase.query-processor.streaming.xlsx` to `metabase.query-processor.streaming.common` and use this common function for CSV and JSON export names. Note that the lifted `column-titles` has some erroneous logic: - It relies on column `:name` or `:id` as unique identifiers -- they are not always unique. - It expects the `col-settings` key format to be exactly `{::mb.viz/field-id id}` or `{::mb.viz/column-name name}` -- Sometimes these keys have additional keys. One change made to this function is normalizing `col-settings` to conform to the expected format by removing extra keys. While this isn't a perfect solution, it conforms with the intent of what already exists and is an improvement in the majority of cases. The _right_ thing to do is _probably_ to use `metabase.lib.equality/find-matching-column` to match the column and settings keys, _but_ the `col-settings` keys are in a weird format that isn't really conducive to doing this. I'd rather we make an incremental step forward and try doing this in another effort. This second change should not make anything that wasn't already problematic worse, while making the general case better. * Updated `update-card-viz-settings` for unique fields case When `update-card-viz-settings` is called, sometimes fields have ids that aren't part of the `column-viz-settings` map. For cases where they are part of the viz settings map, they are merged in, potentially more than once. For cases where the field ids aren't found in the column viz settings but do have settings, we add these in as new entries. * Test for JSON keys * Fixed broken unit test that had the wrong data shape.
-
Oleg Gromov authored
-