This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 07, 2022
-
-
Cam Saul authored
-
- Apr 05, 2022
-
-
Cam Saul authored
* Remove :google driver * Remove unneeded stuff * Remove another reference to :google driver * Remove another reference to :google
-
- Apr 01, 2022
-
-
Noah Moss authored
-
- Mar 24, 2022
-
-
Cam Saul authored
* Fix Postgres filter by quarter * Fix test for MongoDB to work around #5419 * Spark SQL doesn't allow quarters in intervals either
-
- Mar 23, 2022
-
-
Cam Saul authored
* Remove references to qp/query->preprocessed * Fix Oracle
-
Howon Lee authored
This is the first vertical slice of #708. There is a material ways to go, including mysql implementation, plinking away at the data model stuff, and frontend. There are also big putative sync speed gains I think I should chip away at.
-
- Mar 16, 2022
-
-
Cam Saul authored
* Use Service Accounts for Google Analytics auth going forward * Update GA dox * Dox tweak * Fix e2e test * Remove dead googleanalytics form code Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com>
-
Cam Saul authored
* Change u/profile from println to log/info * Change most test printlns to log/info * Make u/profile message a fn rather than a delay * Apparently clj-http errors aren't wrapped in :object anymore * Add running commentary * Log the amount of time it took to find and run tests * Sort namespaces * Update test Co-authored-by:
Diogo Mendes <diogo@metabase.com>
-
- Mar 10, 2022
-
-
Cam Saul authored
* Improved error messages when query execution fails * Pretty-print hx/identifier in a different way if it contains extra keys * Fix #20806 * Rename key used to record that we should not qualify * Fix line breaks * Test fix
-
- Feb 24, 2022
-
-
Michiel Borkent authored
* Refer all * allow refer all in tests * Add toucan test macro config * wip * Improve hooks * Fix formatting issue * Improve * presto * oracle * mongo * druid * zero errors * undo whitespace change * ns linter satisfaction
-
- Feb 16, 2022
-
-
Cam Saul authored
-
- Feb 15, 2022
-
-
Cam Saul authored
* Replace AOT Spark SQL deps with a `proxy` and a `DataSource` * Support `connection-details->spec` returning a `DataSource` * Remove target/classes * Don't need to deps prep drivers anymore * Fix duplicate `this` params in `proxy` methods; add `:test` alias for Eastwood to make it be a little quieter * Make sure to call `pool/map->properties` * Upgrade Hive JDBC driver version from 1.2.2 -> 3.1.2; Bump Spark SQL from 2.1.1 to 3.2.1 * Clean the namespaces * Don't need to register the a proxy JDBC driver since we're not even using it anymore * Fix Spark SQL :schema sync for newer versions * Remove unneeded override * Fix day-of-week extract for new :sparksql * Hive/Spark SQL needs to escape question marks inside QUOTED identifiers now
* Some minor SQL generation improvements to avoid duplicate casts * Revert change to debug test
-
- Feb 14, 2022
-
-
Cam Saul authored
* Add failing test for #15978 * Improved test * Add new metabase.driver.query-processor.escape-join-aliases QP middleware * Test fix
* Add reference to #20307 * Add some extra dox * Test fixes for BigQuery drivers * revert unneeded change * Fix :bigquery and :bigquery-cloud-sdk mixup * Test fixes * Test fix * Remove comment I meant to remove
-
- Feb 11, 2022
- Feb 08, 2022
-
-
Jeff Evans authored
* Remove :bigquery driver Add "migration" to convert existing Database instances from :bigquery to :bigquery-cloud-sdk (with error log if using outdated OAuth mechanisms), by way of `normalize-db-details` Removing references to :bigquery from various places in the code * Remove from modules/drivers/deps.edn * Remove stuff from CircleCI that is running the old driver Remove `driver-switch-test` since there is no practical way to run this anymore (since we can't initialize the old driver) Remove buggy redef of `isa?` from `semantic-type-migration-tests` Co-authored-by:
Cam Saul <github@camsaul.com>
-
- Feb 03, 2022
-
-
Cam Saul authored
* Bump backend dependencies (Jan 2022) * Revert java-time version upgrade for now until https://github.com/dm3/clojure.java-time/issues/77 is fixed * Add license overrides * Bump a few more deps (again). Revert Google/BigQuery and Vertica version bumps * Revert MariaDB and Redshift version changes
-
- Feb 02, 2022
-
-
Cam Saul authored
-
Jeff Evans authored
Break out separate util fn to return the given `authdb` or the canonical default ("admin") Add invocation to new util fn from the `mcred/create` call
-
- Jan 27, 2022
-
-
Alexander Polyankin authored
-
- Jan 26, 2022
-
-
Jeff Evans authored
* Support overriding ROWCOUNT for SQL Server Add new "ROWCOUNT Override" connection property for `:sqlserver`, which will provide a DB-level mechanism to override the `ROWCOUNT` session level setting as needed for specific DBs Change `max-results-bare-rows` from a hardcoded constant to a setting definition instead, which permits a DB level override, and move the former constant default to a new def instead (`default-max-results-bare-rows`) For `:sqlserver`, set the DB-level setting override (if the connection property is set), via the `driver/normalize-db-details` impl Add test to confirm the original scenario from #9940 works using this new override (set to `0`) Move common computation function of overall row limit to the `metabase.query-processor.middleware.limit` namespace, and invoke it from execute now, called `determine-query-max-rows` Add new clause to the `determine-query-max-rows` function that preferentially takes the value from `row-limit-override` (if defined)
-
- Jan 25, 2022
-
-
Jeff Evans authored
* Apply schema inclusion/exclusion filtering to sql-jdbc drivers Update `sql-jdbc` namespaces to handle schema inclusion/exclusion patterns when filtering schemas Add new generic schema inclusion/exclusion test for sql-jdbc drivers that define the property Update Snowflake and Redshift driver manifests to include schema filtering property Create `db-details->schema-filter-patterns` util fn to turn DB details into the inclusion/exclusion patterns Move schema inclusion/exclusion filtering code to new namespace (since it's not strictly used by `:sql-jdbc` derived drivers) Move existing tests accordingly Add schema inclusion/exclusion check to the new `filtered-syncable-schemas` multimethod (and updating docstring) Change `:redshift` impl of `filtered-syncable-schemas` to call the `:sql-jdbc` version instead Use new multimethod instead for `filtered-syncable-schemas`, and have default impl of `syncable-schemas` call that Mark `syncable-schemas` as deprecated and include notes on the new method (and update driver markdown file accordingly)
-
- Jan 20, 2022
-
-
Jeff Evans authored
* Add drive scope to BigQuery client Adding new drive auth scope in order to be able to query Google Drive files created in BigQuery as external tables Adding new test to confirm such a table can be queried successfully
-
Cam Saul authored
* Add test for #7487 * Fix error message * Update test for new error message
-
Noah Moss authored
-
- Jan 19, 2022
-
-
Cam Saul authored
* Add test for #15538 * Add extra validation for native source queries * Add test for sql-source-query validation
-
Jeff Evans authored
* Remove hardcoded project-id from `:bigquery-cloud-sdk` tests Pull out common helper fn to extract project-id from credentials Update `bigquery_cloud_sdk_test.clj` to have a var that loads the service-account-json from the env var, then uses aforementioned function to determine project-id Change sensitive-data-redacted-test to use an arbitrary/fake project-id to remove any sort of confusion
-
Cam Saul authored
-
- Jan 18, 2022
-
-
Cam Saul authored
Nested Queries Overhaul 2022: Split logic for determining appropriate table & column aliases out of SQL QP (#19384)
-
- Jan 14, 2022
-
-
Jeff Evans authored
Move bulk of dataset-id normalization logic into new private helper fn Perform app DB update for db-details after dataset-id has been turned into inclusion filter Add test to confirm that normalization only happens once
-
Noah Moss authored
-
- Jan 13, 2022
-
-
dpsutton authored
* Don't update tables in a schema one by one Code had wanted to log each table which is admirable. But on bigquery there can be 15,000 tables and this will lock up calls to /api/database. On stats they are taking about 18s for me. Need to do once and let the db do the heavy lifting * Also where schema is nil * slightly better query
-
- Jan 12, 2022
-
-
Jeff Evans authored
Add functions to describe-database namespace for performing inclusive/exclusive schema filtering Add tests for these functions in isolation Update `:bigquery-cloud-sdk` driver and QP code to remove the single `dataset-id` conn-param Changing :bigquery-cloud-sdk` driver to use dataset inclusion/exclusion filters instead Updating `add.cy.spec.js` Cypress test to account for new structure Add data upgrade (via `driver/normalize-db-details` implementation) to change `dataset-id` property to inclusion filter Add test to confirm data upgrade Adding server side expansion of `:schema-filters` type connection property
-
- Jan 11, 2022
-
-
Noah Moss authored
-
- Jan 08, 2022
-
-
Alexander Polyankin authored
-
- Jan 07, 2022
-
-
Jeff Evans authored
* Allow override of WEEK_START in Snowflake driver Incorporate the following sources of WEEK_START, in decreasing order of precedence: 1) the connection string, a.k.a. additional-options (ex: WEEK_START=N) 2) the Metabase "start-of-week" setting (i.e. day of a week) 3) the default value (7: Sunday) Adding new fn to the driver.common namespace to parse a connection string param out of additional-settings (plus a test for that) Adding Snowflake driver test to ensure that all cases above are covered as expected, by invoking the DAYOFWEEK function on a set of fixed dates Update documentation for start-of-week setting to clarify that it now influences this behavior Swap out parse-additional-options-value for additional-options->map instead (more generic) Update test accordingly
-
- Dec 28, 2021
-
-
Cam Saul authored
* Rename setting/get and setting/all; GeoJSON via env var tests * Fix typo (thanks @noahmoss) * Support Database-local Settings in metabase.models.setting itself * Rework Settings code so it can handle possibly-already-deserialized values * Database-local Settings * Remove empty part of docstring * Appease linters * Update dox again * Use text.type for the new column * Test fixes
* Test fix * Test fix * All negative integer values when setting :integer Setting with a string -
dpsutton authored
-
- Dec 21, 2021
-
-
Noah Moss authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Dec 20, 2021
-
-
Jeff Evans authored
* Fix file upload of secret values Fix logic in `db-details-client->server` to properly consider the `-options` suffixed connection property from the client version, to determine the treatment to be applied (i.e. base64 decode) Change logic in `db-details-client->server` to `assoc` nil rather than `dissoc` unused keywords (so they override the saved db details on merge) Update `driver.u/database->driver*` so that the engine loaded from the database instance is *always* a keyword Update `metabase.test.data.oracle/connection-details` to pass the property vals through the client->server translation layer Change `creator_id` in `secret` model to be nullable (since, when creating test DBs, the API current user is deliberately set to nil) Switch the logic in Oracle SSL test to iterate on the file-path and uploaded variants to the test itself to get around weird CircleCI/environment issues Use `rds_root_ca_truststore.jks` for the test instead since we don't need the full cacerts for this
-