Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 19, 2021
    • Jeff Evans's avatar
      Make SSH heartbeat interval configurable (#14679) · 391749b7
      Jeff Evans authored
      Adding entry in public_settings.clj for ssh heartbeat interval, and referencing that from ssh.clj
      
      Adding the heartbeat interval to the existing log message when tunnel is established
      
      Adding mention of the env var to environment-variables.md
      Unverified
      391749b7
  2. Feb 17, 2021
  3. Feb 16, 2021
  4. Feb 15, 2021
    • Jeff Bruemmer's avatar
    • dpsutton's avatar
      Semantic types pt 1 (special-type -> semantic-type rename) (#14780) · 80a88883
      dpsutton authored
      * Semantic types migration
      
      * Fixup for basic querying
      
      * Remove the relation type migration.
      
      it makes the diff far too hard at the moment. need to be able to just
      move everything from special_type -> semantic_type and then correct
      the few that look at it to care about the effective type.
      
      the PK/FK stuff gets really invasive and needs to be in its own much
      smaller changeset
      
      * Just rename special_type -> semantic_type for first change
      
      * Special type -> semantic type
      
      * special-type -> semantic-type
      
      * SpecialType -> SemanticType
      
      * special type -> semantic type
      
      mostly in documentation, docstrings, etc
      
      * Fix tests which relied on order of sets
      
      database position was annotated by map-index'ing over the
      set. changing `:special-type` to `:semantic-type` changed the order of
      the seq produced from it.
      
      * special -> semantic in schema_metadata
      
      * Tim is awesome: Undo overeager special->semantic in docstrings
      
      * Un-rename semantic_type in data_migrations
      
      These migrations are run unless a migrations table marks them as
      already having run. If they haven't run, then the db is older and the
      column is special_type most likely. So we let them run as
      `:special_type` and add some error handling to the migration runner
      that is _opt in_.
      
      ```clojure
      (defmigration ^{:author "camsaul", :added "0.20.0", :catch? true}
        migrate-field-types
        ...
        )
      
      (try
        (@migration-var)
        (catch Exception e
          (if catch? ;; catch? from metadata
            (log/warn (format "Data migration %s failed: %s" migration-name (.getMessage e)))
            (throw e))))
      ```
      
      * Fix merged master changes
      
      just accepted their changes and fixed up rather than fix conflicts.
      Unverified
      80a88883
  5. Feb 12, 2021
  6. Feb 09, 2021
  7. Feb 08, 2021
  8. Feb 04, 2021
  9. Feb 02, 2021
  10. Jan 29, 2021
  11. Jan 28, 2021
  12. Jan 26, 2021
  13. Jan 25, 2021
  14. Jan 20, 2021
  15. Jan 15, 2021
  16. Jan 13, 2021
  17. Jan 06, 2021
  18. Dec 29, 2020
    • Nemanja Glumac's avatar
      Convert integration tests to Cypress (#14174) · fef0664a
      Nemanja Glumac authored
      This completes one step towards removing Enzyme.
      The complete list of all tests is at #13657.
      
      * Run each test in isolation
      
      * Convert `EditUserModal.integ.spec.js` to Cypress
      
      * Convert `PeopleListingApp.integ.spec.js` to Cypress
      
      * Convert `GroupDetailApp.integ.spec.js` to Cypress
      
      * Delete `GroupsListingApp.integ.spec.js`
      
      It was already covered in Cypress.
      
      * Delete `NewUserModal.integ.spec.js`
      
      It was already covered in Cypress.
      
      * Convert `UserActivationModal.integ.spec.js`
      
      * Convert `UserPasswordResetModal.integ.spec.js`
      
      * Convert `UserSettings.integ.spec.js`
      
      * Remove integration tests
      
      * Remove integration tests from CI
      
      * Fix linter errors
      
      * Delete `AuditTable.integ.spec.jsx`
      
      * Clean up `people.cy.spec.js`
      
      * Update assertion that makes sure XHR didn't happen
      
      * Remove redundant command from PR template
      
      Note: `yarn-lint` already runs `yarn flow`.
      https://github.com/metabase/metabase/pull/14174#discussion_r549790198
      
      * Remove explicit mention of timezones in `developers-guide.md`
      Unverified
      fef0664a
    • Jeff Bruemmer's avatar
      Closes #14090 & #14074 (#14163) · ce73c4a6
      Jeff Bruemmer authored
      Unverified
      ce73c4a6
  19. Dec 22, 2020
  20. Dec 16, 2020
  21. Nov 16, 2020
  22. Nov 12, 2020
  23. Nov 09, 2020
  24. Nov 06, 2020
    • Cam Saul's avatar
      Mega build script improvements (#13638) · cfa6bf84
      Cam Saul authored
      * Mega build script improvements
      
      * Look for project.clj to determine root directory since we delete .git on CI for speed
      
      * If .git folder is missing (i.e., in CI) fail gracefully
      
      * Don't need to generate version file to run Cypress tests, right?
      
      * Build uberjar step can cache version.properties
      (so the Cypress test steps don't need to generate it again)
      
      * Flush caches
      
      * Update uberjar cache key
      Unverified
      cfa6bf84
  25. Oct 30, 2020
  26. Oct 29, 2020
    • Cam Saul's avatar
      Migrate build/upload Elastic Beanstalk artifact code into main release script... · 077b2b8a
      Cam Saul authored
      Migrate build/upload Elastic Beanstalk artifact code into main release script and other improvements (#13635)
      
      * Always use current branch; determine CE vs EE build based on version number
      
      * Rename delete-file! -> delete-file-if-exists!
      
      * Dox & TODO message
      
      * Move draft release template
      
      * Some logging tweaks for deleting files
      
      * Move s3 upload code to common namespace
      
      * Integrate EB artifact logic
      
      * Move .ebextensions -> release
      
      * Remove old EB release scripts
      Unverified
      077b2b8a
  27. Oct 23, 2020
  28. Oct 22, 2020
  29. Oct 21, 2020
  30. Oct 15, 2020
    • Nemanja Glumac's avatar
      Convert e2e tests to Cypress (#13418) · b9ac0ef6
      Nemanja Glumac authored
      
      * Convert `drillthroughs.e2e` tests to Cypress (#13128) [ci skip]
      
      Convert e2e tests from drillthroughs.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/visualizations/drillthroughs/chart_drill.cy.spec.js
      - frontend/test/metabase/scenarios/visualizations/drillthroughs/dash_drill.cy.spec.js
      
      Note:Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Convert `Visualization.e2e` tests to Cypress (#13021) [ci skip]
      
      Convert e2e tests from Visualization.e2e.spec.js to Cypress tests:
          - frontend/test/metabase/scenarios/dashboard/text-box.cy.spec.js
      
      Original note by @Opalevanescence : "Some of these tests weren't in Cypress yet, so I added them in."
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * E2e to cy/port/dashboard (#13013) [ci skip]
      
      Convert e2e tests from dashboard.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/dashboard/dashboard.cy.spec.js
      
      Affected files:
      - frontend/test/metabase/scenarios/dashboard/parameters-embedded.cy.spec.js
      - frontend/test/metabase/scenarios/dashboard/parameters.cy.spec.js
      
      * Quarantined breaking Cypress tests (breaking changes introduced with the work on the dashboard UI)
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Convert `alert.e2e` tests to Cypress (#12969) [ci skip]
      
      Convert e2e tests from alert.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/alert/alert.cy.spec.js
      - frontend/test/metabase/scenarios/alert/alert_auth.cy.spec.js
      
      * Quarantined breaking Cypress tests (cannot use email setup in CI)
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Convert `initial_collection.e2e` tests to Cypress (#12968)
      
      Convert e2e tests from initial_collection.e2e.spec.js to Cypress tests:
      - frontend/test/metabase/scenarios/collection_defaults.cy.spec.js
      
      * Quarantined breaking Cypress tests (cannot use email setup in CI)
      
      Note: Squashed all previous commits in a branch for cleaner output.
      Co-authored-by: @nemanjaglumac
      
      * Delete `PivotByCategoryDrill` e2e test [ci skip]
      
      * Delete `metadata` e2e tests
      
      * Add `metadata` Cypress test [ci skip]
      
      - remapped column value (Product ID => Title)
      
      * Delete `SettingsAuthenticationOptions` e2e test [ci skip]
      
      NOTE: we already have similar CY test in `frontend/test/metabase/scenarios/admin/settings/settings.cy.spec.js`:
      - `it("should render the proper auth options", () => {...})`
      
      * Delete `segments` e2e test [ci skip]
      
      existing CY test file: `frontend/test/metabase/scenarios/admin/datamodel/segments.cy.spec.js`
      
      * Delete end-to-end related support and helper files
      
      * Remove e2e tests from CircleCI config [ci skip]
      
      * Delete references of e2e tests in documentation and replace them with Cypress [ci skip]
      
      * Fix and update dashboard related Cypress tests
      
      * Fix `parameters` cy test
      
      * Fix `metadata` failing test
      
      * Fix `parameters` failing test
      
      Note:
      - Asserting on "Rows 1-1 of 2000" was bad idea because card is different size in CI.
      - The number of visible rows directly depend on the card size
      
      Co-authored-by: default avatarJessica DeWitt <58329466+Opalevanescence@users.noreply.github.com>
      Unverified
      b9ac0ef6
  31. Oct 08, 2020
  32. Oct 02, 2020
    • Robert Roland's avatar
      Upgrade to log4j 2.13.3 (#13310) · 1b75a42b
      Robert Roland authored
      * Upgrade to log4j 2.13.3
      
      Upgrades us to newer Log4j
      
      Resolves #12719
      
      * fixing reflection warnings
      
      * reflection warning on test
      
      * make tests work
      
      took a while to figure out how to configure log4j properly
      programatically - it's not as easy as log4j 1
      
      add logging adapters for commons-logging, slf4j, liquibase, etc so that
      all logging routes through log4j2 now
      
      * appease the linters
      
      * okay cljr-clean-ns makes this line too long, I get it
      
      * add log4j2.xml config for Cypress tests
      
      * update log4j configuration file documentation
      
      update which flag is used by the backend tests
      
      [ci all]
      
      * update cheshire because clj-http updated
      
      * Wire up the metabase-appender to Log4j2
      
      This was brutal to figure out - log4j usually silently fails, so it took
      finding the right combination of configuration settings and system
      properties to get it to log enough to find out why the appender was
      never invoked.
      Unverified
      1b75a42b
Loading