* Add action edit modal call (#31171)

* Add action edit from action call form modal

* Code review, unit tests

* Add e2e test

* fixup! Code review, unit tests

* Code review, more tests

* Add edit action trigger tooltip

* Possible fix for read only model

* Fix e2e tests

* Remove unnecessary intercept

* Add limit (3) to the source query

Adding limit to the source query doesn't affect the reproduction
confidence, but it greatly improves performance.

* Fix eslint warning

* Improve assertions

* fix migrations and add new test

* fix migration IDs in test

* dont fail migration if FK already exists

* rewrite without table aliases to try to fix error on mysql/mariadb

* try to rewrite again

* revert to prior version of query

* another attempt at a rewrite

* fix typo

* fix typo

* bump ci

* replace LIKE with =

* Restrict uploading to people with correct perms

[Fixes #30322]

* Remove unused openCollection prop

* Preserve collection sorting given by API in getExpandedCollectionsById
- Fixes #31294

* Use Collections.getListStatePath() to unhardcode the object path

* Use CollectionId instead of any

* Extract Collections.selectors.getCollectionList

* Convert Collections selectors unit tests to TypeScript

* Remove redundant selector

* Add a unit test for Collections.selectorsgetExpandedCollectionsById

* Use createMockCollection for all test collections
- Use Partial<Collection> instead of MockCollection type

* Add a test case for non-nested collections

* Rename identifiers

* Add a test suite for snippet collections

* Fix SnippetCollections.selectors.getExpandedCollectionsById

* Refactor tests

* Refactor tests

* Revert unit tests for selectors

* Revert convert selectors to TypeScript

* Add error support to setupCollectionsEndpoints

* Introduce useCollectionsQuery

* Fix tests

* Add unit tests for preserving order of collections in ItemPicker

* Make assertions more semantic

* Allow mocking root collection
- Make ROOT_COLLECTION object match Collection type

* Add tests for preserving order in snippet collections list
- fix case with an undefined snippet collections list

* Update test case with data loading necessary for ItemPicker underneath the EditSandboxModal after updating selectors

* Update test case with data loading necessary for ItemPicker underneath the AddToDashSelectDashModal after updating selectors

* Rename useCollectionsQuery to useCollectionListQuery

* Remove leftover fetchMock

* Move error out of setupCollectionsEndpoints

* Fix ModelDetailPage unit tests setup

* Remove leftover fetchMocks

* Revert changes to ROOT_COLLECTION constant
- use createMockCollection

* Fix typing

* Remove dead link to Source Sans Pro font
- it caused markdown check to fail during CI, this fixes it
- it seems that the font has been removed from Google Fonts
- users can still choose this font in Metabase settings
- removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW

* Fix getExpandedCollectionsById selector

* Revert adding useCollectionListQuery in unit tests

* MLv2: Fix matching of field literals to field integer IDs (#31487)

* MLv2: Fix matching of field literals to field integer IDs

* Better test

* Update src/metabase/lib/equality.cljc

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Fix #31482 not showing join display name for busted breakout from drill thru

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* initial changes

* add test

* Clean up CSV errors; support missing values

* Make CSV errors a 400, not 500

* Add `include_only_uploadable?` flag to database endpoint

Useful for populating the list of DBs in /admin/settings/uploads

* Remove deprecated 'include_tables' flag

* Remove deprecated 'include_cards' flag

* allow non-actions-enabled DBs for uploads on the frontend

* allow settings manager access

* Only show uploads DBs if EE user has 'manage' access

* Properly handle perms for Settings Managers changing the uploads DB


---------

Co-authored-by: Ryan Laurie <iethree@gmail.com>

* temp

* cast export type

* Fixing types

* T -> TId

---------

Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>

Stress-testing a spec with a lot of tests can easily time out before
20 minutes mark. This commit is bumping that timeout to 60 minutes.

[ci skip]

* Fix join flake for field literals

Example of a failed run from the past:
https://www.deploysentinel.com/ci/runs/647ff0426bd09da7e252a052

* Fix flake in repro #12928

An example of the failed run from the past:
https://www.deploysentinel.com/ci/runs/647f17d60baaca08b249b4aa

This commit extracts the joins logic to select two saved questions to a
seperate helper, because it seems we'll use it in many places.

* Fix flake for repro #18512

An example of a previously failed CI run:
https://www.deploysentinel.com/ci/runs/647f605e4d5097b4de537e07

* Fix flake for repro #18502

An example of a failed run from the past:
https://www.deploysentinel.com/ci/runs/64807a6e45294b33d5240830

* Tentatively fix flake in repro #17767

This flake has a different cause than the rest of the flakes in this PR.
The request `POST /api/dataset` is timing out in CI. It takes more than
30 seconds to complete, and Cypress times out in meantime.

This is suspiciously slow, even for CI.
I'm trying to limit the number of results by limiting rows in the original
query. This reduces the number of total results (after the join) from
1,136 rows to just 9.

* Document how to improve code reviews

This commit adds a section to the existing documentation on code review
process. It points to the video presentation of a research on this topic,
and adds a few pointers for both the code owners and code reviewers.

* Apply Jeff's edits

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* forward migration for size_x and col

* done?

* test fixes

* adds some document

* migration should not contains comment

* mysql and postgres use different syntax in casting

* makes it work on mariadb

* update grid columns

* update specs

* update specs

* use float for postgres

* postgresql not postgres

* add migration for revision with model=Dashboard

* row is reserved in h2 too

* handle edge case with rollback migration where we have a 1x1 card that located at the shrinkage line

* kondo

* Cal's feedback

* add the code we used to generate random array

* clean up

* use the algorithm to dynamicall generate test data

* no more height migrations

* grid ratio

* unmigrate height in cypress specs

* update specs

---------

Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>

* enforce download perms on dashcards

* fix tests

* use hydrate-root-collection on card and dashboard

- GET /api/card/:id
- GET /api/dashboard/:id

* include missing ns require

* copy root-collection-with-ui-details into collection.root

* import the var from collection.root

* remove unused require

* allow upload table prefixes on dbs with schema

* add optional copy

* make boolean logic easier to read

* initial prototype commit

* add default value for text cards

* auto focus text/heading cards on creation

* remove default value - use placeholders instead

* fix inability to edit when there is no heading value

* remove unnecessary comment

* re-word heading & text tooltip

* refactor and fix draggable area bug

* fix border artifacts when combined with dragging styling

* fix stroke width for hovering and focused - make them the same

* display placeholder value in editing mode if content is empty for text and heading dash-cards

* remove duplicate placeholders

* allow pointer-events anywhere on the div (not just content)

* refactor styling to apply no content borders

* Fix heading overflow

* refactor text dash-card button

- remove unnecessary redux store usage

* refactor border styling to one css format

* rename class names to match syntax conventions

* refactor auto-preview styling for dash-card root

* refactor style name

* remove comment

* undo unnecessary re-formatting

* refactor popover styling

* remove comment that was previously addressed

* refactor to typescript

* remove comment

* remove un-used code

* fix TypeScript errors in text unit spec

* update button key and event description

* add e2e tests for text and heading dash-cards

* add e2e tests

* add small heading unit tests

* fix typescript error

* add aria-label removed by merging with master

* fix broken test

* fix broken tests

* fix typescript errors

* align edit text with preview text

* change from hover editing to click editing

* update tests for click editing

- remove hover tests
- change focus tests to click tests
- remove top-level findByText() calls

* refactor to use-focus hook

* add "heading" to getSupportedCardsForSubscriptions

* rename showVisualizationOptions to showDashcardVisualizationSettings

* add aria label to buttons and query in tests by label

* refactor E2E tests to make longer flows

* add existing metabase types to Heading

* refactor heading and text menu to use EntityMenu

* fix aria-label

* [skip ci] fix css syntax error from missing semi-colon

* adjust styles and use rem value standards

* [skip ci] prevent drag on click to edit surface area

* tweak styles for mobile resolutions

* fix react import lint error

* fix E2E tests

* refactor e2e helper to shorthand

* refactor to use e2e helper

* refactor to use saveDashboard() e2e helper

* refactor e2e tests

* rename styling variables

* null coalesce minWidth

* remove unnecessary anonymous function wrapping

* refactor to useToggle

* improve no content check

* use object creation shorthand

* simplify expression

* refactor empty content styling

* move text-edit-container styling into heading and text components

* refactor resize handle styling and abstract condition into function

* refactor to use CSS function for string styling

* improve Heading unit tests

* improve Text unit tests

* update Heading and Text unit tests

* update for new Icons

* fix E2E tests

* refactor E2E test assertions

* refactor click events to use user-event library

* fix tooltip positioning

* update upload loading state for long uploads

* add unit tests

* fix fake timers

* Move core actions E2E tests to a separate folder

* Run new `actions` E2E group in CI

Metabase actions deserve their own E2E group, as the test suite around
them is expected to grow. This commit introduces `actions` E2E group to
the CI.