Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 07, 2024
  2. Jul 12, 2024
    • github-automation-metabase's avatar
      parallelize coll perm graph group lookup (#45256) (#45510) · f2ef93d7
      github-automation-metabase authored
      
      * parallelize coll perm graph group lookup w/ core.async
      
      * respond to code review
      
      * add + uses ExecutorCompletionService map function
      
      * rename test
      
      * more tests
      
      * no concurrency for cljs
      
      * fix timeout + add more tests
      
      * use claypoole
      
      * cleanup
      
      * add kondo hooks for claypoole
      
      * cleanup
      
      * Can't use libraries that don't have a license
      
      Revert "add kondo hooks for claypoole"
      
      This reverts commit 9d93b55b28d69267b65260f2b046420d67604361.
      
      * ignore unused value
      
      -- TODO: check back in on claypoole to see if the kondo config gets merged
      
      * fix linter
      
      Co-authored-by: default avatarbryan <bryan.maass@gmail.com>
      Unverified
      f2ef93d7
  3. Jul 10, 2024
  4. Jul 01, 2024
    • github-automation-metabase's avatar
      Wrap non-latin characters in a span specifying working font (#44580) (#44944) · 99393cbb
      github-automation-metabase authored
      
      * Wrap non-latin characters in a span specifying working font
      
      Fixes: #38753
      
      CSSBox seems to have a bug where font fallback doesn't work properly. This is noticeable when a font does not contain
      glyphs that are present in the string being rendered. For example, Lato does not have many international characters,
      so the rendered version of tables (that show up in Slack messages) will not render properly, making the card
      unreadable.
      
      Since this appears to be a downstream bug, I've opted to work around this limitation by wrapping any non-latin
      characters in a <span> that specifies the font family to be sans-serif, which should contain the glyphs to properly
      render.
      
      This leaves Lato in place for other characters.
      
      For now, I figured it's worth trying this solution over using Noto for 2 reasons:
      - we can keep Lato, which has been the decided font style for the app for some time (this keeps things consistent
      where possible)
      - the Noto font containing all glyphs is quite a large font (>20mb, I think) and it would be nice to avoid bundling
      that if we can.
      
      * stub installed fonts test
      
      * typo
      
      * Do wrapping, but now per-string, and in Clojure data not html string
      
      I've decided that a reasonable solution is to still wrap strings containing non-lato characters. But it's not done
      with str/replace to the html string but rather in a postwalk over the Hiccup data prior to rendering.
      
      Seems like a decent compromise of issues without patching CSSBox or fixing upstream (may be good to do, but will take
      longer to get a fix in).
      
      * add test checking that glyphs render correctly
      
      * Add a test that directly checks the wrapping fn
      
      * Change the string to keep the linter quiet
      
      * Change how we check if string can be rendered to faster method, new Lato Font
      
      With Sanya's help, the way I check if a given string is renderable with Lato is now faster.
      
      Also use the full Lato font, not just the 'latin' lato so we can cover more chars
      
      * change lato so that it loads the fn even in a fresh test run
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      99393cbb
  5. Jun 27, 2024
  6. Jun 13, 2024
  7. Jun 06, 2024
  8. Jun 05, 2024
  9. Jun 04, 2024
  10. May 31, 2024
  11. May 24, 2024
  12. May 10, 2024
  13. May 09, 2024
  14. May 08, 2024
    • bryan's avatar
      adds the new `watch` alias, which reloads BE on file changes (#42371) · 0468c9a7
      bryan authored
      * adds watch alias, which reloads BE on file changes
      
      * watch dev, src, test + every path in `:extra-paths`
      Unverified
      0468c9a7
    • dpsutton's avatar
      bump methodical (#42361) · 5d0ad01a
      dpsutton authored
      now:
      
      ```clojure
      ❯ clj -M:"$ALIASES"
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem
      2024-05-07 19:55:25,167 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      ```
      
      no logs about recur targets unboxing
      Unverified
      5d0ad01a
  15. May 07, 2024
    • dpsutton's avatar
      Silence `abs` warning on startup (#42311) · 64ac0d76
      dpsutton authored
      before:
      
      ```clojure
      ❯ clj -M:"$ALIASES"
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem
      WARNING: abs already refers to: #'clojure.core/abs in namespace: clojure.algo.generic.math-functions, being replaced by: #'clojure.algo.generic.math-functions/abs
      2024-05-07 04:39:37,890 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      ```
      
      after:
      
      ```clojure
      ❯ clj -M:"$ALIASES"
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem
      2024-05-07 04:40:42,561 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      ```
      
      Now no warning about `abs`
      Unverified
      64ac0d76
  16. May 06, 2024
  17. May 05, 2024
  18. Apr 26, 2024
  19. Apr 24, 2024
  20. Apr 15, 2024
  21. Apr 10, 2024
  22. Apr 09, 2024
  23. Apr 08, 2024
  24. Mar 28, 2024
    • Tim Macdonald's avatar
      ParseSQL: select * (#40637) · df1366e1
      Tim Macdonald authored
      * Parse wildcards in native queries
      
      Add query_field.direct_reference
      
      * Do away with old Model refs in Card model test
      
      * Do not show stale cards with a select *
      Unverified
      df1366e1
  25. Mar 25, 2024
    • Tim Macdonald's avatar
      Bump next.jdbc (#40452) · d52d4fe1
      Tim Macdonald authored
      Unverified
      d52d4fe1
    • Tim Macdonald's avatar
      Backend dep bump for 50 (#40372) · 760d1196
      Tim Macdonald authored
      * Remove unused marginalia aliases
      
      * Upgrade deps.edn
      
      From `neil deps upgrade`
      
      * Un-bump jetty-server
      
      * Downgrade H2 due to many problems
      
      * Dep bumping for Athena
      
      * Dep bumps for BigQuery
      
      * Dep bumps for Presto
      
      * Dep bumps for Redshift
      
      * Dep bumps for Snowflake
      
      * Dep bumps for SQLite
      
      * Upgrade to Mongo 5
      
      * Bump next.jdbc
      Unverified
      760d1196
  26. Mar 21, 2024
    • Cam Saul's avatar
      Rename `metabase.mbql` to `metabase.legacy-mbql` (#40158) · 0a15637f
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Rename `metabase.mbql` to `metabase.legacy-mbql`
      
      * Fix Kondo warnings
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Fix import
      
      * Another fix :wrench:
      
      * Merge
      
      * FIXES
      
      * Add another missing REQUIRE
      Unverified
      0a15637f
  27. Mar 20, 2024
  28. Mar 14, 2024
    • Tim Macdonald's avatar
      SQL Lineage: Track field usage, expose stale queries (#39707) · 3093f7c3
      Tim Macdonald authored
      * SQL Lineage: Create the QueryField model
      
      This links Cards (with native queries) to Fields, showing us which
      queries use which Fields.
      
      QueryFields are automatically maintained as part of the Card lifecycle
      
      Cards with stale queries (powered by QueryField info) are exposed via the `card?f=stale` API
      Unverified
      3093f7c3
  29. Mar 08, 2024
  30. Mar 05, 2024
  31. Mar 04, 2024
  32. Feb 29, 2024
    • Alexander Solovyov's avatar
    • bryan's avatar
      Saml2 slo (#39034) · b2d7dc6c
      bryan authored
      
      * wip
      
      * SLO works with auth slo handler route
      
      * move slo handling endpoint to /auth/sso/handle_slo
      
      * fix slo redirect url
      
      * SLO works, and the sso-handle-slo for saml is where it belongs
      
      - a ton of cleanup
      
      * fix api/session namespace + add docstrings
      
      * cleaning up logout action
      
      * add slo logout test along with slo response xml
      
      * whitespace + linter
      
      * add docstring
      
      * update exclusions in deps.edn
      
      * un-require metabase-enterprise ns from oss ns
      
      * add docs for how to setup SLO to metabase docs
      
      * docs: clarify that setting up SLO is optional
      
      * move slo logout endpoint into ee code
      
      - removes sso-info defenterprise since it is no longer needed
      
      * use current version of saml20-clj
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Unverified
      b2d7dc6c
Loading