Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 12, 2024
  2. Jun 19, 2024
    • github-automation-metabase's avatar
      :robot: backported "Add upload button for attached data warehouse" (#44390) · edf4310d
      github-automation-metabase authored
      
      * Add upload button for attached data warehouse (#43511)
      
      * DWH plans added
      
      * UploadCSV button component created
      
      * Comments added
      
      * Main nav bar updates
      
      * Misc
      
      * Align main nav bar button with link
      
      * Misc comment
      
      * Upload package created
      
      * Various upload cleanup
      
      * Misc
      
      * Display button rule cleaned up
      
      * Tracking added to upload CSV button
      
      * Misc comment
      
      * e2e tests WIP
      
      * More comments
      
      * e2e tests basic created
      
      * NEw tracking schema
      
      * e2e tests updated / Tracking WIP
      
      * Analytics cleanup for button
      
      * Misc
      
      * Misc e2e tests Snowplow
      
      * Removed forced Upload CSV button in FE
      
      * Upload helpers created
      
      * Misc unit tests updates
      
      * Updated analytics
      
      * Fix for e2e tests
      
      * Upload fixture paths updated
      
      * Misc for Snowplow
      
      * Misc for plan
      
      * More tests cleanup
      
      * Misc
      
      * Source added to analytics
      
      * Plan unit tests fixed
      
      * Update frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarView.tsx
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Update frontend/src/metabase/components/upload/constants.ts
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Misc imports
      
      * Retrieving `uploads-settings` DB
      
      * Remove default UploadCSV component export
      
      * Misc
      
      * Button copy updated
      
      * Analytics updated with optional properties
      
      * Default upload file input id updated
      
      * csvupload schema updated
      
      * Removed before
      
      * No bad Snowplow events added
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      # Conflicts:
      #	frontend/src/metabase/collections/components/CollectionHeader/CollectionUpload.styled.tsx
      
      * whoops
      
      ---------
      
      Co-authored-by: default avatarBenoit Vinay <ben@benoitvinay.com>
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Unverified
      edf4310d
  3. Jun 18, 2024
  4. Jun 07, 2024
  5. Jun 05, 2024
  6. May 21, 2024
  7. May 13, 2024
    • Romeo Van Snick's avatar
      Combine/extract shortcuts snowplow events (#42445) · 9665e569
      Romeo Van Snick authored
      * Copy question event to new version
      
      * Add new events for adding column via plus modal
      
      * Add plus modal variants
      
      * Track combine column via plus header
      
      * Track extract column via plus header
      
      * Add test for combine question event
      
      * Add e2e test for extract column shortcut snowplow events
      Unverified
      9665e569
  8. May 03, 2024
    • Nicolò Pretto's avatar
      Embed homepage, MS4 (#41990) · 55500108
      Nicolò Pretto authored
      
      * use css modules instead of inline styles for cursor: default (#41644)
      
      * add toast notification after the feedback (#41575)
      
      * fix modal submit sending data while button says skip (#41784)
      
      * fix: it should not send the feedback if button says skip
      
      * add comment explaining why we check that getLastFeedbackCall() is undefined
      
      * embedding homepage analytics (#41725)
      
      * rename defaultTab -> initialTab
      
      * add events schema for embedding-homepage
      
      * fix stories
      
      * add analytics, e2e tests and fix typo in dismiss reason
      
      * copy embed_flow schema for better diff in the next commit
      
      * adds isExampleDashboard to trackStaticEmbedPublished
      
      * utm tags
      
      * fix bug of is_example_dashboard
      
      * better test names
      
      * refactor embed homepage status type
      
      * "() => {}" => "_.noop"
      
      * add "Setup embedding" to the admin setup checklist (#41638)
      
      * add setup embedding to the admin setup checklist
      
      * restore whitespace as it was before
      
      * i miss prettier (whitespace again)
      
      * Clean up check list for embedding
      
      Largely making a new entry for the embedding info just to fight long
      lines. `:embedding-homepage-dismissed-as-done` just made the maps really
      long. If we have a `:done?` under an `:embedding` keyword it reads much
      more naturally.
      
      Also, The previous diff was calling `boolean` on a var rather than
      invoking the var:
      
      ```clojure
      :embedding-app-origin (boolean embed.settings/embedding-app-origin)
      ;;                             ^^^^^^^^^^^^^^ needs to be (invoked)
      ```
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      
      * Change utm tags for embedding homepage links (#42042)
      
      * update utm tags
      
      * utm_media -> utm_content
      
      * add description to the checklist setup step (#42200)
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      55500108
  9. Apr 30, 2024
    • Romeo Van Snick's avatar
      Add analytics event for combining/extracting columns (#41767) · a8c6aace
      Romeo Van Snick authored
      * Add analytics event for combine columns shortcut
      
      * Add new version for question analytics schema
      
      * Add column_combine_via_shortcut event
      
      * Add custom_expressions_used field
      
      * Use trackSchemaEvent to track combine column event
      
      * Move trackColumnCombineViaShortcut to separate file
      
      * Fix typo in event key
      
      * Add column_combine_via_column_header
      
      * Add column_extract_via_shortcut
      
      * Add column_extract_via_column_header
      
      * Add database id for question
      
      * Move analytics file to frontend/src/metabase/query_builder
      
      * Allow null for custom_expressions_used
      
      * Add test for snowplow event
      
      * Fix typo in schema
      
      * Add max length to custom expressions
      
      * Add description to list item
      Unverified
      a8c6aace
  10. Apr 05, 2024
  11. Apr 04, 2024
  12. Apr 03, 2024
  13. Apr 02, 2024
  14. Mar 27, 2024
  15. Mar 25, 2024
  16. Mar 21, 2024
  17. Mar 18, 2024
  18. Mar 01, 2024
    • Nicolò Pretto's avatar
      License activation step - ms1 (#39257) · 636d7185
      Nicolò Pretto authored
      * adds /api/setup/token-check and add license-token to POST /api/setup (#38858)
      
      * adds /api/setup/token-check and add license-token to POST /api/setup
      
      * refactor tests
      
      * license-token => license_token for consistency
      
      * fixed test message
      
      * fix nesting in test
      
      * Add the step in the FE and pass the token to the setup api call (#38953)
      
      * refactor: go back to saving the index for the step, to avoid having to use a selector that needs global state in the reducer
      
      * Revert "refactor: go back to saving the index for the step, to avoid having to use a selector that needs global state in the reducer"
      
      This reverts commit ee7e44f48788528e059c3f1f8816a73b675e082b.
      
      * feat: adds UI and token api logic
      
      * test structure for paid features
      
      * initSetup action as workaround
      
      * pass token to the /setup endpoint
      
      * add jest tests for ee without token case
      
      * add warning comment  on getIsPaidPlan
      
      * copy old schema for better diff
      
      * add license_token step seen event in the schema
      
      * update e2e tests to make them pass
      
      * should make e2e pass
      
      * explicitly check that the license activation step is not rendered
      
      * useStep hook
      
      * refactor: simplify logic in step_number
      
      * refactor: getInactiveStepTitle
      
      * fix too many slashes in import
      
      * refactor: rename selectThisStep to handleStepSelect
      
      * use isSetupCompleted from useStep
      
      * adds expect().toBeInTheDocument
      
      * remove waitFor in favor of await findBy
      
      * add submit snowplow event and increase the onboarding version in the events (#39151)
      
      * trackLicenseTokenStepSubmitted
      
      * adds a test and makes sure we're passing the token as undefined, not as null
      
      * clean up
      
      * remove waitFor
      
      * goToNextStep in all thunks (#39103)
      
      * Revert "initSetup action as workaround"
      
      This reverts commit 0318a55b.
      
      * goToNextStep thunk
      
      * Change the Next button to skip for the license activation step (#39292)
      
      * change the Next button to be Skip
      
      * trim token input
      
      * fix e2e test
      
      * fix quotes
      
      * hide error when the user changes the token (#39440)
      
      * keep token visible when going back (#39443)
      Unverified
      636d7185
  19. Feb 27, 2024
  20. Feb 26, 2024
  21. Feb 23, 2024
    • Mark Bastian's avatar
      LLMs for Question and Dashboard Titles and Descriptions (#38298) · f90e4db2
      Mark Bastian authored
      
      * Endpoint stubs
      
      * It's alive!!!
      
      The summarization endpoint is live, calling OpenAI, and connected to the `POST "metabot/card/summarize"`. `POST card/` also taps the results.
      
      * Updating prompt
      
      * Updated response shape
      
      * [WIP] working front-end suggest button
      
      * Incorporating viz settings
      
      * add suggest description to save question modal
      
      * Updating prompt
      
      * merge title and description suggestion into one button
      
      * Updating prompt
      
      * Removing dead code
      
      * Removing unused param and fn cleanup
      
      * Fix string comment
      
      * Adding dashboard summary endpoint stubs
      
      * auto-request title and description
      
      * dashboard summary wip
      
      * dashboard summary wip
      
      * dashboard summary wip
      
      * better prompt
      
      * remove dead component
      
      * add suggest description button in dashboard sidebar
      
      * fix dashboard description suggestion request
      
      * better prompt
      
      * swap out button when generating dashboard suggestion
      
      * adding keywords
      
      * adding keywords
      
      * adding keywords
      
      * adding keywords
      
      * polish loading question name and description suggestions
      
      * polish UI for dashboard description suggestion
      
      * Stubbed in usage middleware
      
      * Beginning EE Push
      
      Moved metabot/summarize endpoints to autodescribe/summarize in the ee codebase to push this towards being an ee feature and distinguish it from metabot features.
      
      Added snowplow tracking.
      
      * Isolating EE LLM Code
      
      This change completely separates metabot code from ee llm code.
      
      It also introduces a composable client mechanism for creating LLM clients for different tasks.
      
      * Task-Oriented LLM Refactoring
      
      LLM code is now organized clearly into a directory of tasks. Each ns in the tasks package provides a certain LLM task to be used in the API.
      
      * Adding unit test
      
      * Adding admin UI elements for EE OpenAI key
      
      * prettier on frontend/src/metabase/services.js
      
      * Cleaning up description text
      
      * Updating api calls
      
      * FE stuff -- hiding things when feature not enabled.
      
      * Figuring out linting for snowplow file
      
      * Figuring out linting for snowplow file
      
      * Fixing unit test
      
      * add token feature llm-autodscription
      
      * change added from 0.50 to 0.49
      
      * extract logic from SaveQuestionModal into ee plugin
      
      * extract logic from DashboardInfoSidebar to ee plugin
      
      * Fixing unit test
      
      * tests
      
      * cleaning up code for SaveQuestionModal
      
      * gate llm question name behind openAI key setting
      
      * remove styles from SaveQuestionModal.css
      
      * clean up code for dashboard
      
      * lint
      
      * Enabling triggering based on `:llm-autodescription` feature flag
      
      * Starting to look at using a badge for LLM results (#38797)
      
      * Starting to look at using a badge for LLM results
      
      * WIP - Using an Indicator to show AI "stuff"
      
      * Prototype of LLM with badge/indicator
      
      * Removing dashboard description AI
      
      * Ensuring LLM icon only shows when key is present. Updating icon to newer design. TODO: Put the icon in the right place.
      
      * Cleanup -- still need to figure out how to position the indicator and not collapse the radio when selected.
      
      * Updating save question form with LLM values does not reset form
      
      * Cleanup
      
      * Correct icon placement
      
      * Adding MB branding to star
      
      * add ai icon, tweak display
      
      * Fix z-index, tweak padding
      
      * cleanup
      
      * remove inactive code
      
      * Cleaning llm description task cobwebs out
      
      * fix collection creation
      
      * Cleaning lint and merge errors
      
      * Adding "save-question-modal" test id back in
      
      * Fixing jest test
      
      * Touching a file to unstick CI
      
      * Untouching a file to unstick CI
      
      * Fixing some includes from the rebase.
      
      * eslint fixes
      
      * eslint fixes
      
      * Fixing types
      
      * Using `PLUGIN_IS_EE_BUILD.isEEBuild()` instead of `isEnterprise()`
      
      * Removing dead styling
      
      * Adding test ids and fixing cypress tests
      
      * Fixing e2e tests
      
      * Incorporating feedback
      
      * Update frontend/src/metabase-types/api/settings.ts
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      * Update frontend/src/metabase/core/components/EditableText/EditableText.tsx
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      * Update frontend/src/metabase/core/components/Input/Input.tsx
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      * Update frontend/src/metabase/core/components/TextArea/TextArea.styled.tsx
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      * Update frontend/src/metabase/core/components/TextArea/TextArea.styled.tsx
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      * Update frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardInfoSidebar.tsx
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      * Fixing import
      
      * Rebasing on master to fix conflicts
      
      * Fixing types
      
      * Revert "Update frontend/src/metabase/core/components/EditableText/EditableText.tsx"
      
      This reverts commit fe11817086bff50f90336f30d33a1431cae662c5.
      
      * Revert "Update frontend/src/metabase/core/components/Input/Input.tsx"
      
      This reverts commit eef21407ee32e636a8b4e2594d502d5bbaa36870.
      
      * Revert "Update frontend/src/metabase/core/components/TextArea/TextArea.styled.tsx"
      
      This reverts commit dd1c22b993a6576d92547749d2eb93cb68411585.
      
      * Revert "Update frontend/src/metabase/core/components/TextArea/TextArea.styled.tsx"
      
      This reverts commit b169d05364e92c032ae5b6c972888a86079921e2.
      
      * Fixing e2e tests
      
      * address feedback
      
      * Fixing e2e tests
      
      * Fixing modal for models
      
      ---------
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Unverified
      f90e4db2
  22. Feb 21, 2024
  23. Feb 19, 2024
  24. Feb 09, 2024
    • Oisin Coveney's avatar
      Add snowplow events for embedding setup flow (#37617) · d43863a2
      Oisin Coveney authored
      * Add snowplow events for embedding setup flow
      
      * Fix dashboard model tests
      
      * Fix dashboard tests
      
      * Fix card tests
      
      * Fix dashboard API tests
      
      * Fix type error
      
      * Implement analytics 2/7
      
      1. public_link_copied
      2. public_link_removed
      
      * Fix snowplow schema enum
      
      Removing null as we don't seem to put `null` in `enum`
      
      * Complete the embed_flow snowplow schema
      
      * Modify `initial_published_at` to not be overridden
      
      * Implement analytics 4/7
      
      1. public_link_copied
      2. public_link_removed
      3. public_embed_code_copied
      4. static_embed_published
      5. static_embed_unpublished
      
      * Prevent accidental ESLint log in Cypress
      
      * Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues`
      
      We were mixing the type before, as the former one are the type of the
      setting values, not the actual values for the parameters.
      
      * Fix dashboard and card types
      
      * Fix `params` count for `static_embed_published` event
      
      * fixup! Prevent accidental ESLint log in Cypress
      
      * Fix ESlint from the result of upgrading ESLint package
      
      * Fix Snowplow schema enum to include null
      
      * Fully implement `static_embed_code_copied`
      
      * Finish embed_flow snowplow :tada:
      
      
      
      * Fix unit tests because markup change
      
      * Fix E2E tests
      
      * Fix E2E CI failure
      
      Apparently using `.realClick()` on copy button could fail locally,
      but pass on CI and vice-versa. I couldn't replicate this all the time.
      
      I'm not sure why it would fail locally.
      
      * Fix copy to clipboard not working on CI
      
      * Improve test readability
      
      * Remove extra test-id
      
      * Fix refactor `*CodeOptionId`
      
      * Restrict Snowplow schema
      
      * Revert unnecessary change
      
      * Apply Cal's suggestions for BE improvements
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Update src/metabase/util/embed.clj
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Fix backend linter error, hopefully.
      
      ---------
      
      Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
      Unverified
      d43863a2
  25. Feb 08, 2024
    • Nicolò Pretto's avatar
      Meet embedders - minimal version (#38520) · d88d32e5
      Nicolò Pretto authored
      
      * refactor: prepare SettingsPage to have conditionally rendered steps (#38201)
      
      * refactor: prepare SettingsPage to have conditionally rendered steps
      
      * fix tests missing props
      
      * Usage reason question (#38267)
      
      * Invactive -> Inactive
      
      * add question
      
      * fix e2e test
      
      * small refactor
      
      * Update frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * Hide "Add your data" step for people interested in embedding (#38390)
      
      * hide 'Add your data' step when user is interested in embedding
      
      * add other test cases
      
      * refactor: create selector
      
      * address pr feedback
      
      * adds minimal embed focused homepage (#38402)
      
      * very minimal homepage
      
      * fixed text color
      
      * minimal e2e + actual logic that i forgot lol
      
      * refactor the list to not have the numbers in the content
      
      * rename util functions
      
      * use button to have cursor when hovering + accessibility
      
      * refactor: move the waitFor inside the submit step
      
      * fix: make sure state is clean on multiple installs in a row
      
      * test: check that the homepage persists reload + removed typos
      
      * rename s to state
      
      * moved util functions up to home/utils.ts
      
      * adds key to avoid react warning
      
      * refactor and tests for [meet embedders] (#38465)
      
      * test: check all numbered steps during the setup flow
      
      * refactor: introduce getSteps and start using the step name instead of a number to identify steps
      
      * refactor: remove map of the steps, use step names directly
      
      * refactor: getNextStep
      
      * include 'hidden' steps in getSteps so that it won't mess up with analytics
      
      * fix after rebase issue
      
      * use full name instead of s, s -> step
      
      * analytics for meet-embedders (#38521)
      
      * refactor: extract schema version and onboarding version into constants
      
      * remove old ga events
      
      * trackUsageReasonSelected
      
      * update trackStepSeen to send the correct index
      
      * copy old schema for better diff
      
      * adds new snowplow event for usage_reason step
      
      * schema and e2e update for usage_reason_selected
      
      * adds utm tag to the link in the minimal embed homepage
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      d88d32e5
    • Alexander Solovyov's avatar
  26. Feb 02, 2024
  27. Dec 22, 2023
  28. Nov 15, 2023
  29. Nov 10, 2023
  30. Nov 03, 2023
  31. Oct 31, 2023
    • Nicolò Pretto's avatar
      Move card to tab - analytics event (#35151) · c10a995f
      Nicolò Pretto authored
      * move cards analytics event, closes #35123
      
      * change test to check specific analytics event
      
      * fix version in schema
      
      * update src/metabase/analytics/snowplow.clj with 1-1-2 schema version
      
      * update all dashboard schema events to use version 1-1-2
      
      * refactor: exctracted "DASHBOARD_SCHEMA_VERSION" variable
      
      * refactor: use camelCase for local constant
      Unverified
      c10a995f
  32. Jul 31, 2023
  33. Jul 05, 2023
  34. Jul 03, 2023
  35. Jun 27, 2023
Loading