Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 20, 2023
  2. Apr 19, 2023
  3. Apr 18, 2023
  4. Apr 11, 2023
  5. Mar 31, 2023
    • Braden Shepherdson's avatar
      [MLv2] Test `metabase.lib.convert` by round-tripping every `mbql-query` (#29487) · 61d382f1
      Braden Shepherdson authored
      This is a great way to make sure the conversion in both directions
      is robust; every feature of MBQL is exercised somewhere in the BE tests.
      
      In a few cases the `mbql-query` is called from a context where a
      `(is ...)` test won't work - those places can use a `mbql-query-no-test`
      instead. There were actually only two of these.
      
      This exposed several issues in `->legacy-MBQL` which have now been fixed.
      Unverified
      61d382f1
  6. Mar 29, 2023
    • Cam Saul's avatar
      [MLv2] Basic QP support for MLv2 queries (#29635) · d6b958c1
      Cam Saul authored
      * [MLv2] Basic QP support for MLv2 queries
      
      * Fix data/id init on launch
      
      * Fix Kondo errors
      
      * Add missing docstrings
      
      * Seriously Kondo!
      Unverified
      d6b958c1
    • Braden Shepherdson's avatar
      [MLv2] Move template tag extraction into CLJC for use from BE (#29526) · 900651ca
      Braden Shepherdson authored
      This supports both parsing out the tags and constructing the template tags map, with `card-id` and all.
      
      This is not quite a FE no-op because the humanization of text is slightly different between `metabase.util.humanization` and the JS humanization library.
      
      This improves JS<->CLJS conversion to handle UUIDs and be smarter about enums, both of which were needed to handle converting template tag maps.
      
      Extracted a `js=` test helper to `metabase.test.util.js/=` since many tests need to compare JS objects, which are not JS `==` to each other.
      Unverified
      900651ca
  7. Mar 28, 2023
  8. Mar 27, 2023
    • Ngoc Khuat's avatar
      Convert simple-* to toucan2 (#29427) · 8b8669a2
      Ngoc Khuat authored
      * (db/simple-insert! Model opts) -> (t2/insert! (t2/table-name Model)
      opts)
      
      * (db/simple-delete! model opts) => (t2/delete! (t2/table-name) opts)
      
      * (db/simple-insert-many! Model opts) => (t2/insert! (t2/table-name Model) opts)
      Unverified
      8b8669a2
  9. Mar 24, 2023
  10. Mar 23, 2023
    • Ngoc Khuat's avatar
      db/count, db/exist? => toucan2 (#29432) · f31368f6
      Ngoc Khuat authored
      * db/count -> t2/count
      
      * db/exists -> t2/exists
      Unverified
      f31368f6
    • Cal Herries's avatar
      Use type/JSON for field base_type for postgres and mysql (#28849) · 48dcfc92
      Cal Herries authored
      * Use type/JSON instead of type/SerializedJSON
      
      * Tidy migration
      
      * Update migration
      
      * Fix rollback migration for h2
      
      * whitespace
      
      * Add test for migration
      
      * Fix test
      
      * Add rollback
      
      * whitespace
      
      * Test JSONB type as well as JSON
      
      * Don't fingerprint JSON columns
      
      * Remove comment, that might be wrong in the future
      
      * Update test
      
      * Add tests for fingerprinting
      
      * Use base-type JSON for fingerprinting base query
      
      * Add test for visibility-type=details-only
      
      * undo .
      
      * Change migration id
      
      * Fix migration test
      
      * Merge master
      
      * Exclude mariadb from tests
      
      * Make is-mariadb? public
      Unverified
      48dcfc92
    • Ngoc Khuat's avatar
      db/insert! to t2 (#29389) · fbfb7e9b
      Ngoc Khuat authored
      * convert db\/insert! to t2
      Unverified
      fbfb7e9b
  11. Mar 22, 2023
    • Braden Shepherdson's avatar
      [MLv2] Fix `mu/defn` in CLJS · 61ba33e0
      Braden Shepherdson authored
      It's broken there because it tries to capture the Var returned by
      `defn` in a `let`. Vars aren't real in CLJS, so this doesn't work.
      The compile succeeds but the JS output is subtly broken.
      61ba33e0
  12. Mar 21, 2023
  13. Mar 20, 2023
  14. Mar 17, 2023
  15. Mar 16, 2023
  16. Mar 13, 2023
  17. Mar 07, 2023
  18. Mar 02, 2023
  19. Mar 01, 2023
    • Cam Saul's avatar
      Metabase® Lib™ v2 (#28517) · abd1958e
      Cam Saul authored
      * Metabase lib PoC RFC [ci skip]
      
      * Cleanup [ci skip]
      
      * `:lib/uuid` overhaul [ci skip]
      
      * More tests [ci skip]
      
      * Basic join support [ci skip]
      
      * Simplify a few things, more tests, etc. [ci skip]
      
      * Pipeline queries FTW [ci skip]
      
      * Metabase® Lib™ v2
      
      * Fix cljs test assertions
      
      * No bees please
      
      * Update docstring
      
      * Mega simplification
      
      * Fix Kondo warnings
      
      * Address PR feedback
      
      * Fix Malli util for Cljc
      
      * Oops, `instrument!` should be public
      
      * Cloverage do not instrument JS util namespace
      
      * Fix Cloverage again
      
      * Don't count MySQL or Postgres namespaces for Coverage
      
      * Address PR feedback
      
      * Move dispatch value keyword function to util
      
      * Revert acccidental require
      
      * Test fix
      
      * Fix Cljs =?
      
      * Fix totally unrelated broken links
      Unverified
      abd1958e
  20. Feb 27, 2023
    • Braden Shepherdson's avatar
      [metabase-lib] Dev experience and CLJC infra improvements · 4580eab9
      Braden Shepherdson authored
      Dev experience:
      - CLJS now has source maps
      - Devtools extension renders CLJS data in Chrome (et al) Devtools
      - Use a debug build of CLJS in the tests
      - Fixed line numbers and breakpoints being off-by-one in Devtools
      
      CLJC infra:
      - More robust direct approach to JS<->CLJS conversions, powered by
        Malli transformers.
      - Powerful `define-getters-and-setters` macro to generate the accessors.
      4580eab9
  21. Feb 24, 2023
  22. Feb 23, 2023
    • Cam Saul's avatar
      Snowflake Honey SQL 2 (#28478) · e3d817a4
      Cam Saul authored
      * Snowflake Honey SQL 2
      
      * Test fix :wrench:
      
      * Use Honey SQL 2 for GTAP compilation in sandboxing tests
      
      * Test fix :wrench:
      Unverified
      e3d817a4
    • Noah Moss's avatar
      Clojure migration to split v1 data perm paths into v2 data & query perms (#28350) · cde7ff70
      Noah Moss authored
      * new clojure migration for v1->v2 permissions
      
      * updates
      
      * fix rebase issue
      
      * fix reflection warning
      
      * fix final test and address comment about macro name
      
      * fix indentation
      
      * revert changes to defmigration macro to try to fix final test
      Unverified
      cde7ff70
    • Case Nelson's avatar
      Sqlite honey sql 2 (#28389) · 80ba6b1a
      Case Nelson authored
      * Convert sqlite driver to honey-sql-2
      
      * Fix bad case statement
      
      * We can't run native queries with AS for oracle
      
      * Dont call ->honeysql on a honeysql-expr
      
      * Fix bad call to h2x
      
      * Identifier needs to be wrapped
      
      * Update kondo config
      
      * Fix test
      
      * Remove hformat fn handler
      
      * Rotate the Snowflake DB prefix AGAIN
      
      * `sql.qp/format-honeysql` needs to wrap stuff in parens when generating SQL snippets
      
      * Update tests to match new expected SQL format
      
      * Sort namespaces
      
      * Fix the flaky paging test
      
      * Fix flaky `metabase.query-processor-test.timezones-test/filter-datetime-by-date-in-timezone-test`
      
      * MySQL test fix :wrench:
      
      
      
      * Try running Redshift with a beefier runner
      
      ---------
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Co-authored-by: default avatarCam Saul <1455846+camsaul@users.noreply.github.com>
      Unverified
      80ba6b1a
  23. Feb 22, 2023
  24. Feb 21, 2023
Loading