This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 01, 2024
-
-
metabase-bot[bot] authored
* Fix parameter values comparison in x-rays * Skip rerun when `parameterValues` are not initialized * Remove not used code Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Alexander Polyankin authored
-
- Mar 29, 2024
-
-
metabase-bot[bot] authored
* Cards with Results Should Show up in Subscriptions (#40743) * Cards with Results Should Show up in Subscriptions Fixes: #40726 This PR fixes a bug where setting 'Hide thie card if there are no results' in a Dashcard's viz-settings would hide the card even when there were results. * adjust test to show that the setting is respected Before, the setting would always hide the card. Now, the card is only hidden when there are no results. This test sets up 4 cards: 2 are normal, 2 have no results, but 1 has the setting to hide empty. THerefore, we should expect to see 3 results. * test is fine? --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
metabase-bot[bot] authored
* resolve conflicts and update few tests to await userEvents properly * Fix for userEvents 14 on Master (#40761) * Nick is sad * tests passing * fix lint and unit after rebasing on latest 49 branch --------- Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
metabase-bot[bot] authored
* add link * create HAR * formatting * periods * more formatting * feedback Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
* Add E2E test * Move `getDatasetQueryParams` to `data-fetching.js` * Use `null` as a parameter value when missing * Fix missing default `datasetQuery` Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
* Make Formatting on Exports Optional Formatting on exports can be turned off via a middleware key: `:format-export?` which will control if the 'app style' formatting will be applied to the exported results. `:format-export? false` will return the file as in previous Metabase versions. * format_export's default value provided in the QP middleware Should still default to formatted for v. 49, as the formatting is intended as a feature. This default value should be provided in a central place, so is added to the middleware and is therefore not necessary for the API to provide a default. * weird indentation * Add format_export param to dashboard dashcard query endpoint * Add format_export option to embedded dashboard downloads endpoint * Move default true value to the streaming-results-writer impls * Default true but for real this time * Add format_export to the public Question endpoint * Add test to card api * Dashboard exports endpoint test * Add test to dashboard embeds Test still fails and I don't know why yet * the dangers of println debugging.... Well, I was passing a string false the whole time. Turns out the problem was me * Public Card downloads endpoint now has format_export and test * export_format also works for adhoc queries using api/dataset * Let defendpoint do the boolean parsing * Embed endpoint should now work too. * Unify format-rows and format-export middlewares * Sneaky endpoint! * In xlsx, always parse temporal strings so that viz-settings formatting is applied * Snuck in an incomplete change by accident. removed it. * Can now specify format/no format on subscriptions * Fix and move migration * default format rows to true in attachments * Ok, I think that should actually work for subscriptions. * Change endpoints to use format_rows instead of confusing format_export * format_rows everywhere * Fix more test failures * redef'd function had wrong signature * Make format export optional (FE part) (#40643) * Refactor download URL builder code Need to handle query `params` and request `body` separately * Export `useHover` from `metabase/ui` * Add unformatted export for dashboard cards * Add unformatted export for saved questions * Fix POST body encoding * Add unformatted export for ad-hoc questions * Ensure `format_export` is always false for Excel * Add unformatted export to public questions * Add unformatted export to embedded questions and dashboards * Fix behavior for PNG format * Add tests for `QueryDownloadPopover` * Fix e2e downloads helper (allow URL query params) * Rework alt key handling * Add e2e test * Switch to `format_rows` instead of `format_export` * Add unformatted export option to subscriptions * Fix `isHoldingAltKey` initial state * Rework e2e test to use Total column * Fix initial checkbox state for subscriptions * Use "Alt" in tooltip label for Windows/Linux * Show the subscriptions toggle only for CSV attachments --------- * Address review feedback --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
For collections retrieved from the Search API, attach `location` and `effective_location` so the frontend knows... where they're located. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
- Mar 28, 2024
-
-
metabase-bot[bot] authored
* Throttle reset_password endpoint (#40760) * fix ns alias in backport --------- Co-authored-by:
dpsutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
if a previous run had an error, it will remain present but the state would be "indexed". We should just clear that error. Co-authored-by:
dpsutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Mar 27, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Correct issue where EE only LDAP user provisioning feature is breaking OSS instances (#40685) (#40699) Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix duplicate native column nesting * Try wrapping source-query in WITH statement * Fix tests * Fix tests * Only wrap in with when needed * More fixes * Update names and comments * Address PR review Co-authored-by:
Case Nelson <case@metabase.com>
-
metabase-bot[bot] authored
* Add backport resolution script * Fix filtering on LocalDates (#40530) * Split from #40146: only the filter changes * Don't include format-rows changes here. * Test fixes
* Test fix * Misc test fixes * Test fix * Tweak SQL Server fix * Fix Kondo errors * Updated api/dataset tests * Test fix --------- Co-authored-by:Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by:
Cam Saul <github@camsaul.com>
-
metabase-bot[bot] authored
Fixes #40328 [Our documentation](https://www.metabase.com/docs/latest/people-and-groups/managing#group-managers ) states that: > Group managers can: > > - View all people in the Admin settings > People tab. This fixes enforcement to be aligned with the documentation. This behavior makes sense, because as the docs also state, Group Managers should be allowed to *add* people to the group they manage, which they can only do if they can see those people! Initially, I also removed a faulty test, which was described as: ``` ;; Non-segmented users are allowed to ask for a list of all of the users in the Metabase instance. Pulse email lists ;; are an example usage of this. Segmented users should not have that ability. Instead they should only see ;; themselves. This test checks that GET /api/user for a segmented user only returns themselves ``` but actually failed to test this in a relevant way (because it was testing the `GET /api/user` endpoint rather than the `GET /api/user/recipients` endpoint). The test had continued to pass only because the user was the only member of the group they managed. I initially thought this behavior wasn't desired, but as it turns out, it *is* in fact documented behavior to disallow sandboxed users from seeing any email suggestions. Investigating, I found that a bug was allowing sandboxed users to see all users on the `/api/user/recipients` endpoint if the user-visibility setting was set to `:all`. Thus, the second commit fixes the bug and re-adds the (fixed) test. A sandboxed user now only sees their own user when hitting `/api/user/recipients`. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
metabase-bot[bot] authored
* Upgrade node to 18.20 * Trigger CI * Try 20 again * Revert "Try 20 again" This reverts commit 8f4b39e7a64f1fae7c60decfb91ea87aff81f587. * Revert change * Add nvmrc to the frontend_sources list Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
metabase-bot[bot] authored
* Sort official collections first in API endpoints For both `/api/collection/tree` and `/api/collection/items`, sort collections with official collections coming first. Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
metabase-bot[bot] authored
return collections in same order from /api/collections/tree and /api/collections/:id/items (#40044) (#40263) There were two problems here: - one endpoint was sorting in the database, but not putting 'analytics' last. - one endpoint was sorting in the database, but then sorting again in clojure, which had subtly different behavior for special characters Fixes #39965 Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com>
-
- Mar 26, 2024
-
-
metabase-bot[bot] authored
* Use expression fix on both pk-ref and value-ref The gist: inside the query expressions are referred to as [:expression "foo"]. But as a nested query, it's just another field, and the fact that it was an expression is irrelevant and should not leak from that stage. So "downstream" should just be [:field "foo" base-type]. Oddly, if you just fix one field or the other, the query would be "valid", would log an error, but no valid values would be returned. It seems like the invalid expression reference was just dropped so we only selected a single column and those were removed (we run `(filter valid-tuples?)` as we only want valid key/value pairs). So let's add a `(> (count values) 0)` which was failing previously. * Fix indexing error When updating the model index, it diffs the existing values vs the new values and deletes appropriate and adds the new values. But it was using the wrong column when updating the model index values. It used `pk_ref` but that table uses `model_pk`. This led to the following errors on stats: ```sql select pk_ref, value_ref, state, error from model_index where state = 'error' pk_ref,value_ref,state,error "[""field"",563028,null]","[""field"",563018,null]",error,"ERROR: column ""pk_ref"" does not exist Position: 68" "[""field"",534030,null]","[""field"",534037,null]",error,"ERROR: column ""pk_ref"" does not exist Position: 68" "[""field"",545945,null]","[""field"",545948,null]",error,"ERROR: column ""pk_ref"" does not exist Position: 68" ``` Now those errors will be fixed and the model indexes will correctly track the values * Bump indexing threshold to 25,000 Had been limited to 5,000 rows of model indexing. This was a made up number as we went into this endeavor. But it's proving to be far too small. Bumping to 25,000 * Parititon deletions and inserts With a higher limit need to ensure that we don't send too large of a query. ```clojure model-index=> (t2/insert! ModelIndexValue (map (fn [id] {:name (str (gensym "value")) :model_pk id :model_index_id 1}) (range 25000))) Execution error (PSQLException) at org.postgresql.jdbc.PgPreparedStatement/<init> (PgPreparedStatement.java:105). PreparedStatement can have at most 65,535 parameters. Please consider using arrays, or splitting the query in several ones, or using COPY. Given query has 75,000 parameters ``` * move comment and fix test failure explanation comment should be next to the number? check. and also need to use `mc/explain` which returns info rather than `mc/validate` which returns a bool: ```clojure ;; bad model-index-test=> (let [values [[1 "foo"] [2 "foo"] ["foo" "foo"]]] (-> (mc/validate [:sequential [:tuple number? string?]] values) (me/humanize))) nil ;; good model-index-test=> (let [values [[1 "foo"] [2 "foo"] ["foo" "foo"]]] (-> (mc/explain [:sequential [:tuple number? string?]] values) (me/humanize))) [nil nil [["should be a number"]]] ``` Co-authored-by:
dpsutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
* Fix case-sensitive option leaking to string/= (#40535) Fixes #40383 If a native query parameter is set up with a string widget type that supports a `case-sensitive` option, and that parameter is tied to a dashboard filter that did not support that option, the option was still leaking into the filter as an option where options were not expected. For instance the native query parameter used `string/contains` and the dashboard used `string/=`, the QP would try to build a filter like `[:= field value {:case-sensitive false}]` which is an illegal filter. * Fix moved fn --------- Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
* 40232 sortable with popovers (#40378) * custom sensor * e2e test, moving sortable * e2e test adjustment * combining props * backporting move DnDKitElement * adjusting e2e test --------- Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Braden Shepherdson <braden@metabase.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Fixes #37517. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
fix normalized chart crashes when trend lines enabled but there is no insights data (#40624) (#40627) Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
metabase-bot[bot] authored
* Fix e2e utils * Update e2e/support/commands/api/composite/createDashboardWithQuestions.js * Remove unnecessary return --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
* Add reproduction for spaces breaking the search in filter pickers * Search using display name too * Search using display name in summarize picker Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
- Mar 25, 2024
-
-
John Swanson authored
I started a much more complex fix with a job that tried to clean up stale `refreshing` PersistedInfos... then talked to Dan, who pointed out that because only one instance is running these jobs at any given time, we can just add `refreshing` to the list of refreshable states.
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-