This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 09, 2024
-
-
Denis Berezin authored
* feat(sdk): Add Dashboard loading event handlers * Refactor to redux state * Fix logic with load with cards data * Fix nasty e2e fails * Fix nasty e2e fails * Add global events * Fix issue with loading event * Fix issue with loading event * Review fixes * Add unit tests * Fix unit tests
-
Cal Herries authored
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* perf: pass uuid to BE to enable metadata caching during fetching dashboard * fixup! perf: pass uuid to BE to enable metadata caching during fetching dashboard * Add wildcard on interceptions * Add tests
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
-
Alexander Solovyov authored
-
Noah Moss authored
-
John Swanson authored
Prevent anything from being moved to the trash, or created in the trash.
-
Alex Yarosh authored
-
Aleksandr Lesnenko authored
-
Phoomparin Mano authored
-
dpsutton authored
Before ==== ``` 2024-07-04 15:54:39,084 INFO metabase.server :: Shutting Down Embedded Jetty Webserver Exception in thread "Thread-9" java.util.IllegalFormatConversionException: f != java.lang.Long 2024-07-04 15:54:39,122 WARN db.liquibase :: (#object[liquibase.Liquibase 0x2b7e6614 liquibase.Liquibase@2b7e6614]) at java.base/java.util.Formatter$FormatSpecifier.failConversion(Unknown Source) at java.base/java.util.Formatter$FormatSpecifier.printFloat(Unknown Source) at java.base/java.util.Formatter$FormatSpecifier.print(Unknown Source) at java.base/java.util.Formatter.format(Unknown Source) at java.base/java.util.Formatter.format(Unknown Source) at java.base/java.lang.String.format(Unknown Source) at clojure.core$format.invokeStatic(core.clj:5770) at clojure.core$format.doInvoke(core.clj:5764) at clojure.lang.RestFn.invoke(RestFn.java:423) at metabase.db.liquibase$wait_for_all_locks.invokeStatic(liquibase.clj:258) at metabase.db.liquibase$wait_for_all_locks.invoke(liquibase.clj:251) at metabase.db.setup$release_migration_locks_BANG_.invokeStatic(setup.clj:175) at metabase.db.setup$release_migration_locks_BANG_.invoke(setup.clj:170) at metabase.db$release_migration_locks_BANG_.invokeStatic(db.clj:91) at metabase.db$release_migration_locks_BANG_.invoke(db.clj:86) at metabase.core$destroy_BANG_.invokeStatic(core.clj:90) at metabase.core$destroy_BANG_.invoke(core.clj:81) at clojure.lang.AFn.run(AFn.java:22) at java.base/java.lang.Thread.run(Unknown Source) ``` And now it will correctly log ``` 2024-07-09 16:04:28,345 INFO db.liquibase :: Waiting for migration lock(s) to be released (max 0.4 secs) ``` Why no tests? ==== There _is_ a test that would have caught this. And in fact running at the repl will catch it: ```clojure liquibase=> (do (require 'clojure.test 'metabase.db.liquibase-test) (clojure.test/run-test metabase.db.liquibase-test/wait-for-all-locks-test)) Testing metabase.db.liquibase-test ERROR in (wait-for-all-locks-test) (Formatter.java:4515) :h2 Will timeout if a lock is not released expected: (= :timed-out (liquibase/wait-for-all-locks sleep-ms timeout-ms)) actual: java.util.IllegalFormatConversionException: f != clojure.lang.Ratio ``` But this _passes_ in CI: ``` ❯ clj -X:dev:test :only metabase.db.liquibase-test/wait-for-all-locks-test Finding tests took 23.5 s. Running 1 tests Running before-run hooks... Ran 1 tests in 1.461 seconds 3 assertions, 0 failures, 0 errors. {:test 1, :pass 3, :fail 0, :error 0, :type :summary, :duration 1461.175042, :single-threaded 1} Ran 0 tests in parallel, 1 single-threaded. Finding and running tests took 25.0 s. All tests passed. Running after-run hooks... ``` And that's because the log level in testing is FATAL and this is an INFO level log. Discussed ways to improve this like adding a null logger during CI but we aren't ready to increase CI times for that just yet.
-
Nick Fitzpatrick authored
* move subtext to command palette item generation. Support model-indexes * changing text, adding unit tests * PR Feedback
-
Nicolò Pretto authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
* Add the default pinned metric description * Expand unit tests to repro #45270
-
Oisin Coveney authored
-
Cal Herries authored
-
Nemanja Glumac authored
* Enable "Add to dashboard" for metrics v2 * Add repro for #44220
-
Romeo Van Snick authored
-
Alexander Solovyov authored
-
Ngoc Khuat authored
-
Elton Okawa authored
-
Romeo Van Snick authored
* Move focus to separate helper * Use focus method to do initial focus * Use focus method for other _editor.focus calls * Move focus to componentDidMount * Cancel focus timeout on unmount * Add delay to broken test * Switch to requestAnimationFrame * Remove wait in test
-
- Jul 08, 2024
-
-
Noah Moss authored
Allow unrestricted data perms to override block even if another table has legacy no-self-service (#45118)
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
* fix combined cards crash when some cards have invalid viz settings * fix mock column was not metric * ensure combined scalar column has proper type to handle the case when the card returns empty results
-
metamben authored
Fixes #39789.
-
Raphael Krut-Landau authored
This PR also specifies the 'filled' variant for the question duplication modal, since the previous default 'filled' variant for submit button was added to make that specific button filled.
-
bryan authored
* update e2e test for command pallete to use a valid setting * remove the setting from the ui, make it always true, unless set false from env * remove enable-nested-queries from admin section on fe - fix unused oldValue -> _oldValue * tests aren't allowed to change enable-nested-queries * fix test + disallow setting nested queries from code * we cannot set enable-nested-queries - set the env var instead * add checks for the enable-nested-queries setting * make resolve-source-cards work with enable-nested-queries setting * fix recents uri interception * return enable_nested_queries setting to client * adjust fetchmock url matcher --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
John Swanson authored
* Nicer error messages for linting migrations In general, just throw exceptions instead of using clojure spec here. You'll only get one error per run, but that seems fine. I did keep some specs around, but run them slightly differently. Rather than validating the whole collection of changeSets at once with `s/+`, just `doseq` through the changeSets and validate each one separately. That way, the value that's presented as erroneous is much smaller (a single changeSet) and it's easier to see what went wrong. * Update bin/lint-migrations-file/test/lint_migrations_file_test.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Update bin/lint-migrations-file/src/lint_migrations_file.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Require preConditions for certain liquibase change types to encourage idempotence (#44578) Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * remove `!`s from non-side-effecty fns * add preConditions to a few v51 migrations --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Jeff Bruemmer authored
-
Noah Moss authored
-
Cam Saul authored
* Split unrelated changes into separate PR * Fix test since user perms set reset fix split into other PR * Fix syntax error * Test fixes
* Test fix??? * Test fix -
Noah Moss authored
-
Nemanja Glumac authored
* Use Mantine Modal for QB Newb disclaimer * Add repro for #44754 * Use theme spacing units * Tweak the design slightly * Fix E2E test
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-