Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 14, 2023
    • Tim Macdonald's avatar
      Ensure actions are created with models (not cards) (#28299) · 54a56bab
      Tim Macdonald authored
      [Fixes #28298]
      Unverified
      54a56bab
    • Tim Macdonald's avatar
      Action archiving (#28268) · 8554eaed
      Tim Macdonald authored
      * Add action.archived and search
      
      Constituent commits:
      
      Basic action archiving and search; no perms
      
      Only show actions in search with appropriate permissions
      
      archive test
      
      Make search tests more tolerant of local DB state
      
      Show model that actions come from in search results
      
      Test action search properly
      
      Per Conor/Bruno, actions have higher search precedence than pulses
      
      Don't return archived actions from the main GET endpoint
      
      Clean things up based on PR review
      
      Don't show archived actions in most endpoints
      
      Remove actions from search so this can be merged sooner
      
      Delete associated DashboardCard when Action is archived
      
      Add a few more tests
      Unverified
      8554eaed
    • Cal Herries's avatar
      BE - Handle existing actions when database-enable-actions setting is disabled (#28153) · 923e4efb
      Cal Herries authored
      * Check at GET /action/:uuid
      
      * Optimize queries
      
      * Fix and add tests
      
      * Add tests for public_links
      
      * Remove tap>
      
      * Use t2
      
      * More of ngoc's suggestions
      
      * use nil for default connection
      
      * Use post-select
      
      * Use select-one instead
      Unverified
      923e4efb
    • Cal Herries's avatar
      Include database settings in GET "/api/database" and GET "/api/database/:id"... · 58f724f1
      Cal Herries authored
      Include database settings in GET "/api/database" and GET "/api/database/:id" response and respect `:visibility` (#28150)
      
      * Apply visibility to database settings
      
      * Refactor: Apply same pattern to writable visibilities
      
      * Remove extra whitespace
      
      * Update user-readable-values-map docstring
      
      * Fix syntax error
      
      * Update JSON encoding to filter settings even if the database is writeable
      
      * Update test
      
      * Add database endpoint tests
      
      * Update to-json docstring
      
      * Update comment
      
      * Fix kondo errors
      
      * Update geojson env var test
      
      * Fix tests
      
      * Change comment
      
      * Rename to writable-settings and other suggestions
      
      * Un-private test settings
      
      * Typo
      
      * Change temp-defaults to have setting be {} not nil
      
      * Update settings only when settings is non-nil
      
      * Fix
      
      * Fix tests
      
      * Fix test
      
      * Fix test
      Unverified
      58f724f1
  2. Feb 13, 2023
    • Cam Saul's avatar
      Switch MySQL driver to Honey SQL 2 (#28176) · b820fa55
      Cam Saul authored
      * Support Honey SQL 2 for SQL QP
      
      * Sort namespace
      
      * Make Postgres/Redshift be Honey SQL 2-only
      
      * Test fix :wrench:
      
      * Fix busted
      
      * Redshift test fixes :wrench:
      
      * Sort namespaces
      
      * Fix Postgres convert_timezone
      
      * Fix linter config.
      
      * Switch MySQL driver to Honey SQL 2
      
      * Fix one last test failure
      
      * Redshift test fix
      
      * Test fixes and some extra validation etc.
      
      * Update common.clj
      
      * Update common.clj
      
      * Update common.clj
      
      * Add missing reflection warning
      
      * Add missing reflection warning
      
      * Use new namespace names
      
      * Fix a few things.
      
      * We should error on double-compilation of Honey SQL forms.
      
      * Fix a bunch of nonsense
      
      * Move Token features check fixes to a different branch
      
      * Test fixes
      
      * Fix double-compilation of raw forms
      
      * Test fix :wrench:
      
      * Test fix :wrench:
      
      * Eliminate unneeded casts
      
      * Fix syncing JSON table in MySQL 5.7
      
      * Don't error on sync for tests that are supposed to test sync error handling
      Unverified
      b820fa55
    • Bryan Maass's avatar
      update mu/defn kondo config 2 support lsp renaming (#27980) · 9ae71520
      Bryan Maass authored
      * update mu/defn kondo config 2 support lsp renaming
      
      * update mu/defn kondo config 2 support lsp renaming
      
      * add docstrings
      
      * fix linting error
      
      * fix "unused binding" error in test fxn
      
      * fix some calls to mu/defn
      Unverified
      9ae71520
    • Cam Saul's avatar
      Address feedback on #28017 (#28242) · 51c6120c
      Cam Saul authored
      * Address feedback on #28017
      
      * Fix evil code order
      Unverified
      51c6120c
    • Ngoc Khuat's avatar
      avoid n+1 in search (#28185) · 3a32560d
      Ngoc Khuat authored
      * avoid n+1 in search api
      
      * remove the mapping from model to the old toucan model
      
      * use model vars instead of keyword
      Unverified
      3a32560d
  3. Feb 10, 2023
  4. Feb 09, 2023
  5. Feb 08, 2023
  6. Feb 07, 2023
    • Braden Shepherdson's avatar
      Standardize on `metabase.util.log` for logging; use it everywhere (#28050) · dad3d414
      Braden Shepherdson authored
      This has the same interface as `clojure.tools.logging` but supports CLJS
      as well. It was formerly known as `metabase.shared.util.log`.
      Unverified
      dad3d414
    • Bryan Maass's avatar
      mu/defn fix: no return schema docstring generation (#28121) · f95817bf
      Bryan Maass authored
      * handle nil return schemas for docstring gen
      
      * adds more mu/defn docstring generation tests
      Unverified
      f95817bf
    • Cal Herries's avatar
      Serdes for Actions (#27879) · 115d42c6
      Cal Herries authored
      * Whitespace
      
      * Add Action to entities list
      
      * Add entity_id column migration
      
      * Correct migration ids
      
      * Add entity-id property to action model
      
      * Extract and serdes-dependencies for action
      
      * storage for Action
      
      * ingest for Action
      
      * Generate for Action
      
      * load for Action
      
      * Remove comment
      
      * Add entity_id to action submodels
      
      * Add submodels to copy entities
      
      * Add submodels to exported-models
      
      * Add submodels to legal-top-level-paths
      
      * Slufigy extracted label for action
      
      * Extract for QueryAction
      
      * Generate query_action
      
      * Fix query_action extract test
      
      * Add action subtype extract tests
      
      * Update Action-subtype-IModel-impl docstring
      
      * Generate ImplicitAction and HTTPAction
      
      * Export and Import action_id FK with dashcards
      
      * Generate nano-id
      
      * Add load tests to e2e test
      
      * Nest subtypes directories in actions
      
      * Remove prn
      
      * Add docstring
      
      * Fix copy
      
      * Add select-action fn
      
      * Change extract tests to only extract Action model
      
      * Update action/select-one tests
      
      * Update legal-top-level-paths
      
      * Rename select-action -> select-one
      
      * Implement extract-one for Action only, not subtypes
      
      * Move subtype models from exported to inlined
      
      * Remove entity_id from subtypes
      
      * Reuse type->model
      
      * Ingest Action with inlined subtype info
      
      * Fix serdes-dependencies for Action
      
      * Add action to serdes-descendants for Dashboard
      
      * Add docstring to action update!
      
      * Reuse update! for PUT API
      
      * Add missing ns
      
      * Remove serdes-generate-path impl
      
      * Tidy
      
      * Sort ns
      
      * Restore add-entity-id
      
      * Update entity_id_test
      
      * Undo refactor
      
      * Include id in action arg for update!
      
      * Delete action, with delete cascading to the subtype
      
      * Fix clj-kondo warning
      
      * Fix returning nil Action in dashboard serdes-descendants
      
      * Braden's suggestions
      Unverified
      115d42c6
    • Tim Macdonald's avatar
      Log a warning when extraneous parameters are passed into a request (#28032) · 5d106f30
      Tim Macdonald authored
      
      * Log a warning when extraneous parameters are passed into a request
      
      * Massive Metabase logging performance improvement: use configured log levels in logs API endpoint
      
      ---------
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      5d106f30
  7. Feb 06, 2023
    • Noah Moss's avatar
      Rework sandboxing QP middleware to use `sandboxes` table as source of truth (#27985) · 0579ebf6
      Noah Moss authored
      * rework sandbox enforcement to use sandboxes table as source of truth
      
      * remove test that no longer reflects expected behavior
      
      * cleanup & refactor
      
      * clarify docstring
      
      * update segmented-user? to use new helper functions
      
      * fix tests
      
      * address comments
      Unverified
      0579ebf6
    • metamben's avatar
    • Bryan Maass's avatar
      mu/defn auto docstrings (#28042) · 6d7ac621
      Bryan Maass authored
      mu/defn now prepends docstrings onto functions, the way prismatic schema does.
      
      
      * prepend docstring with m.schema annotation
      * refinement of alignment
      * fix typo in docstring
      Unverified
      6d7ac621
    • Cal Herries's avatar
      [Feature] Allow actions to be shared via public link: Milestone 1 (#27777) · 90919d31
      Cal Herries authored
      * Add public_uuid and made_public_by_id to actions table & endpoints to enable/disable the public sharing on individual actions (#27721)
      
      * Add migration for public_uuid (indexed) and made_public_by_id
      
      * Add UUIDString schema
      
      * Add endpoints for enabling/disabling sharing of actions
      
      * Test that the new fields are returned with `GET /api/action/:id`
      
      * Remove validCheckSum on migration
      
      * Remove trailing whitespace
      
      * Fix DELETE test
      
      * Fix tests
      
      * Please migration linter
      
      * Update the default public_uuid every test run
      
      * Please migration linter
      
      * Add FK onDelete cascade
      
      * Replace ü
      
      * Add GET endpoint and post-select for action
      
      * Revert "Add GET endpoint and post-select for action"
      
      This reverts commit 8cc8b57d6034146dd726b54bc4199830ec1fda21.
      
      * Fix merge
      
      * Reorder migrations
      
      * Update test for GET `api/action?model-id=<id>` endpoint to include public sharing keys (#27802)
      
      * Add GET: /api/public/action/:uuid endpoint (#27781)
      
      * Add test
      
      * Remove non-public columns and check for 404
      
      * Fix docstring
      
      * Rename for clarity
      
      * Fix missing ns
      
      * Remove unneccessary keys from action
      
      * Update test
      
      * Remove unused refer
      
      * Reorder migrations
      
      * Use mt
      
      * Add require and refactor
      
      * Use mt
      
      * Add endpoint for executing a public action (#27793)
      
      * Add endpoint and test
      
      * Add more tests and TODOs
      
      * Use mt
      
      * Reorder migrations
      
      * Remove unused require
      
      * Rate limit actions at 1 per second
      
      * Fix the tests for the throttle
      
      * Refactor tests
      
      * Fix test
      
      * Fix docstring
      
      * Add test for failed execution if actions are disabled
      
      * Use crowberto in tests
      
      * Fix using crowberto in tests
      
      * Fix cyclic load dependency
      
      * Refactor ActionCreator (#27832)
      
      * Refactor make ActionCreator more sane
      
      * Render sidebar conditionally with JS rather than hiding it in CSS
      
      * Make action public (#27809)
      
      * Move action creator action buttons to the header following design
      
      * Remove double border which make it looks thicker
      
      * Draft toggle action public
      
      * Add confirmation when disabling public link similiar to questions and dashboards
      
      * Add an action public UUID input and copy button
      
      * Show action settings based on user permission
      
      * Add public action toggle tests
      
      * Remove unused import :face_palm:‍
      
      * Attempt to fix flaky CI unit tests
      
      The problem seems to be because of how long it takes for the response
      to be received even on unit tests, it took longer than 1 second which is
      the default timeout for `waitFor`.
      
      * See if not using `userEvent` could make the involving nock faster
      
      * Improve test speed to reduce flakiness
      
      * Add public action page (#27747)
      
      * Add basic public action page
      
      * Add form submit logic placeholder
      
      * Use "Submit" as default action form's button label
      
      * Add "big" variant to `EmbedFrame's` footer
      
      * Use new footer variant for action page
      
      * Break down the page, add document title
      
      * Handle long forms better
      
      * Add `PublicWritebackAction` type
      
      * Use public action GET endpoint
      
      * Add endpoint to execute public actions
      
      * Use action execution endpoint
      
      * Add tests
      
      * Handle actions without parameters
      
      * Rename variant prop
      
      * Replace `waitFor` with `findBy`
      
      * Define `FooterVariant` type
      
      * Fix router setup in `renderWithProviders`
      
      * Show which action is publicly accessible on model detail page (#28039)
      
      * Bring e2e tests back
      
      Manually bringing back tests added in: https://github.com/metabase/metabase/pull/28056
      
      
      
      * Update typo
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * Remove TODO and use malli for defendpoint
      
      * Add malli schema for endpoints
      
      * Update permissions checks for POST and DELETE
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      Unverified
      90919d31
    • Ngoc Khuat's avatar
      makes sure snowplow tracking for taskhistory does not exceeds the chars limit (#28019) · 3bfa4e16
      Ngoc Khuat authored
      * makes sure snowplow tracking for taskhistory does not exceeds the 2048 limit
      
      * explains why 2048 limit is needed and return nil instead of empty string
      Unverified
      3bfa4e16
  8. Feb 02, 2023
Loading