Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 31, 2024
  2. Oct 30, 2024
  3. Oct 29, 2024
    • adam-james's avatar
      Mongo objects should download as JSON, not EDN (#49255) · d23d7a3a
      adam-james authored
      * Mongo objects should download as JSON, not EDN
      
      Fixes #48198
      
      Prior to this change, object columns (base or effective type of :type/Dictionary) were just formatted with `(str
      value)` which results in a csv or json download containing EDN formatted objects.
      
      This is a bug because we present object column values as json in the app, so the expected formatting of the download
      should match this.
      
      The formatter function now takes this type into account. As well, since this is a type of formatting that should be
      always applied (even when format_rows is false), the function is modified to unconditionally apply the json/encode
      formatting to dictionary types when encountered.
      
      * add a test
      
      * add proper condition to test
      
      * card-download should be public
      
      * uncomment json encoding formatter
      
      * set-cell! should keep encoded json string for Objects
      
      I think this is the correct change; I don't really understand the reason for wrapping, encoding, decoding, and then
      string-ing that value. Maybe I'm missing something.
      
      * Adjusted xlsx Object set-cell! implementation
      
      * forgot the not... inverted
      Unverified
      d23d7a3a
    • Noah Moss's avatar
  4. Oct 25, 2024
  5. Oct 24, 2024
  6. Oct 23, 2024
  7. Oct 22, 2024
  8. Oct 21, 2024
    • adam-james's avatar
      Fix a Couple bugs related to pivot exports (#48867) · 290845ef
      adam-james authored
      * Fix a Couple bugs related to pivot exports
      
       - pivot-grouping value, when not an int (in the case of Oracle dbs), would cause exports to contain zero rows. This
       fixes that
       - json formatted/unformatted for the dataset API endpoints (unsaved questions) was not being used, so all exports
       were formatted
      
      * json and csv use (int group) to check row inclusion
      
      * grouping change fix tests
      
      * json formatted/unformatted test
      
      * xlsx formatters are correct when pivot-grouping col is removed
      
      * cljfmt
      
      * fix up failing tests
      
      * fix test
      
      * Update src/metabase/api/dataset.clj
      Unverified
      290845ef
  9. Oct 18, 2024
    • Cam Saul's avatar
      Modularize metabase.pulse; add metabase.pulse.core API namespace (#48640) · c92e8c99
      Cam Saul authored
      * Modularize metabase.pulse; add metabase.pulse.core API namespace
      
      * Rename metabase.pulse.send-test
      
      * Split email result attachment stuff into its own namespace
      
      * Update dashboard-subscription-test
      
      * Allow metabase.email.result-attachment externally... for now
      
      * More code cleanup
      
      * Decouple models.card and email.messages
      
      * Decouple models.collection and metabase.email.messages
      
      * Hopefully the last fix :wrench:
      
      * Fix #48647 :slight_frown:
      
      * Fix event handler
      
      * :render/text, not :pulse/text
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * RESPECT the modules
      
      * Remove unused namespace
      Unverified
      c92e8c99
    • bryan's avatar
      More grouped metrics data (#48900) · 1d195113
      bryan authored
      * Adds query_executions_by_source_24h and entity_id_translations_last_24h
      
      - add docstring
      
      * clear eid translation count in stats-post-cleanup
      
      * remove ->> with after? it's confusing
      
      * dissoc the right path
      Unverified
      1d195113
    • lbrdnk's avatar
      Use case expression type inference logic similar to annotate middleware in MLv2 (#47902) · 63a3b4b3
      lbrdnk authored
      * Use type date for case expression when there are Date and DateTime args
      
      * Use logic for getting case expr type from annotate middleware
      
      * Add e2e test
      
      * Add bigquery test
      
      * Update test
      
      * cljfmt and comment
      
      * Adjust e2e test
      Unverified
      63a3b4b3
  10. Oct 17, 2024
  11. Oct 16, 2024
  12. Oct 15, 2024
    • bryan's avatar
      Adds missing schemas + data for metrics to snowplow stats ping (#48476) · e5c181bd
      bryan authored
      * adds data + schema for metrics stats ping
      
      * remove comment
      
      * annotate todos
      
      * fill in the rest of the metrics values
      
      - and add defaults
      
      * fix some definitions + use a single timestamp
      
      * shuffle stuff around to appease the namespace linter
      
      - we aren't reaching into the api API, so the linter is more of a
        formality here.
      
      * update docstring
      
      * fix jsonschema, maybe
      
      * review responses
      
      - revert changes to 1-0-0
      - add metrics section to new file: 1-0-1
      - bump ::instance_stats to "1-0-1"
      - add tags into 1-0-1
      - make the code return tags (empty for now until we know what to tag things.)
      
      - also fix test that broke from shuffling settings around
      
      * remove a footgun
      
      * add tags to metrics,
      
      add grouped_metrics to jsonschema 1-0-1
      
      format 1-0-1
      
      * indent
      
      * cljfmt
      
      * version should match filename
      
      * update instance stats 1-0-1 schema
      
      * require `tags` in grouped_metric + snowcat comment
      
      * fix formatting noise
      
      * update schema to make it valid
      
      * remove grouped_metrics from instance_stats schema
      
      * cljfmt appeasement
      
      * unbin cache_num_queries_cached value
      
      - alphabetize metrics generation
      
      * we can now guarantee metric values will be ints
      
      * jsonschema for instance_uuid, settings, and grouped_metrics
      
      * add analytics_uuid and make it required
      
      * lint + alphabetize instance stats json schema
      
      * update setting key type
      
      - add maxLength to some strings
      
      * lint jsonschema
      
      - Add description to setting.items.tags
      - add maxLength, and {min,max}imum to setting.items.value
      
      * Bump instance stats to 2-0-0
      
      - remove analytics_uuid string length == 36 check
      - adds assertion to ensure required fields are set (and it passes)
      - adds info for embedding settings
      
      * adds a grouped-metric to stats ping
      
      - adds length info to the schema to pass jsonschema linting
      
      * cljfmt
      Unverified
      e5c181bd
    • adam-james's avatar
      Incremental Pivot Processing for Exports (#46995) · 8d52a03f
      adam-james authored
      
      * Incremental Pivot Processing for Exports
      
      WIP
      
      Fixes pivot exports for CSV and xlsx.
      
      The CSV export should use less memory by incrementally building up the data structure and aggregating necessary row
      data right away, so the memory overhead becomes only as large as the total pivot result.
      
      In cases where the pivot rows/cols do combine into many many columns and rows, this can still be a large set of data,
      but it should behave much better now in most cases.
      
      The Excel export is a little more straightforward: create the export rows in the same fashion, streaming one row at a
      time, and just post-process the sheet to add the pivot table in one shot at the end.
      
      * WIP adding row totals.
      
      * aggregate totals as rows are added
      
      Row, column, section, and grand totals are all aggregated as each row is added.
      This means the final step of building pivot output becomes just an exercise of lookups/arrangement, no further
      aggregation is needed.
      
      * CSV pivot works per-row, export respects formatting
      
      This is a big step forward; we don't need to hold the entire dataset in memory, we instead aggregate a row's data into
      the pivot datastructure, which only holds onto:
      
      - unique values for each pivot-row in a sorted set
      - unique values for each pivot-col in a sorted set
      - grand total for each measure N values, where N is number of measures, ususally 1 or 2
      - row totals for each combination of each pivot-row * N measures
      - col totals for each combination of each pivot-col * N measures
      - totals for each 'section', determined by unique values of first pivot-row * N measures
      - values for each measure in every 'cell'; Row Combos * Col Combos * N Measures
      
      So, there can still be a decent amount of data to store; but it will never hold onto all of the 'raw rows' from the
      dataset.
      
      We can never completely guarantee that Row Combos * Col Combos * N Measures remains small, but two things let us move
      forward anyway:
      
      - there's now visible feedback in the app that the download is running (or if it's failed)
      - Pivot table utility diminishes rapidly with huge output anyway; users still need to curate/set up their data
      - effectively to improve the table's utility, so we can assume that a slow-to-download pivot table is also slow to
      - use/less effective, and will likely be something the user doesn't want (as often).
      
      * some test fixes
      
      * now, if we export 'raw pivot rows', they don't show pivot-grouping
      
      and they also don't include the 'extra' rows for totals/subtotals/grand totals (any row with pivot-grouping > 0).
      
      This means that now the non-pivot version of a pivot table export will match what a user sees if they change the viz
      to a regular table.
      
      * remove old test
      
      * re-incorporate some changes from master
      
      * fix csv for non-pivots due to oversight in my changes
      
      This is just a temporary change, I think I should clean up this bit of the code a little, I can probably make it a
      little more readable and use some cleaner logic regarding if the rows are 'raw pivot rows' or not.
      
      * start moving format_rows to POST bod, add pivot_results too
      
      There's still wiring work to do, but this starts to add format_rows and pivot_results to POST body for the various API
      endpoints. Also modify tests to improve coverage/consistency across downloads and alerts/subscriptions.
      
      The tests will not pass on this commit, but fixes will be incoming
      
      * native pivot tables in xlsx
      
      * add precondition to pass migration linter
      
      * try to get migrations fixed
      
      * pasing pivot-results through api and attachments
      
      * fix tests for format_rows in BODY vs query param
      
      * tests!
      
      * might have the tests all fixed now
      
      * the pivoted export now respects col/row totals settings
      
      * add test coverage for public questions and dashboards
      
      * col and row totals work as expected
      
      * build-pivot refactor for clarity
      
      * docstring change + tiny refactor in helper fn
      
      * see if dashcard download works with format_rows
      
      * csv pivot handles nil values
      
      * pass format_rows and pivot_results in :params not :body
      
      * fix some other tests
      
      * pivot-grouping col filtered out of xlsx
      
      * pivot-grouping-col removed for all rows
      
      * configurable pivot exports and attachments (#47880)
      
      * exports fe
      
      * specs
      
      * ui
      
      * specs
      
      * format/unformatted now works for xlsx
      
      * format test changes for xlsx formatting
      
      * embedding endpoints accept pivot_results
      
      * cljfmt and eslint fix
      
      * empty
      
      * embedding test should have formatting defaulted to true
      
      * embed test fixes
      
      * Use `Chip` for export settings widget
      
      * downloads e2e test fix
      
      * fix public download limit test
      
      * public card download defaults
      
      * fix public download defaults in some tests
      
      * Fix visual test
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      8d52a03f
    • Aleksandr Lesnenko's avatar
      fix iframe dashcards crash subscriptions (#48589) · ba06b99e
      Aleksandr Lesnenko authored
      
      * fix iframe dashcards crash subscriptions
      
      * add a test to ensure iframes are filtered out of subscriptions
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Unverified
      ba06b99e
Loading