This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 20, 2024
-
-
Kamil Mielnik authored
* Allow navigating with arrow up/down between lines in expression editor * Do not hijack up/down arrow keys for autocomplete suggestions navigation when there's only 1 suggestion * Add explanatory comments * Convert tokenizer to TS * Add a test * Format code * Add basic test case * Fix a deprecation * Handle incomplete bracket identifier tokens * Shorten code * Add comment * Fix suggestion not always getting selected * Fix computation * Fix types * Update comment * Add repros for #49882 * Add repro * Fix comment * Deprecate a HOC * Update assertion * Remove _.compose and default export * Fix types in ExplicitSize * Fix typing in ExpressionEditorTextfield * Fix types * Fix error handling * Fix showing errors when expression is invalid * Do not submit null expressions * Fix typing * Update assertion * Fix flaky test * Fix filter * Decrease flakiness * Fix crashing * Add comment * Fix incomplete bracket idenfitiers * Fix type * Improve typing * Add an explanatory comment
-
- Nov 19, 2024
-
-
Romeo Van Snick authored
* Allow TableInteractive to render it's own empty message * Pass renderEmptyMessage to visualization in model editor * Add reproduction for #37300 * Use double equals ofr null check Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
* Do not show values initially when single select search does not have a filter * Add repro for 49577 * Reword test case Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Fix e2e test --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Uladzimir Havenchyk authored
* chore: forbid legacyQuery usage with eslint * fixup * fixup
-
Jeff Bruemmer authored
-
Aleksandr Lesnenko authored
* allow more iframe attributes * make iframe sandbox more permissive * update spec
-
metamben authored
-
Kamil Mielnik authored
* Fix #50128 * Add repro for #50128
-
Nicolò Pretto authored
* fix(sdk): handle relative urls for metabaseInstance in loading maps * addTrailingSlash -> ensureTrailingSlash Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Oisin Coveney authored
-
- Nov 18, 2024
-
-
Aleksandr Lesnenko authored
* remove LegendVertical logic that preserves legend width * memoize pie legend items * prevent pie from jumping when toggle legend * fix responsive legend logic, cleanup * drop hyphens from the pie legend (#29597) * eliminate flickering on render due to not having dimensions * shortcut * specs * test vertical layout has no hyphens * setup func * set explicit showLegend=true default
-
Ryan Laurie authored
-
Nick Fitzpatrick authored
-
lbrdnk authored
* Add temporal unit to display name * Remove temporal unit adjustments from FE * formatColumn to displayNameForColumn * Factor out getFriendlyName * Adjust BE tests * Add require * Adjust FE unit tests * Adjust temporal-unit-parameters.cy.spec.js * Adjust dashboard-reproductions.cy.spec * Convert formatColumn occurrence * Adjust legacy display name logic generation After `getFriendlyName` was removed from FE, capitalization of display name should happen here. Logic is similar, should be adjusted prior merging the PR. * Adjust embedding-linked-filters.cy.spec.js * Adjust joins-reproductions.cy.spec.js * Adjust metrics-editing.cy.spec.js * Adjust timelines-question.cy.spec.js * Adjust offset.cy.spec.ts * TMP Avoid duplication of temporal unit in display name in MLv2 code * Probably FE fix: add default temporal bucket only if not present * WIP Add ends-with-temporal-unit? function Current strategy is to add temporal units to display names if same is not already present * Adjust display-name-method :metadata/column Append TU to display name only if different to what's already present * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element * Return also temporal-unit from visible-columns * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec * Adjust multiple-column-breakouts.cy.spec.ts * It was not a bug. * Revert changes in _BaseBucketPickerPopover * Restore temporal-unit for next stages removal in stage.cljc * Add inherent-temporal-unit * Adjust display name temporal bucket logic * Rename to inherited-temporal-unit * Shutdown too broad display name capitalization * Eastwood * Adjust pivot-rows-order-test * Adjust pivot-non-numeric-values-in-aggregations * Adjust inherent to inherited * Rename to inherited * Add inherent-temporal-unit only to returned-columns * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts * Update consistent-date-formatting-test * Update dashboard/x-rays.cy.spec.js * Update waterfall.cy.spec.js * Return month default for default inherited-temporal-unit * Update reproductions-3.cy.spec.js * Update downloads/downloads.cy.spec.js * Update legend.cy.spec.js * Update pie_chart.cy.spec.js * Update click-behavior.cy.spec.js * Update embedding-linked-filters.cy.spec.js * Return QueryColumnPicker's condition to original state * Remove reundant export * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts * Comment * Update nested.cy.spec.js * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js * Adjust to TS types * Adjust for cljfmt * Capitalize * Add propagation tests * Add inherited-temporal-unit propagation for expressions * Add default inherited-temporal-unit test cases * Add qp temporal-bucket-test ns * Simplify default unit logic * Comment * Use NULL_DISPLAY_VALUE * Comment * Comment * Comment * Comment * Comment * Comment * Remove redundant code (for now) * Update comments * Comment * Restore way too daring simplification * cljfmt * Adjust capitalize * Update comment * Update test * Address remarks in tests * Update test * Address remarks * typo
-
Uladzimir Havenchyk authored
* fix: pass noop as navigateToNewCardFromDashboard from public or embedded dashboard * add e2e test * rework a fix
-
Romeo Van Snick authored
* Use Flex instead of Group for items in button * Allow column picker to stretch to match the height of the element * Fix height of data picker buttons * Make sure the whole button is clickable * Add e2e test for metabase/metabase#50038 * Use correct id for issue in e2e test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Nicolò Pretto authored
* attempt to fix 49537 by removing position relative from the tooltip container * Make echart tooltip container cover all iframe area * Update the E2E test * Update loki snapshots from CI * Re-enable echarts tooltip assertion. I couldn't find a better way to fail these assertions on the previous version of the code, but these assertions are better than nothing. --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 15, 2024
-
-
Nicolò Pretto authored
-
- Nov 14, 2024
-
-
Aleksandr Lesnenko authored
* fix hiding incorrect y-axis on hover * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix smartscalar texts to use user locale * Fix Pie chart texts to use user locale * Fix line chart tooltip texts to use user locale * Add trend chart assertions * Add pie chart assertions * Add line chart other series tooltip assertions * Update frontend/src/metabase/visualizations/echarts/pie/constants.ts Co-authored-by:
Nicolò Pretto <info@npretto.com> * Fix failed E2E tests --------- Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Oisin Coveney authored
-
- Nov 12, 2024
-
-
Phoomparin Mano authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props
-
Aleksandr Lesnenko authored
* update subscription checkboxes * update spec
-
Noah Moss authored
-
Romeo Van Snick authored
* Allow using the arrow buttons to change the limit value * Add a min prop to the number input * Use base-10 Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Ensure number is integer * Add issue name to unit test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
* Use ParameterValueWidget for default value picker in native parameter settings * Fix e2e test * Fix native filter tests * Fix e2e test * Fix e2e test * Add repro for #44665 * Assert that filter values are shown in the popover. Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Oisin Coveney authored
-
- Nov 09, 2024
-
-
Nemanja Glumac authored
* Remove dead code from browse models page * Use the grid to control the gap * Implement "Add database" button * Add basic unit tests * Make sure the feature works when there are no databases * Add analytics to the db list * Add "Add database" button to the sidebar * Add E2E Snowplow tests * Add unit tests * Deal with authentication in each beforeEeach separately * Add Snowplow E2E test for a database card * Slightly tweak the title line height
-
Chris Truter authored
Search currently returns a detailed list of the scores for each item, which is pretty hefty, and the type is also coupled to the current rankers, which will change in future. Removing from the type to start to just validate that nothing uses it. Best to just not model this. Going to see about just removing it from the BE as well, and put in some other way to debug. Worst case an opt-in query parameter.
-
- Nov 08, 2024
-
-
adam-james authored
* Keep Pivoted Option works in Subscriptions Fixes: #49525 Even though the user could toggle 'Keep data pivoted` in the Sharing Sidebar UI, the setting was not being propagated to the backend, so attachments would not be pivoted. * add a cypress test * add viz settings to get the pivot working * fix for linter * remove eslint ignore --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Romeo Van Snick authored
* Handle touch start capture as well as mouse down for popover * Also stop event propagation for touch events on menu item
-
Raphael Krut-Landau authored
Closes #49534
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Nemanja Glumac authored
* Move the upload CSV button to the main nav bar * Remove the old `SidebarOnboardingSection` * Remove obsolete unit tests * Rework E2E tests * Add some spacing around the button * Fix E2E test * Break `MainNavbar` unit test down * Expand unit tests * Update E2E tests * Fix E2E test failure * Move JSDoc where it belongs * Provide context for translators * Simplify the condition
-
Oisin Coveney authored
-
Kamil Mielnik authored
Fix - Values from the returned rows not present in the visualization are interpolable in the URL but don't have values (#49530) * Fix #46318 * Add repro for #46318 * Move setup to beforeEach
-
- Nov 06, 2024
-
-
Uladzimir Havenchyk authored
-