This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 16, 2024
-
-
github-automation-metabase authored
* notes on memory usage * typo * Update observability-with-prometheus.md * Update running.md * update link --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
* refactor: memoize getSteps selector * screen.getXXX.click() => userEvent.click(...) to avoid missing act() warning * use mockSettings so that MetabaseSettings.setAll is called and we avoid the unknown features warning Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Aug 15, 2024
-
-
github-automation-metabase authored
* Add Timeseries insights even when Custom Columns exist (#46253) * Add Timeseries insights even when Custom Columns exist WIP Fixes 46244 I don't know why it was (maybe still is) required that the :other columns be empty before providing insights. * might be a solution to changing trendlines when data doesn't change The insights code that powers the frontend trendline requires taking a sample of the dataset. This sampling has some randomness associated by design, and should maintain its randomness. But it makes some sense to use the exact same sample when the input has not changed at all, hence trying this memoize approach out. Might not be the final solution, but it's a start * add test to show that insights are computed * use java.util.random with a seed to keep insights stable * fix failing e2e test I don't understand why other runs on the release branch have been passing this? But in any case, I've copied this change from master to fix it. --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
github-automation-metabase authored
* skip some troubleshooting stats when hosted * fix typo * just skip "system-info" and "app db details" Co-authored-by:
bryan <bryan.maass@gmail.com>
-
John Swanson authored
* Allow disabling encryption for settings For two settings, we want to disable encryption entirely. On the way out of the data source, we don't need to worry - the decryption is already backwards-compatible with non-encrypted data. On the way in, things are a bit less straightforward. The core of the change is replacing the `t2/deftransform` that *always* runs `encryption/maybe-encrypt` on the value with: - a define-after-select that always tries to decrypt the value (so we can handle existing encrypted values in the db) - a define-before-insert that encrypts the value if the `defsetting` told us to, and - a define-before-update that does the same thing. For now, set two settings to be never-encrypted: `analytics-uuid` and `anon-tracking-enabled`.
-
github-automation-metabase authored
* Functional and typed * migrate Recipient Picker * removing dead code Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
github-automation-metabase authored
* Clean up serdes v2 exceptions (#46577) * Add missing field to exception * fix indentation * Inline helper that doesn't exist yet --------- Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Aug 14, 2024
-
-
github-automation-metabase authored
* Show loading state while fetching data in a new model page (#46694) * Show new model loading state while fetching * Show new model loading state while fetching * Add unit test * Use `DelayedLoadingSpinner` instead * Update the test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Prettier --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Fix the test --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Enable type info computation for fields coming from model source query * Add test * Add handling for fields coming from joins Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
github-automation-metabase authored
I didn't consider that we might not have permissions necessary to disable triggers. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
metabase-bot[bot] authored
Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
github-automation-metabase authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
-
github-automation-metabase authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
- Aug 13, 2024
-
-
github-automation-metabase authored
* Add v0.50.20 to the list of releases * Update releases.md --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
Repro #46756: Add/remove a single column in a model with tables joined by themselves adds/removes all columns (#46757) (#46764) Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
github-automation-metabase authored
fix(admin/performance): Ensure that the tab's title (e.g. Database caching) and 'Performance' are visible in document title (#46602) (#46685) Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* Export Formatting Correctness WIP Several bugs exist around the correctness of export formatting, this aims to fix them. Fixes #27374 When a model has viz settings/metadata changed after save, the download won't incorporate said changes. At least it's clear that scale doesn't work. * number formatter merges settings from columns too * column formatting on aggregated cols works in xlsx now too * fixes 43040 by grabbing global-type-settings in csv formatter Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
backported "fix(webapp/sidenav): Move Browse sidebar section in between Trash and other collections" (#46604) * fix(webapp/sidenav): Move Browse sidebar section in between Trash and other collections (#46457) * wip * restore mainnavbarview * fix(webapp/sidenav): Move Browse sidebar section below collections (#46457) --------- Co-authored-by:Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* new version of data_access migration + run ANALYZE beforehand * relax constraints on migration timestamps * more migration rewrites * fix bug in migration * fix another bug and remove extraneous logging * reorder migrations to fix ID validation * start adapting the changes to mysql as well * wip * add more ANALYZE calls * revert logging changes * finish duplicating work for mysql + a bit of clean up * create H2 versions of migrations without the ANALYZE calls * remove ANALYZE call from view_data.sql (probably not necessary) * fix mysql syntax * fix another mysql bug * another mysql fix * Don't exclude inactive tables for data_access * Don't write rows for Administrators group * Don't write rows for Admins (H2/MySQL) * disable triggers before perms migration --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Denis Berezin authored
* Manual backport 46160 * e2e tests fix
-
github-automation-metabase authored
Fixes: #46558 In #45575 we introduced casting uuid fields for drilldowns. However we failed to include a check that the rhs was itself another field of uuid type and so no casting should occur. This broke joins on models when the database_type of the field may not be known. Co-authored-by:
Case Nelson <case@metabase.com>
-
John Swanson authored
* Nicer error messages for linting migrations In general, just throw exceptions instead of using clojure spec here. You'll only get one error per run, but that seems fine. I did keep some specs around, but run them slightly differently. Rather than validating the whole collection of changeSets at once with `s/+`, just `doseq` through the changeSets and validate each one separately. That way, the value that's presented as erroneous is much smaller (a single changeSet) and it's easier to see what went wrong. * Update bin/lint-migrations-file/test/lint_migrations_file_test.clj * Update bin/lint-migrations-file/src/lint_migrations_file.clj * Require preConditions for certain liquibase change types to encourage idempotence (#44578) * remove `!`s from non-side-effecty fns * add preConditions to a few v51 migrations --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
* Refactor filter utils to TS * Remove type casts * Improve dimension instantiation * Fix typing Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Aug 12, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Nemanja Glumac authored
* Fix relative date options popover * Add repro for #46342 * Revert "Fix relative date options popover" This reverts commit ceaf62d9. * Use the Mantine Popover z-index
-
github-automation-metabase authored
* conditional dismissal step * check for download status in the container * try fixing flakes again * try again * chartPathWithFillColor already verifies chart has been rendered Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
* Dowload Row Limit Env Var Adds `MB_DOWNLOAD_ROW_LIMIT` to enable changing the row limit on downloads and alert/subscription attachments (not the rendered tables, but the .csv, etc.). Based on: #44982 (Thanks, @r-kot) Partially implements: #28144 The difference in this PR compared to #44982 is that the download limit applies to all downloads, the only exception being when the limit is above `qp.i/absolute-max-results` (1048575, based on Excel's limitation); in such a case, the user supplied limit is only used if the download is csv or json, and `qp.i/absolute-max-results` is used for xlsx. This PR also fixes alert/subscription attachment limits; prior to this, they were set to the in-app limit of 2000 rows, but now they will follow the user supplied download-row-limit. This PR also adds a test to the downloads-and-exports test namespace, confirming that they follow the supplied limit, or the max limit if none is supplied. * add test confirming the default limit works * fix test to use the download-row-limit * address review feedback * Update src/metabase/public_settings.clj * add test covering case where download-row-limit is unset --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
github-automation-metabase authored
* Revert "Remove unused humanizeCoercionStrategy and its test suite (#36136)" This reverts commit 5375347e. * humanize coercion strategies, add e2e test * unit test adjustment * pr feedback Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Alexander Solovyov authored
Also OpenAPI generation now handles parameter renaming, like in `{c :count}` destructuring.
-
github-automation-metabase authored
* Fix oom during sync field values (#46524) Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-