This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 28, 2023
-
-
Denis Berezin authored
-
- Feb 06, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Jan 10, 2023
-
-
Anton Kulyk authored
* Install and enable plugins * Run eslint auto fix * Fix linter issues (part 1) * Fix Visualization test * Fix Pie Visualization test * Add `getIcon` and `queryIcon` helpers * Fix `VisibilityToggler` tests * Fix `QuestionActivityTimeline` tests * Fix formatting tests * Fix `EntityMenuItem` tests * Fix `ClampedText` tests * Fix `ObjectRelationships` tests * Fix `EmailAttachmentPicker` tests * Fix `SavedQuestionHeaderButton` tests * Fix `DatabaseEngineWarning` tests * Fix `Tooltip` tests * Fix `TippyPopoverWithTrigger` tests * Fix `TippyPopover` tests * Fix `TableLabel` tests * Fix `TableInfo` tests * Fix `ModerationStatusIcon` tests * Fix `Sidebar` tests * Fix `PermissionSelect` tests * Fix `PinnedItemCard` tests * Fix widget tests * Fix `DimensionSemanticTypeLabel` tests * Fix `ListSearchField` tests * Fix `ControlledPopoverWithTrigger` tests * Fix `FieldFingerprintInfo` tests * Fix `ErrorActionButton` tests * Fix `QueryValidationError` tests * Fix `LineAreaBarRenderer` tests * Fix `DataSelector` tests * Fix `PivotTable` tests * Fix `ItemPicker` tests * Fix `TokenField` tests * Fix `TagEditorParam` tests * Fix tests * Fix tests * Run prettier * Fix tests
-
- Jan 09, 2023
-
-
Anton Kulyk authored
* Install `eslint-plugin-jest` * Enable `eslint-plugin-jest` * Run eslint auto fix * Fix linter issues * Fix get-column-key * Fix extra space * Fix ChartSettingFieldPicker * Fix eslint issues * Remove redundant describe
-
- Oct 03, 2022
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Sep 12, 2022
-
-
Ryan Laurie authored
* enforce import order * reorder all imports * more import updates
-
- May 19, 2022
-
-
Dalton authored
-
- Dec 13, 2021
-
-
Dalton authored
-
- Dec 07, 2021
-
-
Alexander Polyankin authored
-
- Nov 02, 2021
-
-
Dalton authored
* move querystring-syncing logic to new hook * rename <Parameters> to <SyncedParametersList> * Remove syncQueryString prop * remove unused 'query' prop * remove 'isQB' prop * remove ParametersWidget in favor of ParametersList handling empty parameters list * Rely on value-populated parameters objects over parameterValues map * remove unused pass-through prop 'vertical' * make props passed from Dashboard to SyncedParametersList explicit * Update name of component * create a more generic hook for syncing the url query string
-
Anton Kulyk authored
* Fix typo * Don't warn about unused variables prefixed with _ * Fix unused var warning for Icon component * Add `varsIgnorePattern` for JS files too
-
- Oct 07, 2021
-
-
Alexander Lesnenko authored
* add basic typescript configuration * convert a tiny hook use-debounced-value to typescript * allow any for now? * update terser and static viz configs * adjust config * change extension of QuestionActivityTimeline from jsx to js to match jest config * adjust config * skip failing tests * Fix missing question method in unit tests (#18314) * review fix * fix Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- Aug 30, 2021
-
-
Ariya Hidayat authored
-
- Jul 30, 2021
-
-
Dalton authored
* Update babel dependencies to latest * Remove some old babel dependencies The dependencies in this commit include dependencies that have been renamed, such as babel-cli which is now @babel/cli. It also includes dependencies that have been replaced, such as babel-preset-stage-0 and its ilk, which have been replaced with @babel/preset-env. * Remove babel-register dependency This is referenced in our webpack.config.js file. I don't think we need Babel in our Node envionment, but I could be wrong, so leaving this as a separate commit. * Remove @babel/standalone and dependent code We're using @babel/standalone to support the writing of JSX in our internal-only ScratchApp editor. Unfortunately, this dependency is large--1.5mb not gzipped--and our current build does not intelligently split bundles, meaning our users our burdened by the size of this dependency whenever they must redownload the Metabase JS bundle. I'm removing it. We should still be able to write JS in the ScratchApp, but JSX no longer. * Add @babel/node to dev deps Needed by a cypress command * Add browserslist config Babel's preset-env dep needs this config to determine how to transform our JavaScript. By default I believe it ends up defaulting to "defaults." "defaults" is equivalent to the following rules: > 0.5%, last 2 versions, Firefox ESR, not dead A comma between rules represents a UNION operator. Per https://www.metabase.com/docs/latest/faq/general/supported-browsers.html we have deprecated IE 11 so I am including that explicitly in our browserslist. * Update babelrc plugins and presets - Replaced presets with preset-env and preset-react - Updated the names of some plugins, like transform-decorators-legacy, which is now @babel/plugin-proposal-decorators with an explicit "legacy: true" passed in the config. - Removed add-react-displayname because it is included in preset-react - Removed transform-builtin-extend because it is included in preset-env* - Removed syntax-trailing-function-commas because it is supported by all browsers we support * note: There is a "loose" config option for handling the extension of builtin classes. We may need it, but I am not sure. * Update babel cli args Replace -q with --quiet because -q no longer exists * Fix circular dep in auth.js by making it async Our app unfortunately contains MANY circular dependencies. Some, like this one, caused problems when the app instantiates because the "refreshCurrentUser" method is undefined when auth.js is initially run. While we should in the future avoid having circular deps in the first place, making them run async by requiring the dep and function run-time fixes this particular issue. * Fix circular dependency in metabase/redux/requests.js The handleActions and createAction methods imported from "metabase/lib/redux" are actually just methods from the "redux-actions" dependency... so importing those methods directly from that dep fixes this circular dependency problem. * Remove references to global.services and exports in metabase/services This line breaks the build. Git blame says the line is 5 years old, and I wouldn't expect such code to be used with how our app now requires deps. * Fix MBQLArrayClause problem caused by Array extension * Explicitly pass args from flatMap to function via anonymous cb I think the old Array.prototype.flatMap prototype must've had different args. They are now "currentValue, index, array" so when we passed it "enumeratePaths" as a callback, the second arg of enumeratePaths gets set to a number. This breaks the logic of enumeratePaths because it is a recursive function that depends on that second arg getting initialized as an empty array by default. * Remove code that spreads non-iterable value in array New Babel is stricter about handling this sort of code that doesn't match the JS spec. You can't spread an undefined value inside of an iterator. * Update jest and babel-jest to latest Updating Babel breaks our unit tests. Updating nothing causes every test to fail due to a Babel version mismatch. Updating only babel-jest causes the following error: TypeError: Jest: a transform must export a `process` function There may be a way around updating Jest, but updating it does not appear to be too difficult. * Set the testEnvironment to jsdom This was the default testEnvironment in our old version of jest. At some point the default was changed to node. * Remove unfinished "pending" unit tests I'm unfamiliar with this pending function, but the function no longer exists, causing the tests to fail. * don't pass async callback to describe * Update name of runTimersToTime to advanceTimersByTime * Fix incorrectly nested unit test * mock SVGElement.prototype.getBBox method * Don't return values in describe callback * Move variable declaration to above usage * Fix prettier error * Upgrade `documentation` library to the latest version (13.x.x) This library was the only one left that was still using Babel 6. * Return an MBQLClause instance after using Array methods * remove 'not IE 11' from browserslist * Remove mock that breaks unit test Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- May 05, 2021
-
-
Nemanja Glumac authored
* Handle errors in `ColorSchemeWidget.jsx` * Handle errors in `audit_app/routes.jsx` * Fix missing key prop warnings * Turn on `react/jsx-key` lint rule Co-authored-by:
alxnddr <alxnddr@gmail.com>
-
- Apr 30, 2021
-
-
Ariya Hidayat authored
As we progress better with refactoring and simplification, the complexity threshold should be reduced as well.
-
- Apr 26, 2021
-
-
Nemanja Glumac authored
* Fix `eslint-react/no-string-refs` errors (#15427) * Handle errors in `AdminLayout.jsx` * Rmove unused ref from `MetadataEditorApp.jsx` * Remove unused ref from `EditBar.jsx` * Handle errors in `Confirm.jsx` * Handle errors in `Header.jsx` * Handle errors in `NewsletterForm.jsx` * Handle errors in `ColorPicker.jsx` * Remove unused ref from `PasswordReveal.jsx` * Handle errors in `Triggerable.jsx` * Handle errors in `TokenField.jsx` * Handle errors in `DashboardHeader.jsx` * Handle errors in `RefreshWidget.jsx` * Handle errors in `DatabaseEditApp.jsx` * Handle errors in `FieldRemapping.jsx` * Handle errors in `ObjectActionsSelect.jsx` * Handle errors in `ObjectRetireModal.jsx` * Remove unused ref from `UserGroupSelect.jsx` * Handle errors in `PermissionsGrid.jsx` * Handle errors in `ParameterTargetWidget.jsx` * Handle errors in `ParameterValueWidget.jsx` * Handle errors in `PulseEdit.jsx` * Handle errors in `PulseEditName.jsx` * Handle errors in `DataSelector.jsx` * Remove unused ref from `FieldWidget.jsx` * Handle errors in `NativeQueryEditor.jsx` * Handle errors in `SearchBar.jsx` * Handle errors in `ExpressionEditorTextfield.jsx` * Remove unused ref from `FieldWidget.jsx` * Remove unused ref from `SpecificDatePicker.jsx` * Handle errors in `RevisionMessageModal.jsx` * Handle errors in `Setup.jsx` * Handle errors in `LeafletMap.jsx` * Handle errors in `TableSimple.jsx` * Handle errors in `PieChart.jsx` * Handle errors in `Progress.jsx` * Remove unused refs from `QueryBuilder.jsx` * Remove unused ref and methods from `MetadataHeader.jsx` * Remove unused ref from `DashboardActions.jsx` * Handle errors in `DatabaseListApp.jsx` Note: dynamic refs * Handle errors in `LegendHorizontal.jsx` Note: dynamic refs * Disable linting rule `react/no-string-refs` in `LegendVertical.jsx` Note: dynamic refs * Partially handle errors in `GuiQueryEditor.jsx` * Disable linting rule `react/no-string-refs` in `GuiQueryEditor.jsx` Note: dynamic refs * Revert "Remove unused ref from `DashboardActions.jsx`" This reverts commit 5facb9d60ecb561093af15efcfc99b29ff96980e. * Handle errors in `DashboardActions.jsx` * Remove redundant `ReactDOM.findDOMNode` from `Setup.jsx` * Revert "Handle errors in `DashboardActions.jsx`" This reverts commit b3d64b8f7a982e0371d225d0d624ecbeaf776b76. * Disable linting for `DashboardActions.jsx` * Fix prettier error * Delete non-existing prop `getTarget` * Fix typo * Fix typos in more places * Fix `footerRef` check * Turn on `react/no-string-refs` lint rule * Disable `react/prop-types` in files that are breaking the build * Fix broken refs Co-authored-by:
alxnddr <alxnddr@gmail.com>
-
- Apr 19, 2021
-
-
Nemanja Glumac authored
* Fix `react/no-children-prop` error (#15122) * Turn on `react/no-children-prop` lint rule
-
- Apr 09, 2021
-
-
Nemanja Glumac authored
* Fix `react/no-unescaped-entities` error * Handle untransalted string * Turn on `react/no-unescaped-entities` lint rule
-
- Apr 08, 2021
-
-
Nemanja Glumac authored
* Fix `react/jsx-no-target-blank` error (#15110) * Fix `react/jsx-no-target-blank` error * Handle untranslated string * Add `dataMetabaseEvent` prop to `ExternalLink` * Update missed `ExternalLink` component in `frontend/src/metabase/query_builder/components/template_tags/TagEditorHelp.jsx` with `dataMetabaseEvent` * Turn on `react/jsx-no-target-blank` lint rule
-
Nemanja Glumac authored
* Upgrade `eslint-plugin-react` * Disable `react/prop-types` warning in stray files * Register breaking rules and turn off warnings * Fix wrong `eslint-disable` comment * Fix `react/display-name` error in `NotebookCell.jsx`
-
- Apr 02, 2021
-
-
Nemanja Glumac authored
* Switch the rule to "error" * Disable linting for `prop-types` in unit tests * Disable linting for `prop-types` in all affected files
-
- Mar 24, 2021
-
-
Dalton authored
* add new linting package * add rule to eslint config * remove it.only * fix race condition err in test
-
- Mar 04, 2021
-
-
Ariya Hidayat authored
* yarn remove flow-bin eslint-plugin-flowtype * CI: remove fe-linter-flow * Remove Flow from ESLint config * Remove Flow type annotations and directives * Simplify Flow types for React elements and components * Import missing Flow types * Remove lint-flow from package.json
-
- Mar 02, 2021
-
-
Dalton authored
the plugin raises an error on anything that looks like a hook (a function that starts with "use") so am disabling eslint for two false positives
-
- Oct 23, 2020
-
-
Cam Saul authored
-
- Jul 20, 2020
-
-
Robert Roland authored
* Update eslint Updates eslint, babel and plugins to the latest compatible versions Drops the 'no-color-literals' parameter which doesn't exist (looks like it's actually part of eslint-plugin-react-native which we don't use) adding a dirlocal to make sure js2-mode doesn't confuse you with type errors that aren't actually errors because of flowtype and such * update generated css classes in snapshots Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com>
-
- Dec 05, 2019
-
-
Paul Rosenzweig authored
-
- Sep 13, 2019
-
-
Tom Robinson authored
-
- Jun 10, 2019
-
-
Paul Rosenzweig authored
-
- Jul 06, 2018
-
-
Tom Robinson authored
-
- Jul 03, 2018
-
-
Tom Robinson authored
-
Tom Robinson authored
-
- Jul 02, 2018
-
-
Tom Robinson authored
-
- Jun 20, 2018
-
-
Tom Robinson authored
-
- Apr 25, 2018
-
-
Tom Robinson authored
-
- Feb 16, 2018
-
-
Tom Robinson authored
-
- Nov 14, 2017
-
-
Atte Keinänen authored
This commit has the UI for users to add alerts to a question. Admins are able to setup alerts for questions and modify alerts that users have setup.
-
- Aug 21, 2017
-
-
Tom Robinson authored
-
- Jul 13, 2017
-
-
Atte Keinänen authored
-