* remove defaultProps from Modal

* bump patch version of react-markdown

* fix isOpen prop

Co-authored-by: Phoomparin Mano <poom@metabase.com>

* Use type date for case expression when there are Date and DateTime args

* Use logic for getting case expr type from annotate middleware

* Add e2e test

* Add bigquery test

* Update test

* cljfmt and comment

* Adjust e2e test

Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>

Co-authored-by: Alexander Solovyov <alexander@solovyov.net>

* Adds query_executions_by_source_24h and entity_id_translations_last_24h

- add docstring

* clear eid translation count in stats-post-cleanup

* remove ->> with after? it's confusing

* dissoc the right path

Co-authored-by: bryan <bryan.maass@gmail.com>

== Behaviour without this fix ==

See #48881

== Behaviour with this fix ==

1. Metabase starts with an empty application database, and a config file
   containing configuration for a connected database
3. By the time it reaches "INFO metabase.task :: Task scheduler started",
   `qrtz_triggers` contains `metabase.task.sync-and-analyze.trigger.1`
   (sample DB) and `metabase.task.sync-and-analyze.trigger.2` (DB from
   config file)

Closes: https://github.com/metabase/metabase/issues/48881



Co-authored-by: Dennis Schridde <63082+devurandom@users.noreply.github.com>
Co-authored-by: Noah Moss <noah@metabase.com>

* defineEmbeddingSdkConfig to make typing easier when the config is created outside of the jsx

* also add defineEmbeddingSdkTheme, move them to index.ts as i don't have a good name for what file to put them into :shrugs:

* updated the readme to use the defineXXX functions

Co-authored-by: Nicolò Pretto <info@npretto.com>

Co-authored-by: appleby <86076+appleby@users.noreply.github.com>

* rework ChartSettings to typescript

* lint

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>

* hide formatted export description when unformatted

* add unformatted copy

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

Store API can handle higher load and customers might want to see
changes earlier.

Fixes: cc28ee60

Co-authored-by: Dennis Schridde <63082+devurandom@users.noreply.github.com>

* cleaning up links, adjusting tests

* guard rails

* linter fix

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* hide downloads by default in the sdk

* update readme to reflect withDownloads prop

* update readme formatting

* update tests

Co-authored-by: Phoomparin Mano <poom@metabase.com>

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>

* Fix expression stage

* Add test

* Parallel test

* Adjust test

* Adjust test

Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>

* adding webhook counter to AlertListItem

* PR feedback

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* fix: Always cast json number types as decimal

Fixes #48507

* Fix tests

* Fix tests

* Fix test

Co-authored-by: Case Nelson <case@metabase.com>

* Use metric's aggregation :name

* Add test

Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: bryan <bryan.maass@gmail.com>

* Add new promethues counter for :metabase-metrics/adjust-errors

To record errors in metabase.query-processor.middleware.metrics/adjust

* Add prometheus metrics test to metrics middleware tests

* Also inc :metabase-metrics/adjust-errors when throwing an exception

* Make splice-compatible-metrics private

It doesn't seem to be used outside of metabase.query-processor.middleware.metrics.

* Add test for :metabase-metrics/adjust-errors when exception is thrown

* Move inc-and-throw! helper into metabase.analytics.prometheus

* Add inc-and-throw! test to prometheus tests

* Rename inc-test to inc!-test and use approx= and metric-value helpers

* Add try/catch to metrics adjust and record metric errors in a single place

Record promethues metrics in a single place in metabase.query-processor.middleware.metrics and ensure we record
failures for any exception throw.

* Improve testing description string

* Rename :metabase-metrics/adjust-errors to :metabase-query-processor/metrics-errors

* Move metrics adjustment try/catch into a new helper

This ensures we count all exceptions generated by adjust-metric-stages.

* Add new prometheus metric to count number of MB metrics seen by the QP

This new metric is intended to count the number of metrics that the query processor metrics middleware sees and
attempts to adjust.

* Add more metrics metrics tests

- Ensure that queries with no metrics do not incremement either counter
- Ensure that successful calls to adjust do not increment the error counter
- Ensure that exceptions throw from other libs also increment the error counter

* Rename test to adjust-prometheus-metrics-test and add helper to reduce code dup

* If no metrics are found immediately return query in metrics middleware adjust

Don't attempt to adjust query if we don't find any :metric clauses.

* Appease cljfmt

* Improve metric description



* Improve epsilon test in approx=



* Remove adjust-metric-stages-counting-errors

This function was an attempt to avoid double-counting errors, but probably not worth the effort.

See

https://github.com/metabase/metabase/pull/48598#discussion_r1800197964
https://github.com/metabase/metabase/pull/48598#discussion_r1800200421

* Count metrics directly when mocking prometheus/inc!

Based on PR feedback here:

https://github.com/metabase/metabase/pull/48598#discussion_r1800207674

* Remove prometheus/inc-and-throw!

Value prop was always questionable, but now that it's only called from a single place, just remove it and inline the
call to prometheus/inc!. Easy to add back later if it proves generally useful.

PR discussion thread

https://github.com/metabase/metabase/pull/48598#discussion_r1799728596

* Rename match-one-metric to find-first-metric

https://github.com/metabase/metabase/pull/48598#discussion_r1803321025

* Rename :metabase-query-processor/metrics-errors to metric-errors

https://github.com/metabase/metabase/pull/48598#discussion_r1803313818

* Throw an exception rather than logging a warning if we fail to adjust a metric

https://github.com/metabase/metabase/pull/48598#discussion_r1803328482



---------

Co-authored-by: appleby <86076+appleby@users.noreply.github.com>
Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

Fixes #48639

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

* Don't open sidesheet on SDK dashboards

* Add E2E test

* Fix `className` not passed

* Fix unit tests

* Fix E2E tests

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>

* make sure all top-level API paths are present in OpenAPI doc (#48718)

* fix /notify

---------

Co-authored-by: Alexander Solovyov <alexander@solovyov.net>

* Let non-admins see tables in recents

```shell
❯ http get "localhost:3000/api/activity/recents?context=views" Cookie:"metabase.SESSION=ba..3d" -pb
{
    "recents": [
        {
            "can_write": false,
            "database": {
                "id": 6,
                "initial_sync_status": "complete",
                "name": "pg restaurants"
            },
            "description": null,
            "display_name": "Restaurants",
            "id": 112,
            "model": "table",
            "name": "restaurants",
            "table_schema": "public",
            "timestamp": "2024-10-15T22:11:39.412100Z"
        },
        {
            "can_write": false,
            "database": {
                "id": 6,
                "initial_sync_status": "complete",
                "name": "pg restaurants"
            },
            "description": null,
            "display_name": "Reviews",
            "id": 110,
            "model": "table",
            "name": "reviews",
            "table_schema": "public",
            "timestamp": "2024-10-15T19:53:19.999445Z"
        }
    ]
}
```

We were getting permissions of a "fake" table. Instead, let the db
select it and get the proper stuff. Worked for admins because
mi/can-read? is presumably always true for tables, and worked in tests
because we mocked mi/can-read?

* bump ci

Co-authored-by: dpsutton <dan@dpsutton.com>

* fix iframe dashcards crash subscriptions

* add a test to ensure iframes are filtered out of subscriptions

---------

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Co-authored-by: Adam James <adam.vermeer2@gmail.com>
Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

* Don't assert dynamic value

* Restart CI

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>

 backported "Remove "Replace or save question" UI when saving and edited question from a metric" (#48732)

* Remove "Replace or save question" UI when saving and edited question from a metric (#48669)

* Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question

* Allow visitQuestion to work for metrics

* Use visitQuestion in metric test

* Add test for #48555 (showing the 'Save as new?' ui for metrics)

* Add issue info to repro

* Use visitMetric, visitModel and visitQuestion helpers in createQuestion

* Move check to make it more clear what the save ui does

* Use cy.button for Done button

* Remove unnecessary .within

* Sign in as normal user

* Add missing dataset alias

* Fix x-ray test

---------

Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>

* Create metric button and docs link in empty state (#48468)

* Add 'Create metric' button to empty metrics page

* Add e2e test for 'Create metric' button

* Remove duplicate main on Browse page

* Add docs link

* Split off common test for BrowseMetrics

* Add whitespace

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Use cy.button

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Hide Create metric button when the user does not have data access

* Use findByText for link

* Add test for hiding the 'Create metric' button when the user does not have data access

* Fix unit tests

* Improve copy

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Add whitespace

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Add explanatory comment for enterprise

---------

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Update failing loki test

---------

Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>