This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 12, 2021
-
-
Robert Roland authored
It's possible for the scheduler to get in a weird state if the sync fails while it executes. This change makes it *only* recreate a job/task if the schedule has changed or if it is missing. Previously, clearing the state at every start had bad effects if the JVM had terminated during the sync. Adds a vector of Exception classes that signal a "fatal" exception during sync for a specific database. If these exceptions occur, the sync for that database stops and will pick up next time. This will have to be expanded per driver, but I don't see a way around that, as each driver will have its own, unique way of failing. metabase/metabase#14817
-
- Mar 10, 2021
-
-
Nemanja Glumac authored
* Move user groups above users * Use `email` in a user object instead of `username` * Add `createUser` function - Get rid of `makeUserObject` and store users' group membership directly within the user object * Improve `createUser` function * Add sandboxed user to the main `USERS` object * Use newly constructed `sandboxed` user in tests * Export `signInAsSandboxedUser()` * Fix function name Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com> * Fix linter errors * Simplify `createUser()` function * Use user attributes directly in tests * Fix broken tests * Destructure users in tests * Use double quotes * Extract Cypress user data (#15103) * Extract user data in a separate file * Convert `createUser` function to a Cypress custom command * Convert `signIn` function to a Cypress custom command * Convert `signInAsAdmin` function to a Cypress custom command * Convert `signInAsNormalUser` function to a Cypress custom command * Convert `signInAsSandboxedUser` function to a Cypress custom command * Convert `signOut` function to a Cypress custom command * Guard against user groups data falling out of sync Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
-
dpsutton authored
* Fix click through behavior (#15014) * formatting * Safer get's, author metadata and correct added * Don't return anything if we didn't modify it * Make private and add a docstring * Generate json strings rather than long in-line versions * Docstrings and prevent migrating ones that may already be migrated * Noisier as it now merges click_behavior on top of existing * update docstring with new nesting * always keep column settings previously the script was only looking for column settings which included view_as or link_template. Now we always keep those columns and merge in the new click_behavior when those keys are present * linkTemplateText -> linkTextTemplate * Ensure dashcard goes on top of card viz settings * Update expected now that dash merges on top of card * drop columns that don't have view_as so we don't overwrite the top level stuff if there is already a click_behavior. That signifies that either this migration has run, or perhaps already has had manual intervention. An open question is if we extend this to the columns: if there's manual intervention do we really want to be mucking about in here? Also, go back to the dropping columns style. ```clojure (if (and ...) (assoc m col (merge field-settings click-behavior)) m) ;; here we omit the column again in our reduce-kv ``` * Fundamentally: scour card for click and merge them into dashcard reshape all click behaviors in both and merge them in. Still some broken tests at the moment * Remove old style click behavior no longer expected * fixed * Some more comments and remove some silly select keys and when-lets just compute both keys and then u/select-non-nil-keys and be done with it * Docstrinc additions about nil * Remove niles, test scenario #5 from flamber * Handle empties and nil _AFTER_ merging previously had taken care to punt things down to nil, collapse empty maps, etc. but this is a value that will merge on top of a map rather than with the map ```clojure (m/deep-merge {:a {:b :c}} {:a nil}) {:a nil} ;; vs (m/deep-merge {:a {:b :c}} {:a {}}) {:a {:b :c}} ``` so let the postwalk after the merge clean up empty collections and nil values and let them blend as normal * Deep merge and prioritize new shape in card and dashcard ```clojure (m/deep-merge fixed-card fixed-dashcard (existing-fixed card) (existing-fixed dashcard)) ``` This is the change here essentially. Fix the card and dashcard, look for existing new shapes on the card and dashcard as well * Don't merge existing fix from card. can't happen this change though did help out. we want to resolve when there are old style and new style on the same dashcard. In this case, the new style should persist: ```clojure (testing "If there is migration eligible on dash but also new style on dash, new style wins" (let [dash {"column_settings" {"[\"ref\",[\"field-id\",4]]" {"view_as" "link" "link_template" "http://old" ;; this stuff could be migrated "link_text" "old" "column_title" "column title" "click_behavior" {"type" "link", "linkType" "url", ;; but there is already a new style and it wins "linkTemplate" "http://new", "linkTextTemplate" "new"}}}}] (is (= {"column_settings" {"[\"ref\",[\"field-id\",4]]" {"click_behavior" {"type" "link", "linkType" "url", "linkTemplate" "http://new", "linkTextTemplate" "new"}, "column_title" "column title"}}} (migrate nil dash))))) ``` note the column settings for field-id 4 have the old style and the new style but the result is that the new style survives. This happens from the `(m/deep-merge fixed-card fixed-dashcard (existing-fixed dashcard))` as the existing is put on top * Don't strip original values * propagate old info in migration test
-
- Mar 08, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Raimon Grau authored
* To be able to run a devcontainer its own network (not just --net host), webpack-dev-server serves on 0.0.0.0. * Fix expired signature (EXPKEYSIG): https://github.com/yarnpkg/yarn/issues/786
-
- Mar 05, 2021
-
-
Cam Saul authored
* Test fix
* Fix whitespace error -
Luis Paolini authored
* Update the guide for deploying Metabase in ElasticBeanstalk * parent bb5f28dee441ca09e610a6918890920592d215a2 author Luis Paolini <paoliniluis@gmail.com> 1610502973 -0300 committer Luis Paolini <paoliniluis@gmail.com> 1614898920 -0300 * Please work CircleCI
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
* Update endpoint documentation * Adding the API key documentation at the endpoint level * Add all API changes
-
- Mar 03, 2021
-
-
Howon Lee authored
If someone puts in a tix for the opposite semantics then we sigh and then actually put in an option
-
Nemanja Glumac authored
* Add Cypress custom command `cy.sandboxTable` * Apply `cy.sandboxTable()` to all related tests * Tuck permissions updating within sandboxing custom command This abstracts away one layer of sandboxing that is necessary, but at the same time made tests harder to read. * Account for the possibility of passing multiple user attributes Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
-
Cam Saul authored
* Date range filters should respect the start-of-week Setting (#14294) * Test fix
* Test fixes * Add test for #13604 * Test fix * Improved BigQuery data loading * Fix BigQuery bucketing by day-of-week * Fix Oracle bucketing by :day-of-week * Add error type * Presto ?? * Test fix * Fix a few things -
Nemanja Glumac authored
-
Raimon Grau authored
-
- Mar 02, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Cam Saul authored
* Fix BigQuery not returning errors right away (#14918) * Remove diacriticals and other invalid chars from BigQuery field alias identifiers * Test fix
-
Nemanja Glumac authored
-
Cam Saul authored
* Fix pivot table queries w/o data permissions * Text fix
* Refactor * Ns sorting -
Nemanja Glumac authored
-
Paul Rosenzweig authored
-
- Mar 01, 2021
-
-
Howon Lee authored
* obey those number separator settings * make it lint
-
Nemanja Glumac authored
-
Cam Saul authored
* Fix nested queries with joins and expressions (#14969) * Re-enable cypress tests * Test fix
* Test fixes * Fix Cypress test * Remove check for "Grand totals" from Cypress test * Test fixes Co-authored-by:Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Cam Saul authored
-
Nemanja Glumac authored
* Add custom Cypress log function Shoutout to @filiphric for the original idea and inspiration. * Update all occurrences of `cy.log` * Remove `.only` from a test left by mistake * Reset log counter for each test
-
- Feb 27, 2021
-
-
Cam Saul authored
There was a bug where we were reusing source query metadata with multiple levels of nesting which was actually incorrect with breakouts/aggregations were used in the nested levels. Simple fix, should eliminate a whole class of bugs around nesting multiple levels deep
-
- Feb 26, 2021
-
-
Robert Roland authored
This will make the JVM output more details as it crashes for running out of memory. New output: ```text rroland@tardis:~/src/metabase/target/uberjar$ java -Xmx50m -XX:+CrashOnOutOfMemoryError -jar metabase.jar WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance. 2021-02-25 11:38:31,689 INFO metabase.util :: Maximum memory available to JVM: 50.0 MB Aborting due to java.lang.OutOfMemoryError: Java heap space \# \# A fatal error has been detected by the Java Runtime Environment: \# \# Internal Error (debug.cpp:338), pid=40255, tid=40256 \# fatal error: OutOfMemory encountered: Java heap space \# \# JRE version: OpenJDK Runtime Environment (11.0.10+9) (build 11.0.10+9-post-Debian-1) \# Java VM: OpenJDK 64-Bit Server VM (11.0.10+9-post-Debian-1, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64) \# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again \# \# An error report file with more information is saved as: \# /home/rroland/src/metabase/target/uberjar/hs_err_pid40255.log \# \# If you would like to submit a bug report, please visit: \# https://bugs.debian.org/openjdk-11 \# Aborted ``` Previous output: ```text rroland@tardis:~/src/metabase/target/uberjar$ java -Xmx50m -XX:+ExitOnOutOfMemoryError -jar metabase.jar WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance. 2021-02-25 11:38:46,898 INFO metabase.util :: Maximum memory available to JVM: 50.0 MB Terminating due to java.lang.OutOfMemoryError: Java heap space ```
-
Jeff Evans authored
* Change string-operations-from-subquery to use test-data instead of sample-data, because the latter currently is incompatible with Redshift (see #14784) * Add MSSQL_MEMORY_LIMIT_MB: 1024 to CircleCI config (cherry pick of https://github.com/metabase/metabase/commit/4a714f3e21fb06fdb73b11fa7812f417b38a069e)
-
Nemanja Glumac authored
-
Jeff Evans authored
* Fix regex-match-first operator for Postgres to work properly when run against subqueries Capture col-name at beginning of fn for :regex-match-first operator in Postgres driver to work around laziness problem (see PR #14858) Adding test * Unskip Cypress test for #14873
-
Nemanja Glumac authored
* Add `updatePermissionsGraph` custom command * Add `updatePermissionsSchema` custom command * Add `updateCollectionGraph` custom command * Update `updatePermissionsSchemas` command This accounts for a different case sensitivity that different DBs have.
-
- Feb 25, 2021
-
-
Howon Lee authored
* add cypress test * actions now parse int Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com>
-
Nemanja Glumac authored
#14515 Repro: Slack-based dashboard subscriptions should have a "Send to Slack now" button (#14968) [ci skip] * Extract common repro steps in `beforeEach` * Add repro for #14515
-
Nemanja Glumac authored
#13455 Repro: Order of rearranged columns not preserved after column removal via sidebar [ci skip] (#14967)
-