This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 15, 2023
-
-
Ryan Laurie authored
* add special flaky group * tag tests with flakes over 10% * mark more flaky jobs
-
Maxime Pauvert authored
-
Nemanja Glumac authored
This reverts commit 44de976d.
-
Ngoc Khuat authored
-
- Nov 14, 2023
-
-
Aleksandr Lesnenko authored
* Hide edit question menu item on dashboards when there is no collection write permission * Add :can_write to dashboard->dashcards->cards This hydrates each card in a dashboard's dashcards with :can_write. * Check in a dashboard test that :can_write shows up on cards. Just adding a key to one of these tests to let us know that it's being hydrated. --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
Ibe Dwi authored
* fix: duplicated loadingIds on pending action * chore: rename unit test name
-
Anthony Hivert authored
-
Case Nelson authored
Fixes #35719
-
Mark Bastian authored
* Adding linter and formatter to staged BE files. Note that `.cljfmt/indents.clj` tries to capture our indent rules and, so far, seems to get things right. There are still some inconsistencies in some of our nses in how we indent assoc(-in) and some t2 functions when it comes to key-value pairs on following lines. Should the keys align with the function call or be indented. Aesthetically, people seem to like indents, but these are functions, so should align with the first argument. IDK that it really matters as long as we have agreement. We may, as we adopt this, have some files be reformatted in unexpected ways for items that have been missed. If so, the developer can simply update the .cljfmt/indents.clj file, rerun the hook, and commit that along with their other changes. * Added whitespace linter. * Updating husky commit hook * Updated hook scripts to be exclusively for staged files. Updated cljfmt to use the latest and greatest along with the new format of config file. * Commenting out the actual formatting hook in .husky/pre-commit until we come up with a globally happy solution to forms that don't have good formatting rules, like defprotocol+ in a reader conditional. * Reverting formatting * Moving pre-commit hooks from .husky/pre-commit to the package.json's lint-staged section. Note that we're still not calling the cljfmt file (.bin/cljfmt_staged.sh) until we get agreement on formatting. One thing we might do since we're using lint-staged is we can probably exclude the "bad" files that go sideways with linting and format everything else automatically. This might be a good follow-on PR.
-
Steve Xu authored
-
Jeff Bruemmer authored
-
Cam Saul authored
-
Luis Paolini authored
Add Noto fonts in Alpine Dockerfile
-
Cam Saul authored
-
Ibe Dwi authored
* fix: misplaced negative sign * update formatting unit test * chore: update test name
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Cam Saul authored
-
Nemanja Glumac authored
-
bryan authored
* remove internal user on rollback + test * fix naming + add newline * fix typo * rollback change to migration changeset ID - since it would alter the checksum for it
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Cal Herries authored
-
Roman Abdulmanov authored
-
Ryan Laurie authored
-
Ngoc Khuat authored
-
Ryan Laurie authored
This reverts commit adfda064 now that #35621 has fixed the underlying issue.
-
Cal Herries authored
-
- Nov 13, 2023
-
-
bryan authored
* respect MB_PLUGINS_DIR on serialization load * respect MB_PLUGINS_DIR on serialization load
-
bryan authored
-
Jesse Devaney authored
* refactor use-list-select hook - toggleAll(items) felt unintuitive as some items could be selected while simultaneously unselecting others - switched to selectOnlyTheseItems(items) to be more explicit on what the function is doing - updated consumers of useListSelect to use the new API * convert to functional component * convert HoC ListSelect to hook useListSelect * convert redux connects to useSelectors * refactor ArchiveApp and improve types * hide read only items in the archive * verify desired behavior * refactor beforeEach * remove unused eslint disable line * refactor item can_write accessor logic * Add :can_write key into the search data response. uses `mi/can-write?` * update archive app for archived search changes * refactor filtering of list * replace hard-coded collection ids in spec * move specific helper outside of generic helpers file * remove admin gets unfiltered data * BE sends only can_write true results when search with archived?=true This change modifies the `check-permissions-for-model` method to check for write access if the SearchContext has archived true. This means that the only results sent to the frontend are those results that the user can take actions on, namely, unarchiving them. * reomve unused require * update FE to account for BE changes --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
bryan authored
-
bryan authored
* Audit db sync cannot happen - disable all job scheduling for audit db - make syncing/scanning auditdb a noop in prod (throws otherwise) * better name for job-data -> jobs-to-create * test no scheduling and no running audit db sync * sort ns * fix trivial check in test * use metabase.task/scheduler-info intead qrtz table * sort ns
-
Nemanja Glumac authored
-
Noah Moss authored
* tweak wording in config file docs * Update docs/configuring-metabase/config-file.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> * add period --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
* command page * formatting * command updates
-
Jeff Bruemmer authored
-
Noah Moss authored
-
Braden Shepherdson authored
The QP returns "large int" IDs like FKs as string, since JS doubles only guarantee 51 bits of mantissa and a 64-bit ID might get rounded. However NULL IDs were getting returned as `""` empty strings. This fixes the QP middleware to return `nil` (JS `null`). In addition, the drill-thru logic in the FE and MLv2 was trying to filter incorrectly with a NULL value. This PR prevents the FK filter drill from returning anything in that case. I filed #35561 to track the fact that would be useful to drill thru to all rows with a NULL for some FK, but it's low priority. Fixes #13957.
-