Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 12, 2024
  2. Aug 20, 2024
  3. Jun 10, 2024
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light,... · e8fedf01
      Denis Berezin authored
      feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687)
      
      * Migrate text-brand
      
      * Migrate text-dark
      
      * Migrate text-light
      
      * Migrate text-medium
      
      * Migrate admin-navbar
      
      * make compact formatting consistent across all series (#43472)
      
      * make compact formatting consistent across all series
      
      * fix rebase
      
      * [Browse] Show Browse models link in nav only when there are models (#43286)
      
      * Upgrade to TypeScript v5.4 (#43736)
      
      * use correct github api for CI (#43750)
      
      * update list of releases (#43754)
      
      * Multi Series Dashcards Render with Filters Applied To All Series (#43428)
      
      * Multi Series Dashcards Render with Filters Applied To All Series
      
      Fixes: #39083
      
      Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each
      card in the multi-series card.
      
      * Small refactor for executing dashcards in a pulse context.
      
      - move execute-dashboard-subscription to pulse.util
      - this fn now will also execute all card series cards
        and put those results into a list on the key :series-results in the dashcard
        which is then used in the render multimethod to send the correct data to the javascript context
      
      A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key
      
      * Fix up render fn
      
      The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more
      understandable.
      
      Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes
      
      * pull :data up a level from :result in the series cards
      
      * Update src/metabase/pulse/render/body.clj
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Remove unneeded let
      
      * set/rename-keys won't work here because we raise the :data key
      
      I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data
      from within the result key up to the same level (and dissoc result).
      
      I've renamed the helper function to make its purpose a bit clearer
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Hydrate can_run_adhoc_query and address review comments (#43747)
      
      This is a followup on #43625.
      
      * Consolidate dashboard-card specs (#43716)
      
      * Consolidate joins specs (#43717)
      
      * Update translations for v50 and add Danish Language Support (#43314)
      
      * update translations for v50
      
      * add Danish
      
      * update translations for v50 release
      
      * alphabetical order is nice
      
      * Move database role to url parameters from connection properties on Snowflake (#43602)
      
      * Move role to url parameters from connection properties
      
      * Fix test
      
      * Fix width of save button in cache sidebar (#43755)
      
      * Remove dead code (#43603)
      
      * Combine search e2e specs (#43718)
      
      * Highlight the table cell data in dashboards when the cell is an ID column (#43728)
      
      * highlight id cell column
      
      * add simpletable stories
      
      * add simple table test data
      
      * add loki reference image
      
      * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Remove old repro for 39150 (#43749)
      
      * Fix remaining `tinyint` booleans in MySQL (#43296)
      
      * Correct type for `report_card.dataset`
      
      This was missed in the original migration of boolean types to
      ${boolean.type} in MySQL/MariaDB, and then missed again by me when I
      migrated `collection_preview` over a week ago.
      
      * Change all boolean types to `bit(1)` in MySQL
      
      Liquibase changed their boolean type in MySQL from `bit(1)` to
      `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these
      as booleans, so we needed to migrate them to `bit(1)`s.
      
      As discussed [here](#36964), we
      changed all existing `boolean` types that were in the
      `001_update_migrations.yml` but not the SQL initialization file.
      
      For new installations, this works: things in the SQL initialization file
      get created with the `bit(1)` type.
      
      However, for existing installations, there's a potential issue. Say I'm
      on v42 and am upgrading to v49. In v43, a new `boolean` was added.
      
      In this case, I'll get the `boolean` from the liquibase migration rather
      than from the SQL initialization file, and it need to be changed to a
      `bit(1)`.
      
      I installed Metabase v41 with MySQL, migrated the database, and then
      installed Metabase v49 and migrated again. I made a list of all the
      columns that had the type `tinyint`:
      
      ```
      mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE,        COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test';
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | TABLE_SCHEMA  | TABLE_NAME                   | COLUMN_NAME       | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | metabase_test | core_user                    | is_datasetnewb    | tinyint     | 1              | NO          |
      | metabase_test | metabase_field               | database_required | tinyint     | 0              | NO          |
      | metabase_test | metabase_fieldvalues         | has_more_values   | tinyint     | 0              | YES         |
      | metabase_test | permissions_group_membership | is_group_manager  | tinyint     | 0              | NO          |
      | metabase_test | persisted_info               | active            | tinyint     | 0              | NO          |
      | metabase_test | report_card                  | dataset           | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | default           | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | time_matters      | tinyint     | NULL           | NO          |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      10 rows in set (0.01 sec)
      ```
      
      Then wrote migrations. For each column, we:
      
      - turn it into a `bit(1)`,
      
      - re-set the previously existing default value, and
      
      - re-add the NOT NULL constraint, if applicable.
      
      * Change author and add missing `dbms`
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * Add ts-pattern library (#43752)
      
      * Add events to measure search performance (#43135)
      
      * new_search_query event
      
      * Filters in object, search click event
      
      * updating event schema
      
      * type and event schema adjustments
      
      * delete comments BE code
      
      * adjusting tests
      
      * PR feedback
      
      * typos and spacing
      
      * Fixup missing colors
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarAlex Yarosh <alexandra@metabase.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Co-authored-by: default avatarlbrdnk <lbrdnk@users.noreply.github.com>
      Co-authored-by: default avatarPhoomparin Mano <poom@metabase.com>
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      Co-authored-by: default avatarSakuragiYoshimasa <ysrhsp@outlook.com>
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      e8fedf01
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 5 - success, summarize, warning, white, text-white, bg-white (#43676) · 7046fef3
      Denis Berezin authored
      * Migrate success
      
      * Migrate summarize
      
      * Migrate warning
      
      * Migrate white
      
      * Add colors to storybook
      
      * Fix CI
      
      * Fix CI
      
      * Codereview fixes
      
      * Convert warning color
      Unverified
      7046fef3
  4. Jun 05, 2024
  5. Jun 03, 2024
  6. May 17, 2024
  7. Apr 19, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add prefix to CSS custom properties (#41574) · 855b3245
      Mahatthana (Kelvin) Nomsawadi authored
      * Migrate --border-*
      
      * Migrate *breadcrumb*
      
      * Migrate --color-bg-black
      
      * Migrate --color-bg-dark
      
      * Migrate --color-bg-light
      
      * Migrate --color-bg-medium
      
      * Migrate --color-bg-white
      
      * Migrate --color-border
      
      * Migrate --color-brand*
      
      * Migrate --color-error
      
      * Migrate --color-focus
      
      * Migrate --color-shadow
      
      * Migrate --color-success
      
      * Migrate --color-text-dark
      
      * Migrate --color-text-light
      
      * Migrate --color-text-medium
      
      * Migrate --color-text-white
      
      * Migrate --color-white
      
      * Migrate --default-border-radius
      
      * Migrate --default-button-border-radius
      
      * Migrate --default-font-family
      
      * Migrate --default-font-size
      
      * Migrate --default-header-margin
      
      * Migrate --gap-1
      
      * Migrate --icon-width
      
      * Migrate --input-border-color
      
      * Migrate --input-border-radius
      
      * Migrate --margin-*
      
      * Migrate --muted-color
      
      * Migrate --padding-*
      
      * Migrate --page-header-padding
      
      * Migrate --subtitle-color
      
      * Migrate --title-color
      
      * Reset to master
      
      * Remove unused --color-text-default
      
      * Remove unused --color*
      
      * Remove unused CSS custom properties
      
      * Prefix only necessary CSS custom properties
      Unverified
      855b3245
  8. Apr 11, 2024
  9. Apr 03, 2024
    • Uladzimir Havenchyk's avatar
      Do not put js code into page title (#40901) · d12c549a
      Uladzimir Havenchyk authored
      
      * Do not put js code into page title
      
      * Typecheck
      
      * Add e2e test
      
      * Update e2e/test/scenarios/question/document-title.cy.spec.js
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      d12c549a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [MS2] 1. Analytics (#40681) · af54379a
      Mahatthana (Kelvin) Nomsawadi authored
      * Remove old config + fix typo
      
      * Add new analytics for 4 new illustration settings
      Unverified
      af54379a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [M1] Metabase illustration settings (#40219) · 715174d3
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Add login page illustration (#39299)
      
      * Move Metabot setting to a new place
      
      * Add setting for login page illustration
      
      * fix UI styling
      
      * Fix not able to upload the same file twice
      
      * Update the admin > appearance > conceal metabase copy
      
      * Prepare the component for tests
      
      * Add some unit tests
      
      * Prevent settings not saved sometimes
      
      After setting the value to/from `custom` one of the setting could be
      failed to save, I suspect this happens because the race condition from
      trying to save the setting values relatively at the same time.
      
      * Make unit tests easier to read
      
      * Add all unit test test cases
      
      * Add basic E2E test
      
      * Show fallback icon for broken images
      
      * Make use of the proper component
      
      * Update the comment to affect the reality
      
      * Add an error message when file size is over 2MB
      
      * Show an error message when the file size > 2MB
      
      * Add the error message tests
      
      * Preserve the preview image aspect-ratio
      
      * Detect corrupted images
      
      * Fix failing unit tests
      
      * Address feedback: Type
      
      * Feedback: Create meaningful variables
      
      * Feedback: Make selector API more sensible
      
      * Prevent race condition
      
      Makes sure we save the settings completely before making other actions
      that also change settings otherwise, there could be race conditions.
      
      * Feedback: tighten up a type
      
      * Feedback: Fix inconsistency callback calls
      
      * 2. Add the rest 3 illustration settings (#40487)
      
      * Add the rest 3 illustration settings
      
      * Don't make the X icon feel lonely
      
      * Fix illustration widget saving
      
      * Fix type error
      
      * 3. Update the select UX to match new design (#40491)
      
      * Update the select UX to match new design
      
      * Move info dot next to file upload button
      
      * Simplify IllustrationWidget API
      
      * Update setting title copy
      
      * Clean up test comments
      
      * Feedback: Clarify `any` type
      
      * Feedback: Use shorthand object creation
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Use global CSS glass instead of inlining values
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Remove unnecessary curly brackets in JSX
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * 4. Connect illustrations to new setting values (#40139)
      
      * Wire landing page illustration to the setting value
      
      * Wire the unsubscribe page to the setting value
      
      * Prepare no rows error to be wired to the setting value
      
      * Wire no question results illustration to the setting value
      
      * Wire no search results illustration to setting value
      
      * Fix error from fixing conflict
      
      * Fix required unnecsseary prop on Image
      
      * Use Image component
      
      * Link dashboard card no results image to the setting value
      
      * Move the no data results to more a generic directory
      
      * Link collection picker no results image to the setting value
      
      * Make illustrations more accessible
      
      * Fix failed tests
      
      * Test unscribe page illustration + test no illustration
      
      * Add landing page tests
      
      * Simplify Cypress selectors
      
      * Refactor: Rename settings to match the new requirements
      
      No question data -> No Data
      No search results -> No object
      
      These changes are made so, these 2 settings are generic enough to
      include other illustrations later on.
      
      * Add no data illustration test
      
      * Add no object illustration tests
      
      * Fix unsubscribe page background style
      
      * Fix not able to build static viz
      
      * 5. Follow-up on milestone 1 (#40710)
      
      * Update custom background illustration scale behavior
      
      * Remove the need to put an SVG file in static folder
      
      * Fix test from rebasing off master with @testing-library/user-event upgrade
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      715174d3
  10. Mar 28, 2024
  11. Mar 22, 2024
  12. Mar 21, 2024
  13. Mar 20, 2024
  14. Mar 12, 2024
    • Romeo Van Snick's avatar
      Split up "Doing science..." message (#39619) · da96c24f
      Romeo Van Snick authored
      * Convert QueryVisualization to a functional component
      
      * Add a custom message after loading for a while
      
      * Add test for slow database message
      
      * Loop through different custom messages
      
      * Use cy.clock to test timeouts
      
      * Make getLoadingMessage a function
      Unverified
      da96c24f
  15. Feb 20, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Follow up on "Polish appearance settings" (#38850) · db2624f8
      Mahatthana (Kelvin) Nomsawadi authored
      * Renaming files for consistency
      
      * Combine both container and view component
      
      * Add the new selector + improve types
      
      * Force user to refresh to see the colors change.
      
      * Revert "Add the new selector + improve types"
      
      This reverts commit 1587411da685857ee586b3096a58148f6a0ce36c.
      
      * Type setting selectors to support enterprise setting keys
      
      * Copy changes
      
      * Remove unused files
      
      * Remove default exports/imports
      
      * Add a modal telling users to refresh the page after changing colors
      
      * Revert "Add a modal telling users to refresh the page after changing colors"
      
      This reverts commit ac8772d01f18c1e5ba80a92d79f18843ac8a50cf.
      
      * Makes it obvious to users they need to refresh browser
      
      After changing colors, we want to make sure the behavior of colors is
      consistent across the board. Previously this wasn't the case, some
      elements will immediately change colors, while some don't. This created
      confusion.
      
      The new behavior is to NOT change any color at all after changing the
      application colors and let users refresh their browsers themselves.
      
      * Update copy according to a discussion
      
      * Fix e2e from copy change
      
      * Make assertion explicit
      
      * Fix the last E2E failure
      Unverified
      db2624f8
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
  16. Feb 19, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Polish appearance settings (#38713) · 8281abdc
      Mahatthana (Kelvin) Nomsawadi authored
      * Introduce tabs to admin settings
      
      * Change route when changing tabs
      
      * Reorder whitelabel settings according to the new design
      
      * Modify ImageUpload to support value from the setting
      
      * Update colors settings copy and style
      
      * Update copy in appearance/branding page
      
      * Update copy in appearance/conceal-metabase page
      
      * Add toggle grouping description
      
      * disconnect application colors from chart colors
      
      * Update whitelabel/branding copy
      
      * Update whitelabel/conceal-metabase toggles
      
      * Deprecate the old admin text input widget
      
      * Extend the test
      
      * Introduce SettingtextInput which uses metabase/ui component
      
      * Update Admin Select widget
      
      * Convert font Select to metabase/ui
      
      * Fix style conflict causing Select dropdown to overflow the page
      
      * Prevent repression on other settings page than Appearance
      
      * Move landing page (EE) to general settings page
      
      * Fix FE type
      
      * Fix unit tests
      
      * Fix E2E tests
      
      * Fix type
      
      * Removed commented out code
      
      * Fix E2E from master change
      Unverified
      8281abdc
  17. Feb 13, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add ESLint rule for Metabase strings (#38553) · 279b3721
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix case where Metabase links are render inside template strings
      
      * Add `no-literal-metabase-strings` ESLint rule
      
      * Fix all Metabase string errors
      
      * Address review: Fix the rule
      
      The rule was checking if we have imported the selector
      `getApplicationName` then ignore all Metabase strings. This is different
      than `no-unconditional-metabase-links-render` because in that rule, when
      fixed the Documentation URLs are still in the file, but in this rule,
      when fixed, there should be no Metabase strings left in the file.
      
      * Fix errors from the new lint rule
      Unverified
      279b3721
  18. Jan 15, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add show metabase links toggle admin setting (#37076) · 9a840f92
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Add show metabase links toggle admin setting
      
      * Hide Metabase links
      
      * Fix type error
      
      * Add selector tests
      
      * Hide a link in HomeHelpCard
      
      * Make test names more consistent with existing test suites
      
      * Add tests to `NewModelOptions`
      
      * Prepare `VisualizationError` for testing
      
      * Add tests to `VisualizationError`
      
      * Hide link and add tests to `PreviewQueryModal`
      
      * Extract components to make it easier to test
      
      * Move the new component into its own folder
      
      * Hide Metabase link in `ActionDashcardSettings`
      
      * Prepare `EmptyFormPlaceholder` for testing
      
      * Hide Metabase link in `EmptyFormPlaceholder`
      
      * Extract Metabase link from `FormCreator` for testing
      
      * Hide Metabase link in `FormCreator`
      
      * Extract link from `DashCardCardParameterMapper` to prepare for testing
      
      * Hide Metabase link in `DashCardParameterMapper`
      
      * Clean up the test setup function
      
      * Hide Metabase link in `ExpressionEditorHelpText`
      
      * Hide Metabase link in `TagEditorHelp`
      
      * Hide Metabase links in `MetricList`
      
      * Hide Metabase link in `SegmentList`
      
      * Prepare `CaveatMessage` for testing
      
      * Hide Metabase link in `CaveatMessage`
      
      * Hide Metabase link in `CustomMapFooter`
      
      * Hide Metabase link in `ImpossibleToCreateModelModal`
      
      * Hide Metabase link in `ExpressionWidget`
      
      * Hide Metabase link in `ExpressionWidget`
      
      * Add BE tests
      
      * Update sample database description
      
      * Fix TypeScript type-check
      
      * Fix failed unit tests
      
      * Fix wrong test names
      
      * Add missing translations
      
      * Make tests looks like tests from other components
      
      * Update enterprise/frontend/src/metabase-enterprise/whitelabel/components/MetabaseLinksToggleWidget/MetabaseLinksToggleWidget.tsx
      
      Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
      
      * Simplify the change
      
      * Fix weird import directory
      
      * Fix wrapped translation copy
      
      * Fix test name
      
      * Move comment next to the component
      
      * Fix test names
      
      * Review: Make code easier to review
      
      * Fix wrong document link
      
      * Update src/metabase/public_settings.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * Update src/metabase/public_settings.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * Address review: BE changes
      
      ---------
      
      Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      9a840f92
    • Alexander Polyankin's avatar
      Fix filter UI issues (#37676) · b8b42945
      Alexander Polyankin authored
      Unverified
      b8b42945
  19. Jan 10, 2024
    • Sloan Sparger's avatar
      Fix external landing page urls locking users out of Metabase (#37322) · 4a9b1162
      Sloan Sparger authored
      * updates enterprise appearance settings ui to validate that landing page urls are relative
      
      * adds e2e test, impls feedback to use isMetabaseUrl util
      
      * makes new e2e tests more resilient
      
      * fixes logical mistake in e2e test
      
      * removes old e2e test that accounted for invalid landing page urls being saved
      
      * impls pr feedback
      
      * extracts out url validation logic and adds unit tests
      Unverified
      4a9b1162
  20. Jan 09, 2024
  21. Dec 18, 2023
  22. Dec 12, 2023
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix whitelabeled application name replaces Metabase in admin settings (#36032) · e09323b6
      Mahatthana (Kelvin) Nomsawadi authored
      * Make it explicit when we want to replace the app name for whitelabeling
      
      * Remove the ttag hack so we can verify this solution works
      
      * Review: Remove unnecessary translation on the app name
      
      * Delete unused files
      
      * WIP replacing application names
      
      * Fix more places
      
      * Replace application names in more places
      
      * Replace the rest of the application name
      
      * Remove debug comment: admins
      
      * Remove debug comments: setup flow
      
      * Remove debug comments: misc
      
      * Remove debug comments: screenshots
      
      * Fix failed unit tests
      
      Because we're changing some components to get the application name from
      redux store, we need to update certain tests that still use `render` to
      `renderWithProvider` instead.
      Unverified
      e09323b6
  23. Dec 07, 2023
  24. Aug 22, 2023
  25. Aug 15, 2023
  26. Jul 31, 2023
  27. Jun 19, 2023
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Merge Encourage admins to add a database to master (#31610) · 31951b43
      Mahatthana (Kelvin) Nomsawadi authored
      * Encourage admin users to connect to a database (#31210)
      
      * Encourage admin users to connect to a database
      
      * Only render either payment banner or database prompt banner
      
      Discussed here:
      https://metaboat.slack.com/archives/C057T1QTB3L/p1685549180307149?thread_ts=1685547913.580079&cid=C057T1QTB3L
      
      
      
      * Improve mobile view layout
      
      * Address review: Remove `withRouter` HoC
      
      * Address review: Remove optional chaining
      
      * Address review: Refactor a component's deprecated `shouldRender` property
      
      * Add an e2e test to cover happy path
      
      * Remove new translation in `aria-label`
      
      * Fix sticky parameter widgets when showing database prompt banner
      
      * Fix E2E tests
      
      * Address review: Add missing unit tests
      
      * Fix a failed E2E test from rebasing off `master` branch
      
      * Add analytics (#31470)
      
      * 2/x Add analytics
      
      * Fix a failed E2E test from merging code from master
      
      * Prevent rendering the database prompt banner when white labeling (#31471)
      
      * 3/x Convert enterpise settings selectors to TypeScript
      
      * Add missing enterprise settings selectors tests
      
      * Don't render db prompt banner when white labeling
      
      * Reorganize the test to make an EE test more standing out
      
      * Address review: Remove unused function
      
      * 4/x Follow up reviews and tests (#31545)
      
      * 4/x Address review: Simplify code structure
      
      * Address review: Fix variable name collision
      
      * Move logic to display database banner to a hook
      
      * Remove unnecessary await
      
      * Restructure AppBanner tests
      
      * Swap test position to match the defined test matrix
      
      * Address review: removed outdated comment
      
      * Address review: Make `useShouldShowDatabasePromptBanner` hook tests clearer
      
      * Address review: Make conditions easier to follow
      
      Co-authored-by: default avatarUladzimir Havenchyk <uladzimir.dev@gmail.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarUladzimir Havenchyk <uladzimir.dev@gmail.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * 5/x Add embedding tests (#31557)
      
      * 5/x Add embedding tests
      
      * Clean up: Fix a selector signature
      
      * Address review: Using existing utility
      
      * Ensures that embedding pages are loaded before asserting UI not existing
      
      * Ready to write PublicQuestion tests
      
      * Move public and signed embeds tests to unit tests
      
      * Removed outdated eslint comment
      
      ---------
      
      Co-authored-by: default avatarUladzimir Havenchyk <uladzimir.dev@gmail.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      31951b43
  28. May 31, 2023
  29. May 13, 2023
  30. Apr 20, 2023
  31. Apr 05, 2023
  32. Feb 08, 2023
Loading