Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 09, 2020
  2. Mar 06, 2020
    • Paul Rosenzweig's avatar
    • Paul Rosenzweig's avatar
    • Tom Robinson's avatar
      Expressions: filter expressions, case statements, string extracts, and share aggregations (#11868) · 09001d6c
      Tom Robinson authored
      
      * Upgrade Chevrotain to v6.5.0
      
      * Switch from embedded actions to visitor
      
      * rename tokens to lexer, remove no-longer needed Chevrotain hack from webpack.config.js
      
      * get tests passing again
      
      * progress converting syntax parser
      
      * got intermediate Sum(A) test passing
      
      * more progress on parsing expressions
      
      * get complex expression passing
      
      * prettier
      
      * linting
      
      * Add TokenizedExpression snapshot test
      
      * Add support to parser for recovering whitespace tokens
      
      * Add case clause [ci all]
      
      * fix test [ci all]
      
      * Harden test [ci all]
      
      * More tests [ci all]
      
      * Correctly infer case return type [ci all]
      
      * Fix test [ci all]
      
      * Fix tests [ci all]
      
      * Improved syntax parser
      
      * More parser cleanup + start adding filters and functions
      
      * Add CASE and partial filter support, cleanup tests
      
      * Add string extracts [ci all]
      
      * Typo [ci all]
      
      * Make linter happy [ci all]
      
      * Add regex-match-first [ci all]
      
      * Fix arglist [ci all]
      
      * Fix test [ci all]
      
      * Add sum-where count-where and share support. Refactor aggregation tokens
      
      * Fix tests [ci all]
      
      * Add ns prefixes [ci all]
      
      * Add ns qualifiers [ci all]
      
      * Fix trim [ci all]
      
      * Tests: ensure stable ordering of results [ci all]
      
      * Fix trim [ci all]
      
      * Support only 1-arg trim [ci all]
      
      * Fix ns prefixes [ci all]
      
      * Fix psql [ci all]
      
      * Fix redshift [ci redshift]
      
      * Refactor/simplify grammer to consolidate aggregation, expression, and filter functions
      
      * Add isCase to isExpression
      
      * Directly splice regex pattern for psql & redshift [ci all]
      
      * Fix schema [ci all]
      
      * Redshift: splice replace args [ci redshift]
      
      * Add ns prefix [ci redshift]
      
      * Typo [ci redshift]
      
      * Filter expressions
      
      * Add metrics and segments back in to expressions
      
      * Disable tokenized editing
      
      * Update tests to clojure.test [ci all]
      
      * Add concat to sqlite [ci all]
      
      * Add length [ci all]
      
      * Add missing ns [ci all]
      
      * Fix test [ci all]
      
      * Fix messed up multimethods [ci all]
      
      * Fix mssql [ci all]
      
      * Fix sqlite concat [ci all]
      
      * sqlite: correctly qoute literal strings [ci all]
      
      * Misc improvements to syntax highlighting etc
      
      * Cleanup tests [ci all]
      
      * Reoder defs [ci all]
      
      * Make linter happy [ci all]
      
      * Mongo: add case [ci mongo]
      
      * mongo: fix switch [ci mongo]
      
      * typo [ci mongo]
      
      * Improve syntax highlighter and suggestions
      
      * Mongo: always have default fallback in case [ci mongo]
      
      * Rearrange test to split out ones using expressions [ci mongo]
      
      * Remove uneeded merge [ci all]
      
      * misc
      
      * Much improved syntax highlighting using recovery mode and partial CST
      
      * Improved suggestions
      
      * try monospace font for expressions
      
      * Better typing in parser, various other fixes
      
      * Avoid parsing multiple times
      
      * Fix tests
      
      * Fix tests
      
      * More test fixes
      
      * Special case for UnderlyingRecords drill with sum-where/count-where/share
      
      * switch back to square brackets for identifiers
      
      * change extract to regexextract
      
      * Lift expressions to subselect [ci all]
      
      * Commit on enter
      
      * rename extract to substitute, fix tests
      
      * Refactor [ci all]
      
      * Fix normalization [ci all]
      
      * Correctly handle joins [ci all]
      
      Co-authored-by: default avatarDaniel Higginbotham <daniel@flyingmachinestudios.com>
      Co-authored-by: default avatarSimon Belak <simon@metabase.com>
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      09001d6c
    • Paul Rosenzweig's avatar
    • Walter Leibbrandt's avatar
      Replace util fns with ones from (updated) medley (#12061) · d411f304
      Walter Leibbrandt authored
      * Replace util fns with ones from (updated) medley
      
      * Clean ns
      Unverified
      d411f304
    • Paul Rosenzweig's avatar
  3. Mar 05, 2020
  4. Mar 04, 2020
  5. Mar 03, 2020
  6. Mar 02, 2020
  7. Feb 27, 2020
  8. Feb 26, 2020
    • Kyle Doherty's avatar
      Improve month picker legibility (#11973) · 256f8cef
      Kyle Doherty authored
      * switch to 3up grid
      
      * cleanup
      Unverified
      256f8cef
    • Kyle Doherty's avatar
      Tweak date picker visuals (#11990) · 987db8a4
      Kyle Doherty authored
      * tweak date picker visuals
      
      * update Calendar snapshot
      Unverified
      987db8a4
    • Walter Leibbrandt's avatar
      Support for question references in native query template tags (#11835) · 013a6a0d
      Walter Leibbrandt authored
      * Port tests from expectations to clojure.test
      
      * Fix docstring
      
      * Added :question template tag type with lookup
      
      * s/question/card/
      
      * Fix typo: s/substitue/substitute/g
      
      * Wrap card query parameter data in a record
      
      Just like `FieldFilter`s.
      
      * Unrelated: Improve test layout
      
      * Add substitution of card query parameters in queries
      
      This implementation is incomplete.
      
      * Finish substitution of card query in parent query
      
      * Basic FE support for question template tags
      
      * Update card ID on tag name update
      
      Also, don't use `\d` in regexes.
      
      * yarn prettier
      
      * Add support for MBQL queries in template tag lookup
      
      * Return query strings directly as tag value
      
      * Fix query type lookup
      
      * Initialize QP store for MBQL→native conversion
      
      * Fix MBQL to native query conversion
      
      * Port tests from expectations to clojure.test
      
      * Add middleware to resolve tables/fields from referenced cards
      
      This needs to happen before `substitute-parameters` in the QP pipeline,
      so that `substitute-parameters` can convert any MBQL queries (from
      referenced cards) into native queries. Maybe it should be consolidated
      with the other resolution steps.
      
      * Use mbql-query util instead of manual query def
      
      * Add docstring to now public function
      
      * Remove unused import
      
      * Fix docstring positioning :face_palm:
      
      
      
      * Clean ns declaration
      
      * Convert tests to clojure.test
      
      * Be more specific about errors we're looking expecting
      
      Invalid queries caused unexpected exceptions to be thrown when checking
      permissions.
      
      * Recursively check permissions of referenced queries
      
      * Add incomplete test [WIP]
      
      * Finish permission check test for referenced MBQL queries
      
      * Add tests for referenced native queries perms check
      
      * Clean ns
      
      * Use existing mbql-to-native middleware
      
      Rather than calling driver-specific `mbql->native` directly.
      
      * Fix formatting
      
      * Use more comprehensive qp func for converting query to native
      
      * front end updates
      
      * Check that all referenced queries are from the same db
      
      * Add test for checking db id of referenced MBQL query
      
      * Clean ns
      
      * add metadata and better error states to UI
      
      * move error message beneath the question picker
      
      * Combine `vals`+`filter`+`map` into a single `keep`
      
      * Rename `CardQuery`→`ReferencedCardQuery`
      
      * Cosmetic: fix typo and formatting
      
      * Test substitution of multiple sub-queries
      
      * Test CTE syntax substitution of multiple sub-queries
      
      * Clean ns
      
      * Clean ns
      
      * Simplify referenced card substitution tests
      
      * Test recursive sub-query substitution
      
      * Cosmetic: typos
      
      * Fix parameter names in comments
      
      * Check that queries don't include circular sub-queries
      
      * Clean ns
      
      * Give users a more user-friendly error for circular referencing sub-queries
      
      * Test referencing queries with parameters
      
      * Update src/metabase/query_processor/middleware/resolve_referenced.clj
      
      Co-Authored-By: default avatarMaz Ameli <maz@metabase.com>
      
      * Fix error message and combine card name queries
      
      * Wrap sub-query error in a more user friendly explanation
      
      * Cosmetic: function argument alignment
      
      * Test error handling of referenced sub-queries
      
      * Remove unused 1-arity version of `card-subquery-graph`
      
      * Cosmetic: indentation
      
      * Normalize l10n of error messages
      
      * Reuse functions for looking up referenced cards from query
      
      * implement FE PR feedback
      
      * card -> card_id backend changes
      
      * fix tests
      
      * fix another test
      
      * disallow space between # and number
      
      * Align new middleware with newer QP architecture
      
      * Align sub-query error handling with the new QP
      
      It seems like exceptions are handled more consistently in the new QP, so
      we can be less hacky.
      
      * (Re)wrap sub-query errors in user-friendly expalanation
      
      * Rename `xformf`→`rff` to align with QP changes
      
      * force cypress click on select placeholder
      
      * move popover attachement and cap its height
      
      * icon spacing
      
      * customize highlighting for template tags
      
      Co-authored-by: default avatarPaul Rosenzweig <paulrosenzweig@users.noreply.github.com>
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      013a6a0d
  9. Feb 25, 2020
  10. Feb 24, 2020
  11. Feb 21, 2020
Loading