Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 17, 2023
  2. Mar 16, 2023
    • Nick Fitzpatrick's avatar
      Updating graph.metrics when column is removed (#29189) · aa3a5978
      Nick Fitzpatrick authored
      * Updating graph.metrics when column is removed
      
      * updating logic and adding unit tests
      aa3a5978
    • Emmad Usmani's avatar
      revert centering of undo toast (#29292) · 05b38d79
      Emmad Usmani authored
      05b38d79
    • dpsutton's avatar
      Ensure we use the ssh tunnel on action execution (#29228) · 37ebb437
      dpsutton authored
      * Ensure we use the ssh tunnel on action execution
      
      I'm gonna see if we have an existing way to run tests against ssh dbs. I
      see there are some tests that use a faking ssh server. Not sure if those
      are useful or not. But otherwise ssh stuff needs out of process help to
      accomplish so not sure if it's easily feasible right now
      
      * introduce new `with-unpooled-connection-spec` macro
      
      it is identical to the `with-connection-spec-for-testing-connection`
      macro but has a better name. In the future they could diverge as testing
      requirements and action requirements change. But we want that
      _implementation_ (which correctly uses tunnels), but we do not want a
      "testing connection" slug in the usage.
      
      In the future (or now if we prefer a different name) we can rename it,
      find the usages that are not testing vs the ones that are, etc.
      
      * tests for actions over ssh
      
      * unused require of mb.u.ssh
      
      had brought it in but then stuffed all of this inside of
      `with-unpooled-connection-spec` so no need to worry about ssh, closing
      it, ensuring the port is there, etc.
      
      * Don't test h2 with ssh tunnel
      
      details lack a host and it npe's in the ssh tunnel stuff. No big loss as
      ssh on h2 is not supported (due to this error, and probably many more)
      
      * Switch to toucan2 for db access in tests
      
      * Use connection pool for custom actions connection
      
      Was originally using `jdbc/get-connection` from the details of the
      db. This was a one-off non-pooled connection that also did not reuse ssh
      tunnels. I thought the one-off connection was important since it is not
      read only, but that's not the case. So we can reuse the exact same
      mechanism that the implicit actions are using with
      `metabase.driver.sql-jdbc.actions/with-jdbc-transaction`.
      
      * cyclic dependency
      
      almost moved it into execute, but that gives a very inviting
      `sql-jdbc.execute/with-jdbc-transaction`. Welcoming even. But
      `sql-jdbc.actions/with-jdbc-transaction` lets you know its only for
      transactions.
      37ebb437
    • metamben's avatar
      Add filter constructor functions (#29253) · cf662f31
      metamben authored
      * Add filter constructor functions
      
      * Revert changes to defop
      
      * Address linter complaints
      
      * Add function to set the query filter
      
      * Address linter complaints
      
      * Fix test name
      cf662f31
    • Jeff Bruemmer's avatar
      69dc9e8b
    • Alexander Polyankin's avatar
    • Case Nelson's avatar
      Add an aggregate function to add aggregations to queries (#29225) · 6154130e
      Case Nelson authored
      * Add an aggregate function to add aggregations to queries
      
      * Call ->op-arg on aggregate input
      
      * Allow any in aggregations for now because expressions on aggregates are allowed
      
      * We have to recurse into clauses
      6154130e
    • Natalie's avatar
      4e8bc850
    • Jerry Huang's avatar
      Add 404 error when fetching a group that doesn't exist (#29249) · 28c94fc7
      Jerry Huang authored
      * add permissions and test
      
      * address comments
      
      * fix whitespace
      
      * remove ehitespace
      
      * revert vscode changes
      28c94fc7
    • Tim Macdonald's avatar
    • Nemanja Glumac's avatar
    • Denis Berezin's avatar
      De-crazy the expression editor function helper popover (#28678) · eb12c954
      Denis Berezin authored
      * Refactored ExpressionWidget, ClauseStep components to TS (#28687)
      
      * Implement new UI design, add unit tests (#28776)
      
      * Add design changes to ExpressionWidget
      
      * Add new design for ExpressionEditorHelpText (#28920)
      
      * Add expression function arguments interactivity (#28966)
      
      * New design for expression editor info link (#29113)
      eb12c954
    • Anton Kulyk's avatar
      Fix action database picker state without available databases (#29039) · c7185de5
      Anton Kulyk authored
      * Fix empty database picker state
      
      * Remove redundant `requireWriteback` occurrences
      
      * Update test
      
      * Update test
      
      * Use clearer names
      
      * Don't show query language message for actions
      
      * Use database `hasActionsEnabled` method
      
      * Remove `requireWriteback` prop
      
      * Respect `readOnly` prop in `DataSourceSelectors`
      
      * Extend e2e test coverage
      
      * Use `setActionsEnabledForDB` in Cypress
      
      * Fix data picker behavior
      c7185de5
    • Nemanja Glumac's avatar
      cb5562e7
  3. Mar 15, 2023
  4. Mar 14, 2023
    • Bryan Maass's avatar
      defendpoint auto coercion :gear: (#28929) · 3110b54d
      Bryan Maass authored
      * defendpoint auto coercion :arrow-heading-up::gear:
      
      * annotate all the id fields on the api with ms/Id
      
      * mark nillable "boolean"
      
      * update shape of action map
      
      - also improve the error messages with "recieved: _"
      
      * oh yeah! there are like 20 more *id*'s!
      
      * fix docstring + parse numbers properly
      
      * rename IntGreaterThanZero -> PositiveInt
      
      - remove ms/Id
      
      * fiddle with test wording
      
      * add regexes into compojure routes to avoid arbitrary route matching
      
      * tests for compojure route disambiguation w/ regex
      
      * trivial change to kick CI
      
      * minor refactor + update docstring
      
      * add nil condp default case
      
      * fix linter errors that snuck through .. somehow
      
      * fix typo + update tests that no longer regex-match
      3110b54d
    • Tim Macdonald's avatar
      Trivial test refactor (#29218) · 18ea6fc6
      Tim Macdonald authored
      18ea6fc6
    • Ryan Laurie's avatar
      Add Recent Item Links to link cards (#29197) · 5389aee5
      Ryan Laurie authored
      * Allow linkviz to show recent item suggestions
      
      * unit test recent link adding
      
      * oops
      5389aee5
    • Tim Macdonald's avatar
      Users can run actions if they have access to the database (#29088) · c46d7099
      Tim Macdonald authored
      * Users can execute actions if they can read the model and the DB is not blocked
      
      [Fixes #28425]
      c46d7099
Loading