Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 09, 2024
  2. Oct 08, 2024
    • Chris Truter's avatar
    • Alexander Polyankin's avatar
    • Aleksandr Lesnenko's avatar
      add iframe dashcards tracking (#48382) · 291384d1
      Aleksandr Lesnenko authored
      
      * track iframe creation
      
      * Update Loki Snapshots
      
      * Update frontend/src/metabase/visualizations/visualizations/IFrameViz/utils.unit.spec.ts
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      291384d1
    • dpsutton's avatar
      Ensure the temp directory exists (#48488) · 5fd75e0d
      dpsutton authored
      https://github.com/metabase/metabase/issues/41919#issuecomment-2400542908
      
      This issue goes away in 5.3.1 of apache poi. Seems like they have a
      yearly release cadence so we can ensure this exists for the time being
      and then remove this when we can bump to 5.3.1
      
      ```diff
      index b763a1ffdf..c87992c935 100644
      --- a/deps.edn
      +++ b/deps.edn
      @@ -122,7 +122,7 @@
         {:mvn/version "2.23.1"}             ; allows the slf4j2 API to work with log4j 2
         org.apache.logging.log4j/log4j-layout-template-json
         {:mvn/version "2.23.1"}             ; allows the custom json logging format
      -  org.apache.poi/poi                        {:mvn/version "5.2.5"}              ; Work with Office documents (e.g. Excel spreadsheets) -- newer version than one specified by Docjure
      +  org.apache.poi/poi                        {:mvn/version "5.3.1"}              ; Work with Office documents (e.g. Excel spreadsheets) -- newer version than one specified by Docjure
         org.apache.poi/poi-ooxml                  {:mvn/version "5.2.5"
                                                    :exclusions  [org.bouncycastle/bcpkix-jdk15on
                                                                  org.bouncycastle/bcprov-jdk15on]}
      ```
      Unverified
      5fd75e0d
    • Aleksandr Lesnenko's avatar
      isomorphic viz settings computation (#47963) · c6b0b2b7
      Aleksandr Lesnenko authored
      
      * isomorphic viz settings computation
      
      * stories
      
      * drop duplicated static formatter
      
      * drop formatValue from the renderingContext
      
      * clean up
      
      * stories
      
      * fix static charts stories
      
      * clean up mocked env
      
      * update sunburst formatters
      
      * no longer injecting formatValue
      
      * exclude modules without name
      
      * Update Loki Snapshots
      
      * Update Loki Snapshots
      
      ---------
      
      Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
      Unverified
      c6b0b2b7
    • Ryan Laurie's avatar
      Update Settings Copy to kick Ci + fix milestone setting bug (#48486) · 62861cc7
      Ryan Laurie authored
      * update setting copy
      
      * update settings context strings
      
      * fix milestone check
      Unverified
      62861cc7
    • Cam Saul's avatar
      :race_car::rocket: :race_car::rocket: :race_car::rocket: Test partitioning for MySQL: shave ~5 minutes off of CI runs :race_car::rocket::race_car::rocket: :race_car::rocket: (#48422) · b8172829
      Cam Saul authored
      * SQUASH!
      
      * Add another sanity checc
      
      * Another test fix attempt
      
      * Appease Kondo
      Unverified
      b8172829
    • Nick Fitzpatrick's avatar
      Collection of UI updates to the alert modal (#48431) · 372d529b
      Nick Fitzpatrick authored
      * collection of UI updates to the alert modal
      
      * remiving unused es lint directive
      
      * adding tag to cypress test
      Unverified
      372d529b
    • github-automation-metabase's avatar
    • Alex Yarosh's avatar
      fix links (#48478) · cdea683a
      Alex Yarosh authored
      Unverified
      cdea683a
    • Nemanja Glumac's avatar
      [MS1] Better Onboarding: Educational Section in the Main Sidebar (#48369) · 662bf17c
      Nemanja Glumac authored
      * [MS 1.1] Better Onboarding via First-Time UX (#48202)
      
      * Add new `learn` icon
      
      * Add initial visual elements WIP
      
      * Add a menu WIP
      
      * Use named export instead of a named one
      
      * Encapsulate the menu item logic
      
      * Redo the styling
      
      * Add todo notes
      
      * Get rid of the `style` prop where possible
      
      * Fix CSS logic for the container
      
      * Collapse section when the sidebar is closed
      
      * Use Mantine prop instead of the `style`
      
      * Fix the translation issue
      
      * Collapse section completely when the sidebar is closed
      
      * Remove hard coded color reference from SVG
      
      * Simplify element positioning
      
      * Collapse sidebar when closed
      
      * Fix E2E tests unscoped selectors
      
      * Rename props
      
      * Extract `SidebarOnboardingSection` logic into a separate component
      
      * Allow only admins to add data
      
      * Remove "Add your own data" button
      
      * Simplify menuitem component
      
      * Add initial unit tests
      
      * Use predefined vars for the CSV button subtitle
      
      * Show Upload CSV modal
      
      * Enable file uploads
      
      * Improve file organization
      
      * Tidy up types
      
      * Add analytics
      
      * Remove "Upload CSV" button from the sidebar
      
      * Fix "unmocked GET request"
      
      * Make menu usable on small screens
      
      * Make sure sidebar is scrollable
      Unverified
      662bf17c
    • appleby's avatar
      Fix typo in devguide (#48247) · 1f733b98
      appleby authored
      Unverified
      1f733b98
    • Chris Truter's avatar
    • Alexander Polyankin's avatar
      Fix query_metadata not including metadata for native queries (#48459) · 3a0a9690
      Alexander Polyankin authored
      * Fix query_metadata not including native queries
      
      * Fix query_metadata not including native queries
      
      * fix tests
      Unverified
      3a0a9690
    • Nicolò Pretto's avatar
      update embedding homepage now that we don't auto-enable embedding (#48455) · 173227ae
      Nicolò Pretto authored
      * update embedding homepage now that we don't auto-enable embedding
      
      * more cleanup and a test "Enable interactive embedding"
      Unverified
      173227ae
    • Alexander Polyankin's avatar
      Native query drill (#48232) · 4aa67506
      Alexander Polyankin authored
      Unverified
      4aa67506
    • Ryan Laurie's avatar
      Update release channel settings copy (#48425) · 2ec9fdb1
      Ryan Laurie authored
      * update release channel copy
      
      * update e2e tests
      Unverified
      2ec9fdb1
    • Raphael Krut-Landau's avatar
      Mock audit info requests (#48432) · 0b7bf918
      Raphael Krut-Landau authored
      This PR
      * mocks audit requests in tests of `DashboardInfoSidebar` and `QuestionInfoSidebar` (these tests were flaking)
      * introduces a helper, `setupAuditEndpoints`, to facilitate this in the future
      * uses the helper in one other place where audit requests were getting mocked
      Unverified
      0b7bf918
    • Nicolò Pretto's avatar
      Unverified
      537ba417
    • Alexander Polyankin's avatar
      Default to `=` operator when `Filtering on this field` is set to `A list of... · f03e6d8c
      Alexander Polyankin authored
      Default to `=` operator when `Filtering on this field` is set to `A list of all values` or `Search box` (#48412)
      
      Unverified
      f03e6d8c
    • lbrdnk's avatar
      [Databricks] Address initial remarks (#48377) · 72495873
      lbrdnk authored
      * Address initial remarks
      
      * Extract hive-like to separate module and set it as dependency
      
      * Remove hive-like also from spark
      Unverified
      72495873
    • Phoomparin Mano's avatar
    • Kamil Mielnik's avatar
      [Epic] Search in selection in entity picker (#47755) · f6aab536
      Kamil Mielnik authored
      
      * Maintain selected folder state in Entity Picker (#47309)
      
      * Keep tabs mounted
      
      * Rename TablePicker onChange to onItemSelect to match QuestionPicker and also call it for folders
      
      * Inline small functions
      
      * Remove unused type
      
      * Rename
      
      * Remove TODOs
      
      * Remove duplication
      
      * Reduce diff
      
      * Rename
      
      * Lift state from TabsView
      
      * Remove redundant callback
      
      * Store folder state in DataPickerModal
      
      * Refactor computing tabs
      
      * Consolidate search tab definition with recents tab definition
      
      * Simplify computeInitialTab interface
      
      * Extract RECENTS_CONTEXT
      
      * Store tab state in DataPickerModal
      
      * Propagate initial tab state
      
      * Fix a flicker
      
      * Keep tab state in EntityPickerModal
      
      * Fix typing computeInitialTab
      
      * Remove Notebook prefix
      
      * Pass onItemSelect to individual tabs from EntityPickerModal
      
      * Auto select folder
      
      * Fix types
      
      * Adjust remaining tabs definitions to use render
      
      * Adjust tabs definitions to use render in tests
      
      * Fix inverted condition
      
      * Fix TS error
      
      * Fix types
      
      * Rename EntityTab to EntityPickerTab, TabId to EntityPickerTabId
      
      * Rename EntityTabRenderProps to EntityPickerTabRenderProps
      
      * Separate tab models from tab ids
      
      * ESLint
      
      * ESLint
      
      * Recognize folders inside EntityPickerModal
      
      * Add missing prop
      
      * Remove console.log
      
      * Simplify handleFolderSelect
      
      * Revert changes that will go to a different PR
      
      * Fix unit tests
      
      * Refactor
      
      * Remove keepMounted prop
      
      * Fix type
      
      * Remove useMemo from tabs computation (#47505)
      
      * Extract getTabs for DataPickerModal
      
      * Extract getTabs for EntityPickerModal
      
      * Add explicit return type
      
      * Revert "Add explicit return type"
      
      This reverts commit feb3f58c.
      
      * Revert "Extract getTabs for EntityPickerModal"
      
      This reverts commit 4e875a1f.
      
      * Revert "Extract getTabs for DataPickerModal"
      
      This reverts commit cdda8ea1.
      
      * Remove useMemo
      
      * Maintain tab state in Entity Picker (#47794)
      
      * Store picker path state in data picker modal
      
      * Adjust remaining QuestionPicker usages
      
      * Store collection picker state
      
      * Use dedicated onPathChange prop
      
      * Store dashboard picker state
      
      * Improve naming
      
      * Fix unit tests
      
      * Remove accidental code
      
      * Return to previously opened tab when search input is cleared in Entity Picker (#47798)
      
      * Restore previous tab when clearing search input
      
      * Add a unit test for new behavior
      
      * Update comment
      
      * Don't use effect
      
      * Add more tests
      
      * Reduce diff
      
      * Fix flakes
      
      * Change search input placeholder depending on selected folder & tab in Entity Picker (#47801)
      
      * Make TabFolderState generic, pass folder to EntityPickerSearchInput
      
      * Simplify interface
      
      * Extract getSearchInputPlaceholder
      
      * Reduce diff
      
      * Remove TODO
      
      * Implement it
      
      * Shorten code
      
      * Reduce diff
      
      * Use database to scope search if there's only 1 schema
      
      * Add scoped search in the Search tab in Entity Picker (#47839)
      
      * Cleanup entity picker search types (#48098)
      
      * Add e2e tests for local search in the entity picker (#48122)
      
      * Sync the value back into selectedItem when it changes
      
      * Await element
      
      * Handle empty tabs
      
      * Pick everywhere tab
      
      * Click Everywhere in unit tests
      
      * Use deep equality to sync value
      
      * Sync back the path value to the dashboard too
      
      * Run test as admin to avoid (unrelated) permissions issues
      
      * Filter scoped results too
      
      * Fix post-merge issues
      
      * Fix type issues
      
      * Fix null scoped search results
      
      * Sign in as admin to appease the tests
      
      * Use useDeepCompareEffect when syncing back state
      
      * Add default value for searchResultFilter to avoid double condition
      
      * Avoid using useEffect to sync selectedItem
      
      * Avoid overwriting path in useEnsureCollectionSelected
      
      * Fix e2e test
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Co-authored-by: default avatarRomeo Van Snick <romeo@romeovansnick.be>
      Unverified
      f6aab536
    • Oisin Coveney's avatar
      Removes unneeded query parameters (#48401) · 9f50306f
      Oisin Coveney authored
      Unverified
      9f50306f
    • Cam Saul's avatar
      :race_car::rocket::race_car::rocket: :race_car::rocket: SHAVE 7 MINUTES OFF OF NON-CORE DRIVER TEST RUNS IN CI :race_car::rocket::race_car::rocket: :race_car::rocket: (#47681) · cd4d7646
      Cam Saul authored
      * Parallel driver tests PoC
      
      * Set fail-fast to false for now
      
      * Try splitting up non-driver tests to see how broken tests are
      
      * Whoops fix plain BE tests
      
      * Ok nvm I'll test this in another branch
      
      * Fix fail-fast
      
      * Experiment with the improved Hawk split logic
      
      * Fix some broken/flaky tests
      
      * Experiment: try splitting MySQL 8 tests into FOUR jobs
      
      * Divide other Postgres and MySQL tests up and use num-partitions = 2
      
      * Another test fix :wrench:
      
      * Flaky test fix :wrench:
      
      * Try making more stuff fast
      
      * Make athena fast??
      
      * Fix a few more things
      
      * Test fixes? :wrench:
      
      * Fix configs
      
      * Fix Mongo job syntax
      
      * Fix busted test from #46942
      
      * Fix Mongo config again
      
      * wait-for-port needs to specify shell I guess
      
      * More cleanup
      
      * await-port can't have a timeout-minutes I guess
      
      * Let's only parallelize MySQL for now.
      
      * Cleanup action
      
      * Cleanup wait-for-port action
      
      * Fix another flaky test
      
      * NOW driver tests will be FAST
      
      * Need to mark driver tests too
      
      * Fix wrong tag
      
      * Use Hawk 1.0.5
      
      * Fix busted metabase.public-settings-test/landing-page-setting-test
      
      * Fix busted `metabase.api.database-test/get-database-test` etc. (hopefully)
      
      * Fix busted `metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test` for Oracle
      
      * Maybe this fixed `metabase.query-processor.middleware.permissions-test/e2e-ignore-user-supplied-perms-test` maybe not
      
      * Fix busted metabase.api.dashboard-test/dependent-metadata-test because endpoint had differemt sort order than test
      
      * Ok my test fix did not work
      
      * Fix metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test for Redshift
      
      * Better test name
      
      * More test fixes :wrench:
      
      * Schema fix
      
      * PR feedback
      
      * Split off test partitioning into separate PR
      
      * Fix failing Oracle tests
      
      * Another round of test fixes, hopefully
      
      * Fix failing Redshift tests
      
      * Maybe the last round of test fixes
      
      * Fix Oracle
      
      * Fix stray line
      Unverified
      cd4d7646
  3. Oct 07, 2024
  4. Oct 05, 2024
Loading