Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 25, 2021
  2. Aug 24, 2021
  3. Aug 23, 2021
  4. Aug 21, 2021
  5. Aug 20, 2021
    • Jeff Evans's avatar
      Fix serialization P2 issues (#17388) · e8c7140a
      Jeff Evans authored
      * Fix serialization dump error when there are no collections
      
      Update `select-collections` to correctly handle the case where there are no collections
      
      Adding new test that removes all collections, then ensures that dump works with no errors
      
      * Fix serialization load error into empty/blank target DB
      
      Rethrowing exception in cmd when overall load fails
      
      Add test to ensure that a dump containing a user can be loaded into a blank target app DB successfully
      
      Adding a few missing bindings to the `with-temp-empty-app-db` code to set the connection vars under metabase.db.connection
      
      In upsert, add hooks for a :pre-insert-fn and :post-insert-fn to be invoked for new entity instances created by the upsert process, since whether an entity will be an insert or update isn't necessarily known by the load process (only by upsert once identity-condition is checked for each)
      
      In load, setting the pre and post insert functions for a User instance to initialize :password with a random value, and to generate and send a password reset email to the newly inserted user's email, respectively
      
      NOTE: this post insert fn (to send a password reset email for newly inserted users) is NOT hooked up for User as of x.41 release, since it is considered a bugfix, but this can be enabled in a future release)
      
      Adding new defs for the magic permission group names to make those easier to override from tests that might need to (such as the one added for this commit)
      
      * Fix serialization objects being incorrectly updated on skip
      
      Remove `maybe-fixup-card-template-ids!`, which was forcing mode :update, since the existing retry logic should cover what it was trying to do
      
      Update Card and Metric models to delete any Dependency instances for which they are the `:model_id` (to make serialization tests after other tests created temporary Card/Dependency pairs)
      
      Adding missing assertions for Dependency serialization
      
      * Serialization: Fix reload entity logic
      
      Now that the `:mode` is always respected instead of being ignored sometimes, we need to update our "second pass" reload functions to always make the mode `:update` on the second pass, or else that entity would just be skipped, which is bad
      
      Also updated the test to use `:mode` `:skip` from the beginning to be more stringent
      e8c7140a
    • Dalton's avatar
      refactor/move parameter object transformations to one place (#17461) · 02713dd3
      Dalton authored
      * refactor/move parameter object transformations to one place
      
      * use hasParameterValue in place of nil check
      
      * remove enableDefaultParameters arg since it is unused
      02713dd3
    • Gustavo Saiani's avatar
      c9bbfbc7
    • Jeff Evans's avatar
      New BigQuery Driver (#16746) · a980e085
      Jeff Evans authored
      New BigQuery Driver
      
      Create new :bigquery-cloud-sdk driver using the google-cloud-bigquery library instead, and whose source is adapted from the :bigquery driver
      
      https://cloud.google.com/bigquery/docs/reference/libraries
      
      Marking existing :bigquery driver as deprecated, and superseded-by the new one (bigquery-cloud-sdk)
      
      Update new driver and query processor code to use newer Google SDK
      
      Switch test data loading over to use new API
      
      Add project-id connection property to override the value from the service account JSON, and use it as part of qualified names in the query processor if set
      
      Updating google driver so its libraries are compatible with the newer ones used in BigQuery
      
      Update date bucketing tests to skip :bigquery-cloud-sdk (new driver) where :bigquery is skipped
      
      Update `with-bigquery-fks` to take in the driver, since there are now multiple ones
      
      Adding test to confirm that overriding project-id for a public BQ project works (sync and query)
      
      Fixing a bunch of whitespace alignment errors in tests
      a980e085
    • Ariya Hidayat's avatar
    • Ariya Hidayat's avatar
      Remove some superfluous return types in the metadata code (#17519) · 3480ca89
      Ariya Hidayat authored
      Type inference can already correctly infer those return types, no need
      to explicit anymore.
      3480ca89
    • Ariya Hidayat's avatar
      57e50c79
Loading