This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 25, 2021
-
-
Anton Kulyk authored
* Move JoinStep's NotebookCell down to JoinClause * Break JoinClause into two NotebookCells * Update labels * Use `space` helper function * Simplify conditional statement * Fix not translated string
-
Alexander Polyankin authored
-
- Aug 24, 2021
-
-
Ariya Hidayat authored
-
Gustavo Saiani authored
-
Jeff Evans authored
* Add Kerberos support to Presto JDBC Driver Adding Kerberos properties as DB details properties Refactoring utility methods for dealing with additional options Adding test for Kerb properties -> connection string Adding GitHub action to run integration test Start to move logic for capturing necessary files to new script, and calling that from mba run Adjust settings in `metabase.test.data.presto-jdbc` to capture test parameters
-
Jeff Evans authored
Fix counting on grouped aggregated field Adding QP test Reworking the BigQuery version of the :breakout to more closely match the structure of the standard sql.qp version
-
Gustavo Saiani authored
-
Noah Moss authored
-
Nemanja Glumac authored
-
Alexander Lesnenko authored
* add PermissionSelect component * add PermissionSidebar component * add PermissionTable component * add PermissionEditor component * add useLeaveConfirmation hook * add selectors for the collections permissions page * add selectors for the data permissions pages * add confirmation creators to use in selectors * sandboxing permissions modal: redirect to parent route when closed * Add PermissionsPageLayout component * Adjust CollectionPermissionsModal to use new permissions UI * Add CollectionPermissionsPage * Add data permissions pages * Adjust collection permissions modal route * Adjust permissions routes according new pages structure * update permissions actions, reducers * adjust sandboxing * remove old permissions code * support admin colorScheme in Radio * support admin colorScheme in TextInput * support admin colorScheme in Tree * update permissions specs * fix data permissions url typo * fix sandboxing * add search debounce to permission pages * exclude schemas from search, make it flat * fix permissions for databases without schemas * fix copy for native queries permissions, show table display_name instead of raw name * fix before leave warning shown when change collections * permissions sidebar: make database name clickable * fix string groupIds lead to bugs in permissions editor * fix disabling table permissions shows all tables permission disabled * fix permissions copy * fix permissions disabled tooltips copy * fix, add specs * fix permissions edit bar button colors, fix breadcrumbs on schemaless dbs * fix official collection color, make sidebar tree scrollable * fix scroll in permissions modal * fix breadcrumbs * change table icon * create helpers for entity ids and permissions url creation * remove hardcoded colors * make confirmations an array * store confirmAction in state * add ModalRoute specs * fix propTypes, typo * build permission pages urls with helpers * revert switching from ref to state for confirm action function due to react invokes it on a render * move mapStateToProps to the top of the files * add visual specs * add more specs * fix edit sandbox access action * add cypress spec for sandboxing
-
Ariya Hidayat authored
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Try reverting mongo QA image back to 4.0 * Update mongo query assertion
-
Nemanja Glumac authored
-
Ariya Hidayat authored
-
- Aug 23, 2021
-
-
Dalton authored
* enable unset default params on dashboard * add unit tests
-
Gustavo Saiani authored
-
Nemanja Glumac authored
* Update parameter names in `editDashboardCard` Cypress custom command * Update tests
-
Howon Lee authored
Mongo custom expressions now are turned on for mongo 5.0 and after only. One idiosyncrasy is that we don't really support the BSON ID format at all in our typesystem despite having it in there, but both of my attempts to get them to work with the native mongo pipeline commands bounced because they really aren't strings, they're BSON ID's. We do rely on the pipeline commands heavily which is the reason for the version requirement.
-
Ariya Hidayat authored
-
Ariya Hidayat authored
This requires unfortunately an additional layer of indirection, however I believe it's super cheap and it shouldn't impact execution speed. In the mean time, many other predicates (isFoo etc) which rely on isa() will be correctly type-inferred, which gives a huge win for editing and debugging purposes.
-
Noah Moss authored
-
Nemanja Glumac authored
* Expand `setAdHocFilter` helper function to include current date * Add repro for #17551 * Update test title
-
dpsutton authored
I'm not sure we can fix this. We need the graal compiler which doesn't appear to be jdk 8 compatible but I can't actually find javadocs for it. Its not clear from https://github.com/oracle/graaljs/blob/master/docs/user/RunOnJDK.md how you can actually run it. I tried adding the graal compiler but that seems to assume you are in a graal vm and fails not finding a class. To get a list of all the options available for a context's engine, ```clojure (doto 'metabase.pulse.render.js-engine require in-ns) (map (comp (juxt :name :help) bean) (.getOptions (.getEngine (context)))) ``` I've done some profiling ```clojure (dotimes [_ 5] (time (do (let [rows [["apples" 2] ["bananas" 3]] colors {"apples" "red" "bananas" "yellow"}] (js-svg/categorical-donut rows colors)) nil))) "Elapsed time: 210.32659 msecs" "Elapsed time: 193.211736 msecs" "Elapsed time: 190.97775 msecs" "Elapsed time: 195.843254 msecs" "Elapsed time: 188.077405 msecs" nil ``` For interpreted and in another language, this doesn't seem the end of the world. And adding more quantities ```clojure (letfn [(rand-string [] (str/join "-" (repeatedly 4 #(rand-nth ["banana" "horse" "battery" "cloak"]))))] (dotimes [_ 5] (let [rows (repeatedly 20 (fn [] [(rand-string) (rand-int 100)])) colors (zipmap (map first rows) (cycle ["red" "green" "blue" "yellow"]))] (time (js-svg/categorical-donut rows colors))))) "Elapsed time: 288.659887 msecs" "Elapsed time: 334.733071 msecs" "Elapsed time: 317.369294 msecs" "Elapsed time: 272.084918 msecs" "Elapsed time: 272.7203 msecs" nil ``` For a timeline line chart, rendering one datapoint per day for a whole year: ```clojure (dotimes [_ 5] (let [dates (take 365 (iterate #(.plusDays % 1) #t "2020")) rows (map (fn [d] [d (rand-int 200)]) dates) labels {:left "count" :bottom "year"}] (time (js-svg/timelineseries-line rows labels)))) "Elapsed time: 569.691124 msecs" "Elapsed time: 544.415676 msecs" "Elapsed time: 539.131092 msecs" "Elapsed time: 492.60486 msecs" "Elapsed time: 523.765691 msecs" nil ```
-
Noah Moss authored
-
Alexander Lesnenko authored
-
Greg Wilson authored
* Troubleshooting guide for filters. After conversation with @flamber, split this into one guide for simple filters and one for linked filters. The explanation at the top of the second page may still need some work... * Updating filter troubleshooting * Troubleshooting when you can't see the tables you should. * Why is my dashboard slow? * Troubleshooting: can't send email * Adding @flamber's batch script-style guide * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * Fixing first item * Addressing feedback * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Adding flamber's comment * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Splitting entry * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Troubleshooting timezones * Reformatting the filter troubleshooting guides * Partial update to troubleshooting filters * specify sql questions * link * update relative links * more link fixes * still more links * specify dashboard filters * fix typo * Italicizing one more word * Unifying all troubleshooting guides so far * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Incorporating suggestion * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Another small fix Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> Co-authored-by:
jeff bruemmer <jeff.bruemmer@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Aug 21, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Aug 20, 2021
-
-
Jeff Evans authored
* Fix serialization dump error when there are no collections Update `select-collections` to correctly handle the case where there are no collections Adding new test that removes all collections, then ensures that dump works with no errors * Fix serialization load error into empty/blank target DB Rethrowing exception in cmd when overall load fails Add test to ensure that a dump containing a user can be loaded into a blank target app DB successfully Adding a few missing bindings to the `with-temp-empty-app-db` code to set the connection vars under metabase.db.connection In upsert, add hooks for a :pre-insert-fn and :post-insert-fn to be invoked for new entity instances created by the upsert process, since whether an entity will be an insert or update isn't necessarily known by the load process (only by upsert once identity-condition is checked for each) In load, setting the pre and post insert functions for a User instance to initialize :password with a random value, and to generate and send a password reset email to the newly inserted user's email, respectively NOTE: this post insert fn (to send a password reset email for newly inserted users) is NOT hooked up for User as of x.41 release, since it is considered a bugfix, but this can be enabled in a future release) Adding new defs for the magic permission group names to make those easier to override from tests that might need to (such as the one added for this commit) * Fix serialization objects being incorrectly updated on skip Remove `maybe-fixup-card-template-ids!`, which was forcing mode :update, since the existing retry logic should cover what it was trying to do Update Card and Metric models to delete any Dependency instances for which they are the `:model_id` (to make serialization tests after other tests created temporary Card/Dependency pairs) Adding missing assertions for Dependency serialization * Serialization: Fix reload entity logic Now that the `:mode` is always respected instead of being ignored sometimes, we need to update our "second pass" reload functions to always make the mode `:update` on the second pass, or else that entity would just be skipped, which is bad Also updated the test to use `:mode` `:skip` from the beginning to be more stringent
-
Dalton authored
* refactor/move parameter object transformations to one place * use hasParameterValue in place of nil check * remove enableDefaultParameters arg since it is unused
-
Gustavo Saiani authored
-
Jeff Evans authored
New BigQuery Driver Create new :bigquery-cloud-sdk driver using the google-cloud-bigquery library instead, and whose source is adapted from the :bigquery driver https://cloud.google.com/bigquery/docs/reference/libraries Marking existing :bigquery driver as deprecated, and superseded-by the new one (bigquery-cloud-sdk) Update new driver and query processor code to use newer Google SDK Switch test data loading over to use new API Add project-id connection property to override the value from the service account JSON, and use it as part of qualified names in the query processor if set Updating google driver so its libraries are compatible with the newer ones used in BigQuery Update date bucketing tests to skip :bigquery-cloud-sdk (new driver) where :bigquery is skipped Update `with-bigquery-fks` to take in the driver, since there are now multiple ones Adding test to confirm that overriding project-id for a public BQ project works (sync and query) Fixing a bunch of whitespace alignment errors in tests
-
Ariya Hidayat authored
Type inference can already correctly infer those return types, no need to explicit anymore.
-
Ariya Hidayat authored
-