Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 09, 2024
  2. Jun 08, 2024
  3. Jun 07, 2024
  4. Jun 06, 2024
    • Nemanja Glumac's avatar
      Fix milestone reminder (#42861) · 25c4cb0b
      Nemanja Glumac authored
      * Add a helper to extract linked issues from PR body
      
      * Add tests
      
      * Tweak the workflow
      
      * Fix the workflow
      
      * Delete obsolete code
      
      * Improve the message
      
      * Fix whitespace error
      Unverified
      25c4cb0b
    • Jesse Devaney's avatar
      Fix RowChart X-Axis ticks formatter (#43783) · f54e3d5a
      Jesse Devaney authored
      * fix RowChart XAxis ticks formatter
      
      - remove scaling from x-axis tick values like we did for y-axis tick values in ECharts charts
      
      * add loki variant
      Unverified
      f54e3d5a
    • Jesse Devaney's avatar
    • Ryan Laurie's avatar
      Send more tests to flake jail (#43761) · 1e50d9f3
      Ryan Laurie authored
      * mark more tests as flaky
      
      * all the flakes
      Unverified
      1e50d9f3
    • Aleksandr Lesnenko's avatar
    • Nick Fitzpatrick's avatar
      Add events to measure search performance (#43135) · 6d0f5e69
      Nick Fitzpatrick authored
      * new_search_query event
      
      * Filters in object, search click event
      
      * updating event schema
      
      * type and event schema adjustments
      
      * delete comments BE code
      
      * adjusting tests
      
      * PR feedback
      
      * typos and spacing
      Unverified
      6d0f5e69
    • Sloan Sparger's avatar
      Add ts-pattern library (#43752) · c7048cf8
      Sloan Sparger authored
      Unverified
      c7048cf8
    • SakuragiYoshimasa's avatar
      Fix remaining `tinyint` booleans in MySQL (#43296) · 49b126ef
      SakuragiYoshimasa authored
      
      * Correct type for `report_card.dataset`
      
      This was missed in the original migration of boolean types to
      ${boolean.type} in MySQL/MariaDB, and then missed again by me when I
      migrated `collection_preview` over a week ago.
      
      * Change all boolean types to `bit(1)` in MySQL
      
      Liquibase changed their boolean type in MySQL from `bit(1)` to
      `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these
      as booleans, so we needed to migrate them to `bit(1)`s.
      
      As discussed [here](#36964), we
      changed all existing `boolean` types that were in the
      `001_update_migrations.yml` but not the SQL initialization file.
      
      For new installations, this works: things in the SQL initialization file
      get created with the `bit(1)` type.
      
      However, for existing installations, there's a potential issue. Say I'm
      on v42 and am upgrading to v49. In v43, a new `boolean` was added.
      
      In this case, I'll get the `boolean` from the liquibase migration rather
      than from the SQL initialization file, and it need to be changed to a
      `bit(1)`.
      
      I installed Metabase v41 with MySQL, migrated the database, and then
      installed Metabase v49 and migrated again. I made a list of all the
      columns that had the type `tinyint`:
      
      ```
      mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE,        COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test';
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | TABLE_SCHEMA  | TABLE_NAME                   | COLUMN_NAME       | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | metabase_test | core_user                    | is_datasetnewb    | tinyint     | 1              | NO          |
      | metabase_test | metabase_field               | database_required | tinyint     | 0              | NO          |
      | metabase_test | metabase_fieldvalues         | has_more_values   | tinyint     | 0              | YES         |
      | metabase_test | permissions_group_membership | is_group_manager  | tinyint     | 0              | NO          |
      | metabase_test | persisted_info               | active            | tinyint     | 0              | NO          |
      | metabase_test | report_card                  | dataset           | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | default           | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | time_matters      | tinyint     | NULL           | NO          |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      10 rows in set (0.01 sec)
      ```
      
      Then wrote migrations. For each column, we:
      
      - turn it into a `bit(1)`,
      
      - re-set the previously existing default value, and
      
      - re-add the NOT NULL constraint, if applicable.
      
      * Change author and add missing `dbms`
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      49b126ef
    • Nemanja Glumac's avatar
      Remove old repro for 39150 (#43749) · 2473fa2f
      Nemanja Glumac authored
      Unverified
      2473fa2f
    • Phoomparin Mano's avatar
      Highlight the table cell data in dashboards when the cell is an ID column (#43728) · ea2d0a7e
      Phoomparin Mano authored
      
      * highlight id cell column
      
      * add simpletable stories
      
      * add simple table test data
      
      * add loki reference image
      
      * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      ea2d0a7e
    • Ryan Laurie's avatar
      Combine search e2e specs (#43718) · 8cb8d640
      Ryan Laurie authored
      Unverified
      8cb8d640
Loading