Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 02, 2024
  2. Mar 26, 2024
    • Denis Berezin's avatar
      Embedding SDK - integration commit (#40198) · 98f6cd82
      Denis Berezin authored
      * Minimal SDK code
      
      * Fix viz, styles
      
      * Move SDK code to enterprise folder
      
      * Fix files structure
      
      * Clean-up
      
      * Review fixes
      
      * Review fixes
      
      * Review fixes
      
      * Remove elementid
      
      * Reuse some options from main webpack config
      
      * Actualize package.json
      
      * Actualize package.json
      Unverified
      98f6cd82
  3. Mar 21, 2024
  4. Mar 20, 2024
    • bryan's avatar
      Feature branch for airgap-token: Milestone 1 (#39733) · bcda8468
      bryan authored
      
      * decrypt and read values from airgap token
      
      - Adds notion of "AirgapToken"
      - Adds max-users and company optional fields to `TokenStatus`
      - Adds branch to `fetch-token-status*` for handling airgapped tokens
      
      * Add support for handling airgap tokens
      
      - validate airgap token valid-thru date
      
      * enforce user creation limits using airgap token
      
      * fix airgap token reads + fill in the token data
      
      * in oss mode don't try to read the airgap_ token
      
      * use airgap-token? helper
      
      * tighten the user-creation logic
      
      - make the check correct
      - account for archived users
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * check airgap user count
      
      setting premium-embedding-token
      app startup
      
      * move decryption code into ee namespace
      
      * add some tests for token decryption
      
      * fix tests and add tests
      
      * move ee features into ee tests
      
      * add typehint + warn on reflection
      
      * add a check for missing public key resource
      
      * respond to review
      
      - add docstring to AirgapToken
      - remove outdated comment
      - fix off-by-1 error
      
      * valid-now? takes a TokenStatus instead of a :map
      
      * revert usage of mt/with-temporary-setting-values
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      bcda8468
  5. Mar 11, 2024
    • Cam Saul's avatar
      Convert QP to MLv2 Part 2 (#39824) · 5bbc0aa7
      Cam Saul authored
      * Keep fetch_source_query.clj
      
      * Copy fetch_source_query.clj into fetch_source_query_legacy.clj
      
      * Set back fetch_source_query.clj file
      
      * Convert QP to MLv2, part 1
      
      * Keep legacy implementation around for time being
      
      * Port thru convert-to-legacy
      
      * expand-macros is converted to legacy
      
      * Test fixes :wrench:
      
      * Test fixes and better keys
      
      * Test fixes
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Test fix? :wrench:
      
      * Wow, maybe I finally fixed everything :wrench:
      
      * Last few test fixes :wrench:
      
      * PR feedback; lib.walk should support splicing in multiple replacement stages
      
      * Update fetch-source-query to use improved lib.walk
      
      * Have I fixed everything now? :wrench:
      
      * Remove stray println
      
      * Another MongoDB fix :wrench:
      
      * Convert QP to MLv2 Part 2
      
      * Remove most of the fetch-source-query-legacy stuff
      
      * Remove the changes to expand-macros for now, we can do that in a follow-on PR.
      
      * Test fix
      
      * Test fix
      
      * TEST FIXES?! :wrench:
      
      * Kondo & test fixes
      
      * Oops, make sure we have the updated tests
      
      * Fixes :wrench:
      
      * Test fixes :wrench:
      
      * Convert resolve-source-table
      
      * Appease Kondo
      
      * Unparallelize the tests
      
      * Another test that shouldn't be parallel
      
      * Make tests more robust
      
      * Test fixes :wrench:
      Unverified
      5bbc0aa7
  6. Mar 08, 2024
    • Cam Saul's avatar
      Convert QP to MLv2 (Part 1) (#39613) · 2dccd287
      Cam Saul authored
      * Keep fetch_source_query.clj
      
      * Copy fetch_source_query.clj into fetch_source_query_legacy.clj
      
      * Set back fetch_source_query.clj file
      
      * Convert QP to MLv2, part 1
      
      * Keep legacy implementation around for time being
      
      * Port thru convert-to-legacy
      
      * expand-macros is converted to legacy
      
      * Test fixes :wrench:
      
      * Test fixes and better keys
      
      * Test fixes
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Test fix? :wrench:
      
      * Wow, maybe I finally fixed everything :wrench:
      
      * Last few test fixes :wrench:
      
      * PR feedback; lib.walk should support splicing in multiple replacement stages
      
      * Update fetch-source-query to use improved lib.walk
      
      * Have I fixed everything now? :wrench:
      
      * Remove stray println
      
      * Another MongoDB fix :wrench:
      
      * Remove the changes to expand-macros for now, we can do that in a follow-on PR.
      
      * Test fix
      
      * Test fix
      Unverified
      2dccd287
  7. Dec 21, 2023
  8. Dec 11, 2023
  9. Nov 08, 2023
  10. Oct 25, 2023
  11. Oct 23, 2023
  12. Oct 14, 2023
  13. Sep 26, 2023
    • Nick Fitzpatrick's avatar
      Only run BE tests on static viz FE changes (#33760) · 39acfd4a
      Nick Fitzpatrick authored
      * output static viz sources, update be workflow and file paths
      
      * build static viz before file check
      
      * extending file check timeout
      
      * fixing mistake
      
      * disable optimization when generating file paths
      
      * prefer offline
      
      * moving workflows to save 89505
      
      * Maybe caching the build?
      
      * removing minification
      
      * upload artifact instead of use cache
      
      * Add workflows back
      
      * reduce files changed timeout
      
      * removing unneeded yarn install
      Unverified
      39acfd4a
  14. Jun 17, 2023
  15. Mar 16, 2023
  16. Mar 01, 2023
    • Nemanja Glumac's avatar
      [E2E] Regroup and move all related files to the root (#28749) · f71f20e1
      Nemanja Glumac authored
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      Unverified
      f71f20e1
  17. Feb 27, 2023
    • Braden Shepherdson's avatar
      [metabase-lib] Dev experience and CLJC infra improvements · 4580eab9
      Braden Shepherdson authored
      Dev experience:
      - CLJS now has source maps
      - Devtools extension renders CLJS data in Chrome (et al) Devtools
      - Use a debug build of CLJS in the tests
      - Fixed line numbers and breakpoints being off-by-one in Devtools
      
      CLJC infra:
      - More robust direct approach to JS<->CLJS conversions, powered by
        Malli transformers.
      - Powerful `define-getters-and-setters` macro to generate the accessors.
      4580eab9
  18. Jan 31, 2023
  19. Jan 05, 2023
    • Bryan Maass's avatar
      Defendpoint autogen dox polish (#27492) · 90e293ad
      Bryan Maass authored
      * fix automatic dox generation for malli+defendpoint
      
      - there isn't a concept of not having an error message for a schema \o/
      - warn but don't break when the schema is invalid
      - polish the descriptions a little "a nullable a vector" -> "a nullable vector"
      
      * gitignore malli types files
      
      * schema -> defendpoint api/setting GET :key
      
      + docs example
      
      * schema -> defendpoint api/action + dox generation
      
      * quickfix + add smaller trivial tests
      
      * add imported clj kondo rules to git
      
      * add with-api-error-message to fix some tests
      
      * use mu/with-api-error-message
      
      * fix tests
      
      * finish defendpoint migration for api/action ns
      
      * do not stringify errors
      
      * fix devtime annoyance with malli-dox generation
      
      * more polish
      
      - add length to numerics
      - respond to review
      
      * unused var linter fix
      
      * fix off by 1 in umd/description
      
      * aligator eats the big number + update action.md
      Unverified
      90e293ad
  20. May 12, 2022
  21. Mar 22, 2022
    • Benoit Vinay's avatar
      Various fixes for errors seen in the console while browsing (#21060) · ef256e31
      Benoit Vinay authored
      * shouldNotForwardTransientProp method created for emotion
      
      * BadgeIcon html attributes clean up
      
      * Usage of transient property $hasMargin in Badge for BadgeIcon
      
      * HTML attribute cleanup for LinkRoot
      
      * React key added to ButtonBar child if not defined
      
      * Properties for TableInfoPopover properly typed
      
      * Misc
      
      * analyticsContext property set as non required as non of the parents enforce it or pass a value
      
      * Clean up attributes for SVG in Icon
      
      * CSS fix for share icon special case in Icon
      
      * Checkbox controlled component default value fix
      
      * Misc clean up
      
      * index file for collection side bar
      
      * Collections collectionID type fix
      
      * collection type in NewCollectionItemMenu fix
      
      * Misc
      
      * TokenField fix for value
      
      * noPopover passed properly to WidgetStatusIcon
      
      * Updates to controlled input/checkbox
      
      * VS Code workspace file added to gitignore
      
      * shouldNotForwardTransientProp renamed to shouldForwardNonTransientProp
      
      * AddAggregationButton defaultProps updates
      
      * propTypes for TableInfoPopover added back
      Unverified
      ef256e31
  22. Jan 21, 2022
  23. Nov 29, 2021
  24. Nov 02, 2021
  25. Oct 20, 2021
  26. Sep 27, 2021
  27. Jul 30, 2021
  28. Mar 17, 2021
  29. Mar 16, 2021
    • dpsutton's avatar
      Add lsp (#15181) · 3edc7d0b
      dpsutton authored
      * Add lsp and config
      
      ```emacs-lisp
        (use-package lsp-mode
          :ensure t
          :hook ((clojure-mode . lsp)
                 (clojurec-mode . lsp)
                 (clojurescript-mode . lsp))
          :config
          (setq lsp-enable-indentation nil)
          (setq lsp-enable-file-watchers nil) ;; annoying and i can't specify paths
          ;; add paths to your local installation of project mgmt tools, like lein
          (dolist (m '(clojure-mode
                       clojurec-mode
                       clojurescript-mode
                       clojurex-mode))
             (add-to-list 'lsp-language-id-configuration `(,m . "clojure"))))
      ```
      
      * Add socket repl support to project.clj (also include reveal)
      
      * Configure lsp so that enterprise is on the classpath
      Unverified
      3edc7d0b
  30. Mar 05, 2021
    • Cam Saul's avatar
      Shared CLJ/CLJS lib (#14980) · cca03d22
      Cam Saul authored
      * Shared CLJ/CLJS lib (PoC/WIP)
      
      * PoC 2.0
      
      * Fixes :wrench:
      
      * More test fixes :wrench:
      
      * Bump shadow-cljs version
      
      * Fix more stuff
      
      * Need to ^:export the exports
      
      * CI fixes :wrench:
      
      * Add eslintignore
      
      * Ignore cljs files for FE code coverage
      
      * Try prefixing CLJS -> JS import with goog:
      
      * Revert indentation change
      
      * No goog:
      
      * Add .prettierignore
      
      * Use advanced build for now for JS tests unit we can figure out how to make it work
      Unverified
      cca03d22
  31. Dec 11, 2020
    • Nemanja Glumac's avatar
      Merge Cypress metadata extraction method from `release-x.37.x` (#14053) · 6697758c
      Nemanja Glumac authored
      * Extract sample dataset metadata in Cypress (#13994)
      
      * Extract `SAMPLE_DATASET` metadata
      
      * Test that metadata extraction is working properly in CI
      
      Note: `frontend/test/__support__/cypress_sample_dataset.json` file will be overwritten every single time Cypress runs. It is added to `.gitignore` for that reason.
      
      * Update Cypress tests with new metadata retrieval method (#14004)
      
      * Update enterprise tests
      
      * Update admin related tests
      
      * Update dashboard related tests
      
      * Update `public.cy.spec.js`
      
      * Update question related tests
      
      * Update visualization related tests
      
      * Update repro for #13990 with new metadata method [ci skip] (#14011)
      
      * Add metadata sync for external DBs (#14015)
      
      * Fix post-merge errors
      Unverified
      6697758c
  32. Dec 09, 2020
    • Robert Roland's avatar
      Dashboard subscriptions work, squashed (#13390) · dd2ecc51
      Robert Roland authored
      
      * Dashboard subscriptions work, squashed
      
      This test namespace differs in EE and OSS
      
      Without other changes from EE, this won't work
      
      so, for now, I've restored the pure OSS version of this test
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      links to configure pulse types
      
      Display a link to configure email or slack when they aren't already
      
      Fix the am/pm picker
      
      set up a new schedule tooltip
      
      The sidebar can appear and disappear from the Sharing popover
      
      run prettier on everything
      
      email recipients now does the "name [and n other]" thing
      
      Dashboard subscriptions work, squashed
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      styling for email not configured state
      
      add styling for slack unconfigured state
      
      disable cursor-pointer if email or slack isn't configured
      
      Implement cancel button for the sidebar (#13741)
      
      Dashboard subscription UX enhancements:
      
      * Implement cancel button for the sidebar
      
      * Don't return duplicate dashboard subscriptions
      
      * Move sidebar cancellation into Redux
      
      * Add close icon
      
      * Fix popover behavior
      
      Dashboard Subscriptions: Fix build (#13859)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Subscribe to dashboards send test email (#13886)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      * uggh cypress
      
      * Add button to send test email for dashboard subscriptions
      
      * Disable test email with no recipients
      
      * Refactor SendTestEmail
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Fix failing collection tests (#13891)
      
      * Move dashboard embedding button (#13928)
      
      * Revert migration 277 (as in master)
      
      styling and hover tweaks for subscription cards (#14003)
      
      Fix positioning of create and close buttons (#13999)
      
      * fix positioning of create and close buttons
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * import Flex
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      Co-authored-by: default avatarKyle Doherty <kyle.l.doherty@gmail.com>
      
      Add deprecation warning to Pulse create/edit page (#13954)
      
      * add pulse deprecation warning
      
      * remove unused Link component
      
      * kyle comments
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      More dash subscription styling tweaks (#14006)
      
      * change hovers for email and slack delivery options
      
      * calm down, delete button
      
      * style csv and xlsx options as buttongroup
      
      * settings spacing tweaks
      
      Dashboard subscription attachment question selection (#13950)
      
      * Move email attachment into its own component
      
      Add appropriate checkbox behavior
      
      Set pulseCards appropriately
      
      * Delete PulseCards when dashboard card removed
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      dd2ecc51
  33. Dec 08, 2020
  34. Oct 27, 2020
    • dpsutton's avatar
      Adds dev/src/dev/nocommit to ignore file (#13353) · 1ab05174
      dpsutton authored
      * Adds dev/src/dev/nocommit to ignore file [ci skip]
      
      now you can create a folder nocommit/ under the dev classpath root so
      you can keep some namespaces around as you work on features.
      
      Ex:
      
      ```clojure
      (ns dev.nocommit.oom
        (:require [metabase.models
                   [database :refer [Database]]
                   [field :refer [Field]]
                   [table :refer [Table]]]
                  [metabase.sync.analyze
                   [fingerprint :as analyze.fingerprint]]
                  [metabase.sync :as sync]
                  [metabase.sync
                   [field-values :as sync.field-values]]
                  [metabase.models.field-values :as field-values]
                  [metabase.sync.analyze.fingerprint.fingerprinters :as fingerprinters]
                  [metabase
                   [util :as u]]
                  [metabase.sync.sync-metadata.fields :as metadata.fields]
                  [metabase.sync.sync-metadata.fields.fetch-metadata :as fetch-metadata]
                  [metabase.query-processor :as qp]
                  [toucan.db :as db]
                  [metabase.db
                   [metadata-queries :as metadata-queries]]))
      
      (def pg (Database 4))
      
      (comment
        (fetch-metadata/db-metadata pg emails-table)
        (metadata.fields/sync-fields! pg)
      
        (sync/sync-database! pg))
      
      (clojure.test/run-tests 'whatever-namespace)
      
      ```
      
      I ended up with lots of `(comment ...)` blocks in lots of different
      namespaces and this has helped keep my worktree clean.
      
      * Empty commit to trigger CI [ci skip]
      
      skipping ci thought so hopefully the checks on Github are satisified.
      Unverified
      1ab05174
  35. Oct 09, 2020
    • Cam Saul's avatar
      New driver build scripts (#13383) (#13428) · 2468cac2
      Cam Saul authored
      * New driver build scripts and fix Google driver build
      
      * Install Clojure CLI in Circle CI
      
      * Fix driver build script
      
      * Build script fix :wrench:
      
      * More dox
      
      * Enforce minimum build Clojure CLI version and address feedback
      
      * New metabuild-common directory for shared stuff. Address some PR feedback
      Unverified
      2468cac2
    • Cam Saul's avatar
      New driver build scripts (#13383) · 4315dbed
      Cam Saul authored
      * New driver build scripts and fix Google driver build
      
      * Install Clojure CLI in Circle CI
      
      * Fix driver build script
      
      * Build script fix :wrench:
      
      * More dox
      
      * Enforce minimum build Clojure CLI version and address feedback
      
      * New metabuild-common directory for shared stuff. Address some PR feedback
      4315dbed
  36. Oct 08, 2020
    • Cam Saul's avatar
      New driver build scripts (#13383) · 9a82d7d9
      Cam Saul authored
      * New driver build scripts and fix Google driver build
      
      * Install Clojure CLI in Circle CI
      
      * Fix driver build script
      
      * Build script fix :wrench:
      
      * More dox
      
      * Enforce minimum build Clojure CLI version and address feedback
      
      * New metabuild-common directory for shared stuff. Address some PR feedback
      Unverified
      9a82d7d9
  37. Aug 08, 2020
  38. Jul 07, 2020
  39. Apr 10, 2020
Loading