Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 18, 2021
    • Dalton's avatar
      Reimplement tooltips using tippy.js (#18880) · 80d81a10
      Dalton authored
      * add tippy and react-is
      
      * add tippy styles to vendor.css
      
      we'll probably override most things but it handles
      apply the triangle to tooltips
      
      * reimplement Tooltip using tippy
      
      * reimplement ChartTooltip using Tooltip
      
      * add tooltip theme styling
      
      * fix StoreLink styling
      
      * remove TooltipPopover
      
      * add util for easy mapping to innerRef
      
      * use innerRef util with StoreLink target
      
      * react-is type defs
      
      * convert Tooltip into tsx
      
      * convert styled-components util into typescript
      
      * fix Tooltip fallback return
      
      * use Tooltip in Icon over Tooltipify
      
      * remove Tooltipify
      
      * pass ref all the way through Icon
      
      * fix DimensionListItem styling caused by missing ref
      
      * fix ChartTooltip event target bug
      
      * fix unit test by making Icon.tsx grosser
      
      * replace popover() util with tooltip() in cy tests
      
      * fix random broken e2e test
      
      * improve types in Tooltip
      
      * move everything to a separate folder + add tests
      
      * add more examples
      
      * rmv accidental deps
      
      * fix run button styling
      
      * add Link tooltip prop to avoid tooltip on icon
      
      * wrap MetabotLogo in forwardRef
      
      * support reduced motion
      
      * remove flow type from dom.js so we can use in ts files
      
      * pass isEnabled prop to tippy's disabled prop
      
      once you've activated "control mode" in tippy you can't turn it off so
      using "visible" as a toggle doesn't work. instead, use disabled.
      
      * fix uncentered tooltip the right way
      
      tippy includes padding/margin in its centering calculations, unlike
      tether, so we will need to be careful about adding one-sides
      padding/margins to a tooltip target, otherwise the tooltip will appear
      offcenter
      
      * workaround for absolutely positioned element
      
      the tooltip appeared on the far end of the target because of a child div
      that is absolutely positioned. quick fix is to instead target the icon
      
      * fix positioning of HintIcon tooltip
      
      * lint fix
      
      * add placement prop
      
      * fix styled component tooltip target styling
      
      * place QuestionNotebookButton tooltip below
      
      * Make the NativeQueryButton an actual button
      
      * set tooltip placement to bottom
      
      * lint fix warning
      Unverified
      80d81a10
  2. Nov 09, 2021
    • Anton Kulyk's avatar
      Add ability to turn a dataset back into a question (#18873) · 6bc2fb9f
      Anton Kulyk authored
      * Add `hasPlugin` check to moderation plugin
      
      * Remove border from QuestionModerationSection
      
      * Remove padding from question description
      
      * Reorder imports and exports
      
      * Remove not used prop
      
      * Manage section border in the sidebar
      
      * Add tests for question details sidebar
      
      * Add basic dataset management section
      
      * Add icon for dataset > question action
      
      * Test dataset —> question change
      
      * Add ability to turn a dataset into a question
      
      * Use HTML buttons for dataset management
      
      * Show question verification section
      
      * Fix datasets e2e test helper
      
      * Fix hover effect for dataset action buttons
      
      * Fix question sidebar button alignment
      
      * Use CSS to handle sidebar border
      Unverified
      6bc2fb9f
  3. Nov 01, 2021
  4. Oct 29, 2021
  5. Oct 26, 2021
  6. Oct 22, 2021
  7. Oct 18, 2021
  8. Oct 15, 2021
  9. Oct 14, 2021
  10. Oct 12, 2021
  11. Oct 07, 2021
    • Anton Kulyk's avatar
      Fix new questions don't appear in the Saved Questions picker (#18095) · 8c43bd62
      Anton Kulyk authored
      * Enable repro
      
      * Move saved questions virtual DB id to own file
      
      * Add saved question helpers
      
      * Add test-id to Metabase logo component
      
      * Extend repro test to cover archived items handling
      
      * Handle saved question actions in schema entity
      
      * Handle saved question actions in table entity
      
      * Fix moved file import
      
      * Fix Cypress can't find logo in EE (whitelabeling)
      
      * Fix saved questions order
      
      * Fix saved questions included in database tables
      Unverified
      8c43bd62
  12. Oct 06, 2021
    • Howon Lee's avatar
      Erroring question page nits (#18190) · 384218e6
      Howon Lee authored
      Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit,
      
      - Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it
      - No more left nav on the table page
      - Page heading for table page
      - Independent scroll-x behavior on the table
      - Styling for the error section on the table page
      - Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers)
      - Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards
      Rename error name to error content search
      Unverified
      384218e6
  13. Oct 05, 2021
  14. Sep 30, 2021
  15. Sep 29, 2021
    • Howon Lee's avatar
      Revert reversion of error cards details page (#18107) · 4853b793
      Howon Lee authored
      Overall purpose of PR is to add row drill-ins to the tools to fix broken questions, so you can take a look-see into what the broken questions are.
      
      A tiny nit thing wasn't caught by CI and broke master. This was because there's a CI cache. I can confirm that this didn't hit the CI cache and the other thing that broke isn't breaking anymore
      Unverified
      4853b793
  16. Sep 28, 2021
  17. Sep 24, 2021
  18. Sep 23, 2021
    • Alexander Lesnenko's avatar
      Subscriptions and alerts audit (#17765) · 9393a03b
      Alexander Lesnenko authored
      
      * subscriptions and alerts audit
      
      * Add tables
      
      * Add tables
      
      * Extract to lib
      
      * Extract to lib
      
      * Add modal
      
      * Add modal
      
      * Add modal
      
      * Fix modals
      
      * Fix modals
      
      * Add children for displaying modals
      
      * Add children for displaying modals
      
      * Add children for displaying modals
      
      * Add children for displaying modals
      
      * Add edit dialogs
      
      * Add edit dialogs
      
      * Add edit dialogs
      
      * Add edit dialogs
      
      * Remove deletion
      
      * Remove deletion
      
      * Add users
      
      * Add users
      
      * Fix selection issues
      
      * Add placeholder
      
      * Add placeholder
      
      * Add delete button
      
      * Fix wrapping issues
      
      * F
      
      * Small fixes
      
      * Add reloading
      
      * fixes
      
      * cypress specs
      
      * fixes
      
      * post rebase fixes
      
      * rebase fixes
      
      * review fixes
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Unverified
      9393a03b
  19. Sep 22, 2021
  20. Sep 21, 2021
  21. Sep 20, 2021
  22. Sep 17, 2021
    • Alexander Lesnenko's avatar
    • Anton Kulyk's avatar
      Feature | More Granular Caching Controls (Frontend) (#17802) · 7d6e031b
      Anton Kulyk authored
      * Rename dashboard details edit action
      
      * Use render props at dashboard edit form
      
      * Add enterprise caching plugin
      
      * Move dashboard entity forms to own file
      
      * Make FormField's margin configurable
      
      * Pass custom style to FormField
      
      * Use null as a default cacheTTLFormField value
      
      * Add tests for DashboardDetailsModal
      
      * Add cache_ttl field to DashboardDetailsModal
      
      * Add tests for CreateDashboardModal
      
      * Test cache_ttl is invisible when creating a dashboard
      
      * Remove not used mocks
      
      * Add tests for EditQuestionInfoModal
      
      * Move question entity forms to own file
      
      * Add cache_ttl field to EditQuestionInfoModal
      
      * Test cache_ttl is invisible when creating a question
      
      * Extract CacheTTLField component
      
      * Don't show cache field if caching is disabled
      
      * Fix typo
      
      * Update cache_ttl field look
      
      * Revert "Pass custom style to FormField"
      
      This reverts commit 3944ca8ff1dcad478f0f1c3a1973f454447c88c1.
      
      * Revert "Make FormField's margin configurable"
      
      This reverts commit ca7dc434532038da736012147f6889e6cc01ec11.
      
      * Fix CacheTTLField width
      
      * Add descriptionPosition prop to FormField
      
      * Add DatabaseCacheTTLField
      
      * Show cache_ttl field on database form
      
      * Use 24h as a default database cache TTL field value
      
      * Fallback to database cache_ttl in question form
      
      * Remove console.log
      
      * Fix request body assertion for CreateDashboardModal
      
      * Fix request body assertions for EditQuestionModal
      
      * Fix request body assertions for DashboardDetailsModal
      
      * Fix cache_ttl not included in `PUT /api/card/:id`
      
      * Use simple for for EditQuestionInfoModal
      
      * Refactor how unit tests mock caching settings
      
      * Add dashboard caching EE test
      
      * Add question caching EE test
      
      * Add caching e2e test for database add/edit
      
      * Remove debug stuff
      
      * Add error state to CacheTTLField
      
      * Fix DB cache field reverts to default value on 0
      
      * Validate cache_ttl field
      
      * Add getQuestionsImplicitCacheTTL helper
      
      * Remove redundant tests
      
      * Remove not used import
      
      * Nomalize `cache_ttl: 0` to null
      
      * Fix duplicated card update request
      
      * Add QuestionCacheTTLField component
      
      * Add test-id to Radio's option names
      
      * Use a new cache TTL field for questions
      
      * Check setting cache_ttl to null in E2E tests
      
      * Style question cache TTL field
      
      * Add dashboard ID to query request body
      
      * Extend `duration` formatting helper to support hours
      
      * Fix default caching duration display
      
      * Fix tests
      
      * Fix old dashboard edit action title
      
      * Fix missing translations
      
      * Add prop types to EditQuestionInfoModal
      
      * Remove `test.todo`
      
      * Simplify `getQuestionsImplicitCacheTTL`
      
      * Use `space` style helper
      
      * Add `key` prop to `jt`
      
      * Move time coverting utils to lib/time
      
      * Hide caching field label if just showing the input
      
      * Fix unit tests
      
      * Fix flacky E2E test
      
      * Add hover style for "More options" control
      
      * Fix missing translation
      
      * Use placeholder for cache inputs
      
      * Fix E2E tests to use cache field's placeholder
      
      * Feature flag for caching UI
      Unverified
      7d6e031b
  23. Sep 16, 2021
  24. Sep 14, 2021
  25. Sep 13, 2021
  26. Sep 10, 2021
  27. Sep 02, 2021
  28. Aug 27, 2021
  29. Aug 24, 2021
Loading