Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 06, 2024
  2. Mar 05, 2024
  3. Feb 29, 2024
  4. Feb 28, 2024
  5. Feb 23, 2024
  6. Feb 20, 2024
    • Uladzimir Havenchyk's avatar
      Rework findColumnIndexForColumnSetting to MLv2 (#37854) · e94ea96a
      Uladzimir Havenchyk authored
      * Rework findColumnIndexForColumnSetting to MLv2
      
      * Throw an error to find all places without query
      
      * Use MLv2 in ChartSettingTable (#38171)
      
      * Add a comment why we can't use mlv2 in chart setting table
      
      * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns
      
      * Tests completed, so revert throwing
      
      * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170)
      
      * Use mlv2 findColumnIndexForColumnSetting in object detail
      
      * Address review
      
      * Use mlv2 findColumnIndexForColumnSetting in Question (#38169)
      
      * Use mlv2 findColumnIndexForColumnSetting in Question
      
      * Update question tests
      
      * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172)
      
      * Use mlv2 findColumnIndexForColumnSetting in Table (#38168)
      
      * Cleanup finColumnSettings usage (#38914)
      
      * Fix linting
      Unverified
      e94ea96a
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
  7. Feb 16, 2024
    • Braden Shepherdson's avatar
      Enable source maps for CLJS in release builds (#38819) · c062ab7f
      Braden Shepherdson authored
      We do this for our JS and TS code. This change configures shadow-cljs to
      emit the source maps in release mode, and bumps the versions of
      shadow-cljs and the transitive dependency `source-maps-js` to enable
      webpack to consume these source maps correctly.
      
      (The output source maps have some quirks, and broke some consumers.
      Mainly that inlining of CLJS functions can result in empty namespaces,
      and while the file contents were correctly inlined,
      `sourceContents: ""` looks falsy in JS. Webpack would try to read the
      nonexistent source files and fail to build.)
      Unverified
      c062ab7f
  8. Feb 08, 2024
  9. Feb 07, 2024
  10. Jan 31, 2024
  11. Jan 29, 2024
    • Anton Kulyk's avatar
      Convert `ExplicitSize` to TypeScript (#38098) · 221ca042
      Anton Kulyk authored
      * Remove `wrapped` arg from `ExplicitSize`
      
      * Remove `AutoExpanding` HOC
      
      * Convert `ExplicitSize` to TypeScript
      
      * Fix `ExplicitSize` mock
      
      * Remove redundant type
      
      * Revert "Remove `wrapped` arg from `ExplicitSize`"
      
      This reverts commit 014bc4c61ae21ff67ae2157c40297f33fd39d95d.
      
      * Fix type
      Unverified
      221ca042
  12. Jan 25, 2024
  13. Jan 24, 2024
    • Denis Berezin's avatar
      Add code diff logic and switch to preview mode (#37155) · 8f0a57ba
      Denis Berezin authored
      * Migrate EmbedModalContent to TS
      
      * Add basic UI changes to Embed modal
      
      * More styling
      
      * Add more styling
      
      * Self review fixes
      
      * Self review fixes
      
      * Fix action button
      
      * Fix unit tests
      
      * Fix e2e tests
      
      * Fix e2e tests
      
      * Code review and design fixes
      
      * Fix unit test
      
      * Add Parameters tab text diff and switch to preview
      
      * Add code diff display logic for appearance tab
      
      * Self review fixes
      
      * Fix e2e tests
      
      * Button text hotfix
      
      * Move state to component, fix diff
      
      * Review fixes, action buttons refactor
      
      * Implement new code diff
      
      * Fix text highlight, fix unit tests
      
      * Code review fixes
      
      * Design review fixes
      
      * New code diff highlight UX
      
      * Remove folding
      
      * Change code diff logic, add automatic client code switch
      
      * Fix code highlight logic
      
      * Add unit tests
      
      * Fix some e2e tests
      
      * Fix e2e tests
      
      * Fix code highlight, parameters diff
      
      * Add code highlight on locked parameter value change
      
      * Add more tests
      
      * Review fixes
      
      * Refactor unit tests
      
      * Rollback preview tab remove, add utm tags
      
      * Fix prettier
      
      * Add interactive modal header with hover
      
      * Review fixes
      
      * Review fixes
      Unverified
      8f0a57ba
    • Nemanja Glumac's avatar
  14. Jan 18, 2024
  15. Jan 15, 2024
  16. Jan 09, 2024
    • Mark Bastian's avatar
      Multiple Cypress Reporters (#37421) · 89cad7b3
      Mark Bastian authored
      * Multiple Cypress Reporters
      
      This PR modifies our Cypress reporter to support multiple reporters, currently pretty mochawesome reports and junit xml files. This was enabled using the [cypress-multi-reporters](https://www.npmjs.com/package/cypress-multi-reporters) reporter. Additional reporters are added via yarn packages:
      - [mocha-junit-reporter](https://www.npmjs.com/package/mocha-junit-reporter)
      - [mochawesome](https://www.npmjs.com/package/mochawesome) which was already installed
      
      One of the biggest challenges here is simply getting the config keys right, primarily `mochaJunitReporterReporterOptions` as opposed to the more sane `mochaJunitReporterOptions`, but I guess that the legacy of Java (:coffee:). Also be aware that `mochawesomeReporterOptions` is NOT the same as `mochaAwesomeReporterOptions` but `mochaJunitReporterReporterOptions` is not `mochJunitReporterReporterOptions` for obvious reasons.
      
      For future reference, note that multiple `mochawesome` reporters are available. Read more [here](https://glebbahmutov.com/blog/the-awesome-battle/) in the event that one of them is mochawesomer than the other and we want to level up.
      
      Closes #37195
      
      * Adding feedback per @iethree.
      
      * Updated lock file
      Unverified
      89cad7b3
  17. Jan 08, 2024
  18. Jan 05, 2024
  19. Dec 27, 2023
  20. Dec 22, 2023
  21. Dec 20, 2023
  22. Dec 13, 2023
  23. Dec 08, 2023
  24. Dec 07, 2023
  25. Dec 04, 2023
  26. Nov 29, 2023
    • Nemanja Glumac's avatar
      Tweak ReplayIO E2E runs (#36138) · b85414cb
      Nemanja Glumac authored
      * Run ReplayIO E2E tests every three hours
      
      * Fix the conditional and run all tests
      
      * Upgrade replay runner to the latest version
      
      * Use unique GitHub run id to tag Replay runs
      
      * Make replay API key available to each run
      
      * Use native replay upload
      
      * Upgrade replay plugin to v1.7.5
      Unverified
      b85414cb
  27. Nov 23, 2023
  28. Nov 22, 2023
  29. Nov 17, 2023
  30. Nov 14, 2023
  31. Nov 10, 2023
Loading