Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 15, 2023
  2. Aug 06, 2023
    • Cam Saul's avatar
      QP: use Malli (#32657) · 18c1b198
      Cam Saul authored
      * QP: use Malli
      
      * Fix schema names
      
      * Fix missing namespaces
      
      * Fix busted stuff
      
      * Simplify the new schema
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * MongoDB fixes :wrench:
      
      * FAST mu/defn
      
      * Malli registry
      
      * Misc fixes
      
      * Some cleanup
      
      * Misc cleanup and test fixes :wrench:
      
      * mu/disable-enforcement
      
      * Test fix
      
      * Fix Cljs version of `disable-enforcement`
      
      * Misc improvements
      
      * Update tests
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Fix busted Malli schema
      
      * PR feedback
      
      * Fix busted schema
      
      * Kondo fixx
      
      * Test fixes :wrench:
      
      * Use Malli version of `describe` now that PR was merged
      
      * Work around https://github.com/metosin/malli/issues/924
      
      * Test fixes :wrench:
      
      * Improvements
      
      * Test fix
      Unverified
      18c1b198
  3. Aug 02, 2023
  4. Jul 11, 2023
    • Nemanja Glumac's avatar
      Overhaul E2E tests token activation logic (#32186) · a54b3dc6
      Nemanja Glumac authored
      
      * Start all tests without a token
      
      * Update tests
      
      * Fix tests in `admin` group
      
      * Fix tests in `dashboard-filters` group
      
      * Fix tests `visualizations` group
      
      * Batch fixes
      
      * Fix database banner snowplow test
      
      * Fix full-app mobile view banner test
      
      * Simplify and remove `isPremiumActive` check
      
      * Fix the helper
      
      * Fix helper to fail fast
      
      * Fix tests
      
      * Ensure token scope is set
      
      * Ensure CYPRESS_ env tokens are present
      
      * Set token only if running Metabase ee
      
      * Improve JSDoc
      
      * Slightly tweak log message
      
      * Update E2E dev guide
      
      * Update cross-version tests
      
      * Remove premium token from Cypress backend setup
      
      * Improve a comment
      
      * Fix test
      
      * Update embedding copy
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Unverified
      a54b3dc6
  5. Jul 04, 2023
  6. Jun 20, 2023
    • Noah Moss's avatar
      Connection impersonation (#30714) · f85ccd77
      Noah Moss authored
      * initial prototype w/out statement count parameter
      
      * new approach
      
      * default-database-role driver method
      
      * migration for connection_impersonations table
      
      * conn impersonation model, API and tests
      
      * impersonation fetch and deletion endpoints
      
      * switch test to t2 with-temp
      
      * read conn impersonation settings from DB
      
      * fix merge issue
      
      * add impersonated key to data perms graph and treat it the same as full self-service access
      
      * include impersonated key in returned permissions graph
      
      * make sure impersonated graph passes StrictDataPerms validation
      
      * fix boolean logic
      
      * make sure impersonated keyword doesnt cause error when deleting gtaps
      
      * clear impersonations as necessary when perms graphs changes
      
      * add impersonation support for postgres
      
      * fix typo
      
      * make sure impersonation updates are a non-lazy seq
      
      * add impersonated-user? fn
      
      * fix impersonation api tests
      
      * fix snippet tests
      
      * fix build & exclude connection impersonations from serialization
      
      * switch a test to use t2.with-temp
      
      * add with-impersonations helper and util tests
      
      * move macro and add a connection impersonation driver-level test for postgres
      
      * fix rebase issue
      
      * more tests and code reorganization
      
      * add snowflake test
      
      * clarify comment
      
      * fix lint errors
      
      * fix final kondo error
      
      * reorganization
      
      * fix one test
      
      * fix lint errors
      
      * revert change to sql_jdbc.execute from bad merge
      
      * make sure perms for all users gets reset after conn impersonation tests
      
      * ignore exceptions when restoring perms
      
      * fix postgres test
      
      * refactor to address bryan's comment
      
      * add note about new methods to database changelog
      
      * driver method refactor
      Unverified
      f85ccd77
    • john-metabase's avatar
    • Cal Herries's avatar
  7. Jun 17, 2023
  8. Jun 13, 2023
    • Kamil Mielnik's avatar
      Respect alphabetical order of collections in "Move" modal (#31355) · 750f1cfe
      Kamil Mielnik authored
      * Remove unused openCollection prop
      
      * Preserve collection sorting given by API in getExpandedCollectionsById
      - Fixes #31294
      
      * Use Collections.getListStatePath() to unhardcode the object path
      
      * Use CollectionId instead of any
      
      * Extract Collections.selectors.getCollectionList
      
      * Convert Collections selectors unit tests to TypeScript
      
      * Remove redundant selector
      
      * Add a unit test for Collections.selectorsgetExpandedCollectionsById
      
      * Use createMockCollection for all test collections
      - Use Partial<Collection> instead of MockCollection type
      
      * Add a test case for non-nested collections
      
      * Rename identifiers
      
      * Add a test suite for snippet collections
      
      * Fix SnippetCollections.selectors.getExpandedCollectionsById
      
      * Refactor tests
      
      * Refactor tests
      
      * Revert unit tests for selectors
      
      * Revert convert selectors to TypeScript
      
      * Add error support to setupCollectionsEndpoints
      
      * Introduce useCollectionsQuery
      
      * Fix tests
      
      * Add unit tests for preserving order of collections in ItemPicker
      
      * Make assertions more semantic
      
      * Allow mocking root collection
      - Make ROOT_COLLECTION object match Collection type
      
      * Add tests for preserving order in snippet collections list
      - fix case with an undefined snippet collections list
      
      * Update test case with data loading necessary for ItemPicker underneath the EditSandboxModal after updating selectors
      
      * Update test case with data loading necessary for ItemPicker underneath the AddToDashSelectDashModal after updating selectors
      
      * Rename useCollectionsQuery to useCollectionListQuery
      
      * Remove leftover fetchMock
      
      * Move error out of setupCollectionsEndpoints
      
      * Fix ModelDetailPage unit tests setup
      
      * Remove leftover fetchMocks
      
      * Revert changes to ROOT_COLLECTION constant
      - use createMockCollection
      
      * Fix typing
      
      * Remove dead link to Source Sans Pro font
      - it caused markdown check to fail during CI, this fixes it
      - it seems that the font has been removed from Google Fonts
      - users can still choose this font in Metabase settings
      - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW
      
      * Fix getExpandedCollectionsById selector
      
      * Revert adding useCollectionListQuery in unit tests
      Unverified
      750f1cfe
  9. Jun 10, 2023
  10. Jun 05, 2023
    • Kyle Doherty's avatar
      Remove styled-system (#31306) · 050b4fd8
      Kyle Doherty authored
      * rip out styled-system usage
      
      * fix yarn type-check errors, replace space properties w/ className equivelants
      
      * find / replace space prop usage [ci skip]
      
      * find / replace use of hover styled-system prop [ci skip]
      
      * account for fontSize usage w/ Text component [ci skip]
      
      * use font-size and weight props for styling text
      
      * fix a few additional uses of color
      
      * fix lint
      
      * fix lint
      
      * fix dumb rebase mistake
      Unverified
      050b4fd8
  11. May 30, 2023
  12. May 23, 2023
    • Nemanja Glumac's avatar
      Stress test E2E flake fixes (#30940) · 0b3e479f
      Nemanja Glumac authored
      * Introduce stress-test E2E workflow
      
      * Explain how to stress-test an E2E flake fix
      
      * Disallow test retries in stress-test mode
      
      * Increase the job timeout
      
      * Re-word the number of times to run the test
      
      * Keep labels casing uniform
      
      * Address review suggestion
      
      * Fix unintentional line break
      
      * Multi-line command fix
      
      * Format the spec path example as code
      Unverified
      0b3e479f
  13. May 18, 2023
    • Kamil Mielnik's avatar
      Improve dev guides (#30823) · 445f7d97
      Kamil Mielnik authored
      * Specify node v16 in engines in package.json
      
      - The project does not work with node v20 yet
      
      * Fix undeclared variable in example snippet
      
      * Update Popover docs
      
      * Update Request mocking docs
      
      * Revert "Specify node v16 in engines in package.json"
      
      This reverts commit 84990e1c7b6956e08dc7b696e81e2888e1cb4537.
      
      - 'yarn build-static-viz' was failing because of this change
      Unverified
      445f7d97
  14. May 17, 2023
  15. May 11, 2023
    • Cal Herries's avatar
      Add `schemas` driver feature (#30536) · 659db87c
      Cal Herries authored
      
      * Add schemas driver feature flag
      
      * Add sql_jdbc schemas test
      
      * Add more general test
      
      * Make schemas feature default to true
      
      * Implement supports? for other drivers
      
      * Add feature to the driver changelog
      
      * Remove redundant schemas from h2
      
      * Spelling fix
      
      Pre-rebase SHA: 8a2c7e0 or 5686b2f
      
      * MySQL does *not* support schemas
      
      * Bad rebase
      
      * Typo?
      
      Co-Authored-By: default avatarTim Macdonald <tim@metabase.com>
      Unverified
      659db87c
  16. May 05, 2023
    • Cal Herries's avatar
      Add GET /api/database/{id}/syncable_schemas endpoint (#30529) · e3211320
      Cal Herries authored
      * Add `include_empty` parameter to GET /api/database/{id}/schemas endpoint
      
      * Reuse filtered-syncable-schemas
      
      * Add schemas driver feature flag
      
      * Add comment
      
      * Add driver specific tests for all-schemas
      
      * Fix kondo
      
      * Revert "Add schemas driver feature flag"
      
      This reverts commit 91474aff84dfb7e47f392de5836c0d18a508b23f.
      
      * Rename to syncable-schemas and create new endpoint
      
      * syncable-schemas default impl
      
      * Update tests
      
      * Add multimethod to driver changelog
      
      * Fix Tamas' suggestions
      Unverified
      e3211320
    • Cal Herries's avatar
      Tidy driver/database-supports? defmethods and remove usage of driver/supports? (#29516) · ea25b693
      Cal Herries authored
      * Tidy database-supports? defmethods
      
      * Fix oracle build
      
      * Fix driver
      
      * Fix typo
      
      * prefer driver/database-supports? instead of driver/supports?
      
      * driver/supports? -> driver/database-supports? in tests
      
      * Fix foreign-key support for sqlite in tests
      
      * supports? -> database-supports?
      
      * `supports?` -> `database-supports?`
      
      * supports? -> database-supports?
      
      * Update supports? docstring
      
      * Fix tests
      
      * Fix test
      
      * Remove unused require
      
      * Add mt/with-everything-store in tests
      
      * fix test
      
      * Fix tests
      
      * Add note in driver changelog
      Unverified
      ea25b693
  17. May 03, 2023
  18. Apr 21, 2023
  19. Apr 07, 2023
  20. Mar 30, 2023
  21. Mar 29, 2023
  22. Mar 28, 2023
  23. Mar 27, 2023
  24. Mar 24, 2023
  25. Mar 08, 2023
  26. Mar 01, 2023
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
      Fix dead link (#28789) · 2a1e37dc
      Nemanja Glumac authored
      Unverified
      2a1e37dc
    • Cam Saul's avatar
      Build script overhaul 2023 (#28767) · 3c980639
      Cam Saul authored
      * Build Script overhaul
      
      * Remove stray deps.edn
      
      * Include :ci profile for build and release tests
      
      * Fix release script
      
      * Update markdown dox
      
      * Update another dox
      
      * Tweakz
      
      * Don't pin new version of data.xml to core project, just for build scripts
      
      * Ignore unrecognized options
      
      * Fix i18n/enumerate
      Unverified
      3c980639
    • Nemanja Glumac's avatar
      [E2E] Regroup and move all related files to the root (#28749) · f71f20e1
      Nemanja Glumac authored
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      Unverified
      f71f20e1
  27. Feb 23, 2023
  28. Feb 20, 2023
    • metamben's avatar
      Mongo joins (#28293) · 32854d3c
      metamben authored
      * Make joins work
      
      * Run fuzzy-field-info-test only against H2
      
      * Set driver/*driver* when performing actions
      
      * Restrict expressions+joins-test to DBs supporting date arithmetics
      
      * Fix ordering of (top level) fields in mongo tables
      
      * Explicitly exclude mongo from tests requiring foreign key support
      
      * Optimize away $sort stage for implicit order-by.
      Unverified
      32854d3c
    • Ryan Laurie's avatar
      Custom Table e2e Tests 5: Simple actions testing (#27989) · cecbdc20
      Ryan Laurie authored
      * add helpers for actions testing
      
      * add basic action execution test
      
      * update add action test
      
      * add tags and documentation for tags
      
      * add tags to model actions spec
      
      * update test for new actions adding flow
      
      * fix merge conflicts
      
      * fix merge conflict again
      
      * address review comments
      
      * make test more reliable
      
      * prettier
      
      * prettier
      Unverified
      cecbdc20
  29. Feb 17, 2023
  30. Feb 16, 2023
Loading