Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 14, 2018
  2. Sep 12, 2018
  3. Sep 11, 2018
  4. Sep 10, 2018
    • Ryan Senior's avatar
      Add UserLocalizedString and SystemLocalizedString for i18n · 96b77169
      Ryan Senior authored
      Currently i18n'd strings that are defined at compile time only return
      english text. This occurs with both system and user locale
      strings. For system locale, the locale can be changed via setting, so
      we can't rely on the JVM locale on startup to be correct as it may
      have changed. For the user locale, it could be different for every
      request.
      
      This commit adds two new `tru` and `trs` macros that have the same
      name as the `puppetlabs.i18n.core` macros (and thus will be extracted
      similarly) but will return a defrecord with a `toString` method. This
      delays the conversion of the english text to the translated text until
      `str` is invoked. All of the code hasn't been flipped to use the new
      i18n macros yet, but this gets it in place and tested for the rest of
      the application to be migrated to.
      
      Fixes #8245
      96b77169
  5. Sep 06, 2018
  6. Aug 31, 2018
    • Ryan Senior's avatar
      Add new flag for BigQuery to use JVM timezone [ci drivers] · 4a1be8a8
      Ryan Senior authored
      This commit adds a flag to allow dates parsed from BigQuery to be
      parsed in the JVM's timezone rather than UTC. By default all BigQuery
      dates are in UTC but it's possible to modify the timezone via a
      function invocation. This flag allows installs that have all of their
      queries modifying the timezone in that way to match the actual and
      expected timezones via setting the JVM's timezone.
      4a1be8a8
  7. Aug 30, 2018
    • Simon Belak's avatar
      Correctly handle JodaTime [ci all] · 51f02503
      Simon Belak authored
      51f02503
    • Ryan Senior's avatar
      Add TaskHistory for storage sync and background task metadata · 921d3751
      Ryan Senior authored
      This adds a new table for storing sync metrics and a quartz task for
      cleaning up old entries in the table.
      
      For now this only stores sync metrics and metadata for the task
      history cleanup task. Going forward our other background tasks would
      store information as well to help with debugging/troubleshooting those
      tasks.
      
      Fixes #7611
      921d3751
    • Ryan Senior's avatar
      core.async take/put ops in `go` blocks use single `!` functions · 048a164f
      Ryan Senior authored
      When using the core async `alts` and `>` functions, they should use
      the single `!` version (i.e. `alts!` and `>!` instead of the `!!`
      version. When using HTTP/2 and a reverse proxy, the multiplexed HTTP/2
      requests get issues to Metabase not as a single connection, but as
      multiple requests at the same time. The combination of those
      simultaneous requests and the incorrect usage of the `core.async`
      functions leads to the query responses not being delivered.
      
      Fixes #8312
      048a164f
  8. Aug 24, 2018
    • Ryan Senior's avatar
      Fix an issue retrying migration failures · 21d1e2c1
      Ryan Senior authored
      The existing code would retry a database migration if it failed. If
      the failure was such that it didn't release the lock, the retry will
      always fail. To make this worse, if the user didn't have Metabase set
      to the WARN log level, they would not see the original exception, but
      only the lock exception.
      
      This commit tries to release the lock if a failure occurs. This will
      cause the real exception to bubble up on subsequent retries rather
      than complaining about the lock.
      21d1e2c1
  9. Aug 22, 2018
    • Ryan Senior's avatar
      Ensure we handle no git Metadata for BQ startup [ci drivers] · 72a6b3fb
      Ryan Senior authored
      When connecting to a Google service, we identify ourselves with a
      string that includes version, hash and branch information. If a user
      downloads a Metabase tarball from Github, it won't have that Git
      metadata and we will throw a NullPointerException on startup.
      
      This commit just ensures we always have a value for that string, even
      when there is no git metadata available.
      
      Fixes #8368
      72a6b3fb
    • Ryan Senior's avatar
      Fix FK remappings with a user included fields clause [ci drivers] · cb11b2ef
      Ryan Senior authored
      Our existing remappings code didn't work when an MBQL fields clause is
      present. Typically that fields clause is populated by the
      `add-implicit` middleware, but that doesn't happens with the user
      included fields.
      
      Fixes #8270
      cb11b2ef
  10. Aug 20, 2018
  11. Aug 17, 2018
  12. Aug 16, 2018
    • Ryan Senior's avatar
      Pulse graphs should skip nil value rows · 1ee398df
      Ryan Senior authored
      Previously an NullPointerException would be thrown if the Pulse was a
      bar graph and the resultset contained a nil value for the x or y
      axis. This commit just omits those rows so that it doesn't fail and
      renders the data it does have.
      
      Fixes #8260
      1ee398df
  13. Aug 15, 2018
  14. Aug 14, 2018
  15. Aug 13, 2018
  16. Aug 09, 2018
  17. Aug 08, 2018
Loading