This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 24, 2024
-
-
Phoomparin Mano authored
-
Denis Berezin authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Rewrite startNewNative helpers * Update existing tests * Fix table hovercards E2E flake * Fix repro 37009 * Update repro 30680 * Add comment * Fix nested question flake * Fix typo
-
adam-james authored
* Embedding Parameter Values set in Tokens work properly when `nil` or empty list Fixes: #40292 If a locked parameter's value is set to `nil` or `[]` in the embedding JWT, we want to treat this as 'no value has been set' on that filter, but we should still run the query as normal. Likewise, any linked filters should still properly derive their values from the unfiltered values of the filter to which they are linked. * when a parameter's value is nil or empty seq, don't include it This is a partial solution as I still need to find the place that's still erroring on the empty list case in terms of the linked parameter's values. * Treat empty list like `nil` for the token param When you're using a filter in the App, it makes intuitive sense that when you've not selected anything from a filter's drop down list (or entered any text, etc.), then the filter is effectively not applied. For token params, we should behave similarly; `nil` and `[]` can both be accepted, and signal that the user intends for that filter to basically NOT apply. This also means we should not pass the constraint to the linked filters, since it errors, but even if it worked, it would return 0 results, making it impossible to properly apply the linked filter at all. So, this change causes empty lists to be treated as nil, AND will remove any parameters with `nil` as a value before being passed to the query processor, which results in the proper behaviour of not having constraints on the linked filter, and having the 'parent' filter not filtering anything. * Embed preview should always use params from the token In making a screenshot, I discovered a slight bug in previews, where if the embed had been previously published, it could pull embedding params from the db that don't match the settings on screen. So, always pull the settings from the token, which updates as the user is making changes in the Preview Embed UI. * for previews, merge the embedding params sources instead * alter 'nil' behaviour to work just as if the key doesn't exist * fix one spot where I was passing maps into set functions * Adjust tests to check for consistent behaviour in dash/qstn embeds * fix an e2e test * fix up last 2 failing e2e tests * add the test case of a locked param having no value set in token * some further e2e changes
-
John Swanson authored
We have N+1 detection for simple hydration methods that checks to see whether the hydration method made any DB queries at all. This makes sense, because a simple hydration method is called on each instance individually - if we make database calls *each time*, we're in trouble. Where this runs into issues is with cached data, where the simple hydration method is populating the cache - e.g. `:can_read` or `:can_write` dereferencing `api/*current-user-permissions-set*`. Currently we specifically exclude those hydration methods from the check. But after running into this again for a different simple hydration method, I think there's a more robust approach: - first, run the hydration method without counting DB queries - then, run it again and make sure we don't make any additional DB queries. There is a potential downside here: if someone wrote a simple hydration method with side effects, they'd potentially be very confused (in development - this doesn't run in prod!) when those side effects happened twice for a single hydration. But I *think* that's fairly unlikely.
-
Alexander Polyankin authored
* Proper fix * Add e2e repro * E2E repro * Update e2e/test/scenarios/models/reproductions.cy.spec.ts Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update e2e/test/scenarios/models/reproductions.cy.spec.ts Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Uladzimir Havenchyk authored
-
Uladzimir Havenchyk authored
* dx: clean output folder before building jar * clean output only in prod mode
-
Nick Fitzpatrick authored
-
github-automation-metabase authored
-
Phoomparin Mano authored
* handle errors when useMetabaseAuthStatus is used outside of sdk context * address review comments feedback * extract useSdkContext * fix import type error
-
Chris Truter authored
-
Nemanja Glumac authored
-
Phoomparin Mano authored
* polyfill useSyncExternalStore for React 17 * adds the shim * use ReactDOM.render instead of createRoot for backwards compat * use createRoot for React 18 environment * refactor renderRoot compatibility * remove semver dependency * add small test for version * use the same check for react 17
-
Chris Truter authored
-
Chris Truter authored
-
Ngoc Khuat authored
-
- Jul 23, 2024
-
-
Cam Saul authored
* Potential Redshift sync flake fix * Make Redshift sync much more robust
-
Noah Moss authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Cal Herries authored
-
Jeff Bruemmer authored
* notes * more notes * edits * update app db page * file-based db mention * anchor link
-
Noah Moss authored
-
Nick Fitzpatrick authored
-
Raphael Krut-Landau authored
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
Alexander Polyankin authored
-
Chris Truter authored
-
Uladzimir Havenchyk authored
* fix webpack refresh in static mode * clean output * revert
-
Ryan Laurie authored
* what does this break? * Revert "what does this break?" This reverts commit 93e09edeb3618db1e992bdda5842ba897cb0bce5. * don't show audit db in permissions
-
use-tusk[bot] authored
Co-authored-by:
use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
-
Nemanja Glumac authored
* Rewrite reproduction for 24223 * Fix test
-
Luis Paolini authored
-
Uladzimir Havenchyk authored
* dx: make fe stress test faster * uncomment * invalidate cache and run in band
-
Chris Truter authored
-
Kamil Mielnik authored
* Add repro for #39487 * Refactor test * Add repro for 'on' filter * Fix metabase#39487 * Refactor test * Change order of tests * Improve assertions * Group tests * Add tests for filter pills * Refactor tests * Rename helpers * Add filter modal tests * Add tests for filter drill * Add notebook tests * Fix test * Add one more repro * Fix typo * Optimize tests * Simplify the fix - apply the fix everywhere - remove fix for width * Update tests * Improve comment * Move min height to Calendar
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
Noah Moss authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Fix the flake for repro 39477 * Expand the repro
-