Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 27, 2021
  2. Sep 24, 2021
  3. Sep 23, 2021
  4. Sep 22, 2021
    • Ariya Hidayat's avatar
    • dpsutton's avatar
      Static Viz Formatting (#17957) · de39de8a
      dpsutton authored
      * Formatting
      
      return a format string so it can be used over multiple rows. The rules
      for formatting are quite annoying because there are defaults that are
      assumed rather than present. IE, if you set a column as currency it
      doesn't set the number style sometimes and defaults to USD without that
      being in the settings. In the future would be far preferable to always
      create a fully fleshed map of defaults rather than inferring them in
      random places.
      
      * appease our doc string supervisor
      
      * Include column information for formatting numbers
      
      really important for requiring two decimal places by default on doubles
      and none on integers. Its close to correct ignoring it and using
      "#,###.##" and this leaves non decimal places on integers and allows
      only up to two on doubles, but things like 31.10 will format as 31.1 and
      that is improper
      
      * Remove unneeded metabase.test
      
      * Update tests with nil column
      
      * Get global viz settings in middleware, pass entire to formatting
      
      Passing the entire viz settings to the formatting stuff makes the
      calling code much simpler and the places where we merge global settings,
      possibly get currency settings, etc, just in one place. We already had
      the col information there so just use it.
      
      * Remove public settings now that we get it from the metadata
      Unverified
      de39de8a
    • Alexander Kiselev's avatar
      Fix #17397 - "Showing first 2000 rows" is always displayed when results are loading (#17954) · 428bbe31
      Alexander Kiselev authored
      * Check for existing result set when displaying
      "Showing [X] rows" instead of the max limit
      
      * added cypress test
      
      * broke up nested ternary operators in QuestionRowCount
      Unverified
      428bbe31
    • Alexander Kiselev's avatar
      Fix #16810: Dashboard "isDirty" property is set to true after the Dashboard... · 1fe1c7a6
      Alexander Kiselev authored
      Fix #16810: Dashboard "isDirty" property is set to true after the Dashboard title is updated. (#17955)
      
      * added isDirty flag to SET_DASHBOARD_ATTRIBUTES action
      
      * added reducer tests for SET_DASHBOARD_ATTRIBUTES with isDirty
      
      * lint
      Unverified
      1fe1c7a6
    • Gustavo Saiani's avatar
Loading