Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 20, 2024
  2. Jul 23, 2024
  3. Jun 10, 2024
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light,... · e8fedf01
      Denis Berezin authored
      feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687)
      
      * Migrate text-brand
      
      * Migrate text-dark
      
      * Migrate text-light
      
      * Migrate text-medium
      
      * Migrate admin-navbar
      
      * make compact formatting consistent across all series (#43472)
      
      * make compact formatting consistent across all series
      
      * fix rebase
      
      * [Browse] Show Browse models link in nav only when there are models (#43286)
      
      * Upgrade to TypeScript v5.4 (#43736)
      
      * use correct github api for CI (#43750)
      
      * update list of releases (#43754)
      
      * Multi Series Dashcards Render with Filters Applied To All Series (#43428)
      
      * Multi Series Dashcards Render with Filters Applied To All Series
      
      Fixes: #39083
      
      Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each
      card in the multi-series card.
      
      * Small refactor for executing dashcards in a pulse context.
      
      - move execute-dashboard-subscription to pulse.util
      - this fn now will also execute all card series cards
        and put those results into a list on the key :series-results in the dashcard
        which is then used in the render multimethod to send the correct data to the javascript context
      
      A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key
      
      * Fix up render fn
      
      The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more
      understandable.
      
      Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes
      
      * pull :data up a level from :result in the series cards
      
      * Update src/metabase/pulse/render/body.clj
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Remove unneeded let
      
      * set/rename-keys won't work here because we raise the :data key
      
      I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data
      from within the result key up to the same level (and dissoc result).
      
      I've renamed the helper function to make its purpose a bit clearer
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Hydrate can_run_adhoc_query and address review comments (#43747)
      
      This is a followup on #43625.
      
      * Consolidate dashboard-card specs (#43716)
      
      * Consolidate joins specs (#43717)
      
      * Update translations for v50 and add Danish Language Support (#43314)
      
      * update translations for v50
      
      * add Danish
      
      * update translations for v50 release
      
      * alphabetical order is nice
      
      * Move database role to url parameters from connection properties on Snowflake (#43602)
      
      * Move role to url parameters from connection properties
      
      * Fix test
      
      * Fix width of save button in cache sidebar (#43755)
      
      * Remove dead code (#43603)
      
      * Combine search e2e specs (#43718)
      
      * Highlight the table cell data in dashboards when the cell is an ID column (#43728)
      
      * highlight id cell column
      
      * add simpletable stories
      
      * add simple table test data
      
      * add loki reference image
      
      * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Remove old repro for 39150 (#43749)
      
      * Fix remaining `tinyint` booleans in MySQL (#43296)
      
      * Correct type for `report_card.dataset`
      
      This was missed in the original migration of boolean types to
      ${boolean.type} in MySQL/MariaDB, and then missed again by me when I
      migrated `collection_preview` over a week ago.
      
      * Change all boolean types to `bit(1)` in MySQL
      
      Liquibase changed their boolean type in MySQL from `bit(1)` to
      `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these
      as booleans, so we needed to migrate them to `bit(1)`s.
      
      As discussed [here](#36964), we
      changed all existing `boolean` types that were in the
      `001_update_migrations.yml` but not the SQL initialization file.
      
      For new installations, this works: things in the SQL initialization file
      get created with the `bit(1)` type.
      
      However, for existing installations, there's a potential issue. Say I'm
      on v42 and am upgrading to v49. In v43, a new `boolean` was added.
      
      In this case, I'll get the `boolean` from the liquibase migration rather
      than from the SQL initialization file, and it need to be changed to a
      `bit(1)`.
      
      I installed Metabase v41 with MySQL, migrated the database, and then
      installed Metabase v49 and migrated again. I made a list of all the
      columns that had the type `tinyint`:
      
      ```
      mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE,        COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test';
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | TABLE_SCHEMA  | TABLE_NAME                   | COLUMN_NAME       | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      | metabase_test | core_user                    | is_datasetnewb    | tinyint     | 1              | NO          |
      | metabase_test | metabase_field               | database_required | tinyint     | 0              | NO          |
      | metabase_test | metabase_fieldvalues         | has_more_values   | tinyint     | 0              | YES         |
      | metabase_test | permissions_group_membership | is_group_manager  | tinyint     | 0              | NO          |
      | metabase_test | persisted_info               | active            | tinyint     | 0              | NO          |
      | metabase_test | report_card                  | dataset           | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline                     | default           | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | archived          | tinyint     | 0              | NO          |
      | metabase_test | timeline_event               | time_matters      | tinyint     | NULL           | NO          |
      +---------------+------------------------------+-------------------+-------------+----------------+-------------+
      10 rows in set (0.01 sec)
      ```
      
      Then wrote migrations. For each column, we:
      
      - turn it into a `bit(1)`,
      
      - re-set the previously existing default value, and
      
      - re-add the NOT NULL constraint, if applicable.
      
      * Change author and add missing `dbms`
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * Add ts-pattern library (#43752)
      
      * Add events to measure search performance (#43135)
      
      * new_search_query event
      
      * Filters in object, search click event
      
      * updating event schema
      
      * type and event schema adjustments
      
      * delete comments BE code
      
      * adjusting tests
      
      * PR feedback
      
      * typos and spacing
      
      * Fixup missing colors
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarAlex Yarosh <alexandra@metabase.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Co-authored-by: default avatarlbrdnk <lbrdnk@users.noreply.github.com>
      Co-authored-by: default avatarPhoomparin Mano <poom@metabase.com>
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      Co-authored-by: default avatarSakuragiYoshimasa <ysrhsp@outlook.com>
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      e8fedf01
  4. Jun 05, 2024
  5. Apr 26, 2024
  6. Apr 11, 2024
  7. Apr 08, 2024
  8. Mar 28, 2024
  9. Mar 19, 2024
  10. Mar 13, 2024
  11. Mar 05, 2024
  12. Mar 04, 2024
  13. Feb 20, 2024
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
  14. Feb 13, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add ESLint rule for Metabase strings (#38553) · 279b3721
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix case where Metabase links are render inside template strings
      
      * Add `no-literal-metabase-strings` ESLint rule
      
      * Fix all Metabase string errors
      
      * Address review: Fix the rule
      
      The rule was checking if we have imported the selector
      `getApplicationName` then ignore all Metabase strings. This is different
      than `no-unconditional-metabase-links-render` because in that rule, when
      fixed the Documentation URLs are still in the file, but in this rule,
      when fixed, there should be no Metabase strings left in the file.
      
      * Fix errors from the new lint rule
      Unverified
      279b3721
  15. Feb 11, 2024
  16. Jan 26, 2024
  17. Jan 22, 2024
    • Nemanja Glumac's avatar
      Migrate `isNative` to MLv2 (#37805) · 2cd8c5fa
      Nemanja Glumac authored
      * Migrate Question `isNative` and `isStructured` methods to MLv2
      
      * Mark methods as deprecated
      
      * Add the guard to the `isNativeDashCard` util
      
      * Add additional guard to the `buildFieldFilterUiParameter` helper
      
      * Update all `isNative` method instances to MLv2
      
      * Fix the negation logic :face_palm:
      
      
      
      * Remove `isNative()` method altogether
      
      * Simplify the `shouldResolveFkField` check
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Remove explicit Boolean conversion
      
      * Simplify conditional logic for `getTargetsForQuestion`
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      2cd8c5fa
  18. Jan 11, 2024
  19. Jan 10, 2024
  20. Jan 08, 2024
  21. Nov 29, 2023
  22. Nov 08, 2023
  23. Nov 02, 2023
  24. Oct 18, 2023
  25. Sep 06, 2023
  26. Aug 28, 2023
  27. Aug 16, 2023
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add more missing translations (#33123) · d239393e
      Mahatthana (Kelvin) Nomsawadi authored
      * Translate admin audit
      
      * Add missing translations in admin audit details
      
      * Translate MappingEditor
      
      * Translate AddMemberRow
      
      * Translate GroupsListing
      
      * Add missing translation in admin collection permission
      
      * Translate MoveCollectionModal
      
      * Translate invite user form
      
      * Translate Table conditional settings select
      
      * Translate date format options
      
      * Format gauge chart settings
      
      * Remove unused audit tables
      
      * Add missing translation
      
      * Don't translate email
      Unverified
      d239393e
  28. Aug 15, 2023
  29. Jun 26, 2023
  30. Jun 09, 2023
  31. Jun 02, 2023
    • Maz Ameli's avatar
      New icons (#31096) · a1b09db0
      Maz Ameli authored
      
      * arrow_left
      
      * check mark
      
      * arrow_up and chevrons
      
      * add, close, contract, embed, expand, sort
      
      * change viewbox to 16
      
      * icons in +New menu, search, and sidebar toggle
      
      * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons
      
      * fix database icon
      
      * ellipsis, person, and tweak ellipsis size in collections sidebar
      
      * home, reference or book, pencil or edit, table
      
      * dashboard action icons, and remove reference to unused ClockIcon.jsx
      
      * question action icons and related component tweaks
      
      * larger icons on HomeModelCard on homepage
      
      * dashboard and add_to_dash
      
      * snippet and variables
      
      * all the chart type icons and some field type ones
      
      * mail and groups
      
      * make sidebar icons darker blue
      
      * fix add-your-data icon
      
      * filled mail icon and use it on events modal
      
      * stars
      
      * bolt and x-rays and a bunch more
      
      * granular, metric, revision history
      
      * arrows, formula, snippets
      
      * click, cloud, boolean, unpin
      
      * return, hourglass, popover
      
      * pause, ldap, burger
      
      * gear info list pin moon sum sun verified warning
      
      * fix size of row details modal icons
      
      * fix size of left nav icons
      
      * fix size on filter widgets and some selects
      
      * set default size to 16 to fix entity menu icons etc
      
      * fix pagination icons
      
      * size and color on ItemPicker
      
      * bump up database icon in /browse to 32px
      
      * /browse bolt icon size
      
      * find and remove instances of 14px size declarations
      
      * sql editor icons
      
      * sql expand/contract button alignment
      
      * collection breadcrumbs
      
      * remove two more size 14 declarations
      
      * viz selector
      
      * fix add icon in New button
      
      * fix size of ModelDetailLink
      
      * icon for question list empty state
      
      * get rid of model_framed icon
      
      * try to fix event tick icons, replace balloons with cake
      
      * standardize size of question footer actions
      
      * fix dinosaur
      
      * switch star_outline to star, and star to star_filled
      
      * fix notebook sort action
      
      * switch data picker from table2 to table
      
      * fix slack icon
      
      * restyle HomeXrayCard
      
      * fix List icon
      
      * fix sidebar toggle icon size
      
      * fix icon size in field picker popovers
      
      * fix summarize sidebar field type icons
      
      * fix summarize sidebar Add buttons
      
      * table heading sort icons
      
      * fix filter icon, resize button icons
      
      * bulk filters icons
      
      * admin datamodel icons sizing
      
      * fix datamodel metric and segment icons, and sort icon
      
      * dashboard interactivity sidebar close icon
      
      * get rid of grabber2
      
      * bookmark and question actions icon sizes
      
      * revert icon
      
      * Icons cleanup (#31147)
      
      * remove timeline event icon stroke
      
      * cleanup
      
      * add 16x16 viewbox to svgs that were missing it
      
      * add slack_colorized
      
      * correct the join_full_outer icon
      
      * timeline events, cleanup
      
      * fix broken icons
      
      * more cleanup
      
      * fix storybook
      
      * fix all types
      
      * add stories
      
      * try fixing arrow_split
      
      ---------
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * fix specs
      
      * fix specs
      
      * remove unused icons
      
      * use constants
      
      * increase node memory allocation
      
      * bump for chromatic too
      
      * fixes
      
      * fix arrow_split icon
      
      * fix arrow_split path attributes
      
      * fix path again and fix sizing of drillthrough menu icons
      
      * more spec fixes
      
      * prettier
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      a1b09db0
  32. May 31, 2023
  33. Mar 28, 2023
    • Ryan Laurie's avatar
      Add Read-Only Notebook View (#29525) · eba6d8d1
      Ryan Laurie authored
      * use read only notebook instead of GUI query editor to view queries
      
      * remove edit formatting elements for readOnly variant
      
      * add unit tests
      
      * add back support for native queries
      
      * update tests
      
      * fix types
      Unverified
      eba6d8d1
  34. Feb 10, 2023
  35. Jan 10, 2023
    • Anton Kulyk's avatar
    • Anton Kulyk's avatar
      Add jest-dom and testing-library eslint plugins (#27577) · 6d3f5925
      Anton Kulyk authored
      * Install and enable plugins
      
      * Run eslint auto fix
      
      * Fix linter issues (part 1)
      
      * Fix Visualization test
      
      * Fix Pie Visualization test
      
      * Add `getIcon` and `queryIcon` helpers
      
      * Fix `VisibilityToggler` tests
      
      * Fix `QuestionActivityTimeline` tests
      
      * Fix formatting tests
      
      * Fix `EntityMenuItem` tests
      
      * Fix `ClampedText` tests
      
      * Fix `ObjectRelationships` tests
      
      * Fix `EmailAttachmentPicker` tests
      
      * Fix `SavedQuestionHeaderButton` tests
      
      * Fix `DatabaseEngineWarning` tests
      
      * Fix `Tooltip` tests
      
      * Fix `TippyPopoverWithTrigger` tests
      
      * Fix `TippyPopover` tests
      
      * Fix `TableLabel` tests
      
      * Fix `TableInfo` tests
      
      * Fix `ModerationStatusIcon` tests
      
      * Fix `Sidebar` tests
      
      * Fix `PermissionSelect` tests
      
      * Fix `PinnedItemCard` tests
      
      * Fix widget tests
      
      * Fix `DimensionSemanticTypeLabel` tests
      
      * Fix `ListSearchField` tests
      
      * Fix `ControlledPopoverWithTrigger` tests
      
      * Fix `FieldFingerprintInfo` tests
      
      * Fix `ErrorActionButton` tests
      
      * Fix `QueryValidationError` tests
      
      * Fix `LineAreaBarRenderer` tests
      
      * Fix `DataSelector` tests
      
      * Fix `PivotTable` tests
      
      * Fix `ItemPicker` tests
      
      * Fix `TokenField` tests
      
      * Fix `TagEditorParam` tests
      
      * Fix tests
      
      * Fix tests
      
      * Run prettier
      
      * Fix tests
      Unverified
      6d3f5925
  36. Dec 07, 2022
Loading