This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Jul 23, 2024
-
-
Ryan Laurie authored
* what does this break? * Revert "what does this break?" This reverts commit 93e09edeb3618db1e992bdda5842ba897cb0bce5. * don't show audit db in permissions
-
- Jun 10, 2024
-
-
Denis Berezin authored
feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687) * Migrate text-brand * Migrate text-dark * Migrate text-light * Migrate text-medium * Migrate admin-navbar * make compact formatting consistent across all series (#43472) * make compact formatting consistent across all series * fix rebase * [Browse] Show Browse models link in nav only when there are models (#43286) * Upgrade to TypeScript v5.4 (#43736) * use correct github api for CI (#43750) * update list of releases (#43754) * Multi Series Dashcards Render with Filters Applied To All Series (#43428) * Multi Series Dashcards Render with Filters Applied To All Series Fixes: #39083 Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each card in the multi-series card. * Small refactor for executing dashcards in a pulse context. - move execute-dashboard-subscription to pulse.util - this fn now will also execute all card series cards and put those results into a list on the key :series-results in the dashcard which is then used in the render multimethod to send the correct data to the javascript context A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key * Fix up render fn The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more understandable. Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes * pull :data up a level from :result in the series cards * Update src/metabase/pulse/render/body.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Remove unneeded let * set/rename-keys won't work here because we raise the :data key I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data from within the result key up to the same level (and dissoc result). I've renamed the helper function to make its purpose a bit clearer --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Hydrate can_run_adhoc_query and address review comments (#43747) This is a followup on #43625. * Consolidate dashboard-card specs (#43716) * Consolidate joins specs (#43717) * Update translations for v50 and add Danish Language Support (#43314) * update translations for v50 * add Danish * update translations for v50 release * alphabetical order is nice * Move database role to url parameters from connection properties on Snowflake (#43602) * Move role to url parameters from connection properties * Fix test * Fix width of save button in cache sidebar (#43755) * Remove dead code (#43603) * Combine search e2e specs (#43718) * Highlight the table cell data in dashboards when the cell is an ID column (#43728) * highlight id cell column * add simpletable stories * add simple table test data * add loki reference image * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Remove old repro for 39150 (#43749) * Fix remaining `tinyint` booleans in MySQL (#43296) * Correct type for `report_card.dataset` This was missed in the original migration of boolean types to ${boolean.type} in MySQL/MariaDB, and then missed again by me when I migrated `collection_preview` over a week ago. * Change all boolean types to `bit(1)` in MySQL Liquibase changed their boolean type in MySQL from `bit(1)` to `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these as booleans, so we needed to migrate them to `bit(1)`s. As discussed [here](#36964), we changed all existing `boolean` types that were in the `001_update_migrations.yml` but not the SQL initialization file. For new installations, this works: things in the SQL initialization file get created with the `bit(1)` type. However, for existing installations, there's a potential issue. Say I'm on v42 and am upgrading to v49. In v43, a new `boolean` was added. In this case, I'll get the `boolean` from the liquibase migration rather than from the SQL initialization file, and it need to be changed to a `bit(1)`. I installed Metabase v41 with MySQL, migrated the database, and then installed Metabase v49 and migrated again. I made a list of all the columns that had the type `tinyint`: ``` mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE, COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test'; +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | TABLE_SCHEMA | TABLE_NAME | COLUMN_NAME | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | metabase_test | core_user | is_datasetnewb | tinyint | 1 | NO | | metabase_test | metabase_field | database_required | tinyint | 0 | NO | | metabase_test | metabase_fieldvalues | has_more_values | tinyint | 0 | YES | | metabase_test | permissions_group_membership | is_group_manager | tinyint | 0 | NO | | metabase_test | persisted_info | active | tinyint | 0 | NO | | metabase_test | report_card | dataset | tinyint | 0 | NO | | metabase_test | timeline | archived | tinyint | 0 | NO | | metabase_test | timeline | default | tinyint | 0 | NO | | metabase_test | timeline_event | archived | tinyint | 0 | NO | | metabase_test | timeline_event | time_matters | tinyint | NULL | NO | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ 10 rows in set (0.01 sec) ``` Then wrote migrations. For each column, we: - turn it into a `bit(1)`, - re-set the previously existing default value, and - re-add the NOT NULL constraint, if applicable. * Change author and add missing `dbms` --------- Co-authored-by:
John Swanson <john.swanson@metabase.com> * Add ts-pattern library (#43752) * Add events to measure search performance (#43135) * new_search_query event * Filters in object, search click event * updating event schema * type and event schema adjustments * delete comments BE code * adjusting tests * PR feedback * typos and spacing * Fixup missing colors --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
SakuragiYoshimasa <ysrhsp@outlook.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Jun 05, 2024
-
-
Denis Berezin authored
* Migrate brand * Migrate brand-light, brand-lighter * Fix unit tests * Code review fixes * Fix CI
-
Denis Berezin authored
* Migrate bg-error * Migrate bg-medium * Migrate bg-night * Migrate bg-white * Migrate border * Fix CI * Fix unit tests * Fix unit tests * Code review fixes * Code review fixes
-
Oisin Coveney authored
-
- Apr 26, 2024
-
-
Ryan Laurie authored
* remove defunct form components * fix lil type errros
-
- Apr 11, 2024
-
-
Oisin Coveney authored
-
- Apr 08, 2024
-
-
Oisin Coveney authored
-
- Mar 28, 2024
-
-
Oisin Coveney authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Mar 19, 2024
-
-
Ryan Laurie authored
* use rtk for auditInfo * destructured hook export * fix rebase * remove unused services definition
-
Oisin Coveney authored
-
- Mar 13, 2024
-
-
Alexander Polyankin authored
* v1 * v1 * v1 * Move sync code * Small refactor
-
- Mar 05, 2024
-
-
Ryan Laurie authored
-
- Mar 04, 2024
-
-
Ryan Laurie authored
-
- Feb 20, 2024
-
-
Kamil Mielnik authored
* Upgrade eslint-plugin-import * Configure import/order rule for consistent, predictable imports * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line" * Ensure imports are in a single block * Move or remove informative comments between import statements * Remove imports-grouping comments * Configure groups - the difference between the default setting is the presence of "internal" group * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies * Move comment to the same line as import * Run "yarn eslint-fix" 5 times - Remaining: 16 problems (16 errors, 0 warnings) * Manually fix imports order in remaining files * Run "yarn prettier" * Fix import * Fix circular dependency * Fix circular dependency * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency) * Re-add accidentally removed code * Fix typing * ESLint
-
- Feb 13, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix case where Metabase links are render inside template strings * Add `no-literal-metabase-strings` ESLint rule * Fix all Metabase string errors * Address review: Fix the rule The rule was checking if we have imported the selector `getApplicationName` then ignore all Metabase strings. This is different than `no-unconditional-metabase-links-render` because in that rule, when fixed the Documentation URLs are still in the file, but in this rule, when fixed, there should be no Metabase strings left in the file. * Fix errors from the new lint rule
-
- Feb 11, 2024
-
-
Nick Fitzpatrick authored
* adding links with hardcoded IDs * add audit-info endpoint * fix perms * Fetching Dashboard IDs from the API * e2e tests * add BE tests * kinda busted * InstanceAnalyticsButton * removing unused file * Update enterprise/backend/src/metabase_enterprise/audit_app/api/user.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Jan 26, 2024
-
-
Uladzimir Havenchyk authored
-
- Jan 22, 2024
-
-
Nemanja Glumac authored
* Migrate Question `isNative` and `isStructured` methods to MLv2 * Mark methods as deprecated * Add the guard to the `isNativeDashCard` util * Add additional guard to the `buildFieldFilterUiParameter` helper * Update all `isNative` method instances to MLv2 * Fix the negation logic
* Remove `isNative()` method altogether * Simplify the `shouldResolveFkField` check Co-authored-by:Kamil Mielnik <kamil@kamilmielnik.com> * Remove explicit Boolean conversion * Simplify conditional logic for `getTargetsForQuestion` --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Jan 11, 2024
-
-
Alexander Polyankin authored
-
- Jan 10, 2024
-
-
Alexander Polyankin authored
-
- Jan 08, 2024
-
-
Alexander Polyankin authored
-
- Nov 29, 2023
-
-
Oleg Gromov authored
* Remove default exports from dashboard/* * Remove dashboard index.js/ts re-exports
-
- Nov 08, 2023
-
-
Noah Moss authored
Co-authored-by:
Ryan Laurie <iethree@gmail.com> Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
- Nov 02, 2023
-
-
Alexander Polyankin authored
-
- Oct 18, 2023
-
-
Cal Herries authored
-
- Sep 06, 2023
-
-
Denis Berezin authored
-
- Aug 28, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix question name not being shown in some cases * Remove export default to conform to the styleguide * Convert EntityName to TypeScript * Fix question name not renderding when using EntityName * Add a test to cover #33192
-
- Aug 16, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Translate admin audit * Add missing translations in admin audit details * Translate MappingEditor * Translate AddMemberRow * Translate GroupsListing * Add missing translation in admin collection permission * Translate MoveCollectionModal * Translate invite user form * Translate Table conditional settings select * Translate date format options * Format gauge chart settings * Remove unused audit tables * Add missing translation * Don't translate email
-
- Aug 15, 2023
-
-
Alexander Polyankin authored
-
- Jun 26, 2023
-
-
Uladzimir Havenchyk authored
* Rename styled jsx to tsx * Migrate styled files from jsx to tsx * Migrate styled files from js to tsx * Migrate enterprise styled files to tsx * Fixup
-
- Jun 09, 2023
-
-
Uladzimir Havenchyk authored
-
- Jun 02, 2023
-
-
Maz Ameli authored
* arrow_left * check mark * arrow_up and chevrons * add, close, contract, embed, expand, sort * change viewbox to 16 * icons in +New menu, search, and sidebar toggle * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons * fix database icon * ellipsis, person, and tweak ellipsis size in collections sidebar * home, reference or book, pencil or edit, table * dashboard action icons, and remove reference to unused ClockIcon.jsx * question action icons and related component tweaks * larger icons on HomeModelCard on homepage * dashboard and add_to_dash * snippet and variables * all the chart type icons and some field type ones * mail and groups * make sidebar icons darker blue * fix add-your-data icon * filled mail icon and use it on events modal * stars * bolt and x-rays and a bunch more * granular, metric, revision history * arrows, formula, snippets * click, cloud, boolean, unpin * return, hourglass, popover * pause, ldap, burger * gear info list pin moon sum sun verified warning * fix size of row details modal icons * fix size of left nav icons * fix size on filter widgets and some selects * set default size to 16 to fix entity menu icons etc * fix pagination icons * size and color on ItemPicker * bump up database icon in /browse to 32px * /browse bolt icon size * find and remove instances of 14px size declarations * sql editor icons * sql expand/contract button alignment * collection breadcrumbs * remove two more size 14 declarations * viz selector * fix add icon in New button * fix size of ModelDetailLink * icon for question list empty state * get rid of model_framed icon * try to fix event tick icons, replace balloons with cake * standardize size of question footer actions * fix dinosaur * switch star_outline to star, and star to star_filled * fix notebook sort action * switch data picker from table2 to table * fix slack icon * restyle HomeXrayCard * fix List icon * fix sidebar toggle icon size * fix icon size in field picker popovers * fix summarize sidebar field type icons * fix summarize sidebar Add buttons * table heading sort icons * fix filter icon, resize button icons * bulk filters icons * admin datamodel icons sizing * fix datamodel metric and segment icons, and sort icon * dashboard interactivity sidebar close icon * get rid of grabber2 * bookmark and question actions icon sizes * revert icon * Icons cleanup (#31147) * remove timeline event icon stroke * cleanup * add 16x16 viewbox to svgs that were missing it * add slack_colorized * correct the join_full_outer icon * timeline events, cleanup * fix broken icons * more cleanup * fix storybook * fix all types * add stories * try fixing arrow_split --------- Co-authored-by:
Maz Ameli <maz@metabase.com> * fix specs * fix specs * remove unused icons * use constants * increase node memory allocation * bump for chromatic too * fixes * fix arrow_split icon * fix arrow_split path attributes * fix path again and fix sizing of drillthrough menu icons * more spec fixes * prettier --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
- May 31, 2023
-
-
Alexander Polyankin authored
-
- Mar 28, 2023
-
-
Ryan Laurie authored
* use read only notebook instead of GUI query editor to view queries * remove edit formatting elements for readOnly variant * add unit tests * add back support for native queries * update tests * fix types
-
- Feb 10, 2023
-
-
Aleksandr Lesnenko authored
-
- Jan 10, 2023
-
-
Anton Kulyk authored
-
Anton Kulyk authored
* Install and enable plugins * Run eslint auto fix * Fix linter issues (part 1) * Fix Visualization test * Fix Pie Visualization test * Add `getIcon` and `queryIcon` helpers * Fix `VisibilityToggler` tests * Fix `QuestionActivityTimeline` tests * Fix formatting tests * Fix `EntityMenuItem` tests * Fix `ClampedText` tests * Fix `ObjectRelationships` tests * Fix `EmailAttachmentPicker` tests * Fix `SavedQuestionHeaderButton` tests * Fix `DatabaseEngineWarning` tests * Fix `Tooltip` tests * Fix `TippyPopoverWithTrigger` tests * Fix `TippyPopover` tests * Fix `TableLabel` tests * Fix `TableInfo` tests * Fix `ModerationStatusIcon` tests * Fix `Sidebar` tests * Fix `PermissionSelect` tests * Fix `PinnedItemCard` tests * Fix widget tests * Fix `DimensionSemanticTypeLabel` tests * Fix `ListSearchField` tests * Fix `ControlledPopoverWithTrigger` tests * Fix `FieldFingerprintInfo` tests * Fix `ErrorActionButton` tests * Fix `QueryValidationError` tests * Fix `LineAreaBarRenderer` tests * Fix `DataSelector` tests * Fix `PivotTable` tests * Fix `ItemPicker` tests * Fix `TokenField` tests * Fix `TagEditorParam` tests * Fix tests * Fix tests * Run prettier * Fix tests
-
- Dec 07, 2022
-
-
Aleksandr Lesnenko authored
* remove TextInput and use core/Input * review
-