This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 05, 2021
-
-
Maz Ameli authored
* restyle the Verify button * remove unused components * make the verify button blue
-
Ariya Hidayat authored
-
Alexander Polyankin authored
-
Howon Lee authored
Fix cache native queries not working (underlying problem is unit conversion actually) (18160) (#18230) Cache TTL is defined in the nice new column things as per hour. The actual cache wanted it in seconds. There wasn't a conversion hours->secs before, which was the underlying illusion that gave rise to #18160 - with a properly set cache ttl the cache works fine. But the cache ttl's weren't getting set to proper values because of that lack of unit conversion. So here's the conversion, hours->secs.
-
Alexander Lesnenko authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Pawit Pornkitprasan authored
* Make webpack output closer to webpack 4 and fix whitelabelling * Fix recently-viewed.cy.spec.js Not sure why it's started failing with this PR, but adding wait for text.
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Oct 04, 2021
-
-
Dalton authored
-
Dalton authored
When all the necessary data hasn't been fetched you can find yourself in stuck in a loop between the invalid state checks in DataSelector's componentDidUpdate method and the skipSteps method. 1. there seems to always be a single schema (the "Everything Else" schema) available on instantiation 2. the skipSteps method auto-selects this schema when no other schemas exist 3. there's some pre-existing logic to avoid getting in this loop by checking the is_saved_questions property of the database in the selectedSchema. However, for whatever reason this property doesn't exist until AFTER we've fetched some things. The fix is checking a property that is guaranteed to exist, the ID for the "Everything Else" database
-
Cam Saul authored
-
Ariya Hidayat authored
-
Noah Moss authored
-
Alexander Lesnenko authored
-
Alexander Polyankin authored
-
Ariya Hidayat authored
NODE_ENV interferes with other tools (e.g. `yarn` won't pull devDependencies). Since what we need is only a flag indicating Webpack to bundle for production vs developement, invent our own env. This also solves the mystery of unable to call `yarn build` in the build script `bin/build-mb/src/build.clj`.
-
- Oct 03, 2021
-
-
Pawit Pornkitprasan authored
Co-authored-by:
Justin McCarthy <justin@strongdm.com>
-
Ariya Hidayat authored
-
- Oct 01, 2021
-
-
Alexander Lesnenko authored
* Show hidden tables permissions, load tables only when needed * fix padding * remove loader div wrapper * remove redundant wrappers
-
Dalton authored
Fetch and use fields associated with a parameter to parse parameter values found in URL query (#18104) * move logic in dashboard selectors to meta/Dashboard * rmv usage of syncQueryParamsWithURL * add syncQueryParamsWithURL logic to meta/Parameters.js * Fix public questions * fix dashboards * fix query builder * don't normalize when value is empty string * rmv unused setMultipleParameterValues fn * replace selector logic with meta/Dashboard fn * filter out nil fields we need to do more work before we can properly use fields from nested questions when parsing parameter values. * add field to dash parameter so we can correctly type nested native query fields * fix tests * code style tweaks per review
-
Nemanja Glumac authored
* Create `mysql-8` snapshot * Use `mysql-8` snapshot in tests * Extract repro for #15342 * Relocate mysql `add` spec * Extract mysql GUI query tests * Relocate mysql `query` spec * Extract repro for #12445 * Remove `metabase-db` from Cypress * Update Cypress README
-
Noah Moss authored
-
Nemanja Glumac authored
* Create `mongo-4` snapshot * Use `mongo-4` snapshot in tests * Restore and authenticate * Relocate mongo `line` spec * Relocate mongo `native` spec * Relocate mongo `add` spec * Extract repro for #13097 * Relocate mongo `query` spec * Remove mongo from `metabase-db`
-
Nemanja Glumac authored
- a56b640d broke Percy workflow on master and introduced a major inconvenience for developers who wish to run Cypress locally. In both cases, it's required to have all supported QA DB docker images running at all times. Otherwise, the Cypress snapshot creation phase breaks. This PR: - uses the existing ENV var to conditionally skip qa db snapshots - this doesn't affect CircleCI workflow - it merely makes life easier for developers running Cypress locally and for a Percy workflow that runs on GitHub Actions (where we still don't have QA docker images available)
-
Alexander Polyankin authored
-
- Sep 30, 2021
-
-
Jeff Evans authored
Add `escape-alias` multimethod to `sql.qp` to handle translating an alias (whether for a field or expression) into something supported by the driver in quesion Add default impl that is essentially identity Marking `sql.qp/field->alias` as deprecated, and changing its default implementation to invoke the new `sql.qp/escape-alias` on the field's `:name` (with the intention of removing it in a future release, since individual driver won't need to override this, so much as they'll need to override `escape-alias` itself). Override `sql.qp/escape-alias` method for both BigQuery drivers to run through the same `->valid-field-identifier` function already defined for this purpose Add test for a custom expression with weird characters
-
Nemanja Glumac authored
Closes #18168.
-
Nemanja Glumac authored
* Create `postgres-12` snapshot * Use `postgres-12` snapshot in tests * Relocate postgres `add` spec * Relocate postgres `sandboxes` spec * Relocate postgres `native` spec This actually didn't have anything to do with the native questions. We simply used native editor because it was easier to reproduce the issue. * Relocate postgres `permissions` spec * Relocate postgres `query` spec * Relocate postgres `custom-column` spec * Remove postgres from `metabase-db`
-
Alexander Lesnenko authored
-
Howon Lee authored
There is a problem when there are no card ids for a userland query (so not all userland queries are non-adhoc queries: they can be adhoc), where viewlog needs a card id so it chokes. Just adds a check so it doesn't even try to emit a viewlog, since the auditing is for non-adhoc queries only.
-
Gustavo Saiani authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Sep 29, 2021
-
-
Jeff Evans authored
Check feature flag on backend /graph PUT API for block permission Check for the `:advanced-permissions` flag in `update-db-permissions!`, when a `:schemas` `:block` entry is present in the graph Set feature flag in tests when using API Add new test to ensure failure in the case that feature flag is missing
-