* group by "pivot-grouping" column

* update row order in tests

* fix tests

* fix assertion for successful response

* set up question without UI

* eslint

* random attempt to fix test before I set things up locally

* switch to other table 



* pr feedback [ci all]

* whoops! keyboard macro gone wrong [ci all]

* forgot to update a test [ci all]

* another test [ci all]

* put number in right place [ci all]

* Fixing up the errors on PostgreSQL (and other SQL databases)

Also ensuring tests run against drivers that support both expressions
and left-joins

[ci all]

* fixing test failures

* On Oracle and Snowflake, we need to add IDs *and* insert in smaller
batches

* Do not run these tests on Redshift

it takes more than 10 minutes just to insert the sample-dataset into
Redshift, so do not run these tests against Redshift. All other
databases in the `applicable-drivers` def are valid though.

Co-authored-by: Robert Roland <rob@metabase.com>

https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/about-code-scanning

* Infer source_metadata when saving/updating a Card

* Test fixes 

* Constraint sandboxing queries (rebased on infer-source-metadata-when-saving-card)

* extract SearchBar

* move to components dir

* better constant name

* tweak invite email styling

* scrap border on button

* extract 'NormalItem' into own component

* extract CollectionCopyEntityModal

* extract CollectionSectionHeading

* extract CollectionEditMenu

* fix imports on CollectionEditMenu

* move pinned items to own component

* pass actions to pinned items

* pass component properly

* extract BulkActions

* move modals into bulk actions

* extract main collection items

* pass onMove and onCopy

* remove unused dashboard modal

* extract header into own component

* clean up imports

* organize imports

* fix sneaky dnd import

This completes one step towards removing Enzyme.
The complete list of all tests is at #13657.

* Run each test in isolation

* Convert `EditUserModal.integ.spec.js` to Cypress

* Convert `PeopleListingApp.integ.spec.js` to Cypress

* Convert `GroupDetailApp.integ.spec.js` to Cypress

* Delete `GroupsListingApp.integ.spec.js`

It was already covered in Cypress.

* Delete `NewUserModal.integ.spec.js`

It was already covered in Cypress.

* Convert `UserActivationModal.integ.spec.js`

* Convert `UserPasswordResetModal.integ.spec.js`

* Convert `UserSettings.integ.spec.js`

* Remove integration tests

* Remove integration tests from CI

* Fix linter errors

* Delete `AuditTable.integ.spec.jsx`

* Clean up `people.cy.spec.js`

* Update assertion that makes sure XHR didn't happen

* Remove redundant command from PR template

Note: `yarn-lint` already runs `yarn flow`.
https://github.com/metabase/metabase/pull/14174#discussion_r549790198

* Remove explicit mention of timezones in `developers-guide.md`

* new add-folder icon

* prettier

* move BrowseApp into own directory

* extract browse app containers, use functions instead of classes

* remove duplicate table loader, organize import

* move filter and update import

* add back filter bar

* add logic for when to show filters

* show heading if not showing filters

* use unpinned to determine item label

* Update frontend/src/metabase/collections/containers/CollectionContent.jsx

Co-authored-by: Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>

* clean up how we handle the dynamic filter name

* content item border + spacing tweaks

Co-authored-by: Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>

* Better safe than sorry: really check only the hostname

Thus, avoid matching for "openstreetmap.org" in any other parts of the URL.
https://codeql.github.com/codeql-query-help/javascript/js-incomplete-url-substring-sanitization/

* Guard against a potentially invalid map tile URL

This automatically adds "noreferrer noopener", which is important for
security: https://web.dev/external-anchors-use-rel-noopener/.

* basic multi-level pivoting [ci skip]

* better code to get rows

* multiple value columns, other fixes

* fix pivot table unit tests now that values are formatted

* Pivot table column settings (#13760)

* Pivot table virtualization (#13879)

* add pivot table icon

* Dashboard subscriptions work, squashed

This test namespace differs in EE and OSS

Without other changes from EE, this won't work

so, for now, I've restored the pure OSS version of this test

redo wording on existing subscription cards

hacks? to address some timing issues where the render loop executes
before properties are available (loaded from the server)

links to configure pulse types

Display a link to configure email or slack when they aren't already

Fix the am/pm picker

set up a new schedule tooltip

The sidebar can appear and disappear from the Sharing popover

run prettier on everything

email recipients now does the "name [and n other]" thing

Dashboard subscriptions work, squashed

redo wording on existing subscription cards

hacks? to address some timing issues where the render loop executes
before properties are available (loaded from the server)

styling for email not configured state

add styling for slack unconfigured state

disable cursor-pointer if email or slack isn't configured

Implement cancel button for the sidebar (#13741)

Dashboard subscription UX enhancements:

* Implement cancel button for the sidebar

* Don't return duplicate dashboard subscriptions

* Move sidebar cancellation into Redux

* Add close icon

* Fix popover behavior

Dashboard Subscriptions: Fix build (#13859)

* Frontend lint fixes

* Fix failing email tests

* Revert some of the snapshot changes

* regenerate snapshots

* done fixing FE tests?

* Make `dashboard_card_id` optional in CardRef schema

* Fix test setup in pulse model test

* Fix collection API test

* Order pulses by name

* Cypress fixes/skips

Co-authored-by: Paul Rosenzweig <paul.a.rosenzweig@gmail.com>

Subscribe to dashboards send test email (#13886)

* Frontend lint fixes

* Fix failing email tests

* Revert some of the snapshot changes

* regenerate snapshots

* done fixing FE tests?

* Make `dashboard_card_id` optional in CardRef schema

* Fix test setup in pulse model test

* Fix collection API test

* Order pulses by name

* Cypress fixes/skips

* uggh cypress

* Add button to send test email for dashboard subscriptions

* Disable test email with no recipients

* Refactor SendTestEmail

Co-authored-by: Paul Rosenzweig <paul.a.rosenzweig@gmail.com>

Fix failing collection tests (#13891)

* Move dashboard embedding button (#13928)

* PoC of a basic waterfall renderer (#13661) (#13812)

* PoC of a basic waterfall renderer (#13661)

* Ensure that waterfall bars are not razor-thin

* Assume the data is already in the form of increases & decreases

* Waterfall chart: show the correct series values (positives and negatives) (#13661) (#13824)

* Waterfall chart: show the correct series values (positives and negatives)

Also, position the value labels properly (horizontally centered).

* Waterfall: fix the vertical posiition of series values

* Refactor the detection of bar or waterfall display

* Waterfall: add the total bar (#13862)

* Waterfall: add the total bar

This is carried out by adding a new row in the chart series.

* Fix string for translation

* Fix reducer when calculating the total sum

* Fix the position of the value label for the total bar

* Use _.each and array spread operator

* Prepare the total bar for waterfall without mutating the series data

* Waterfall: Refactor stacked bar computation to fix for negative values (#13893)

* Waterfall: Refactor stacked bar computation to fix for negative values

This also simplifies the renderer, as most of the usual logic for
stacked bar can be reused for waterfall.

* Simplify computing waterfall values using Array#reduce

* Add some unit tests for the waterfall renderer (#13909)

* Waterfall: Ensure the correct tooltip and value label for the total (#13907)

* Waterfall setting show/hide the total bar (#13919)

* add waterfall icon

* Waterfall settings: color settings for increases, decreases, total (#13931)

* Waterfall settings: color widgets for increases, decreases, total

* Compactify the color settings for waterfall

* Waterfall colors: apply the increase & decrease colors

* Move waterfall coloring to setChartColor()

* Separate waterfall's total into its own (in the virtual stacked bars)

This makes it easy to color the total bar, which has a value only for
the last one in the series anyway

* Waterfall total color should be conditional on the total toggle

* Hide the regular series color widgets for waterfall charts. (#13951)

Since the waterfall rendering only uses the increase, decrease, and
total colors, there is no need to let the user pick the regular series
colors.

* add some strings that aren't in the UI yet (#13963)

* update translations

* remove all the extra newlines blerg

* check out unmodified dashboard.clj model

* reset two unrelated files

Co-authored-by: Paul Rosenzweig <paul.a.rosenzweig@gmail.com>
Co-authored-by: Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
Co-authored-by: Robert Roland <rob@metabase.com>
Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Co-authored-by: Ariya Hidayat <ariya.hidayat@gmail.com>
Co-authored-by: Reza Lotun <reza@lotun.ca>

* switch to srcset on GTAPModal

* switch to srcset on SettingsSlackForm

* switch to srcset on AlertModals

* switch to srcset on Table

* switch to srcset on WhatsAPulse

* switch to srcset on SharingPane

* switch to srcset on Overworld

* switch to srcSet on Icon

* switch to srcSet on EmbeddingLevel

* remove react-retina-image package

* remove single use of system components

* update snapshots

Co-authored-by: Paul Rosenzweig <paul.a.rosenzweig@gmail.com>

https://codeql.github.com/codeql-query-help/javascript/js-useless-regexp-character-escape/

* apply proper classes when sharing sidebar is open

* add isSharing type

* switch to overflow-y-auto, instead of scroll

Create SECURITY.md

Point README.md to SECURITY.md to avoid duplicated information, and
removed the explicit version table in SECURITY.md to make it easier to
keep up to date.

* try overwriting formatting action entry

* add a guard and clean up some unrelated conditionals

* fix click action update

* flow undefined check

Co-authored-by: Paul Rosenzweig <paul.a.rosenzweig@gmail.com>

* Run each test in isolation

* Add repro for #14124

The bug was fixed in #14096

Reported failing in Postgres, Redshift and BigQuery.

* change default Total color to blue

* change gray in color picker to text-dark

* whoops I meant text-dark

* Add aria roles to our custom checkbox

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role

* Enable keyboard interactions on checkbox

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role#Keyboard_interactions

* Make checkbox's own events work within `FilterOptions.jsx`

Note: Checkbox's own `onClick()` is enabled ONLY if there is `onChange()` prop.

* Update unit snapshots

* add new dashboard icons

* update snapshots

* slightly larger ellipsis icon