This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 10, 2023
-
-
Cam Saul authored
* Support Honey SQL 2 for SQL QP * Sort namespace * Make Postgres/Redshift be Honey SQL 2-only * Test fix
* Fix busted * Redshift test fixes * Sort namespaces * Fix Postgres convert_timezone * Fix linter config. * Fix one last test failure * Redshift test fix * Test fixes and some extra validation etc. * Update common.clj * Update common.clj * Update common.clj -
Jeff Bruemmer authored
* update description * update api docs with script
-
Ngoc Khuat authored
* Better API error message for malli schemas * add tests * fix failed test * fix the backward tests * add api localized error message test * add require and fix test
-
Mark Bastian authored
`/api/collection/root/items` now adds `personal_owner_id` to collection results.
-
Cal Herries authored
* Create select-action * Rename to select-actions * Remove comments * Remove unnecessary () * Missed one * Fix GET /action/:uuid * Use new fns more * Fix * Remove select-action-without-implicit-params, we don't need it
-
Cam Saul authored
* Enable Kondo `:warn-on-reflection` linter * Enable warnings for metabase.api.setting-test * Add warn-on-reflection to metabase.util.jvm
-
Braden Shepherdson authored
Some JVM-specific functions are now in `metabase.util.jvm`, but they are re-exported (in CLJ) by `metabase.util`.
-
- Feb 09, 2023
-
-
Cam Saul authored
-
Case Nelson authored
-
Noah Moss authored
* allow untranslated setting descriptions in tests * tweaks
-
Ngoc Khuat authored
-
Mark Bastian authored
Upgrade to Jetty 11 via https://github.com/sunng87/ring-jetty9-adapter. Required updating from javax servlet packages to jakarta, since jakarta is newer.
-
- Feb 08, 2023
-
-
Case Nelson authored
* Adding support for timezone awareness to mongo * Remove unused ddl multimethod * Remove mongo from the sql driver type test * Fix tests and linters * Add test for filtering datetimes by date in timezone * Use test-data-with-timezones dataset as it should load in more dbs * Exclude broken drivers, vertica especially returns no rows * Address pr review, add timezone to isodate, include a full year of dates in the general timezone test * Assert against each row * Presto-jdbc year was not applying timezone
-
Tim Macdonald authored
-
Braden Shepherdson authored
Includes much-improved testing for the logger in CLJ and CLJS. **This moves us from explicit `shadow-cljs.edn` dependencies to relying on deps.edn for everything. It seems to be working nicely.
-
Ngoc Khuat authored
-
Cam Saul authored
-
- Feb 07, 2023
-
-
Braden Shepherdson authored
This has the same interface as `clojure.tools.logging` but supports CLJS as well. It was formerly known as `metabase.shared.util.log`.
-
Bryan Maass authored
* handle nil return schemas for docstring gen * adds more mu/defn docstring generation tests
-
Cal Herries authored
* Whitespace * Add Action to entities list * Add entity_id column migration * Correct migration ids * Add entity-id property to action model * Extract and serdes-dependencies for action * storage for Action * ingest for Action * Generate for Action * load for Action * Remove comment * Add entity_id to action submodels * Add submodels to copy entities * Add submodels to exported-models * Add submodels to legal-top-level-paths * Slufigy extracted label for action * Extract for QueryAction * Generate query_action * Fix query_action extract test * Add action subtype extract tests * Update Action-subtype-IModel-impl docstring * Generate ImplicitAction and HTTPAction * Export and Import action_id FK with dashcards * Generate nano-id * Add load tests to e2e test * Nest subtypes directories in actions * Remove prn * Add docstring * Fix copy * Add select-action fn * Change extract tests to only extract Action model * Update action/select-one tests * Update legal-top-level-paths * Rename select-action -> select-one * Implement extract-one for Action only, not subtypes * Move subtype models from exported to inlined * Remove entity_id from subtypes * Reuse type->model * Ingest Action with inlined subtype info * Fix serdes-dependencies for Action * Add action to serdes-descendants for Dashboard * Add docstring to action update! * Reuse update! for PUT API * Add missing ns * Remove serdes-generate-path impl * Tidy * Sort ns * Restore add-entity-id * Update entity_id_test * Undo refactor * Include id in action arg for update! * Delete action, with delete cascading to the subtype * Fix clj-kondo warning * Fix returning nil Action in dashboard serdes-descendants * Braden's suggestions
-
Tim Macdonald authored
* Log a warning when extraneous parameters are passed into a request * Massive Metabase logging performance improvement: use configured log levels in logs API endpoint --------- Co-authored-by:
Cam Saul <github@camsaul.com>
-
- Feb 06, 2023
-
-
Noah Moss authored
* rework sandbox enforcement to use sandboxes table as source of truth * remove test that no longer reflects expected behavior * cleanup & refactor * clarify docstring * update segmented-user? to use new helper functions * fix tests * address comments
-
metamben authored
-
Bryan Maass authored
mu/defn now prepends docstrings onto functions, the way prismatic schema does. * prepend docstring with m.schema annotation * refinement of alignment * fix typo in docstring
-
Cal Herries authored
* Add public_uuid and made_public_by_id to actions table & endpoints to enable/disable the public sharing on individual actions (#27721) * Add migration for public_uuid (indexed) and made_public_by_id * Add UUIDString schema * Add endpoints for enabling/disabling sharing of actions * Test that the new fields are returned with `GET /api/action/:id` * Remove validCheckSum on migration * Remove trailing whitespace * Fix DELETE test * Fix tests * Please migration linter * Update the default public_uuid every test run * Please migration linter * Add FK onDelete cascade * Replace ü * Add GET endpoint and post-select for action * Revert "Add GET endpoint and post-select for action" This reverts commit 8cc8b57d6034146dd726b54bc4199830ec1fda21. * Fix merge * Reorder migrations * Update test for GET `api/action?model-id=<id>` endpoint to include public sharing keys (#27802) * Add GET: /api/public/action/:uuid endpoint (#27781) * Add test * Remove non-public columns and check for 404 * Fix docstring * Rename for clarity * Fix missing ns * Remove unneccessary keys from action * Update test * Remove unused refer * Reorder migrations * Use mt * Add require and refactor * Use mt * Add endpoint for executing a public action (#27793) * Add endpoint and test * Add more tests and TODOs * Use mt * Reorder migrations * Remove unused require * Rate limit actions at 1 per second * Fix the tests for the throttle * Refactor tests * Fix test * Fix docstring * Add test for failed execution if actions are disabled * Use crowberto in tests * Fix using crowberto in tests * Fix cyclic load dependency * Refactor ActionCreator (#27832) * Refactor make ActionCreator more sane * Render sidebar conditionally with JS rather than hiding it in CSS * Make action public (#27809) * Move action creator action buttons to the header following design * Remove double border which make it looks thicker * Draft toggle action public * Add confirmation when disabling public link similiar to questions and dashboards * Add an action public UUID input and copy button * Show action settings based on user permission * Add public action toggle tests * Remove unused import
* Attempt to fix flaky CI unit tests The problem seems to be because of how long it takes for the response to be received even on unit tests, it took longer than 1 second which is the default timeout for `waitFor`. * See if not using `userEvent` could make the involving nock faster * Improve test speed to reduce flakiness * Add public action page (#27747) * Add basic public action page * Add form submit logic placeholder * Use "Submit" as default action form's button label * Add "big" variant to `EmbedFrame's` footer * Use new footer variant for action page * Break down the page, add document title * Handle long forms better * Add `PublicWritebackAction` type * Use public action GET endpoint * Add endpoint to execute public actions * Use action execution endpoint * Add tests * Handle actions without parameters * Rename variant prop * Replace `waitFor` with `findBy` * Define `FooterVariant` type * Fix router setup in `renderWithProviders` * Show which action is publicly accessible on model detail page (#28039) * Bring e2e tests back Manually bringing back tests added in: https://github.com/metabase/metabase/pull/28056 * Update typo Co-authored-by:Tim Macdonald <tim@metabase.com> * Remove TODO and use malli for defendpoint * Add malli schema for endpoints * Update permissions checks for POST and DELETE --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Ngoc Khuat authored
* makes sure snowplow tracking for taskhistory does not exceeds the 2048 limit * explains why 2048 limit is needed and return nil instead of empty string
-
- Feb 02, 2023
-
-
Ngoc Khuat authored
deduplicates values returned from multiple fields and use malli for API schema
-
Nemanja Glumac authored
This reverts commit dca5f441.
-
Mark Bastian authored
Added logic to select only collections for a user that are public or their own. Note that original CTE logic was rewritten as inline queries as MySQL5.7 doesn't support CTEs.
-
Bryan Maass authored
insert next-gen permission paths alongside currently active permission paths + classification (#27911) * implement move, which returns v2 paths - TODO: insert these into the db (move v1-path) => [v2 paths] * cleanup + add some schemas * generative tests 4 permission path classification * whitespace lint * detect data, query, and paths for v2 * calling move on v2 paths is a no-op * differentiate between v1 and v2 permissions quickchecking for move, classify-path, and classify-data-path * fix tests + add idempotency test * add tests for classification of permission paths - rename move to ->v2-path - move some fxns around - ascii art in test * making the legos line up - need to insert both v1 and v2 versions of paths (of course) - valid-path? has to allow v2 paths to be inserted * replace mu/with-api-error-message * linter + code quality fixes * privatize rx->kind * remove some changes that should be 4 anotherbranch * revert ns * delete v2 permissions in - they aren't handled by the perm graph parser, so they don't get propagated into "old graph", so the diff between old and new indicates that they need to be rewritten. * only delete v2 paths for the current group_id - reorder declarations in models.permissions * remove extra line break * Update src/metabase/models/permissions.clj fix typo Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Mark Bastian authored
Added bans for print and friends. Fixed issues in kondo config where a macroexpansion put in a print by replacing with (constantly nil) as a no-op.
-
- Feb 01, 2023
-
-
Cam Saul authored
* Switch Audit App to Honey SQL 2 * Compile using Honey SQL 2 * Mark some more tests as ^:parallel * Remove unused namespace * Backport sql.qp/current-datetime-honeysql-form :mysql Honey SQL 2 support * Add `hx/call` and `hx/raw` * Update enterprise/backend/src/metabase_enterprise/audit_app/pages/common.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * `#schema` => `#hawk/schema` * Mark `metabase.async.streaming-response-test` as `^:mb/once` --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metamben authored
-
Ngoc Khuat authored
-
Noah Moss authored
* initial migrations * autofill permission_id when adding new sandbox * use new table name in backend code * add test for migration * fix migration lint errors * WIP fix tests * small cleanup * use CONCAT to fix migration on mysql * break out fk constraint into a separate migration * address feedback
-
Noah Moss authored
* fix GET api/session endpoint for settings managers * fix test
-
Ngoc Khuat authored
Parameter with source is a card: - deduplicates values - remove null/empty values - properly search number
-
Tim Macdonald authored
-
Cam Saul authored
* Switch to the new Hawk test runner * Fix some stuff * Fix everything * Commentz * Bump init timeout? * Fix Kondo config * Remove unused * Bump test runner version to get `:exclude-tags` support
-
- Jan 31, 2023
-
-
Mark Bastian authored
Removed pulses from search API and corresponding tests. There _may_ be cruft tied to pulse search elsewhere because we can't blindly remove pulses yet (need to provide legacy support at the model level), but I think I got it all.
-