Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 01, 2023
  2. Jan 31, 2023
  3. Jan 30, 2023
  4. Jan 27, 2023
  5. Jan 26, 2023
  6. Jan 24, 2023
  7. Jan 23, 2023
  8. Jan 20, 2023
  9. Jan 19, 2023
  10. Jan 18, 2023
  11. Jan 17, 2023
  12. Jan 16, 2023
  13. Jan 13, 2023
  14. Jan 12, 2023
    • Bryan Maass's avatar
      malli describe fixes (#27602) · 69f49f05
      Bryan Maass authored
      * updates + updates tests
      
      - use titles for everything
      - repeat "sounds" right
      - biding time to remerge upstream
      
      * Update src/metabase/util/malli/describe.clj
      
      * pluralize times ouhgt to be private
      
      * keep error messages in tests in sync :neutral_face:
      
      * linter newline
      Unverified
      69f49f05
    • dpsutton's avatar
      restore aliases before annotating (#27637) · 3ddce607
      dpsutton authored
      * restore aliases before annotating
      
      * cleanup
      
      * fix tests
      
      * Don't add escaped->original if aliases have not changed
      
      No need to walk and replace the aliases if they are identical. And in
      that case, no need to keep a mapping of identical to identical. Not
      super important but saves some time and complexity, and keeps other
      tests passing since the presence of [:info :alias/escaped->original] in
      the query caused them to trivially fail.
      
      * oracle has a smaller limit and _expected_ mangled
      
      previous testing behavior was "what happened" and not what should
      happen. we fixed the bug but the "expect garbage" behavior was still
      present
      
      * Relax :alias/escaped->original schema
      
      oracle tests use keywords for the alias
      
      ```clojure
      {:alias/escaped->original
       {:test-data-venues--via-a763718f "test_data_venues__via__venue_id",
        :test-data-users--via--user-id "test_data_users__via__user_id"}}}
      ```
      
      No idea why that is keyworded
      
      * relax `:alias/escaped->original` schema
      
      see previous commit
      Unverified
      3ddce607
  15. Jan 11, 2023
Loading