Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 17, 2020
  2. Nov 13, 2020
  3. Nov 12, 2020
  4. Nov 11, 2020
  5. Nov 10, 2020
  6. Nov 09, 2020
  7. Nov 07, 2020
  8. Nov 06, 2020
  9. Nov 05, 2020
    • Damon P. Cortesi's avatar
    • Nemanja Glumac's avatar
      Fix `settings/settings.cy.spec.js` flakes (#13701) · c97869d0
      Nemanja Glumac authored
      - isolated flake (`it.only("should surface an error when validation for any field fails (metabase#4506)", () => {...})`) passed 10x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348275781)
      - the whole spec passed 20x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348306177)
      Unverified
      c97869d0
    • Ariya Hidayat's avatar
      CI: Fix the cache key for uberjar for running smoketest (#13698) · 2f01ac96
      Ariya Hidayat authored
      Smoketest for OSS edition (for now)
      Unverified
      2f01ac96
    • Ariya Hidayat's avatar
    • Damon P. Cortesi's avatar
      Add a circleci workflow that runs a set of Cypress smoketests (#12775) · 836af536
      Damon P. Cortesi authored
      
      * Add a circleci nightly workflow that runs a bigger set of Cypress smoketests
      
      * Run this every hour while we're testing it, add a small fix to the admin test
      
      * Smoketests: Skip some known failing tests
      
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      Unverified
      836af536
    • dpsutton's avatar
      Initial refingerprinting (#13687) · 722a80a9
      dpsutton authored
      * If scheduled analyze task is short, refingerprint tables
      
      - make the sync steps return their values rather than log and nil
      - dynamic var in fingerprint.clj to swap out query clauses for fields
      - update the fingerprint runner to not consume whole list when
          refingerprinting
      - algorith for fields to refingerprint: shuffle table and do up to
          1000 fields
      - we refingerprint after analyzing in the task if two conditions hold:
         1. the analysis lasted under 5 minutes
            Don't want to hog our CPU or connections
         2. no fields were fingerprinted.
            The first analysis will fingerprint everything and analyze
            fields base on that. Seems subsequently we almost never
            fingerprint unless its a new field.
      
      TODO for the future to make it better:
      - manual overrides to prevent these refingerprinting (might be
      necessary before this goes live. I lean towards actually doing this
      and making it opt IN so that people can enable. We verify that its
      working frequently enough to be helpful but not causing problems. Then
      in 38 or 39 we flip it and make it opt OUT)
      - better strategies for what to refingerprint. Right now just picks
      tables at random. We don't have a place to write down frequency of use
      of tables nor if the fingerprints are changing substantially (for some
      notion of substantial). Also, only date and number fingerprints are
      used by the app at the moment. Could just bias to these fields for the
      moment.
      - Our analysis doesn't override if there's already a special_type (Or
      other field things). We don't capture if special_type and other
      aspects of a field are manually computed (and therefore a candidate to
      use ongoing fingerprint results (state fields based on percentage of
      state values, etc). If this becomes the case and our analysis can
      become more mature to improving insights and knowing its not
      clobbering a human override/input we could just make the initial
      fingerprint smarter.
      
      As it stands this step is after the normal fingerprinting so that we
      don't accidentally do too much work and because we can't really use
      the information in the analysis/classify steps yet.
      
      Docstrings for linter
      
      * Add refingerprint column to Database
      
      its nullable now so that people can opt in and we can migrate to opt
      out in the future with the following strategy:  if null, set to True,
      set default to True. This allows us to respect people who have turned
      it off and enabling in a future release when we are sure the
      performance ramifications are not too severe.
      
      * Add tests for refingerprinting
      
      * Test for refingerprinting being bounded
      
      * Update UI verbiage for refingerprinting
      Unverified
      722a80a9
    • Kyle Doherty's avatar
      Capture component doc progress (#13656) · ca41ee40
      Kyle Doherty authored
      * fix ProgressBar component
      
      * [styleguide] - add some simple stats
      
      * update ProgressBar snap
      
      * cleanup
      Unverified
      ca41ee40
    • Nemanja Glumac's avatar
      Repro for #12928: Join saved questions already containing joins [ci skip] (#13689) · e4efda73
      Nemanja Glumac authored
      * Add repro for #12928 [ci skip]
      (Cannot join Saved Questions that themselves contains joins)
      Unverified
      e4efda73
  10. Nov 04, 2020
  11. Nov 03, 2020
  12. Nov 02, 2020
    • Nemanja Glumac's avatar
      Fix recent Cypress flakes (#13658) · 90759f0f
      Nemanja Glumac authored
      * Fix Cypress flake `should allow bulk hiding tables`
      
      * Fix Cypress flake `should save a setting` in `settings/settings.cy.spec.js`
      
      * Quarantine `view embedded questions` test(s) in `public.cy.spec.js`
      Unverified
      90759f0f
Loading