Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 14, 2023
  2. Aug 13, 2023
  3. Aug 12, 2023
  4. Aug 11, 2023
  5. Aug 10, 2023
    • Cam Saul's avatar
      Test metadata helper function consolidation (#33031) · 88451885
      Cam Saul authored
      * Test metadata helper function consolidation
      
      * More code consolidation
      88451885
    • shaun's avatar
      5a2a6a4a
    • Luis Paolini's avatar
      Wink for GCP users (#33092) · 3e9df688
      Luis Paolini authored
      3e9df688
    • Noah Moss's avatar
      Fix misc errors in currency metadata (#33009) · a40023a5
      Noah Moss authored
      * fix currency metadata
      
      * fix test
      
      * change renminbi back to yuan because that's what Intl.NumberFormat uses
      a40023a5
    • Ryan Laurie's avatar
      Dont crash with bad fieldValues filter options (#33025) · b7ea2376
      Ryan Laurie authored
      * reproduce #32985
      
      * don't crash fieldValuesWidget when we get null options
      b7ea2376
    • Ryan Laurie's avatar
      [MLv2] Expose field_id mlv2 function (#33021) · 0b0edf1b
      Ryan Laurie authored
      
      * expose field_id mlv2 function
      
      * Update frontend/src/metabase-lib/fields.ts
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      0b0edf1b
    • Ryan Laurie's avatar
      Convert DefaultPicker to typescript (#32797) · 50da9046
      Ryan Laurie authored
      * convert DefaultPicker to typescript
      
      * unit test DefaultPicker
      
      * update types
      
      * use rowvalue
      50da9046
    • lbrdnk's avatar
      Unify semicolon and comment handling in nested native queries (#30677) · 9fef23dc
      lbrdnk authored
      
      * Unify semicolon and comment handling in nested native queries
      
      * Use different comment and semicolon removal approach
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update base and effective type verification for oracle
      
      * Avoid running test with snowflake and bigquery
      
      * Update `breakout-results` and test
      
      1. In `breakout-results` case driver statement was redundant.
      Original code had field name and types hardcoded. During further
      examination, I've realized name and types are available thanks
      to the use of `qp.test/col`, so are just "unhardcoded" :)
      
      2. `card-id-native-source-queries-test` is altered, so instead of
      hardcoding native sub-queries, roughly equivalent* mbql query is
      compiled and its native form is used. This way I can hopefully avoid
      problems with extraction of cloud databases' table names for testing
      purposes.
      
      * By roughly equivalent I mean instead of using * for selecting
      fields, mbql is compiled selecting fields explicitly. Also limit is added
      in some cases, but local testing showed no problems with that.
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      9fef23dc
    • lbrdnk's avatar
      Modify `:contains`, `:starts-with` and `:ends-with` so field or expression can... · a98bfa1f
      lbrdnk authored
      Modify `:contains`, `:starts-with` and `:ends-with` so field or expression can be used as the second argument (#32446)
      
      * Update `LIKE` to handle fields and expressions
      
      Previously only string could be used with like clause, ie. as second
      argument of `:starts-with`, `:ends-with` or `:contains`. This commit modifies
      translation of those functions, so fields or expressions can be
      used in place of second argument.
      
      * Make only expression or field args use `concat`
      
      Using concat with values unnecessarily complects generated sql.
      
      * Update tests
      
      * Extend mongo string matching capabilities
      
      Make mongo filter compilation use `$regexMatch` for `:contains`,
      `:starts-with` and `:ends-with` so expressions and fields
      can be matched against.
      
      * Adjust mongo specific tests
      
      * Update druid
      
      Druid's filters work with `:contains`, `:starts-with` and `:ends-with`,
      but only if second argument is literal pattern. This commit updates
      existing code, so expection is thrown if `pattern` has different form
      than `[:value ...]`.
      
      * Address review comments - sql
      
      * Address review comments - mongo
      
      * Use mbql `:concat` instead of `hx/call :concat`
      
      Vertica, orcacle and sqlite handle concat differently than other
      drivers. To overcome this limitation, `pre`, `post` and `arg` are
      wrapped into mbql's concat expression which is then translated
      with regards to the specifics of particular driver.
      
      * Update according to the review feedback
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      a98bfa1f
    • lbrdnk's avatar
      Update mongo native param substitution (#33003) · 88b9ee0f
      lbrdnk authored
      
      Change is compatible with prior implementation. Match clause like
      the following, `{$match: {"something": "Facebook"}}`, does exact match
      if `something` is a scalar, and in case `something` was an array, match
      would check whether it contains the `Facebook` value. Same behavior,
      as with `{$match: {"something": {$in: ["Facebook"]}}}`.
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      88b9ee0f
Loading