Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 03, 2023
    • Braden Shepherdson's avatar
      Fix `yarn dev-ee` with new CLJS setup (#34319) · 21a70290
      Braden Shepherdson authored
      `yarn dev` had been adjusted to use `build-hot:js-wait` (which waits for the first CLJS compilation to be done), but `yarn dev-ee` had not been changed, so its JS compilation ran too early, failed, and never re-ran.
      
      We actually had this broken behavior (JS build runs too early, CLJS build completes, JS build fails, JS build notices new inputs and re-runs) for a long time. But since it fixed itself when the JS build re-ran, it didn't cause any issues. Now that the JS build no longer watches the CLJS output for changes, the CLJS output needs to be there for the first JS build.
      Unverified
      21a70290
  2. Oct 02, 2023
    • Braden Shepherdson's avatar
      Enable ClojureScript REPL and hot reloading of CLJS code (#34007) · 8e298158
      Braden Shepherdson authored
      This also moves the CLJS output out of `frontend/src/cljs{,_release}` to
      `target/cljs_{dev,release}`. If that causes problems for FE tooling I
      don't know about, it could be moved back.
      
      Hot reloading:
      CLJS changes are hot-reloaded into the running app by Shadow CLJS - no
      action is needed. Note that the UI will not refresh; you usually have to
      click around so the updated MLv2 code gets executed.
      
      Usage of the CLJS REPL:
      - Open the browser (you should see `shadow-cljs: #N ready!` in console)
      - Connect to nrepl on 50655
      - "Select" the `:app` build;
          - https://shadow-cljs.github.io/docs/UsersGuide.html#_editor_integration
          - Conjure: `:ConjureShadowSelect app`
          - Plain REPL: Eval in CLJ mode `(shadow/repl :app)`
      - Consider running `yarn build-hot:cljs` and `yarn build-hot:js` in
        separate terminals; then when `yarn build-hot:js` crashes you don't
        have to reconnect your REPL.
      - The REPL works beautifully, even loading files outside the :entries
        of the shadow-cljs build like tests!
      
      "Stale" error in browser:
      - This can happen if the webpack bundle is created before the CLJS is
        done building.
      - If you ran `yarn build-hot:cljs` and `:js` separately, let `:cljs`
        finish compiling first.
      - If you see this otherwise: (a) contact Braden so it can be fixed; and
        (b) either restart `build-hot:js` or force webpack to rebuild by
        hitting http://localhost:8080/webpack-dev-server/invalidate
      
      Yarn commands:
      `dev`, `dev-ee`, `build-hot`, and `build-static-viz:watch` all now wait
      for the CLJS build to be complete by watching for files to be generated.
      They should work the same from a user's POV.
      
      (Since the webpack build no longer watches the CLJS output,
      it won't notice the changes and immediately rebuild after the first
      build. This avoids errors on the clean build, or "stale build" messages
      in the app from Shadow CLJS.)
      
      Fixes #32674.
      Unverified
      8e298158
    • Uladzimir Havenchyk's avatar
      Drop unused typings (#33851) · 89729a8d
      Uladzimir Havenchyk authored
      Unverified
      89729a8d
  3. Sep 27, 2023
  4. Sep 26, 2023
    • Nick Fitzpatrick's avatar
      Only run BE tests on static viz FE changes (#33760) · 39acfd4a
      Nick Fitzpatrick authored
      * output static viz sources, update be workflow and file paths
      
      * build static viz before file check
      
      * extending file check timeout
      
      * fixing mistake
      
      * disable optimization when generating file paths
      
      * prefer offline
      
      * moving workflows to save 89505
      
      * Maybe caching the build?
      
      * removing minification
      
      * upload artifact instead of use cache
      
      * Add workflows back
      
      * reduce files changed timeout
      
      * removing unneeded yarn install
      Unverified
      39acfd4a
  5. Sep 15, 2023
  6. Sep 13, 2023
  7. Sep 12, 2023
  8. Aug 28, 2023
  9. Aug 25, 2023
  10. Aug 18, 2023
  11. Aug 15, 2023
  12. Aug 14, 2023
  13. Aug 04, 2023
  14. Aug 01, 2023
  15. Jul 20, 2023
  16. Jul 06, 2023
  17. Jul 04, 2023
  18. Jun 30, 2023
  19. Jun 29, 2023
  20. Jun 22, 2023
  21. Jun 20, 2023
  22. Jun 12, 2023
  23. Jun 09, 2023
  24. Jun 08, 2023
  25. Jun 07, 2023
  26. Jun 05, 2023
    • Kyle Doherty's avatar
      Remove styled-system (#31306) · 050b4fd8
      Kyle Doherty authored
      * rip out styled-system usage
      
      * fix yarn type-check errors, replace space properties w/ className equivelants
      
      * find / replace space prop usage [ci skip]
      
      * find / replace use of hover styled-system prop [ci skip]
      
      * account for fontSize usage w/ Text component [ci skip]
      
      * use font-size and weight props for styling text
      
      * fix a few additional uses of color
      
      * fix lint
      
      * fix lint
      
      * fix dumb rebase mistake
      Unverified
      050b4fd8
  27. Jun 02, 2023
    • Maz Ameli's avatar
      New icons (#31096) · a1b09db0
      Maz Ameli authored
      
      * arrow_left
      
      * check mark
      
      * arrow_up and chevrons
      
      * add, close, contract, embed, expand, sort
      
      * change viewbox to 16
      
      * icons in +New menu, search, and sidebar toggle
      
      * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons
      
      * fix database icon
      
      * ellipsis, person, and tweak ellipsis size in collections sidebar
      
      * home, reference or book, pencil or edit, table
      
      * dashboard action icons, and remove reference to unused ClockIcon.jsx
      
      * question action icons and related component tweaks
      
      * larger icons on HomeModelCard on homepage
      
      * dashboard and add_to_dash
      
      * snippet and variables
      
      * all the chart type icons and some field type ones
      
      * mail and groups
      
      * make sidebar icons darker blue
      
      * fix add-your-data icon
      
      * filled mail icon and use it on events modal
      
      * stars
      
      * bolt and x-rays and a bunch more
      
      * granular, metric, revision history
      
      * arrows, formula, snippets
      
      * click, cloud, boolean, unpin
      
      * return, hourglass, popover
      
      * pause, ldap, burger
      
      * gear info list pin moon sum sun verified warning
      
      * fix size of row details modal icons
      
      * fix size of left nav icons
      
      * fix size on filter widgets and some selects
      
      * set default size to 16 to fix entity menu icons etc
      
      * fix pagination icons
      
      * size and color on ItemPicker
      
      * bump up database icon in /browse to 32px
      
      * /browse bolt icon size
      
      * find and remove instances of 14px size declarations
      
      * sql editor icons
      
      * sql expand/contract button alignment
      
      * collection breadcrumbs
      
      * remove two more size 14 declarations
      
      * viz selector
      
      * fix add icon in New button
      
      * fix size of ModelDetailLink
      
      * icon for question list empty state
      
      * get rid of model_framed icon
      
      * try to fix event tick icons, replace balloons with cake
      
      * standardize size of question footer actions
      
      * fix dinosaur
      
      * switch star_outline to star, and star to star_filled
      
      * fix notebook sort action
      
      * switch data picker from table2 to table
      
      * fix slack icon
      
      * restyle HomeXrayCard
      
      * fix List icon
      
      * fix sidebar toggle icon size
      
      * fix icon size in field picker popovers
      
      * fix summarize sidebar field type icons
      
      * fix summarize sidebar Add buttons
      
      * table heading sort icons
      
      * fix filter icon, resize button icons
      
      * bulk filters icons
      
      * admin datamodel icons sizing
      
      * fix datamodel metric and segment icons, and sort icon
      
      * dashboard interactivity sidebar close icon
      
      * get rid of grabber2
      
      * bookmark and question actions icon sizes
      
      * revert icon
      
      * Icons cleanup (#31147)
      
      * remove timeline event icon stroke
      
      * cleanup
      
      * add 16x16 viewbox to svgs that were missing it
      
      * add slack_colorized
      
      * correct the join_full_outer icon
      
      * timeline events, cleanup
      
      * fix broken icons
      
      * more cleanup
      
      * fix storybook
      
      * fix all types
      
      * add stories
      
      * try fixing arrow_split
      
      ---------
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * fix specs
      
      * fix specs
      
      * remove unused icons
      
      * use constants
      
      * increase node memory allocation
      
      * bump for chromatic too
      
      * fixes
      
      * fix arrow_split icon
      
      * fix arrow_split path attributes
      
      * fix path again and fix sizing of drillthrough menu icons
      
      * more spec fixes
      
      * prettier
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      a1b09db0
  28. Jun 01, 2023
  29. May 31, 2023
  30. May 26, 2023
    • Nemanja Glumac's avatar
      [E2E] Cypress Replay.io Integration (#29787) · 5e359e20
      Nemanja Glumac authored
      
      * Install `replay.io` library
      
      * Register `replay.io` in the Cypress config
      
      * Run E2E tests using Replay chromium browser but only in CI
      
      * Upload Replay.io recordings to the dashboard
      
      * Manually install Replay.io browser
      
      * Always upload recordings
      
      * Pass in a custom test run id
      
      * Disable asserts and send replays to a separate team
      
      * Upload OSS recordings as well
      
      * Use specific Ubuntu version
      
      * Record and run Replay.io on `master` only
      
      * Do not toggle CI browsers in the config
      
      * Test run: pass `replay-chromium` browser as CLI flag in a run
      
      * Fix multi-line command
      
      * Use replay plugin conditionally
      
      * Set the flag correctly
      
      * Require node process
      
      * Remove sourcemap vars
      
      * Record using replay.io on schedule
      
      * Explicitly name replay runs
      
      ---------
      
      Co-authored-by: default avatarJaril <jarilvalenciano@gmail.com>
      Unverified
      5e359e20
  31. May 25, 2023
  32. May 16, 2023
Loading