Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 12, 2024
  2. Aug 07, 2024
  3. Aug 06, 2024
  4. Jul 16, 2024
  5. Jul 12, 2024
    • bryan's avatar
      parallelize coll perm graph group lookup (#45256) · 534951b7
      bryan authored
      * parallelize coll perm graph group lookup w/ core.async
      
      * respond to code review
      
      * add + uses ExecutorCompletionService map function
      
      * rename test
      
      * more tests
      
      * no concurrency for cljs
      
      * fix timeout + add more tests
      
      * use claypoole
      
      * cleanup
      
      * add kondo hooks for claypoole
      
      * cleanup
      
      * Can't use libraries that don't have a license
      
      Revert "add kondo hooks for claypoole"
      
      This reverts commit 9d93b55b28d69267b65260f2b046420d67604361.
      
      * ignore unused value
      
      -- TODO: check back in on claypoole to see if the kondo config gets merged
      
      * fix linter
      Unverified
      534951b7
  6. Jul 10, 2024
  7. Jun 28, 2024
    • adam-james's avatar
      Wrap non-latin characters in a span specifying working font (#44580) · 97575697
      adam-james authored
      * Wrap non-latin characters in a span specifying working font
      
      Fixes: #38753
      
      CSSBox seems to have a bug where font fallback doesn't work properly. This is noticeable when a font does not contain
      glyphs that are present in the string being rendered. For example, Lato does not have many international characters,
      so the rendered version of tables (that show up in Slack messages) will not render properly, making the card
      unreadable.
      
      Since this appears to be a downstream bug, I've opted to work around this limitation by wrapping any non-latin
      characters in a <span> that specifies the font family to be sans-serif, which should contain the glyphs to properly
      render.
      
      This leaves Lato in place for other characters.
      
      For now, I figured it's worth trying this solution over using Noto for 2 reasons:
      - we can keep Lato, which has been the decided font style for the app for some time (this keeps things consistent
      where possible)
      - the Noto font containing all glyphs is quite a large font (>20mb, I think) and it would be nice to avoid bundling
      that if we can.
      
      * stub installed fonts test
      
      * typo
      
      * Do wrapping, but now per-string, and in Clojure data not html string
      
      I've decided that a reasonable solution is to still wrap strings containing non-lato characters. But it's not done
      with str/replace to the html string but rather in a postwalk over the Hiccup data prior to rendering.
      
      Seems like a decent compromise of issues without patching CSSBox or fixing upstream (may be good to do, but will take
      longer to get a fix in).
      
      * add test checking that glyphs render correctly
      
      * Add a test that directly checks the wrapping fn
      
      * Change the string to keep the linter quiet
      
      * Change how we check if string can be rendered to faster method, new Lato Font
      
      With Sanya's help, the way I check if a given string is renderable with Lato is now faster.
      
      Also use the full Lato font, not just the 'latin' lato so we can cover more chars
      
      * change lato so that it loads the fn even in a fresh test run
      Unverified
      97575697
  8. Jun 26, 2024
  9. Jun 24, 2024
    • Case Nelson's avatar
      fix: dont always optimize between expressions (#44493) · 63179270
      Case Nelson authored
      * fix: dont always optimize between expressions
      
      Fixes #42291
      
      The frontend produces expressions like
      
      ```
      [:between
       [+ [:field ... {:temporal-bucket :day] [:interval 2 :day]]
       [:relative-datetime -1 :week]
       [:relative-datetime 0 :week]]
      ```
      
      This should not be optimized because of the mixed `:day` and `:week`
      units. However, it was being optimized since the compatible units
      weren't being properly picked up by the match.
      
      * Disable suspcicios args eastwood lint, kondo does it better
      
      * Stop autobucket to day when adding a time interval
      Unverified
      63179270
  10. Jun 18, 2024
  11. Jun 13, 2024
  12. Jun 05, 2024
  13. May 31, 2024
  14. May 30, 2024
  15. May 23, 2024
  16. May 22, 2024
  17. May 21, 2024
    • Cam Saul's avatar
      `metabase.search` namespace (#42487) · d5a32ecb
      Cam Saul authored
      * Search API namespace
      
      * Search API namespace
      
      * Search API namespace
      
      * Fix Kondo warnings
      
      * Fix typo
      
      * Finally solve the MySQL ^:parallel test failures <3
      
      * Make some search tests REPL-friendly
      
      * Did I finally fix `^:parallel` MySQL tests?
      
      * Ok I give up just make the search tests single-threaded for MySQL/MariaDB.
      
      * Revert the stuff to make paralell tests work for MySQL... for now.
      
      * Keep new name
      
      * Revert deps-graph changes
      
      * Remove unused namespaces
      
      * Fix Kondo linter for log/info + format
      
      * Misc fixes :wrench:
      
      * Test fixes :wrench:
      Unverified
      d5a32ecb
  18. May 10, 2024
  19. May 09, 2024
  20. May 08, 2024
    • bryan's avatar
      adds the new `watch` alias, which reloads BE on file changes (#42371) · 0468c9a7
      bryan authored
      * adds watch alias, which reloads BE on file changes
      
      * watch dev, src, test + every path in `:extra-paths`
      Unverified
      0468c9a7
    • dpsutton's avatar
      bump methodical (#42361) · 5d0ad01a
      dpsutton authored
      now:
      
      ```clojure
      ❯ clj -M:"$ALIASES"
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem
      2024-05-07 19:55:25,167 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      ```
      
      no logs about recur targets unboxing
      Unverified
      5d0ad01a
  21. May 07, 2024
    • dpsutton's avatar
      Silence `abs` warning on startup (#42311) · 64ac0d76
      dpsutton authored
      before:
      
      ```clojure
      ❯ clj -M:"$ALIASES"
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem
      WARNING: abs already refers to: #'clojure.core/abs in namespace: clojure.algo.generic.math-functions, being replaced by: #'clojure.algo.generic.math-functions/abs
      2024-05-07 04:39:37,890 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      ```
      
      after:
      
      ```clojure
      ❯ clj -M:"$ALIASES"
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/21.0.2-tem
      2024-05-07 04:40:42,561 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      ```
      
      Now no warning about `abs`
      Unverified
      64ac0d76
  22. May 06, 2024
  23. May 05, 2024
  24. Apr 26, 2024
  25. Apr 24, 2024
  26. Apr 15, 2024
  27. Apr 10, 2024
  28. Apr 09, 2024
  29. Apr 08, 2024
  30. Mar 28, 2024
    • Tim Macdonald's avatar
      ParseSQL: select * (#40637) · df1366e1
      Tim Macdonald authored
      * Parse wildcards in native queries
      
      Add query_field.direct_reference
      
      * Do away with old Model refs in Card model test
      
      * Do not show stale cards with a select *
      Unverified
      df1366e1
  31. Mar 25, 2024
  32. Mar 21, 2024
    • Cam Saul's avatar
      Rename `metabase.mbql` to `metabase.legacy-mbql` (#40158) · 0a15637f
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Rename `metabase.mbql` to `metabase.legacy-mbql`
      
      * Fix Kondo warnings
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Fix import
      
      * Another fix :wrench:
      
      * Merge
      
      * FIXES
      
      * Add another missing REQUIRE
      Unverified
      0a15637f
  33. Mar 20, 2024
Loading