This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 13, 2021
-
-
dpsutton authored
log4j includes different class files for different jvm versions. This means our uberjar includes these versions so we are a multi-release jar. Need to set this in our manifest. Fixes the reflection warning seen on startup on jdk 11's ~/p/w/metabase ❯❯❯ java -jar target/uberjar/metabase.jar WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
-
Cam Saul authored
* Fix Druid queries with multiple filters if some but not all are temporal * Fix syntax errors
-
Nemanja Glumac authored
#15959 Repro: Adding cards to dashboard via search can cause the card to show spinner until browser refresh (#16040)
-
Nemanja Glumac authored
* Install `cypress-real-events` library * Register `cypress-real-events` globally
-
- May 12, 2021
-
-
Cam Saul authored
* Dashboard param value (chain filter) endpoints should return cached FieldValues * Test fix
* Test fixes * PR feedback/appease linters * Hydrate :table to avoid lots of DB calls * Use hash of current user perms set for sandboxed field values cache key * Fix missing :require * Test fix -
Raimon Grau authored
Co-authored-by:
Raimon Grau <raimonster@gmail.com> Co-authored-by:
Walter Leibbrandt <23798+walterl@users.noreply.github.com>
-
Nemanja Glumac authored
-
- May 11, 2021
-
-
Nemanja Glumac authored
- Cherry picks 274be949 from `master`, which extracted unit and timezone tests from CircleCi and made them run using GitHub actions - Synchronizes the "state" between the `master` and `release-x.39.x` branches Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Nemanja Glumac authored
#15998 Repro: Tooltip only shows first Y-axis value when X-axis is numeric and style is Ordinal/Histogram (#16003)
-
- May 10, 2021
-
-
Noah Moss authored
Clarifies which part of the Google link is relevant to Metabase, and modifies some language to better mirror the terms used by Google/OAuth
-
Nemanja Glumac authored
Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Nemanja Glumac authored
Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Jeff Evans authored
Update tests in accordance with changed geocode API results ("Begles" -> "Talence") See output of: https://get.geojs.io/v1/ip/geo.json?ip=185.233.100.23
-
dpsutton authored
* Emit events outside of db/transaction When emitting events (particularly revision events), the event handler loads the item from the db to ensure that all post-processing is done. If done from inside a transaction, there's a race between the event handler looking up the object from the db and the transaction completing to put the item in the db. When the event handler wins, the following code fails: ```clojure (push-revision! :entity Dashboard, :id id, :object (Dashboard id), ;; this is nil :user-id user-id, :is-creation? (= :dashboard-create topic) :message revision-message) ``` and then the schema check for `push-revision!` fails `(map? object)` and there is no event recorded for creation. On edit, it might get the pre-edit version and record an incorrect message or not create the revision for the latest change, preventing going back in the future. I'm only doing this in dashboard but these changes should be audited and applied everywhere * Remove `:dashboard-card-update` and `:dashboard-card-create` events These events were introduced 5 years ago and never have had an event handler. No worries about race conditions when emitting them from a transaction if nothing ever cared in the first place.
-
Nemanja Glumac authored
* Add repro for #15947 * Expand the assertion with the joined table Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
- May 07, 2021
-
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
- May 06, 2021
-
-
dpsutton authored
I don't exactly follow what's going on in #15901. But it seems that the field information can be kept in the db > ""field_ref"":[""field"",""count(*)"",{""base-type"":""type/BigInteger""}] And so we need to handle this base type here. Note that in the function that calls `update-filter-for-field-type` it checks that the field has a base_type. I'm also a bit confused by the base_type vs base-type in the above snippet. But again the calling code has ```clojure (and (= param-type :dimension) (get-in value [:field :base_type])) (update-filter-for-field-type value) ``` So it seems the field has a base_type rather than a base-type.
-
dpsutton authored
* Move unhidden table sync off-thread * Test bulk hide/unhide syncing * Check can connect to db and serialize syncs rather than allowing us to create threads willy nilly, serialize them and reuse them in a fixed thread pool with a single thread. This helps if someone "multiple clicks" and launches a few table syncs. It's not appropriate to use the existing deduplicating stuff in the sync which prevents later tasks from happening while the current sync step happens since we want to sync with the most recent changes. So just serialize them to go one at a time rather than off to the races. * Clean up ns, make private, and type hints * Block waiting on table sync to finish * Use driver.util can connect helper uses the timeout of 5seconds and catches errors * disable ToggleHiddenButton during request Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com>
-
Nemanja Glumac authored
-
- May 05, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Add option to choose between source-folder and test-files in CCI * Rearrange Cypress files * Split e2e workflows * Split native queries into a separate CI group
-
- May 04, 2021
-
-
Nemanja Glumac authored
* Extract `printBold()` function * Allow multiple `--spec` arguments
-
Luis Paolini authored
-
- May 03, 2021
-
-
Noah Moss authored
* Change 400 errors to 401s on failed authentication * remove TODO comment * return 401 for expired JWT in enterprise code * keep existing exception message when JWT is expired * fix test failures * remove comment about timeout on CI that's no longer relevant
-
Nemanja Glumac authored
* Move assets inside `e2e` folder * Separate checksum calculation for e2e files * Fix logo path * Remove whitespace character from the test title
-
Nemanja Glumac authored
-
- May 01, 2021
-
-
Ariya Hidayat authored
This ensures that the test is deterministic, i.e not exhibiting different behavior relative to the current date.
-
Nemanja Glumac authored
* Merge all enterprise specs together with the OSS ones * Move whitelabel under `/admin/settings` * Move specs under `/admin/audit` folder * Merge `admin/database/add` specs * Group snippets * Merge OSS and EE sso specs * Move sandboxes under `admin/permissions` * Delete custom drill-throughs spec * Return boolean value * Use `Cypress.env` instead of global vars * Delete empty spec * Update paths for `eslint` script
-
- Apr 30, 2021
-
-
Tim Macdonald authored
[Fixes #8219]
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-
Luis Paolini authored
Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Paul Rosenzweig authored
-
- Apr 29, 2021
-
-
Noah Moss authored
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
* Update notify.clj * Update auth.clj
-