Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 13, 2021
  2. May 12, 2021
  3. May 11, 2021
  4. May 10, 2021
  5. May 07, 2021
  6. May 06, 2021
    • dpsutton's avatar
      Fall back to base_type when calling parse-value-for-field-type (#15905) · 45c4d2fe
      dpsutton authored
      I don't exactly follow what's going on in #15901. But it seems that
      the field information can be kept in the db
      
      > ""field_ref"":[""field"",""count(*)"",{""base-type"":""type/BigInteger""}]
      
      And so we need to handle this base type here. Note that in the
      function that calls `update-filter-for-field-type` it checks that the
      field has a base_type.
      
      I'm also a bit confused by the base_type vs base-type in the above
      snippet. But again the calling code has
      
      ```clojure
      (and (= param-type :dimension)
           (get-in value [:field :base_type]))
      (update-filter-for-field-type value)
      ```
      
      So it seems the field has a base_type rather than a base-type.
      Unverified
      45c4d2fe
    • dpsutton's avatar
      Restore table visibility (#15916) · 494b820b
      dpsutton authored
      
      * Move unhidden table sync off-thread
      
      * Test bulk hide/unhide syncing
      
      * Check can connect to db and serialize syncs
      
      rather than allowing us to create threads willy nilly, serialize them
      and reuse them in a fixed thread pool with a single thread. This helps
      if someone "multiple clicks" and launches a few table syncs. It's not
      appropriate to use the existing deduplicating stuff in the sync which
      prevents later tasks from happening while the current sync step
      happens since we want to sync with the most recent changes. So just
      serialize them to go one at a time rather than off to the races.
      
      * Clean up ns, make private, and type hints
      
      * Block waiting on table sync to finish
      
      * Use driver.util can connect helper
      
      uses the timeout of 5seconds and catches errors
      
      * disable ToggleHiddenButton during request
      
      Co-authored-by: default avatarDalton Johnson <daltojohnso@users.noreply.github.com>
      Unverified
      494b820b
    • Nemanja Glumac's avatar
  7. May 05, 2021
  8. May 04, 2021
  9. May 03, 2021
  10. May 01, 2021
    • Ariya Hidayat's avatar
      Waterfall test: use absolute date range (#15895) · 8a597c6e
      Ariya Hidayat authored
      This ensures that the test is deterministic, i.e not exhibiting different
      behavior relative to the current date.
      Unverified
      8a597c6e
    • Nemanja Glumac's avatar
      Merge EE Cypress tests with the OSS ones (#15887) · 9c0db5e0
      Nemanja Glumac authored
      * Merge all enterprise specs together with the OSS ones
      
      * Move whitelabel under `/admin/settings`
      
      * Move specs under `/admin/audit` folder
      
      * Merge `admin/database/add` specs
      
      * Group snippets
      
      * Merge OSS and EE sso specs
      
      * Move sandboxes under `admin/permissions`
      
      * Delete custom drill-throughs spec
      
      * Return boolean value
      
      * Use `Cypress.env` instead of global vars
      
      * Delete empty spec
      
      * Update paths for `eslint` script
      Unverified
      9c0db5e0
  11. Apr 30, 2021
  12. Apr 29, 2021
Loading