This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 15, 2023
-
-
metamben authored
Fixes #32948.
-
Cam Saul authored
-
Noah Moss authored
-
Tim Macdonald authored
* Remove obsolete CLI flags for `export`; fix collection specification [Fixes #33168] * Allow comma-separated IDs
-
Cam Saul authored
-
Case Nelson authored
* Improve sql parameter mismatch error message It is possible to write native sql queries that try to hide parameters within comments or identifiers. Unfortunately PreparedStatement will almost always explode in these cases since you can only parameterize values in sql caluses. The error message of various drivers is quite poor, so we add a heuristic to look for these poor messages and replace it with a message prompting the user to look for a misuse of parameters. * Address review comments * Exclude drivers that do not support getParameterCount
-
Cam Saul authored
* Remove `:metabase.lib.*` keys from field refs when converting refs to legacy * Fix hardcoded database ID
-
adam-james authored
* Normalize Formatted strings on \space char. Some JVMs use nbsp chars in their formatted strings. I noticed weird test failures that printed the same because of this and it was confusing. So I propose a simple string replace to normalize on one type of space char only. * Change use of strings in str/replace to chars to pass the linter
-
Nemanja Glumac authored
* Consolidate "create new dashboard" workflow * Consolidate "add new dashboard card" tests * Remove redundant repro for 25705 * Group and consolidate "title and description" tests * Move repro 26826 to the main `dashboard` corpus * Fix `visualization-options` spec name * Make `dashboardHeader` more specific * Consolidate "duplicate dashboard" tests * Clean up and consolidate all dashboard management test * Fix test failure https://www.deploysentinel.com/ci/runs/64d9eb30fa6644982d115267 * Fix dashboard auto apply filters test failure https://www.deploysentinel.com/ci/runs/64d9e91c7b3e6a1ddb9363c8 * Fix custom homepage test https://www.deploysentinel.com/ci/runs/64d9e9a8f048784ce96aedf2 * Another attempt to fix a failing test * Bring back a test removed during rebase
-
Alexander Polyankin authored
-
Oisin Coveney authored
-
Uladzimir Havenchyk authored
* Add docs about running tests with snowplow [skip ci] * Update docs/developers-guide/e2e-tests.md Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
metamben authored
Porting fix alias of joined column LHS of standard join conditions (#32987) * Check if the LHS has the alias of the current join before stripping its alias. * Remove dependent joins when removing a join
-
- Aug 14, 2023
-
-
Aleksandr Lesnenko authored
-
Cam Saul authored
* Simplified impl. * Fix kondo errors * Cljs test fix
-
Oisin Coveney authored
-
Emmad Usmani authored
* fix `ChartSettingInputNumeric` decimals on safari * add unit test
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Anton Kulyk authored
* Extend `ace-builds.d.ts` * Partially migrate to TypeScript Define component props and state types, add straightforward types * Add editor ref null checks * Add null checks for optional fn props * Fix missing types (simple) * Add straightforward ace editor null checks * Cast editor type on load * Fix `cardTagIdAtCursor` method * Fix `handleCursorChange` method * Fix missing arguments for ace's `setScrollMargin` * Use `Question` methods over properties * Use ace's completer types * Add editor null checks * Fix `setTableId` method * Fix `_updateSize` method * Fix `getCardTagCompletions` method * Fix `getSnippetCompletions` method * Fix autocompletion types * Fix scroll margin * Fix `fetchQuestion` type * Fix resizable box * Remove redundant editor null check * Fix incorrect type * Break down `OwnProps` * Fix `_lastAutoComplete` type * Minor fix * Minor fix * Avoid ace editor type casting * Add radix to `parseInt`
-
Noah Moss authored
* don't throw when host is nil * fix test ns name * Update enterprise/backend/test/metabase_enterprise/sso/integrations/sso_utils_test.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> --------- Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
-
Anton Kulyk authored
* Extract `aceEditorStyle` * Extract drag handle * Port more `NativeQueryEditorRoot` class names * Port editor root and resizable box * Remove redundant class names * Remove `.NativeQueryEditor` class * Use CSS variable colors in `NativeQueryEditor.css` * Add a comment on `NativeQueryEditor.css`
-
Ryan Laurie authored
-
Kamil Mielnik authored
* Use named import for ErrorView * Export ErrorView and ErrorViewProps from Visualization * Define AddSeriesModalErrorView * Make ErrorView component configurable in Visualization by introducing errorView prop * Use AddSeriesModalErrorView thanks to new errorView prop * Fix export type syntax * Remove the dot for consistency with other error messages * Rename AddSeriesModalErrorView to ErrorView and extract it to a separate file * Allow translating the custom error message * Don't show custom ErrorView when there is only one series (or none) * Add a test case for a single incomplete chart * Inline: dashcardData * Add a reproduction e2e test for #32231 * Add explicit assertion for the error message * Add a test case for default error message when there is only 1 series * Remove redundant setup functions * Wait for series query endpoint * Rename ErrorView to VisualizationErrorView * Rename VisualizationErrorView to MultipleSeriesErrorView * Improve assertions * Use editDashboard helper * Use data-testid for AddSeriesModal * Refactor errorView prop into errorMessageOverride - Do not export ErrorViewProps and Error out of Visualization
-
Nemanja Glumac authored
-
Tim Macdonald authored
* Search by table description [Fixes #25792]
-
Kamil Mielnik authored
* Use MetabaseApi where possible in entities/tables.js * Mock syncing state * Disable table link if sync is not complete * Disable model link if sync is not complete * Gray out the disabled link by inheriting body color * Revert "Disable model link if sync is not complete" This reverts commit 5423834bc6638638f0e3c2d2b51d044e099bea62. * Revert "Mock syncing state" This reverts commit 4546f7655e95310a59bb21f3022a8ebad8479e23. * Export DatabaseTablesPaneProps * Use SearchResult type instead of any * Add a unit test boilerplate * Implement test cases for various initial_sync_status for tables * Update names * Add explanatory comments and functions
-
Kamil Mielnik authored
* Fix initial values not reloading in the action modal * Add a repro test for #33084 * Use cy.button helper
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Case Nelson authored
Part of #33140
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard actions linked with filters don't work * Add E2E test * Make assertion clearer
-
Maz Ameli authored
* add latvian and update translations for 47 * translate untagged strings found in review * okay but really this time is it I swear
-
- Aug 13, 2023
-
-
shaun authored
Creating a collection when saving a question/dashboard should return to the question/dashboard save modal with the new collection selected (#32778)
-
- Aug 12, 2023
-
-
shaun authored
-
- Aug 11, 2023
-
-
Jeff Bruemmer authored
-