This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 15, 2024
-
-
Nicolò Pretto authored
fix header being rendered (with its border) on dashboard embedded with titled=false and only one tab (#41399) * fix header being rendered (with its border) on dashboard embedded with titled=false and only one tab * embedframe-header -> embed-frame-header
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Apr 12, 2024
-
-
Raphael Krut-Landau authored
Adds a Schedule strategy to the Admin / Performance page  [Loom](https://www.loom.com/share/5623cd5d772e417ba2e58c29ae1b8c14?sid=9844f0db-5bb1-4d35-af9b-206d263f5516) As discussed with @luizarakaki, rather than modify the legacy `SchedulePicker` to work with this use case, I made a new version of it - a `Schedule` component - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important. Tests for the Schedule component will be added in a follow-up PR.
-
Denis Berezin authored
* Add interactive question component * Remove excess click actions for embedding * Disable non-working drills * Cleaner components api * Clean up * Review fixes * Fix lint error * Review fixes --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Uladzimir Havenchyk authored
-
Nick Fitzpatrick authored
* no implicit any on callbacks * cleaning up use of any * small adjustments * PR feedback and unit test adjustment * typing click handler
-
Romeo Van Snick authored
* Add help text icon in expression editor suggestions (#41092) * Add helptext to expression suggestions * Deduplicate getDatabase calls * Allow customising popover width * Split out help text content component * Render an info icon with the help text * Remove duplicated defaults for popover * Explicitly wait for suggestion items in test * Remove commented out code * Use React imports directly * Rename e to evt * Inline getHelpText when creating suggestions * Avoid overlapping content * Remove unnecessary Fragment * Avoid selecting item when clicking link or button inside element * Allow shifting popover * Stop Popover mouse events for bubbling * Use onMouseDown instead of onMouseDownCapture to avoid clicks inside popover from triggering select * Add help text to all suggestions that are know mbql functions * Expression suggestions clean up (#41236) * Move ExpressionEditorSuggestions to tsx * Convert ExpressionEditorSuggestions to functional component * Simplify suggestion match component * Move ExpressionEditorSuggestions a separate folder * Remove default export * Use Popover instead of Tippy for suggestions list * Fix suggestions tests * Remove data-ignore-outside-clicks * Add default for suggestions * Fix e2e test * Move helptext wrapper to ExpressionEditorTextfield * Switch to metabase/ui for Button * Use arrow function
-
Oisin Coveney authored
-
Nicolò Pretto authored
* connect the example dashboard id setting to the embedding homepage (#41138) * connect the example dashboard id setting to the embedding homepage * fix types * Update frontend/src/metabase/home/components/EmbedHomepage/StaticTabContent.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * use isNotNull --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Oisin Coveney authored
Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Nemanja Glumac authored
-
- Apr 11, 2024
-
-
Raphael Krut-Landau authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .bordered * Migrate .borderBottom, .borderTop * Fix typo * Remove unused classes * Migrate .borderRight * Migrate .borderLeft * Migrate .borderLight * Migrate .borderError * Migrate .borderSuccess * Migrate .borderBrand * Migrate .borderTransparent * Migrate .borderless * Migrate .borderMedium * Review: Add missing CS import
-
Nick Fitzpatrick authored
* collection and db breadcrumbs * compact breadcrumbs * adding navigation keybindings * recent_views and search changes to always include collection or db name * removing breadcrumbs, display parent name * removing unneeded components * e2e and FE unit tests * waitFor * e2e tests for keybindings * help * be tests passing * PR feedback and type adjustments * unit test adjustment
-
Oisin Coveney authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Alexander Polyankin authored
* Replace AlertApi * Replace AlertApi * Replace AlertApi * Fix bugs * Fix bugs * Fix typo --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Uladzimir Havenchyk authored
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Nemanja Glumac authored
* Keep the original question name in the save modal where possible Resolves #41196 * Update tests * Append "- Modified" to a suggested question name * Preserve the original question description * Address reviews - adjust the translation string * Add E2E reproduction * Remove extra space * Improve assertions
-
Nicolò Pretto authored
* .eslintrc -> .eslintrc.js * This might work? * add env for linting css modules class names * avoid extending postcss-modules/recommended, specify just the used rule instead * add missing . on comment * Remove unused .detailName references * Fix ManageApiKeys and GuiQueryEditor * Fix SettingText and DashboardControls * fix missing textUnspaced class * remove usave of S.headerButton, that's actually never used because we never pass headerLink to ReferenceHeader * Remove flexNoShrink --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Kamil Mielnik authored
-
- Apr 10, 2024
-
-
Raphael Krut-Landau authored
-
Nick Fitzpatrick authored
* increase activation distance for dashboard parameter dragging * updating drag sensitivity for other places * adjusting e2e tests
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .pointerEventsNone * Remove unused global class * Migrate .faded, .fadeInHover * Migrate .circle * Remove unreachable code * Remove unused props
-
Oisin Coveney authored
-
Denis Berezin authored
* Restore tabs display for embedded dashboard without title * Add unit test * Remove empty file --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
- Apr 09, 2024
-
-
Raphael Krut-Landau authored
-
Romeo Van Snick authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove unused CSS custom properties * Migrate .ModalContainer * Migrate .Modal * Migrate .ModalBackdrop * Migrate Modal transition classes * Migrate modal sizes * Fix tests * Add missing classes from migration * Address review: use `data-testid` * Remove unused classes * Revert the util that selects Mantine modal
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Improve the fetching logic in a notebook native preview * Rely on `isFetching` always * Show a disabled convert button when there's no query
-
Nemanja Glumac authored
* Convert `ui` actions to TypeScript * Make sure fetched user is not `null`
-
Nemanja Glumac authored
-
- Apr 08, 2024
-
-
Cam Saul authored
* Wow * Test fix
* Fixes * Actions should use strings for column names (fix :update-row and :create-row normalization) * MLv2 schema should check against keys for the other query type * Ok, have I fixed things? * More fixes * Fix indentation * Another round of test fixes. * Hopefully the last few test fixes * We need to test normalization for queries that have keyword keys as well. * Fix Cljs i18n namespaces * Sort namespaces * Only test against H2 * Rename `metabase.mbql` to `metabase.legacy-mbql` * Fix Kondo warnings * Test fixes * Register MBQL clause schemas and test fixes * Test fixes and PR feedback * Test fix * Remove the normalization tests * Test fixes * Fix kondo * Fix import * Another fix * Merge * FIXES * Add another missing REQUIRE * More Metric => LegacyMetric renaming * metabase.models.metric-important-field => metabase.models.legacy-metric-important-field * Even more renaming * More renaming * Even more fixes. * More renaming * Wow, even more renaming!! -
Nemanja Glumac authored
* Add new user-local setting `notebook-native-preview-preferences` * Update user settings on FE * Use two distinct setting entries * Update FE types * More explicit `notebook-native-preview-sidebar-width` definition * Add selectors * Initialize QB uiControls based on the BE settings * Rename QB store entry `isNativePreviewSidebarOpen` -> `isShowingNotebookNativePreview` * Rename QB store entry `nativePreviewSidebarWidth` -> `notebookNativePreviewSidebarWidth` * Add Redux actions * Dispatch user settings on top of Redux store * Fix test title typo * Add E2E test to make sure sidebar is resizable * Expand the E2E test to cover persisting settings across sessions * Be more explicit that we're resizing along x axis * Store window breakpoint as a variable * Calculate handle's left position more explicitly
-